From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AF7545BAC; Wed, 23 Oct 2024 09:17:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41EFB40A79; Wed, 23 Oct 2024 09:17:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id EF64E402E4 for ; Wed, 23 Oct 2024 09:17:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729667874; x=1761203874; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TkJ5HsvwFQGx4NxirBDlyF0OW1q85F4nK4YEkc9XZgc=; b=E1iOXMgtnt5z0gIlFdSGqN64TNKGFc2KTwQwuz9Tu6M4NS8KwrZhuL8e sLHGwXsmLglS0tzRinySP3OmaVAWybGIwVpQrLvMQ+BjeZRUL/8yYPk+L hrCoWSPM6VXGa9kFWAq8gfiC7o3oko1n9U8/dRio26UPc9MWZ6Piy9Fgw +kVHzEXgj9gtjrxsUdZ9gNZYwwQnk3gE/WBA9tbNRM9ZQevhN3sANl4Pl /kz5NuOqXedAVowLCylzChkETqy5wYwXr2gus5TNnsUXbkx2zOL0Z9EHn aOvvpVC+AFiXnHxkOMc3Upe6R0iD5PozamnOVH35NnNOEns1KccgsQ18/ Q==; X-CSE-ConnectionGUID: gM5me7xwRvCUUonkcXHcjA== X-CSE-MsgGUID: EAr8pOVeSPy9y51B+0J/eA== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="39783276" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="39783276" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2024 00:17:50 -0700 X-CSE-ConnectionGUID: pJvkuxwHQBaqiYm65ks4AQ== X-CSE-MsgGUID: uaX6WqG4SDuThB3tZLYsSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,225,1725346800"; d="scan'208";a="85201179" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Oct 2024 00:17:50 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 23 Oct 2024 00:17:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 23 Oct 2024 00:17:49 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 23 Oct 2024 00:17:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=urQ5X5Nvj40GqnomuaLHHHDAvLrpnb11SjM7fMBKa9j5pv4zbG7m2iwrWnPko67T+hg483E45F/dTU9H+0/UIY6l/HN+i3X2Ho0PRoJ4pLaL7bEmd424Yj34RqHjVaFvhqc9FavXSjp9TuvD7eVmtFTF93umVIO7xHnQfl2smAvk63pSm2IQGuKdKbkxIPZmTy9KCHIORLqG+/E4WHrlJR0mR+/Lh2v6SSZI2Mn1vKlesqAt6Q19zNhT7OOGyjEMVwZAlhNb6qWznZGLCs1YNKEiwl6/QEynqrKlX/QBr7jK/Glx9/WuSNxKJaR+l/I4ch2ANZzRVURVcBcBWTLmrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qJshivdQVl2KBZBZXogmoBP4xoQtI+RUaPxoiHVNdqc=; b=pN4tWYZMhND7xrczaPO7Dnf/3T0YHF76n6AHPM2eUojDD+yhrZ8MVzUfkXOUuTaoWNHM6sjOjaloQUflz6laXAFF2ZaUWC+c6eqfd1yxav9e/UQHi8Gamub/PI5ahw9pjvcnYiQCMwPfQjySK6zGCEBjykBvQCUJTzLn8r0sGPVvLIWHn6nkqhyeymdmX2DRFBklIoxln6sgMonTQSntrDUnBP+rEIRg95Nrwkfm4A7RyIbUnrP+6K8yhn2JzMpdHSmC05MVI2nGS+N2IYh3BNew99V/VQLO+J+vNic8TDVmCU7qEWMQ74/k3pP6amCGyA3+6gOD7QTFUdyoQMWAOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from LV3PR11MB8601.namprd11.prod.outlook.com (2603:10b6:408:1b8::8) by MW3PR11MB4522.namprd11.prod.outlook.com (2603:10b6:303:2d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.29; Wed, 23 Oct 2024 07:17:44 +0000 Received: from LV3PR11MB8601.namprd11.prod.outlook.com ([fe80::7878:b054:82bf:b5b]) by LV3PR11MB8601.namprd11.prod.outlook.com ([fe80::7878:b054:82bf:b5b%5]) with mapi id 15.20.8069.027; Wed, 23 Oct 2024 07:17:43 +0000 From: "Ye, MingjinX" To: Stephen Hemminger CC: "dev@dpdk.org" Subject: RE: [RFC] net/ice: add devargs to control link update Thread-Topic: [RFC] net/ice: add devargs to control link update Thread-Index: AQHbJE2237AuRhHzBkmNxj6ENlsqF7KS5A0AgAD9UCA= Date: Wed, 23 Oct 2024 07:17:43 +0000 Message-ID: References: <20241022062043.1833554-1-mingjinx.ye@intel.com> <20241022082322.44e0004b@hermes.local> In-Reply-To: <20241022082322.44e0004b@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV3PR11MB8601:EE_|MW3PR11MB4522:EE_ x-ms-office365-filtering-correlation-id: 570f2d4c-8d92-46b0-7995-08dcf332c99f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?5JcmrVa4CeRtNetTeCL6EPalABLtMtzYgx4UNvxXr/BHMVIqZSn3dB/I2QO4?= =?us-ascii?Q?XHs75K3IigE8gy/fy4Dy8rGSPI83J0pXto+RB91UBPxsx/n8tlC86pC+refx?= =?us-ascii?Q?VZnUb5NZYeirqIzkGC5yqD8GP70TU22buo77mC+3HOAVhFeBjdnT/ApWUZeU?= =?us-ascii?Q?GeaGchW8p3aRSBnssoDX0Yg50iEasrfTLZzS5gqcYt8s+c5ziMJf9HKaO1TD?= =?us-ascii?Q?GEr/T/e4AEtOqPplCFLU9iBPognE1ixixMVwGS7J9+cZ+jnOS+YZbtTIRwFs?= =?us-ascii?Q?7jfpD2e7QS8Babe8d2PU9dsM6CEvUYPAsdihbBzapwIOjPjMrilY4jxFi6u1?= =?us-ascii?Q?CQ+DFHbEXZN7WaEDiQTkw3/+zSk1uiMcfHkPHdlQp8QuWoRPl+WOpDrT5EWI?= =?us-ascii?Q?yHafbar1VHvoa+f7D1u9MvZVfu0ucfLuWeHuT0rCZdS4CcFu6RCU3Pjzm5kj?= =?us-ascii?Q?qgBvqsSauInSlppEEF13DH931vNlGVnXFvUOwLaGHWiI3JrmuzaSPZlAnJgZ?= =?us-ascii?Q?xf+m7LepOYWcFS+l6ufcBM+k8ROYSpIbi3kXaeYLh7slKJDjdWRyyzTimYon?= =?us-ascii?Q?5o2gaxo18hIAMSHBIPn7lILuUXfF6w59Oarg1VQj4khOjTmcAOI3h8g1+DNR?= =?us-ascii?Q?Z594qqs33G7Br2hZBe7PnZCohNBIa0mj77xirjJUi5fQHV57mF6GnLexLdV8?= =?us-ascii?Q?pPTlp0fAvFbyv3ulvgBE8g3rNTQ8cYPyTHqixuyozvHZmeFVkuylV7MLIZ7V?= =?us-ascii?Q?a05E2qu4WdyFOZ4CKeAxgr+A1spBfkwzVnHy20L46c14kUkii0/RgFqPq+ns?= =?us-ascii?Q?yrmNHifoWMqoeIf8FzHOy+omisgPOktqTBjrgYkudtXlRHhhg3jBACzGiORP?= =?us-ascii?Q?xOe7/fiLohmM4F8k/wVF+51yWS4/0ytayR4pF0CS9TRrEJztLdpJo+pAdOR1?= =?us-ascii?Q?v8XB8x+pI5zAqGkmqn1C3MrlRwFWq0ILhMlLL6ZIs9mXjXwvLP/TnvootMp0?= =?us-ascii?Q?dZHGiWCc2n87T9k7FvKIWiYPgzyiaVp97nTvbHRwfVkErO4Li3k5FMQu5BZx?= =?us-ascii?Q?vgZW20YrPPDV7apI1J/VCsJix03LTyJNfr9EGW59yZb4t0au0olX4ZfTPgpN?= =?us-ascii?Q?Y8SA9cjYqsFhzWnUZuKF8NFkmhmM7eBSpnWB7mM8J44lTuRd5dUAz1O81qqD?= =?us-ascii?Q?XD0wneH5DrfnKmlPmng6UMtzG0rSxIZprDCEHt7mqLfyeojP6DUH/mxJ/Kmu?= =?us-ascii?Q?EKQ65A5ujZUeRIZLoeQsztF1TNiWvPENuPpt2m/qRnvf7r/4WwpQ9BJhuNyT?= =?us-ascii?Q?asKsFt5no8Rmq6b6qbf5blFi76bBcBBTusGpl5MAJ/sPsIky+2rwNVYjw7yG?= =?us-ascii?Q?z7bxxUk=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV3PR11MB8601.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oiqV/shcOw+tircG1i+yYtQUT5gamw7TQHAlCM+3hGjn1aLVaffK35p+5a6z?= =?us-ascii?Q?BBOAD3VGsVsz3tSRxaN+gC9QS/gj7+4VG8XAvByoaGI/xOmrFgAeH3EapAky?= =?us-ascii?Q?+IbSy+7RRc+/ItaYg2XBNvsXv948e6mv4MJgJ9n16V2Udx6y7+DLGeiow1qr?= =?us-ascii?Q?WSKxtET+sxMMz2NlIHsLlo0jT0B7UqYwuWEwwxYUbjfLwwma2RCmcVtyjX66?= =?us-ascii?Q?lHEK0WobLAUEuB/NL04TICUBotC9+PYduYBPwFtZvZr9taOz8t/mfJ2yzZzC?= =?us-ascii?Q?6b7GkAAj/X/Y2C7VSKBpVWYt7QIHEdww6TkmU7yaQI79oWm7Bk7YAeJhl5or?= =?us-ascii?Q?BOy8gqcXO/SuGAZ2IrWv3mqkPmTvO6OCOoZoPbck2Avjw3rmbQeGHIY8Hvja?= =?us-ascii?Q?bLsGMAk2CyahJdDrdPcYrR+oZNCCMOrAR+kGlcLppbTrPOyaOp0bHtVM+scv?= =?us-ascii?Q?xIihk1NkgdLAK7R7KG4SyGJCyPDDJJJYag7wEj6zqLnxYtnGXK+qaxFr8Us3?= =?us-ascii?Q?37hT/m+ytiBqeN5gczxvnR7MYPxsROpQUxE1KYzThwNL0qwfLq8fHfAb9y57?= =?us-ascii?Q?yB/Za3TTNYRmAPGDQHNOhriCUmNyYWChAR6u/EBGPhIFUEWmsi1Yk7qcON7m?= =?us-ascii?Q?3dVRpW2wDrXvOCTNj3B1mvzC2zHaK2cjj+0LCQJrO9AUS+RjrnVrknw+fN9A?= =?us-ascii?Q?u57RISk59esTADQi6qeKf2CZlfsU+5wtDZKiHig7o7WUOEpl5/Y52NZYeX11?= =?us-ascii?Q?aH0A5dxunubfBRhqDmnF1e6tKH+kgtQR8bC/IMPKbYXS7mo+L8dPNvfnxhR8?= =?us-ascii?Q?s9QqY/AMZE+Zv2gV5tRWWxIWxsFXhDDS589Ulcn/d2OAinsnlYtA0CdGYX1h?= =?us-ascii?Q?DsrRTi0TypD5tPzgO0/2aUyyCw6bEAckPzZsDxGB83LrqIeq+pHZoaucOT58?= =?us-ascii?Q?IpLnDE0a4VfQXFxakIiZ/bll0weowh9zIO6HDA+DP9TaRofl6imwlvcZryq3?= =?us-ascii?Q?TXWJDKGPYCaEsHStq7mLoQIqEU0PjiBn8UZlHP/3HBDNxoJA57YvqhbgxLn7?= =?us-ascii?Q?4RUgoS6qhLGOcz/98EvuWk5TGk1ZAImpwdVWHzeutsKst0YfUQoN2D8YJGas?= =?us-ascii?Q?ceKjbWeMzpj1hmYTwTQurvNVZC/uUd2EFUXrhHFeH+pbUoBKMTwBjkb/yvY+?= =?us-ascii?Q?F1qnu2C+GHPU7Avfv+AO/DtvGI8rS5N0Ttpx+lHmwcO2RlzE91R/srun2Zix?= =?us-ascii?Q?jSb4eQyUm4brqpiwJtQKwrZv4R2/6EvLo1bwxdLPsNM9jrq5vVKyF9UkWi16?= =?us-ascii?Q?MWvNXYwxTIx3UOYK92cd7pIWIKwdtKxwINqQ+6XnYDVpEnDj/C54t+2qeCmK?= =?us-ascii?Q?M/Sc9ykYkCQk0JQr7I0O/5j3XR/r/RbR45m8l0FtxQf4IbtDOix6JXrvcOt7?= =?us-ascii?Q?Yjz3EfUxtHXvtMEgenGEhsuhfnR/kQXZZOuKnxTLfCsjwyWjzC/PjysR6icz?= =?us-ascii?Q?Mu9lRrJtQFBB0o0jL6UJ5gHFQ1kLFocHfxu+IgR1rmvC4KWryiCu/guKEi7X?= =?us-ascii?Q?djnQHGPrZ3Egf39dRwhM6P9furqBVtxOUfxb0E0P?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8601.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 570f2d4c-8d92-46b0-7995-08dcf332c99f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2024 07:17:43.6131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7cOouYwgXiutNA1wJf4cxbABQVYQOMSn3JAW4K1f+JFaJORKgMZ34/qEa+3TeJXikDAQHaXzyVc3BGvyNwt0hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4522 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, October 22, 2024 11:23 PM > To: Ye, MingjinX > Cc: dev@dpdk.org > Subject: Re: [RFC] net/ice: add devargs to control link update >=20 > On Tue, 22 Oct 2024 06:20:43 +0000 > Mingjin Ye wrote: >=20 > > +static int > > +ice_parse_clean_subtask_period(__rte_unused const char *key, > > + const char *value, void *args) > > +{ > > + int *num =3D (int *)args; > Cast of void * unnecessary in C. > You probably want period to be unsigned not signed. >=20 > > + int tmp; > > + > > + errno =3D 0; > > + tmp =3D atoi(value); > > + if (tmp < 0) { > > + PMD_DRV_LOG(WARNING, "%s: \"%s\" is not greater than > or equal to zero", > > + key, value); > > + return -1; > > + } > > + > > + *num =3D tmp; > > + > > + return 0; > > +} >=20 > Prefer strtoul() when parsing values, it allows for better error handling= . Thank you. Good suggestion.