From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FD52A054F; Wed, 7 Sep 2022 14:05:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0943240143; Wed, 7 Sep 2022 14:05:09 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A4AB5400D6 for ; Wed, 7 Sep 2022 14:05:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662552306; x=1694088306; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pSgEHh7O+BmzUFBrOUmNUo1IgNgAlbAVuf9Do8jLJ5g=; b=A8+TN9JjIGQEu/G4TLBUw56yiFr+S+J1RkIoHKphlXB/CsuhNhfgWsNp NzwiM9eG4bHAJ1nD0o9o27eXq9DlDHLXD8O1JTqKW1Vg5VLnL7KSsuMQJ G+Ges1dJPF50E7Dbf81eYN/B9D4Iah15AJ1zyJ1dj/O319GHW+y6BOJkc 9by3alDab9QjPvJqqGDZzj9+1l9JnlVGqqlmvr3rkgkbCguu2yqFbI0Jq cfYZ7sxq7VOJe5J3VMgEZeJtqU4Ngcux57lqiI5Fn1n4lZIdS7rJAgIoQ jZ+4dBKJLstR9+In/h0TYVHU6/fMGmh9QzPeUkfolDRwqXrSd145DdKOC g==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="279865378" X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="279865378" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 05:05:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="676158135" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 07 Sep 2022 05:05:05 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 05:05:04 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 05:05:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 7 Sep 2022 05:05:04 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 7 Sep 2022 05:05:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lpX+11H7eliLEyEpj+IinfM8mKenqLEJqzOwHZSHjsQVsP8duAcvgsA7VH5fdgTpzuy/A5CrFLOQ9az9rOb3rgAAs5Xzbs0NFDGQWlVV/XTvChJXVZp7OK68ZU/LSFf6X162GubXmbWmPQ5DZ+42zvwAfWredTeaootcwJkJDhMu4XZIkmZJH2RNeFe/+A/pFNxlrdv4Hx3of7Ch63nqioHGtFKz8/BIDveWIUQHuSdR4Z6ztueUdR8Tm7nbxVFAMaCmvlW1gwTtmsVqoROUiWPgIxEQhRwWUDmEAEVdyJBjVuLNX059w6s7RmB3tcG73pj0pCGrLshnVFTrkRXaOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ra2B+yPe7HjKLFRoOYzndGWEyNb91xZ2H9KK+ASf3Og=; b=ZX4fIxdQZY5DUPyd5ZxUaT37JwcbD7EQ56LbGw4VezX28ozkr8UyV1IyeWlNjLU5Vij3KHhIerx45mVyIlaZrbFV2J7dHoqAR5zezNOQema+Ji9Eu6HTvJ+d2UjH3uVIAwzz7EU0vt8cVNBX8bopzXiEct0TiSYobOQUMWPKAE4yOFNSKnbs5+OZeXJHOaPrl+Qfi9dadWk3pElrUr6OBJcqye1FS/+3k/Dzm08sEsb2d2WzFQCa1mZER8Wx0ZFD3R5L0Bf2MmSUoOV/NRFr7/XUqPt+0SnpJ2aOtOE4+erEsD/wWuRUOp8GZIJNkkJhDL+XhtzBL7pHz6YkLYZzRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB5986.namprd11.prod.outlook.com (2603:10b6:208:371::22) by BYAPR11MB3000.namprd11.prod.outlook.com (2603:10b6:a03:8e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Wed, 7 Sep 2022 12:05:01 +0000 Received: from MN0PR11MB5986.namprd11.prod.outlook.com ([fe80::907d:95fc:bf85:13ff]) by MN0PR11MB5986.namprd11.prod.outlook.com ([fe80::907d:95fc:bf85:13ff%9]) with mapi id 15.20.5588.015; Wed, 7 Sep 2022 12:05:00 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" CC: "dev@dpdk.org" , "Yang, SteveX" Subject: RE: [PATCH] net/ice: fix DDP package init Thread-Topic: [PATCH] net/ice: fix DDP package init Thread-Index: AQHYwrGgVegsQ33f00OQaSMHfOhcIq3T3ngg Date: Wed, 7 Sep 2022 12:05:00 +0000 Message-ID: References: <20220907120603.169681-1-qi.z.zhang@intel.com> In-Reply-To: <20220907120603.169681-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23e9fa8a-cf55-4726-97cb-08da90c930d8 x-ms-traffictypediagnostic: BYAPR11MB3000:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EEneS3ogL7ZlIlBaRVLBLDba85dpMFQdiYluwR5oYyxpXyAkrhwdrExC/usMdoGkG8Zidqp4mLBVo7H/llSovEoYqaKVMyrjN1/vR4iwLFWVzbvl1UWHPr2JYW3+AOCn5fLRwjpa2/uyd2mAHVbGxYgvR/5exZ4egQ+dXccDj3hbxSXHfVppRgjNyN8HcLTDoM+juCwHB3VkNvBnEOnBam4vR6grBUiMGtl0kmVzYwOqDYKf9NEuIjlYoMIqRQ/oBf2Ih9E223ohBvcEZDSCQHya4p63HrQ3EOstv4IHAuzkpt0fUj96NSPvBOhK0wlhhMVwZfBoUxo+PyrVOt955XjhN4VuuNCXW/V/8TsOQoLWMpPwmTZprDuZEJX1I4CeipAJVO761xR/Xv0uGEyBUadbQzBWYRGN8KfTxDOM+UnNe2E9P0u2eib8aQlaqkpQxaHqRi7KPKxl8tEBqlmjGKPBA3qi5dftxIt5K2/3EGq2y5kAjHs98omA5Gn/FoA+MNWeIqzxAkgTQ4f4BjLpIT3ZKZcqsjYRoadjtRnrw8ATtLdH01dmxE0P9AillzyyktLa043/gCiFH8gNlkUduMsPkfZrYySB7/wn7W9q1EonA7qQhm/ejyGTNkcZDS/14cEjDnS36LEiEEVlcWXeZu576bt/HO+oOF6Q1qwq4i5KT+6a/vMVTMtOG2U46++BM3WkFQCBAvoDrdrRwfSS+n9UkDye2Ak0lL5XG2TDSc0ns/ZSWCRLiLK1D9K8u3vJmIcILv67vgDwj1gektDUnZABnriIAIJ79FggWGHN45c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB5986.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(346002)(366004)(396003)(39860400002)(376002)(316002)(6636002)(71200400001)(55016003)(82960400001)(38100700002)(41300700001)(122000001)(54906003)(33656002)(4326008)(66946007)(66556008)(478600001)(38070700005)(83380400001)(8676002)(7696005)(76116006)(6506007)(966005)(52536014)(66446008)(66476007)(64756008)(86362001)(6862004)(186003)(5660300002)(8936002)(26005)(2906002)(107886003)(53546011)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?So9qgK2f5fJmGfUadrZoEE8FwrzIZerW1XlDekqVwDqUvkVQQD6oBOGl+OT5?= =?us-ascii?Q?oKut8MP90WBelaVLC8rvGVBM620u/rGA1RcGsgszF6n7+8MF2M3yVAjoxy05?= =?us-ascii?Q?Jl2D1SUE3TiAOZeyiPIOlLBKaqgH2xJirb37tEVTkMC/3BpQn0gEMY1SCDOW?= =?us-ascii?Q?M4fKTWUgV0Kr1x04WkBQMMQZKMeYjiehN4JyabkoKfcHOtRoPL7SzGjKcCBQ?= =?us-ascii?Q?38LbwLJqtrd78L7LpUzkdXPBeRBaENA5PLDpxZs6e+eHoncD+UjJHlUxetXt?= =?us-ascii?Q?WN4c1Jyt3AuQAAmy+BSgyVpkRp9KIdubai8kLQTEu4JhPmpx4m4hT7dAk3ld?= =?us-ascii?Q?tWbC+zN+jBqsHt9HoIiSD5vRwzBl/oFGLNPM4kTrupGzp3MUdvEHlOZllzNk?= =?us-ascii?Q?xTNlUK5kADRxvb4BiA6S6FmtfBNO81n9Lu9pq9nUxWF07rsg0wcUPX/BHHwF?= =?us-ascii?Q?s2T91wpX6Ebc5iFcpnjZ4pCZCjSAaW0LsGEkDOPewHjBxDbpMdV+fKeopNY7?= =?us-ascii?Q?xqetEqk6gcSQ3RuJjQfK1WGw037CRCzFfxpHEXfEM8pL2Jyj/CoF0MSLWqUS?= =?us-ascii?Q?soKjCmOzOjzgBdmz5eE4EYUuTRlGh3uxgaogvEg4vpXXIVSuy9K8YhScFs/J?= =?us-ascii?Q?Qc2ev8hzCmyHX/68h4ecLLzkH18faFOLKZ9NnmGYfFU40Db12zajmxwaAXoK?= =?us-ascii?Q?uK4Bbt61DBVdzMrVmpK2GGVqoZQSMvJlMfO9oPmXLaesQsIApjhuy6n1PNZI?= =?us-ascii?Q?YVCZTs/t946eF/WYBJgQ1aqw38r6H9nYol2xDOcwTYIjSK8bJKbgf0D+7Hl7?= =?us-ascii?Q?qeQo7xDUhDASGMfUJEVB6gnST6pqAyeh+3sFoFBGv6rgy3S3EmrDzVokI9Zk?= =?us-ascii?Q?wAb/Yw52TIVcXeDhuGUUMVSEha9Z1f86fgltmt2oh1pIs0D77mKwdO7JSEiM?= =?us-ascii?Q?VdqKM8361XB08c5mZn06cdHJOnnMRp/msUWR1vBUX3FiSC/qWBkLksoPbgr9?= =?us-ascii?Q?Y1cj/OMiW0Ht/QDYyTW7dC0EAmiafd6I6GSw5fO/V9dkGdHFq7DalntonLbQ?= =?us-ascii?Q?+EL8uaGVlu+2BUXtGTCbbhjobCAzW7HTT/gXI8cP2t4T+nP3VanyQXux7KgX?= =?us-ascii?Q?ad0NPVizCBND2TYOxDvbygNNxa5Gahb7CdUCP8EsviG1Z4BETlUsES8Qdyg2?= =?us-ascii?Q?/bZguVpXahBKL/g7/J8oYwyPPWj8YOn0AyWdxs8uh9cfVPCbi2lYjSCh/6om?= =?us-ascii?Q?iEA4Mo9xwwJLo3pO/0Zv0Gvez4QCNKz5fe+Ayvyf9jpQpknOyaGvG/OAnfnU?= =?us-ascii?Q?XhklrpAx2jC08+9BE6DGNofX/aJixnt2sxCql54SC45ARYqNY87Asmfo/LjC?= =?us-ascii?Q?gEIJKPeocsckaYoRGKrng6fcv9Pj5wWC+GeFRrQmosTjX4UG7mPDSvGi0LUA?= =?us-ascii?Q?glYGKcyH50I4NTPI679D0TGxZvA+F06VZHqTjbIN+UfGVoXQuC75P5YFg8NY?= =?us-ascii?Q?eENJoADWs+nT9og1qMUwm6pN4DnDuOxea9mtWR2Km8CcDX0y3L0nhrAkcWh8?= =?us-ascii?Q?yN+slVHgKZC2cgiOvvixIsLdxlXC93lbMSsSAEQR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB5986.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23e9fa8a-cf55-4726-97cb-08da90c930d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 12:05:00.8361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7340hXhtZLP2k4dgvutJNzODM+g5SIZv8z6HQvhGNnMahfv22LQeAFyU6zwzgxDW6phB886qqe9K7kPwxwZEGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3000 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, September 7, 2022 8:06 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Yang, SteveX ; Zhang, Qi Z > > Subject: [PATCH] net/ice: fix DDP package init >=20 > ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED and > ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED should not be treated as a > DDP package init failure. Use ice_is_init_pkg_successful to check return = value > of ice_copy_and_init_pkg. >=20 > Signed-off-by: Qi Zhang The patch has been squashed into below patch which has not been merged. https://patchwork.dpdk.org/project/dpdk/patch/20220815073206.2917968-21-qi.= z.zhang@intel.com/ > --- > drivers/net/ice/ice_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > fc889420c7..50fe23fdc4 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -1836,7 +1836,7 @@ int ice_load_pkg(struct ice_adapter *adapter, bool > use_dsn, uint64_t dsn) > PMD_INIT_LOG(DEBUG, "DDP package name: %s", pkg_file); >=20 > err =3D ice_copy_and_init_pkg(hw, buf, bufsz); > - if (err) { > + if (!ice_is_init_pkg_successful(err)) { > PMD_INIT_LOG(ERR, "ice_copy_and_init_hw failed: %d\n", > err); > goto out; > } > @@ -1846,7 +1846,7 @@ int ice_load_pkg(struct ice_adapter *adapter, bool > use_dsn, uint64_t dsn) >=20 > out: > free(buf); > - return err; > + return 0; > } >=20 > static void > -- > 2.26.2