From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ACA5A054F; Wed, 7 Sep 2022 14:17:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C217940143; Wed, 7 Sep 2022 14:17:29 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id CD78E400D6 for ; Wed, 7 Sep 2022 14:17:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662553048; x=1694089048; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Y9wEZy2ps0uARRCIUWqXAByVjXVHKeaMjKuj2JAYbOw=; b=ayMm5qUsA/3I+KcjMytTYmvHKEg0K/VcFE2Ih+N+CgZ/nf35PUl3YDVk HAOvh66XWfKtj9Ctpi46nHnhSCL3X/FsK+05FhBXyCNBUKn4Df0TD2mwu 7KsSf3VcuuwBRdXvIkdB5M41yQ+LymUBrB/om5SlxKOpdf8jVriS9GJjc qRrL4VGLfG+hb8IpHjgNVBa2vSELyO3tJpmPvnsgEaAlcTBfw37xqkP5O ZVTA/ZtsUpjou9AS66rCgfBg3gHS8Ca6Tac0LHeDkoJztCqh3FVIz9LU4 OPIAKZrhoMIY/1OyXECPnlrXZSFJXNyRzegX1TaD0Gx0Sq1DZ9gvvPj8T w==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="295590176" X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="295590176" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 05:17:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="647612491" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 07 Sep 2022 05:17:26 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 05:17:26 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 05:17:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 7 Sep 2022 05:17:25 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 7 Sep 2022 05:17:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSMc2h9evHWNYB2cT1zBnSX+62u/IavuNY/o3RmxJYobRiHssOWQsX48xU1kV3oyAwjeiSwT+Kgq4w7MU0zLpi2ndzr8JW/fWT1FAvnIGQrzOuaiTyDJFHXN48o5KtrziDopPLMnNeQygQhmOWeVCsVeMdrefe9QOFWwvBeYQ+zygtWBckUKK6zovZa4BFvwaRpoGLDHi8xbV12al+5z2ZOJc635Fe06Z9tpbsBK4JnWpH/5vaI2YHi/e+DVW12jB911lWUjhYMbWJ5sHqsCJZCMSBEcl3qE+cdHoMpaLU4pHy4exw02ryBY3STQeucdWMyejw0weSp+TlSgs3FPmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yV2+NIsXBAdddIL4WbiIjK0bGJZ+krghuGkujd/rm8k=; b=J8G3S9o3t8kR5h0pa9FyfApWZqSUXZMAGxm5Ru5tAOBG/Sias4AK763V+njDmRN+xjw+9AcXRUOMunf/bcnJO+TFSN07IGdnSYLGZXEi9lC4lpP1czUM0OyRUyINkiQ6Wd43OvU0TJViFYbJBc1Ql2epbh+3e6fnmn1YFc8smSJbHWkYB8aah8PTHO3EGVpeFAHXsrTkZjrtgW6v+t74WlBhmqhBGXxPaeXnqVB6U+UxvCOmnlpeiW/gBqqMh+azhHOO1a9x878PIZcs9oVwpJ0D6t5rTfKsCueY/ql6/VjI6EtRNHPk1Z8Pd3wsCGeo3hbepLxiKdbrlLlYzmAwKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB5986.namprd11.prod.outlook.com (2603:10b6:208:371::22) by DS0PR11MB6472.namprd11.prod.outlook.com (2603:10b6:8:c0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Wed, 7 Sep 2022 12:17:10 +0000 Received: from MN0PR11MB5986.namprd11.prod.outlook.com ([fe80::907d:95fc:bf85:13ff]) by MN0PR11MB5986.namprd11.prod.outlook.com ([fe80::907d:95fc:bf85:13ff%9]) with mapi id 15.20.5588.015; Wed, 7 Sep 2022 12:17:10 +0000 From: "Zhang, Qi Z" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Yang, Qiming" Subject: RE: [PATCH v1] net/ice/base: fix ddp pkg loaded failed Thread-Topic: [PATCH v1] net/ice/base: fix ddp pkg loaded failed Thread-Index: AQHYwpsoZeOz1wKcvU2P6Bd8J34x3q3T4W1A Date: Wed, 7 Sep 2022 12:17:10 +0000 Message-ID: References: <20220907091001.68216-1-stevex.yang@intel.com> In-Reply-To: <20220907091001.68216-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fc2c793-6678-45c0-1ead-08da90cae3a4 x-ms-traffictypediagnostic: DS0PR11MB6472:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: py9BwAH6Qp9LYk63b5psIzklbMSvmRi2HyHAvT1+JOEq8gn26gG/UHO8a2bn+1uWHSeOPoHSIpI9MrDdywNoXAeBML6ZWAzNoVZ79F0OC3EefsuevDa9eF5ZlQ/7l+RCO6X/yIXhrMw1KzWCO7bFaaHfMgDtN3vHiF/IWAj6La2sPz9gf6GmIGbzEFC0lYX6sz5E67E9K/GRMnsQvVOO2Z9R359WkNblRmcZiUdCQtV6HSJX9hN2dFKogDoViAI6fOpvAyxVlyTyjz/H6D/KBWKXNQhOZC+QWnKUt4zqQe+R/HEcrHp8plTN4okg3HWUszGB5ZqkgKWnmp9ANXfaeww4MwCAXwNof3d0/2WNToAJTaxHR3YurF8qi+8b995oThB4b9B9Jt9NHqqdqybu1SfUXMo6iEJPDzkJv3qShNFeABMLoXt11q5M8A8CDzhOB1sqfCK0Zb8mASXJSVFnhNoELIARzLD2QycPsna8yyYnmm84q1yl0Smiz9O0kLBfq+NQ2/1v0/UxVQM9Sz8fITk/LtkuI8D1AnXQlKfkUfqfjcD94O4EJY4UDOMu5ycHZ5fD6DBKnqOoCXu87jcC3VC2bjiXRkFtl/ZgwemdUpfKa2XEtM4//Eclj2w17j5vV0RT2zk+s9NIgyAPjzj1oYXp1hJaeLNY9+nmKiha3+95tDmsHNPaHpir4laYa7Tah5URiJ9SxB8CSpYhOS2N9oiDv39QG/X+ebgOqcZ4AvMAhIO2LgGKXJb68c/FaZt4/l28IbU+cUZinhsctacIBw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB5986.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(366004)(39860400002)(396003)(136003)(66476007)(76116006)(55016003)(38070700005)(52536014)(66946007)(64756008)(82960400001)(4326008)(8676002)(8936002)(66556008)(86362001)(66446008)(316002)(122000001)(5660300002)(83380400001)(71200400001)(26005)(7696005)(9686003)(41300700001)(6506007)(110136005)(186003)(53546011)(38100700002)(107886003)(2906002)(33656002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vXoi3vScfA8ac/PSg5iN2cLJzVtO+vi3KpRNMNmJjIkRgkeKXcIHB2/zpias?= =?us-ascii?Q?oCQnlg3GzSwum8kUTCTgpcyP6+hzVEWrOw29PNHbmKSiM/Ux7/j82NncWZMl?= =?us-ascii?Q?q67Lh97exREYiXkykDyCBIPMMYP5mspktuv49GP+NocNKhk18nuA+wxNOkfC?= =?us-ascii?Q?KhLH/VAAS/D7BRsWilPF8FFBDSHapGOiZgIX/Tj0RN0md4EYnDfSeQY3AybB?= =?us-ascii?Q?tg9WyJQSvWrXbSK294ma4Gp9AacYXM4mW4SAl5QI77oKITrSGVE/6H9VARUY?= =?us-ascii?Q?NjYOjM7i48kgGfwpvh9j4KNrl9xLVkxLqd6sGQBwX36qki4xDdjHxNBr8yIG?= =?us-ascii?Q?34opX0qvBtUR8oOuKcumpSDlpAqf6CMMQ7qpnWVpI2dbbs1ZHlXWiFM6TV47?= =?us-ascii?Q?rkK2lG2Yt5hVqFa4dQDaj2B8WJpqCkyAG1skoHJLUrKvoSqp6jHM1v2CHf3A?= =?us-ascii?Q?BMUvgOqJ3pDqRXC6KPBtFzo1LT0/8x6fp3KxRGDBUa2UF9Z8uVx4kMFP3UIf?= =?us-ascii?Q?jPZmIyTVXsCWuoYPLb0SokGG0SVs268cNZHTdWJeELm2Q5YKnUW4F630AT+G?= =?us-ascii?Q?+B5Mh8wrlA8jI+tCQmLqrokwfk1mp04f8URhOmqOzCRnz6/qhFFrIpRMy1HM?= =?us-ascii?Q?YjK60J/Gh2AoKnB0N9xukRKIBDI3doqfJKxLJyK6xSquE4NlybmmiwPhLNB8?= =?us-ascii?Q?JPO2ZPhLrs52UdkOfmZmrJSngub/Wa7BnN3+RUAvxxS8FYaNJRuzxP8xwbUi?= =?us-ascii?Q?Wqb+QK9BVSoQFS7d3dkQ4/fPYC7uRuRUD+au1x8qij6u6eylhpc6JRcxCTfS?= =?us-ascii?Q?WBl9+UoFfjfGpBwWtGT/DNfsMzKOM25FQXok4f4B+gzYdQFMy0d/UoxPrLBV?= =?us-ascii?Q?G5l5580sUrgMuXUeUo4saqWcHwa2Hi7aPBJPLHR6vBTMpzRHHVW+p2y1bx8W?= =?us-ascii?Q?stoTLAQJ0BIUQNqTfJdFLUGZKxZxb4Kkw3xzGelsqDeQyZYFOkfvo2DdkFtE?= =?us-ascii?Q?uPYvBXYVcIktq+kV2b2VSmQ+ZknGB74DtHRtcOTCDQRoWTxCe+/HC1NCGEG9?= =?us-ascii?Q?KkU4gWoxx2T6c1RItb0P72ONQjIb0PwHGTpGLwm8GmujZSt19l7zMgjiasa6?= =?us-ascii?Q?XjJ5ie0ZlZPO/nXUPhZABZ++X0Vi2yDtShz9Zx6A+nM3sOcQNK34MFcFEiBu?= =?us-ascii?Q?0UHyxKN6vDYAI1qURkuHNzjaBwMWcqgbaBigqx3qDJS/bQSfgCqJNfUTQRvf?= =?us-ascii?Q?yUI6zyQz1dlaUpfUf1o5Jo1LqwCxAWoQRnNe3AcbpJ893UM3VbIkC6kcWoN3?= =?us-ascii?Q?TlNroeZubHleBVYL7Fl8cEu5sAUNGYpKhX4q62hbcMtuDvH/hEkV5fq0Vt/n?= =?us-ascii?Q?073PU6LzzkTvYRvKuLLVnfGVJnCowDje+i7nCBQzuJC5o5oAtJdTVTdaY+P1?= =?us-ascii?Q?n7fpgvbNfnOLvXMMZwIW9ls87BIk3VlA619zKpPDg/wp0HbMkqgpCg2iqm5J?= =?us-ascii?Q?knXEnCzxR4WpN8Mb6F1aFIwpaHaeVhh9oggr4HwsTljxeKw08+1OmZP5RY1t?= =?us-ascii?Q?yS+Dgi2LZjcVZ7hwcfkD1kCF482QJbqkLFQVJb/g?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB5986.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc2c793-6678-45c0-1ead-08da90cae3a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 12:17:10.3012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y9NnwR76phIl/D3Gh1V7TQk+RFNrx1n7p5P84q8hr1aR4Ys9XU+1UBoxCDNdFZHRSwr93cudwUyxLH3QeawkAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6472 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yang, SteveX > Sent: Wednesday, September 7, 2022 5:10 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX > Subject: [PATCH v1] net/ice/base: fix ddp pkg loaded failed >=20 > When DDP package state is > 'ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED', > it should be treated as success state, otherwise, the wrong state will be= used > within 'ice_load_pkg'. >=20 > Fixes: 58e9fd55be0e ("net/ice/base: refactor DDP code") >=20 > Signed-off-by: Steve Yang > --- > drivers/net/ice/base/ice_ddp.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_dd= p.c > index d1cae48047..284b58a6b1 100644 > --- a/drivers/net/ice/base/ice_ddp.c > +++ b/drivers/net/ice/base/ice_ddp.c > @@ -1378,8 +1378,11 @@ enum ice_ddp_state ice_init_pkg(struct ice_hw > *hw, u8 *buf, u32 len) > */ > if (!state || state =3D=3D ICE_DDP_PKG_ALREADY_LOADED) { > state =3D ice_get_pkg_info(hw); > - if (!state) > + if (!state) { > state =3D ice_get_ddp_pkg_state(hw, already_loaded); > + if (state =3D=3D > ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED) We can use ice_is_init_pkg_successful to check the return value which also = accept ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED and this is expected. Btw, I didn't notice this patch has been sent before I send another one for= the same purpose, this one can be superseded. > + state =3D ICE_SUCCESS; > + } > } >=20 > if (ice_is_init_pkg_successful(state)) { > -- > 2.25.1