From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE89C45522; Fri, 28 Jun 2024 12:09:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA0CD42E5A; Fri, 28 Jun 2024 12:09:19 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 4556842E12 for ; Fri, 28 Jun 2024 12:08:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719569327; x=1751105327; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=o1bu0/PFZBh72bmKNnSVMdIOPXWxphJKCfzuChyn5y0=; b=l8eOQ10LaeCUXhbs9RGg33xYcu25pKFJsgF78XRF4jERZaNlvzcdRatb EKfHSOsgh2yOPum67xw0WNm/b9M45a9JhBjTd5eZ2qQhpzd0XZXWwZ1lY e0ifUtZYljmZPjI56Z5JrWcdsF2axBGk6Wx+WMfLK4WevzpXkxjT/QwA6 sAcHdlStNxfGwgBDfzBwBUAukVs3+1NLm7aL22WZRx0+ifng3lsxb9da+ /M/Cxy6eouJKy1Az3qnBI4XZHuerELiGh4nDQ/TEXmRya7y67v/9r9nqZ fhIDxEz2StxoQfev/Qd9GTHixPnq0LVqNFBsyG1YU8mFx3daVF1nrQILn w==; X-CSE-ConnectionGUID: ZN+CVqisRpCot4qbClJ60g== X-CSE-MsgGUID: N/RVBfGbQ+mhYm/muad0fA== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="42165756" X-IronPort-AV: E=Sophos;i="6.09,168,1716274800"; d="scan'208";a="42165756" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 03:08:46 -0700 X-CSE-ConnectionGUID: bEceZCf9R2CKOyz1Z+jP/Q== X-CSE-MsgGUID: tzqTvqoCRi23GWEVKwQeQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,168,1716274800"; d="scan'208";a="67891055" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jun 2024 03:08:46 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Jun 2024 03:08:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 28 Jun 2024 03:08:46 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 03:08:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=llnagjq5HUoDzWiSjOKQ49GJ5V+/FNUD0kfGsStYBihCHE2+w/IbPB317UDJ8T9+gAuTtxc75kLyK9ub27nR4EremZRGSUdwtQJeFRg02hXN+dYidD/bOsV+EKVsNx2c5emlEqcAiwzi7Sl7uEYz1Qj3OJBYtr46xZnOoK13tsQirSFcCMz7Xv1MtSOPvUygqm5R4QRXMq2wX3GYydOoF9pLe7J63d22+r3YqkEhYliRQTxK/vcfOttLv0rpFpOn6AT7Kj/kQN7mI+E+vbgIjiWqlHMV3cDMzjeXMiNOGeibNNcfbFvjKCMHOWAvnDMozv81Wif49nf8NeRdOl/SCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uTku9PSB4Up2QQlQmBU5wy3fIRilq2aW7gqd+TM5pcE=; b=hHPVGjHCmtFBjJfIZAWIMcyI8sgozfkkin4lHRRX2qUy6VsroTYYGKLyZ/yZLL/qKgO02xxL8AKjNf9laZtW950Lq/AwWIGJ/7mPA7w5sAErnmhKsat2Gwi1ex0sHaeT8EidHLI4zw/fTSA+Ujdw3Z8/EzUVsgIMIcUdNZXzMnlhRxSpVFl3KCiAZnDUoJOwfPfjvuDP2bH+EVo0yduDLkUb3Szkp24NHn66RgYZ4caiXKh970+gs7xbdl7pyzLtkVNHoTZsq9XK/BXNzN3CpZB37IX3uSmZQZ2m71iesVUGeh9xSArlLyxP2N0ci/z7sEZgPYF6R1t/GottyCCdjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6110.namprd11.prod.outlook.com (2603:10b6:208:3ce::19) by DM4PR11MB6335.namprd11.prod.outlook.com (2603:10b6:8:b7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Fri, 28 Jun 2024 10:08:38 +0000 Received: from MN0PR11MB6110.namprd11.prod.outlook.com ([fe80::2d8f:193b:1373:62dd]) by MN0PR11MB6110.namprd11.prod.outlook.com ([fe80::2d8f:193b:1373:62dd%4]) with mapi id 15.20.7698.033; Fri, 28 Jun 2024 10:08:37 +0000 From: "Ma, WenwuX" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Jiale, SongX" Subject: RE: [PATCH] dma/idxd: fix failure to configure a device instance for DSA Thread-Topic: [PATCH] dma/idxd: fix failure to configure a device instance for DSA Thread-Index: AQHayR7aVj+5MzDFI0GterkjSs5uAbHc6KKAgAALQIA= Date: Fri, 28 Jun 2024 10:08:37 +0000 Message-ID: References: <20240628053458.78337-1-wenwux.ma@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6110:EE_|DM4PR11MB6335:EE_ x-ms-office365-filtering-correlation-id: 03289cc5-6f9e-44c1-6ef2-08dc975a473c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?wgMs5O9KHXtq3DmgIhchwvbFxERcaEmWWsE62j1ML554XVwLFX+nctYzsU1F?= =?us-ascii?Q?IJ+ke7pBjWP0PDW3cgYmZpQSiC9Ta2NYwuxosrsdAS1JJW3+jW1TCrFVAQeP?= =?us-ascii?Q?zkjZKPtj5qECfrHzBAdXOGGpcgTcAmoo5CPuHj4MMueSnCURXuDvRy58c8XP?= =?us-ascii?Q?MBblMiKlUwpC2Evh61olH+jF9gvctLblFukqNdhKVxNV0Vc+W+03lMAulXem?= =?us-ascii?Q?b+ev1cxcQplP1umG7u7OXdHhK2HxxUr58gWPHHEsGaZj2JAIUwUuKXGobbwJ?= =?us-ascii?Q?RRswQQtIp64S2upjOwnzCDR81HyEHZZT0SygOHH27Xck9VeX9Fp7Gs8or20c?= =?us-ascii?Q?+1+G/HUf7s/t0WCE/JzFZGQkhpoLOpxiTwkMROwjsKuDHSmyg2T1fVjwxz2V?= =?us-ascii?Q?mbgme3Rvn4GntKrcLk5PqtQ/vappI3nmaRpaJjHpHa9gnLQvIdG0Y5wtHpOl?= =?us-ascii?Q?PPySZJ5X/SnpHZRqXf4vl0POqM0glzc5pRf8ER/NSAGkbio/d/e+BRkBPe1A?= =?us-ascii?Q?eVeHruJN+6iHmpUZeS+xcXSy8jmFdeHAGTbW1O2OsSnyfzAbOVYQRjNTpSX/?= =?us-ascii?Q?mj7uV71jxw1Cg27NqVL3IYbRpt1iTANPidlRYYxXiVX6FyJhgdlJWZO1bZaA?= =?us-ascii?Q?Y/WLo7qsXATHv0jHA8bM/9GXgRpwy0Fksvu4ywvLBBeS6t8m8l5g7YyPpQMd?= =?us-ascii?Q?MWHT81o+0jnPCMeIOiYLHpcmQxMvyPZ60upTzx3BU0/2rRnyvxq1ynYMqf24?= =?us-ascii?Q?1coXKcF8KXJVsYje7uyuPO6SLrD5RPe3bB3fnrGyARYc65eDoJRnbRN+I/lo?= =?us-ascii?Q?iBQoZ9oEw5xAxWb+ImlcGtuc1np9XPbNnGrUviCQe22yP4pE89u08vw08OHk?= =?us-ascii?Q?seoINFWUI7NALS05B+MguRWuD4/70Zbrgln3CrPTo9rGrCFOa7TfV5y+4wXV?= =?us-ascii?Q?MRnpaV3NNe3UdB188gYSHwjgBH8EUtViJSo8kv5eV0TNvdxkvLgQ5UpGuEQH?= =?us-ascii?Q?CpcnMevu/DefrIY0JvnsQdAGLOBIL67YjWvsv45xmOraMPtbchi8l8mTTu4o?= =?us-ascii?Q?Pk9hb4mASm4EItqThTGcAKtpzxqk3QhWyv+J3BUzs6MehGjL48Gt/qCh5Q9h?= =?us-ascii?Q?66Xeiw+lYdSrQofIBb7Th/6j5GgW7wXsX+3Ac+rGeOCo4HUSJUcy3nm/U0VM?= =?us-ascii?Q?Tul+y4FEZh282EW48W00lpRnknPJgPNBxaluZRC30eadkUBT/jZAdmzt9xBh?= =?us-ascii?Q?1hLDxauCJhE4o5iRibWC3PcBGUFa5L+q/98Z/WF7BkmePf86zYlB6KsNGk+u?= =?us-ascii?Q?zaCETtnA08/DoywxtCs4cdlgsJimJ78cZixWwsuD1Xbven6Vk0YIa20/qwuo?= =?us-ascii?Q?jNWp3DOhhqfX8v5FS/jbw5e0NfDdIc0nSZH/MPBAIrb3aqbaRw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB6110.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I3GCoKmmx0wZ9aFzxTSqUQtUQg7lNUhzWy7afqc3PcilomGrnBlAp2DAmLkw?= =?us-ascii?Q?Y8jROCTnm4aI0OH9Zzw5BQ4MpUrsSzL0axtOr2PopNuQ9t/0vT+5LxL+H1Hz?= =?us-ascii?Q?9CQcSz+cknwsiBCRERj2G4FSTvfZmRkg5pa6M9fDrKoLoYOyB6H/Vtlyha3u?= =?us-ascii?Q?CkYZJhcWlmBibGZZng9V1dgV+te9EHu2Vomo8dpj5xURSS+QlQydtunx7nbP?= =?us-ascii?Q?PHf47KbRYwHMG0qkeH7Dsb5IfDFHqj21zOc9bg7X0rHoXGYp8q/s5E9aEj1i?= =?us-ascii?Q?D9LIoZUu+L8kOaYA9YGA945Ew8yZYxDFk6REdMuIyiJX7U4wzDyzxRRoTckY?= =?us-ascii?Q?FlBs6WvjJOIscOH2YblODEgTZdftj2ICBx1zEuHCXoiMXvUipfGxlKKPtfO2?= =?us-ascii?Q?ltSKEQ5lGg17m7wMZ7GK1uL6sjoAr53M+XGNQj61x9in2d0sv5QKHxNg8/TO?= =?us-ascii?Q?o9b1ImyxgfRBhL5ltg1+ms1x7jN5XKVM5ShshKaH9gt5oDVRBNo/PwBSmwDw?= =?us-ascii?Q?MgAh1w1HHeDniNojcfgxTLE8ZJ6jsvsDFdIp4M2IyNx3YuTigoB4HZFL5TA0?= =?us-ascii?Q?oVTzaxXrFAUz5JAMpRGBWN8Yvm2EHobFx9K/Z/lqFUkTj1L5avHCckw//zMc?= =?us-ascii?Q?incK4OJEF4+prL0HArMWzYcb74ocMLRYqyPz2AN83l5tOpQeIEtFfprlOizo?= =?us-ascii?Q?/nLYYGNV6MZ9Nid37ir6SoBcCD0Zof4rpfwrMeeI9hs3YAQhEM0SLFKKr52q?= =?us-ascii?Q?qabko5QtcrXuxzgSmELYSCfNAJjN/HqPvoociGKqK+xxgfnEC8lO1SflXNZ5?= =?us-ascii?Q?2w9ZP4EUECWFJKONz8oNGCJr39spRd02GIDirxC4yS1fWXBKBM7Y8zqeT9XP?= =?us-ascii?Q?7ndW4NUFp9jPnRWXsQJ15ZDh03TEVRczbQTS7xVPmSjBuy4KxUEn2beygOtt?= =?us-ascii?Q?y5TADwPcShb/sdM9IQoeVNTU5vXc0VPHahvv9VIinDbaPM4i/FvYE8MSRgv8?= =?us-ascii?Q?ufbZWvQojjyTjv8DwYPGYPwvd74/ucKRSR6FKYqwVYDo8CxD0goem7B2suNp?= =?us-ascii?Q?z0pZXmUQ61k6sY/PAOrMnTi3Rw47K5d23x7p1qEeQ+TaPocQ+q8mOvNVsTB9?= =?us-ascii?Q?WSLa5+04cRc3HI9efgYC1nemsj70wscIKXtOJ+p9/cHfAK08cZg9YbjVIClT?= =?us-ascii?Q?gh/nNTq/QmCpbFEbnQo18Fjij2QhRyQGLAw86PZk7GRLYxzkQpEbHwJdWyAT?= =?us-ascii?Q?tkc6WE6nWuxz0KiVKzlUqD0kLioNyzOVnk6lbnrAdFwl5rSBt+LDccDjbHZU?= =?us-ascii?Q?6BklDow254zV0o4ntwMzkJPRiNDaVMMzEM7l37re6lyLMjO55eUrqQZQCdLf?= =?us-ascii?Q?zLDQvp9H3EH+Cey0lJbLOLmi/QxM40sUTU1FnRBpyWOvnlzT+vFiUzjTP1+b?= =?us-ascii?Q?ZdbNmB2MwymPJlB43/fqQXyghc3waH6oo9VDC80kCrJiRDn4LOwXIcmuApct?= =?us-ascii?Q?6CSEn7io/5KfKBNu2drRBevWU6hp3fMsle2Ry8997Gy48pIdjAU200a2SmeA?= =?us-ascii?Q?0fLjqaRNnxJEs+r99ZJXzs1jb/5eMxjkDpMMwqoU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6110.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03289cc5-6f9e-44c1-6ef2-08dc975a473c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2024 10:08:37.7434 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qd1grExwujFreDPHi4QWAZFFo6dX1I3krOk6bNGicF/XV27X1n795FNeiaOVDK9+7nfyAJT5pxeyqPkprEHHlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6335 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hi > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, June 28, 2024 5:28 PM > To: Ma, WenwuX > Cc: dev@dpdk.org; Jiale, SongX > Subject: Re: [PATCH] dma/idxd: fix failure to configure a device instance= for > DSA >=20 > On Fri, Jun 28, 2024 at 01:34:58PM +0800, Wenwu Ma wrote: > > In ubuntu 24.04, DSA's workqueue has a new driver_name file in sysfs, > > DPDK needs to write a correct value to this file when configuring a > > device instance using the dpdk_idxd_cfg.py script, otherwise it will > > fail to be configured, this patch fixes the issue. > > > > Signed-off-by: Wenwu Ma > > --- >=20 > One comment inline below. With that addressed: >=20 > Acked-by: Bruce Richardson >=20 > > drivers/dma/idxd/dpdk_idxd_cfg.py | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py > > b/drivers/dma/idxd/dpdk_idxd_cfg.py > > index c0c833ade9..9ca4c4d76c 100755 > > --- a/drivers/dma/idxd/dpdk_idxd_cfg.py > > +++ b/drivers/dma/idxd/dpdk_idxd_cfg.py > > @@ -104,8 +104,10 @@ def configure_dsa(dsa_id, args): > > "priority": 1, > > "max_batch_size": 1024, > > "size": int(max_work_queues_size / nb_queues)} > > - wqcfg.update(parse_wq_opts(args.wq_option)) > > wq_dir =3D SysfsDir(os.path.join(dsa_dir.path, > > f"wq{dsa_id}.{q}")) > > + if os.path.exists(SysfsDir(os.path.join(wq_dir.path, > f"driver_name")).path): >=20 > I think this be simplified to remove the extra SysfsDir call as: > if os.path.exists(os.path.join(wq_dir.path,"driver_name")): Ok, thanks >=20 > > + wqcfg.update({"driver_name": "user"}) > > + wqcfg.update(parse_wq_opts(args.wq_option)) > > wq_dir.write_values(wqcfg) > > > > # enable device and then queues > > -- > > 2.25.1 > >