From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52282430C9; Tue, 22 Aug 2023 04:13:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 037ED4021D; Tue, 22 Aug 2023 04:13:30 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 36C1540041; Tue, 22 Aug 2023 04:13:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692670407; x=1724206407; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=konsDOKAfxK2UElW9jowivvhxKQDsij67+k78mx9aL4=; b=GXe2XHjGoxxP8D8qFSUj7GxWH2EM8oaSOvg3701LYoDhRY4W37ecZVOl 0AY65GkUoMIhF5L6xbywY6+4afTMQIpWEZOz3QQkdutmTW8zz2ixgadvw ByX5fQtgT7J5TO/+NRpYtR+TCtlvF8CsRLjWdAZk9CM+pLTvd0t5ulhO9 lZtA+tZudkCTYcpvXaKtXcVctlUEiukoMsQv96QasvcOSqGK5oxi1xgoI C/zXwZ0z3Z3TD/qbmXu02JPTBG0OVKQMc3J6nZWdFfQlJTVjIXM0+Ug0T 18deqY5Q+539sVxb+lQNi+htPtrlR+BmfWSYUffZHq5a53GHEt7onpm/S w==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="440123485" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="440123485" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 19:13:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="850414563" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="850414563" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 21 Aug 2023 19:13:25 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 19:13:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 21 Aug 2023 19:13:24 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 21 Aug 2023 19:13:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNOGrbwX8mQJPrP3PPHW+pPSal9YUunN9qZ03EWYIUDppJCJBj26R8pBpWvPCB5MBctonbBVldTk42Xj79g5cnPBnb6MqIwkHsf4l+NEiaZax3RrMcksrd+DNbTF4hNCoHtSu3zHPeLkIz6wfWaXwwlXi+MDq8fYFSfCRQg0UehifsSm70zZkDRbE/ogAKSV1lrDUupN1bb366W6POcEuApxYhZAQfQEkvYV8Z8PR8udC7rum+h+0zQq6mdY8d9GkFc7IdOO2tmg44yOJWASVPUun4EDMsrmPInUP+x0oLUImMOkg7hMdyrZTUZMk8iC3IbmoFkpRN0ioDQcWZZgQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=djo+xboCxHbCfrj5AETpnmi1dnTwJVXPYw03jlPk9EM=; b=QKAhE0jZAZazaw+rMKTWvyhTvDYJSCl/3xCiIizNJ/iAMeDyMviae2feJCu+ybQzk3dOYwwtIoteymSPaczxEoAqsea1+XzRoHWKGWIW8rz/zL1bIRisqdJNWedZUMTSiF+2zjTgpBic2ertVh3mRjbgY52VjoC8PKtlOIK08IrX4CTjQQQRBuv+abv46a3jn5fX0caKhNDlWJxgVxDZID8MBlkorSlJ4N07dFB/2pWiyaC46z3/vG4YC3rtd3negQI+kuE3CrKhG470hDV568RAv5DYQPkREZYHB05KnuCyC3D+h3lC8gxmYURLogHtWf0VUgj89v8aPZuMx+3C6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6110.namprd11.prod.outlook.com (2603:10b6:208:3ce::19) by DS7PR11MB7836.namprd11.prod.outlook.com (2603:10b6:8:e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.20; Tue, 22 Aug 2023 02:13:22 +0000 Received: from MN0PR11MB6110.namprd11.prod.outlook.com ([fe80::eed9:9130:4f18:775]) by MN0PR11MB6110.namprd11.prod.outlook.com ([fe80::eed9:9130:4f18:775%5]) with mapi id 15.20.6699.025; Tue, 22 Aug 2023 02:13:22 +0000 From: "Ma, WenwuX" To: Stephen Hemminger CC: "nipun.gupta@amd.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Li, Miao" , "Ling, WeiX" , "stable@dpdk.org" Subject: RE: [PATCH v2] bus/pci: fix legacy device IO port map in secondary process Thread-Topic: [PATCH v2] bus/pci: fix legacy device IO port map in secondary process Thread-Index: AQHZ08/PLMjdBeRJ/kei8ztMAnief6/0DZ0AgAGHDGA= Date: Tue, 22 Aug 2023 02:13:22 +0000 Message-ID: References: <20230807015820.1329972-1-wenwux.ma@intel.com> <20230821012707.315173-1-wenwux.ma@intel.com> <20230820195310.086bebad@hermes.local> In-Reply-To: <20230820195310.086bebad@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR11MB6110:EE_|DS7PR11MB7836:EE_ x-ms-office365-filtering-correlation-id: 6dbd80a0-fa8a-4880-3455-08dba2b55c13 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xm7yRxKkrqOvC4ticpl0jqQRs752hEujYgPqN2NB3Au6DzJfu7luljyYQl+vIdGIn7fbJLiGeb7Ybwj9B1w3YtMmwugZPmbCQEHgPSTwhs65lVCBkPL9gMTwtL/OiTzo/GmzbA41MocbpxCLo/XVL1C2l9m0vB+UdTVSt2MSaPihOFBVewBuVjJ0HbsLYaLsN8hvNGG0u1uaTID0+2R08ZfvvxskV0kW7whVqKhjBQz9xttG3rJLO1h3Cu6gBgBGIw9XnyaWX5Nj9I5tK+3W7d2yTy3eXGsRVVlU4hcSDjWu05tfuOc3OplLF+/9YutwdsmqvO5mRxKbrFrk7g56Lf6fraUGCwW/82aLJ3YJI01r/lESqnToCzWaFKgryV3d1Tdimy6ln+6W3ap6RKenQNa9UGaNfDdm1FBUf3+B7TdhWBQXPz5FymsoKhp641LOeg3Rz9pIfse929bMOu6i3wtxxC6H2zilyiiTKGx9tVEdiMy9XmqwePlaAfDMrxIAZ/e0kbL8AfN75jlZd065JFUGkLltjPeCpk6TXOykmH2DO5aYaqZ1H7zWHUSdedddWS+/NowxZ/EDoSS7SGHVW2o/qi+l7k+Y4x9bS/8hI3LIeD59QYpkN2BY/ESmsJBG x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR11MB6110.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(39860400002)(376002)(346002)(366004)(1800799009)(186009)(451199024)(54906003)(6916009)(66446008)(76116006)(66476007)(66556008)(64756008)(316002)(66946007)(9686003)(82960400001)(8676002)(8936002)(4326008)(41300700001)(122000001)(478600001)(55016003)(71200400001)(38100700002)(38070700005)(53546011)(6506007)(83380400001)(4744005)(2906002)(86362001)(7696005)(5660300002)(33656002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?VEh2Z0tNdmJibjBJQ3RaVlR2cmZqejIxam5NNS9NaE1wTFluVm5hVmlX?= =?iso-2022-jp?B?LzIwS1BpQ25kZFZHSHlJUHNVZjJJSkdnZDJtVDdWbGZGUkRnMlk5SFo1?= =?iso-2022-jp?B?NE5WTVlKZ0FUalV6bncwejdsNU5EcDBmekp2ZlZKUHBsenk0SytEQmRX?= =?iso-2022-jp?B?MFZobFhUTldML084Z2xnMmtNRFdxSUkxVTU2TWVXS242SEpyM1pOdysr?= =?iso-2022-jp?B?eXUxWFRSOVZXOVo5TWIxUGlHbnlNTVJocXRKZkFSNFJha1NCdTNwYzE3?= =?iso-2022-jp?B?U1V1VHNWNEgyazZmSVBQcEZmOVhGRkdvaXZhQ2k3eXduV0JFMGtHUEZp?= =?iso-2022-jp?B?U09oQ1pZMGVud295MVhSYVdkVG8vMHRLVzVRQjZ1Y1ozelQ0SXpuT3d3?= =?iso-2022-jp?B?VzUzWmJVT0RUWDR5WVVIZVJpUzNiOEpKTUl1VDFiY3NkQW9KZ1hlbnRw?= =?iso-2022-jp?B?TStpTUdkWWJvazhWOGNxNHgxLzBsVVdSbWZoZ2Fzcm1xdVhTSStXbXdh?= =?iso-2022-jp?B?RHB5ODI3T21rK3BXcDRXZ0p3L2I4eXY5QzlmMXRSR1BFMUJuT2EzbkhT?= =?iso-2022-jp?B?dUQ4TVl2Y3JRQUFIR0hsYVowZkgxYi8yMmxYaEJoWGhTTHFTQUh4bHdz?= =?iso-2022-jp?B?Wmw3T1E3c1VENlNEUERaTGNHZUhocjJXTmNLQnFVdElmQmZoKzVqY0Jm?= =?iso-2022-jp?B?aGthVDRPazlBYWIrbHFJTVZTN0JESFNTWDRFTTNBa1dBQTJRZHZiNm5Q?= =?iso-2022-jp?B?L2w1dk00M3pCZHhxQ2J0NVBjRG1HMzlvdXlTRldmZkM2OU1Sb2o2cTRl?= =?iso-2022-jp?B?cW9WRk0vaDZkVzI1WldlSUxmTy9JQ25jVG9yQ0dqdklyZGpFaFVScXkz?= =?iso-2022-jp?B?alVHNEFaYTNXcVhDbTBRZkxJVTVZQ0xOYVlIRVoyR0tYMU1vOVVBMXEx?= =?iso-2022-jp?B?eXlFV3Brd3lOeGpWblJud0pwWFpRWDhyRjBTVklPWndCQ0t2VnpjNERi?= =?iso-2022-jp?B?MlNZbVAvVnB2TVdPWGZoc1IxWEc1SWhrSEY2eXF6WDVsQkQ0Q1VuTFRT?= =?iso-2022-jp?B?a2VVMmZsQm56VUEySkV1dVJIMXFmWVJSUmhEZkdIVEpHK3VSZ0xRcFU4?= =?iso-2022-jp?B?eVpHWUtlSzRPK0FqVnpDSThFcjd0RUpYbnRaWmtaMzl6UnpoSi82MjBC?= =?iso-2022-jp?B?SHp4VTNZa1VOZEp0UlJRTUFhRUFnazUydFRxQjU2bWNXWldEMzRmeTRt?= =?iso-2022-jp?B?TGt4a1BEOWpiMEkyTitWRGJHcVc2eFdmUG1vWHhULzNmRXVkVnJTMUo4?= =?iso-2022-jp?B?QVVEY2wycVNnU3FqNVhObkRiY0ZtUnA1ZFNCZFgxMk1WWGN6aWhMUnhp?= =?iso-2022-jp?B?V3dGZW9WcE5GcWRZN3BJdW03VXZLdzBCRllUd0J2V3EwcnhadiswVmVw?= =?iso-2022-jp?B?NVI4aUZhNzQ1V3ZnaWFUSjdUSEZPYXlHN3YyOEh4Q012dElici9kei9y?= =?iso-2022-jp?B?aGlFUHRxRk5IMk5nM0xRZ29lZmxhdFR6MWk0QjdPUHJTWWt2REtjWkdq?= =?iso-2022-jp?B?Vkl5VktSV3piSmpOK1RWbXZJWXdvcG9BRVNGUnliUlJIRlQ5YkdZL2Zo?= =?iso-2022-jp?B?NDVDS3BaMFdEUE5VRFRKYnNSRUJIV2VLZzI0ZHFUVWhCdk9BYm1GTnNU?= =?iso-2022-jp?B?M0d6S0FiR3FNSTdrSGVIbnhWdm1VZHgvRFZrczV3aGY3UkszNjQwbTNz?= =?iso-2022-jp?B?cXpwMVpnbzVNRGF6Uk9jL0Q1b2FsbVVzdUJNVTY0THcyaThkWkQ2UnJT?= =?iso-2022-jp?B?ZlhlUytBUU53TmJiM1RBUjZyYkVBaDRtcHprNTNCVzJzVTZORDRrakdz?= =?iso-2022-jp?B?OWhMbUhFeFdIYUpBNm9HWG1MdTlvS0kwZkx1czl2QVBjVDVnYzJUeFV3?= =?iso-2022-jp?B?TnlYdXBEQVUweEhLUVdhOWVFcHlZMkVaTDBZbVIxelNRL2JCMzRyRmVy?= =?iso-2022-jp?B?blN3VEkxTVVlNFlkMmw4Vm4wQjFIbzBSVWV1M1lVWENnNUVIenJHWEs4?= =?iso-2022-jp?B?ZUV6UXVQMlpvbUpSMFBjQW5xSXNOczI1WUxFV210a28rS3FWSlZ3aXNy?= =?iso-2022-jp?B?TXRLT05EWlJnd25oZVNLcUxxVWFJTS8xeVNUZlpDQTJQTjJaNUtsdlh2?= =?iso-2022-jp?B?UXczRVNXSHlDZFZQcFdyZXo1Y0xVQXI5NFkyeWpXZ25KbDB3Szh1dUNR?= =?iso-2022-jp?B?TG84QT09?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6110.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dbd80a0-fa8a-4880-3455-08dba2b55c13 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2023 02:13:22.0350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eqRqvqfCkbdLvOguFO3KYrr86TOCIpp54cRsW7XQtF/wbedDaIIhUy9xWni6zpEJYdGuq4xyfV7GJ1D9j0w1yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7836 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Stephen Hemminger > Sent: 2023=1B$BG/=1B(B8=1B$B7n=1B(B21=1B$BF|=1B(B 10:53 > To: Ma, WenwuX > Cc: nipun.gupta@amd.com; dev@dpdk.org; david.marchand@redhat.com; > maxime.coquelin@redhat.com; Xia, Chenbo ; Li, > Miao ; Ling, WeiX ; > stable@dpdk.org > Subject: Re: [PATCH v2] bus/pci: fix legacy device IO port map in seconda= ry > process >=20 > On Mon, 21 Aug 2023 09:27:07 +0800 > Wenwu Ma wrote: >=20 > > + struct vfio_device_info device_info =3D { .argsz =3D sizeof(device_in= fo) }; > > + char pci_addr[PATH_MAX] =3D {0} >=20 > Not sure if some tools will complain about initializing chars as zero. > Anyway, why bother since you are using it with snprintf. >=20 > Also, the new variables that are only used in the secondary case should b= e > declared in that if() not for whole function. >=20 >=20 Ok, thanks