From: Raslan Darawsheh <rasland@nvidia.com>
To: Bing Zhao <bingz@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Gregory Etelson <getelson@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/mlx5: fix the workspace double free in Windows
Date: Tue, 31 Oct 2023 08:05:05 +0000 [thread overview]
Message-ID: <MN0PR12MB60561BDCE00BA0695672C8F6CFA0A@MN0PR12MB6056.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231026091447.10991-1-bingz@nvidia.com>
Hi,
> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Thursday, October 26, 2023 12:15 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Suanming Mou <suanmingm@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Gregory Etelson <getelson@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the workspace double free in Windows
>
> The thread specific variable workspace indicated by "key_workspace"
> should be freed explicitly when closing a device. For example, in
> Linux, when exiting an application, the thread will not exit
> explicitly and the thread resources will not be deconstructed.
>
> The commit to solve this introduced a global list to manage the
> workspace resources as a garbage collector. It will also be executed
> in Windows, but the workspaces have already been freed in the
> function mlx5_flow_os_release_workspace().
>
> With this commit, the garbage collector will only be executed in
> Linux. The workspace resources management in Windows will remain
> the same with some stub function when needed.
>
> Fixes: dc7c5e0aa905 ("net/mlx5: fix flow workspace destruction")
> Cc: getelson@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2023-10-31 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 9:14 Bing Zhao
2023-10-31 8:05 ` Raslan Darawsheh [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-26 9:11 Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB60561BDCE00BA0695672C8F6CFA0A@MN0PR12MB6056.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).