DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] common/mlx5: fix unsigned signed mismatch warning
@ 2024-04-15 23:09 Tyler Retzlaff
  2024-04-16 10:04 ` Dariusz Sosnowski
  2024-04-29  7:46 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Tyler Retzlaff @ 2024-04-15 23:09 UTC (permalink / raw)
  To: dev
  Cc: Dariusz Sosnowski, Dekel Peled, Matan Azrad, Ori Kam,
	Suanming Mou, Viacheslav Ovsiienko, Tyler Retzlaff, dekelp,
	matan, stable

Use unsigned int for 2 loop indexes that are being compared against an
unsigned int struct field to avoid signed/unsigned mismatch warning.

Fixes: 718d166e5504 ("net/mlx5: create advanced RxQ table via DevX")
Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
Cc: dekelp@mellanox.com
Cc: matan@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 9b7abab..9952733 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -1816,7 +1816,7 @@ struct mlx5_devx_obj *
 	uint32_t out[MLX5_ST_SZ_DW(create_rqt_out)] = {0};
 	void *rqt_ctx;
 	struct mlx5_devx_obj *rqt = NULL;
-	int i;
+	unsigned int i;
 
 	in = mlx5_malloc(MLX5_MEM_ZERO, inlen, 0, SOCKET_ID_ANY);
 	if (!in) {
@@ -1869,7 +1869,7 @@ struct mlx5_devx_obj *
 	uint32_t out[MLX5_ST_SZ_DW(modify_rqt_out)] = {0};
 	uint32_t *in = mlx5_malloc(MLX5_MEM_ZERO, inlen, 0, SOCKET_ID_ANY);
 	void *rqt_ctx;
-	int i;
+	unsigned int i;
 	int ret;
 
 	if (!in) {
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] common/mlx5: fix unsigned signed mismatch warning
  2024-04-15 23:09 [PATCH] common/mlx5: fix unsigned signed mismatch warning Tyler Retzlaff
@ 2024-04-16 10:04 ` Dariusz Sosnowski
  2024-04-29  7:46 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Dariusz Sosnowski @ 2024-04-16 10:04 UTC (permalink / raw)
  To: Tyler Retzlaff, dev
  Cc: Dekel Peled, Matan Azrad, Ori Kam, Suanming Mou, Slava Ovsiienko,
	dekelp, Matan Azrad, stable

> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Tuesday, April 16, 2024 01:10
> To: dev@dpdk.org
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Dekel Peled
> <dekelp@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Tyler Retzlaff
> <roretzla@linux.microsoft.com>; dekelp@mellanox.com; Matan Azrad
> <matan@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix unsigned signed mismatch warning
> 
> Use unsigned int for 2 loop indexes that are being compared against an
> unsigned int struct field to avoid signed/unsigned mismatch warning.
> 
> Fixes: 718d166e5504 ("net/mlx5: create advanced RxQ table via DevX")
> Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
> Cc: dekelp@mellanox.com
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Thanks,
Dariusz Sosnowski

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] common/mlx5: fix unsigned signed mismatch warning
  2024-04-15 23:09 [PATCH] common/mlx5: fix unsigned signed mismatch warning Tyler Retzlaff
  2024-04-16 10:04 ` Dariusz Sosnowski
@ 2024-04-29  7:46 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2024-04-29  7:46 UTC (permalink / raw)
  To: Tyler Retzlaff, dev
  Cc: Dariusz Sosnowski, Dekel Peled, Matan Azrad, Ori Kam,
	Suanming Mou, Slava Ovsiienko, dekelp, Matan Azrad, stable

Hi,

> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Tuesday, April 16, 2024 2:10 AM
> To: dev@dpdk.org
> Cc: Dariusz Sosnowski <dsosnowski@nvidia.com>; Dekel Peled
> <dekelp@nvidia.com>; Matan Azrad <matan@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Tyler Retzlaff
> <roretzla@linux.microsoft.com>; dekelp@mellanox.com; Matan Azrad
> <matan@mellanox.com>; stable@dpdk.org
> Subject: [PATCH] common/mlx5: fix unsigned signed mismatch warning
> 
> Use unsigned int for 2 loop indexes that are being compared against an
> unsigned int struct field to avoid signed/unsigned mismatch warning.
> 
> Fixes: 718d166e5504 ("net/mlx5: create advanced RxQ table via DevX")
> Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT")
> Cc: dekelp@mellanox.com
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-29  7:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 23:09 [PATCH] common/mlx5: fix unsigned signed mismatch warning Tyler Retzlaff
2024-04-16 10:04 ` Dariusz Sosnowski
2024-04-29  7:46 ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).