From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC28245588; Thu, 4 Jul 2024 12:34:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98C1040280; Thu, 4 Jul 2024 12:34:56 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2049.outbound.protection.outlook.com [40.107.236.49]) by mails.dpdk.org (Postfix) with ESMTP id 3897D4025C for ; Thu, 4 Jul 2024 12:34:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZgUOf05Pl8WScOHjDSKghZ1jibtY/qeVtky1vYF+gpDkq1rO5REpBxb8/UXZyLwPVhQOBp7Aqdf6AWBTAWimW5HqIzz2U4ChTHSlIp47AZ1TME6Z5VCJ+0ifw6zUXF5WrxjVb22wSJ1VHECHJLM3eCKSl5pKvWaCRempO6ElEMjbM6Bz50BPZ7mz7WgHnQJL4LJ9ZPeN7L9SWYc3mBp1A2j93qCDf6YBO76mPUi4Ek+W21doxjdIn3wv7/kVhWC7bNexvl8O33fnzx8XS+fvGJWWy8LI5jeVJf0rSpmzwbgNNXHYxodbL3nc9SXL+52JVMN0WQghroTS6wnUAguW0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xF+Zr5+Pt09cxt2ghYeUxbz/K+5S5FxkpSwB2JSrVOo=; b=j4anP4jCOdX227g50qoLSPAtVtlwoyUtdGNYKz2q30JCAPqkGziaGc8EuSWUhMlxHmZCuY8HBNOUHtwZicVqZAcQecLJLOSSWzADfumOLjdzXk8oyXfQuR2u/VcbFgwB53A61fWz9Be/iF8ZCv4OtrjTduuHWV8Ra5B9mC2O/n4iYBqZTmyu9a/b5cVAzhsVyfmLfrvF+2z1dAlnWiysDUd6EgX49z9T5bLWItcjACMehVypQs/QHuh0ipm7vWvCa1mpa3i+eyyE24tnGExdFGsotmAD+PXcEDGoDUe20ocq7j1PsTWFFLQpKQjU1YsubwgeaSlUceCzlKFtULilDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xF+Zr5+Pt09cxt2ghYeUxbz/K+5S5FxkpSwB2JSrVOo=; b=If6z0yoGqDAH8gCz/AsNuly0oDNG/Tl5y4daXtIwgOk33xr6Avn8iUalTlGx1hqhGD7DyIiiYMcwBsHtUDrIijJU6zJoUBkz5nIxin6bUNmR2uYEk97muXX4OsK99UVSQF7hWyohotC/z1V9i2HiqNuQoBEdDjdIAD9CtpeT6RxMwXEfZQyR1WRXKHUq8DRADb6mtL+CEmJ6xEqY4KRdSrt3k2pkeDAHLjj3HYPdmC2TF6uHNV215X48KiThRcxG8Hcd0ZKY2tLfk+a829qxRyc40BHNKlvHEzwyNW6zog1VjHwZeop02snsfEziKE3prp4M9qdlN/da+rZ0ycHGAA== Received: from MN0PR12MB6056.namprd12.prod.outlook.com (2603:10b6:208:3cc::12) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.25; Thu, 4 Jul 2024 10:34:51 +0000 Received: from MN0PR12MB6056.namprd12.prod.outlook.com ([fe80::4b75:36f4:f278:fcc0]) by MN0PR12MB6056.namprd12.prod.outlook.com ([fe80::4b75:36f4:f278:fcc0%3]) with mapi id 15.20.7719.029; Thu, 4 Jul 2024 10:34:51 +0000 From: Raslan Darawsheh To: Mahmoud Maatuq , Dariusz Sosnowski , Slava Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani CC: "dev@dpdk.org" Subject: Re: [PATCH v3] net/mlx5: fix matcher object memory leak Thread-Topic: [PATCH v3] net/mlx5: fix matcher object memory leak Thread-Index: AQHazLyWOz9Qzm6NtkqgzTsAvamIYbHmYdU3 Date: Thu, 4 Jul 2024 10:34:51 +0000 Message-ID: References: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> <20240702201450.349991-1-mahmoudmatook.mm@gmail.com> In-Reply-To: <20240702201450.349991-1-mahmoudmatook.mm@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR12MB6056:EE_|MN2PR12MB4208:EE_ x-ms-office365-filtering-correlation-id: 6f018af0-fc7f-4302-3925-08dc9c14ef98 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?Q?OCXEQmPClRzBA3SpQzoEHuPAQ0Uaay83KGOQL23Hpw8alqeLpSU2TZD3H8?= =?iso-8859-1?Q?0AKF+Ck3QcrFsemtZ40bDYGveWa35cEFtXbz8L+gr8nwY05Z25HExqAN19?= =?iso-8859-1?Q?c+imh1TG0haucgR5xgY6YtgGlQHpWJsKBbYvoZKglQx2RLbe8cumG9Zty5?= =?iso-8859-1?Q?0V8Cx7kp9NJoTLpplgPh/BoIL2bsVEToTz8zSKKDZKk9eoN+lnWgHuRvuP?= =?iso-8859-1?Q?ajupgzkWoDX13zeFNERfGTxpr94fIabrYprL8/j0Djkui5A0GQYO52Hfed?= =?iso-8859-1?Q?P7ZS7BItvEaCsZKZvFuD2gXitLWPo2bDo7yCAsD2JJ0AqxB+Xuss3YYWv7?= =?iso-8859-1?Q?hevWnZjg2J5NwVV50sFqAOwhv8fW46QHyTr2CXdFmUQpVY6/VHToQ9VP7e?= =?iso-8859-1?Q?GONhB5L4QUA0FJMwA9H0A3nyhqQfPaec0HuE+z0zy1gXf2ygvgitG6GMcc?= =?iso-8859-1?Q?TCGRiarO0LdsjoC3ntcBlEl1km9G7ycjo+HIAkTdKYE93jSivCurIsarAV?= =?iso-8859-1?Q?N5VaqyUSbhYuvdYn8uzRv+F4+gg6a7It7MSWi63R0R0Nls8D+kNhZ86IxR?= =?iso-8859-1?Q?YboyVSQQwWOg/S3s2DjatsUT6tiDjdho3bak+3lmSuKS93mvYM19KCOKCP?= =?iso-8859-1?Q?47ud2aFuef3yasHQFnPk/9q7dpaOQs5NYTMcBbtTtRKBKmAb4nALVOcQK8?= =?iso-8859-1?Q?todbwZ35d3dKgMLRYzDziqgsTAhLzLl7dYUxcUoPdJgjmLZ2rz3rNJMlWM?= =?iso-8859-1?Q?gMVUBjKL46hIXcqD2A68+qpwPlNJYnO11RuQc8l9jIkQUEHHs7/i5jwX1j?= =?iso-8859-1?Q?h8S6GJIT7h6G1PHXOG26nhqNbVZOGxMz4x9L9avyYJrWmJChz9O7xZp0yI?= =?iso-8859-1?Q?/Am8/PywK7QA/oTLBm3t8O4LTFdzKZU09sXZS7Bu0n3KEcv3rQ1FkcHN5y?= =?iso-8859-1?Q?lKbd8TmBAJ+x9l0eyXOyINyxbH/VU+Y6pcK/gdQa//LQG9FInjxLjsD3rA?= =?iso-8859-1?Q?OIMtEHhZ7pPdTr0noCJN29wiK/PRPtmZmRsaP67zTWYjsA1jzln1YyB2/S?= =?iso-8859-1?Q?4lfgYQpHO4aOwgXqT8cOL1onsJWo0yrBeXioVlEeYIP+FKmA8/419SU9wE?= =?iso-8859-1?Q?97nd2Qhr3ZT2ZLc6xtLzEeyKkfdWVQyvMDoUvSbfGcuUvQgjhF8iFdDP/S?= =?iso-8859-1?Q?OQGRg/gvFt/s96/9Dgm5P/bzME9yaaoMwBz8wthuM5KX5RfoI0SHXizmLp?= =?iso-8859-1?Q?RK8drV7TJg2qws77U2a9+Q6gQMKLp+R5mlfQFdW2h3U49UKWgMvcQ1gIFb?= =?iso-8859-1?Q?9pLKSeAYdXcyw9ZeWAwFneixZQC7KuscVrl+ne3czfEEoblrHPugH6USh0?= =?iso-8859-1?Q?sgQUZu7XD1Zvt3eW8Y3x76wS3ymIZAw8dyq/h9jKj5L4tnmog0T7aRyn/C?= =?iso-8859-1?Q?jvz2LiygpR44DVMszTyGFgsl4mA/ZjPdnQvgtA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR12MB6056.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?+iWaOJmP/N1cKVszWkdDgM34cVIYUjcmu92iFy+r5MIJJ3j5pTTCRR2oRh?= =?iso-8859-1?Q?BqaPWPKY46gn7UyK8+pIDz7jmr4BCxj9wggIimSio4egszlBr4GKzCt2z0?= =?iso-8859-1?Q?bchggznKTNq3kFiO4AeYEQK74Usc2kpbusZytyZsL99jxQ9QI8E/3a0WAg?= =?iso-8859-1?Q?UWWSDy452jsYQPNeKoFfz4uuVDJzS+R0R8UXmlCIlm8D0S3rWXFNsYDWVP?= =?iso-8859-1?Q?B9kvfLx0JCDEmIwHUlNz/O47aohyKYGAjNSuwjdqX736MYqpnzzy5oT9RN?= =?iso-8859-1?Q?4f79FE2uveJIyv4+klzj6SYXqq07L5u+XPUF42blQcbPnxGMbig7E8uPEc?= =?iso-8859-1?Q?oveccPLKc21Om2FZSBJRVfKq2fnyNdXU0N+gBRsB3doHM6uWVRqlytl1O9?= =?iso-8859-1?Q?9Lgotu9jP2FQ61SKud2XRa1+cSAL1ctmCqMsypwVaJysPLttGwxb30UP0L?= =?iso-8859-1?Q?dz2WU9iFYaRGe4AhCUznbPYTaEOC4idIjFKvkzI942oXuB72sJlKUTEika?= =?iso-8859-1?Q?G8UbrpcasgTIyoa0M96Sp5cFmbz5Iw2FAPVHHvUYHOaEI9xKeypDYOTmt+?= =?iso-8859-1?Q?8symPtJAHNWA5Kk88TFizqN5LEryT+ADkHvN9zL8xXHjl7OFLU6iNFbp9N?= =?iso-8859-1?Q?+VrhFmTFbPwh3rKqxJKqsVlmlpkcVOCbbeo16LVYPKdMRYXKYtgS9Nd19x?= =?iso-8859-1?Q?3rKs+s2XO2ucQEwv8g6kAb45mIbsUBXN5ax+CH+KKdYKWSQEAp+SRI62Zb?= =?iso-8859-1?Q?mhgCVuFmVW0Kn0EtQ9/Vu2tbLMrDf8ucOa0dAoc2XJBSBbc3HoCDp8qodc?= =?iso-8859-1?Q?AaZuKyGViO7JhSqNnMOd08V/9M1rxGf2jWgfhY5LzFv0rBWpWzNxJhmYc3?= =?iso-8859-1?Q?/QI8kc/cruTv06deE53RAWyt4apTlSHNyXOUoc9P1fwYtxhQdTqAiG5zJg?= =?iso-8859-1?Q?r9j1cstxLdUUhxtLhpb2RoXTuaVqZd5GqwBVF1hRrH7zVtvRb8ICNUdEEa?= =?iso-8859-1?Q?vCptgYBIH/BB4gi2zCfWQKc+Ck7fjHyNvZiAiEIBfN19di6QkOwsbzte9a?= =?iso-8859-1?Q?fI26xl5RyZTIg0dNDerY+/HOjsjsohnERtx1x+3p2ZfI4u5LeU1tZ5AZjO?= =?iso-8859-1?Q?lJE1K78btonJgrlrKZXgGb2AYiJakwNCXah4Hgn65vOZ8MfZIkmJsyNyEi?= =?iso-8859-1?Q?HoA6LmOwd+hmsMZvjNE+8B7p1eOsZ+D97Ks7K/N/Z9tpP9HifKJIUD6sTw?= =?iso-8859-1?Q?IZ9/LisS10lsCkgPCBkR4NhjSRJZi/oRDFNFn4CVgUIdTsKw3ZlJbHTC57?= =?iso-8859-1?Q?z/D7ZDXE4/Ck/fDD/Zh1ugIXXPg8aXtR0h2Bg2pE8q9PW5P4LKqtvqTaNN?= =?iso-8859-1?Q?dD38nTdid/t9vgNBgQW8Vvfo+ccSfi5zhq4tHob44/0xom2vjkhyDokT0O?= =?iso-8859-1?Q?GDeBg4wFWLhaS7t5b9Zw1tz8h9f/U66sCbVnpqZOVQJDCPgIAUTMWRaM+6?= =?iso-8859-1?Q?swzKDcoPaHoWsNzNLpciEiicbFDPkuGmN/E+yGUqQim1xnOblU3RF0dcwb?= =?iso-8859-1?Q?vlXL2b7wMas1AL0YZlc8zTqCy8LHa8Gw2k6xBGzzswe/4GCwVk1LkEh10T?= =?iso-8859-1?Q?j3DYTn6ugXQh99IOngQftbQ8OznHVdMqgY?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6056.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f018af0-fc7f-4302-3925-08dc9c14ef98 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2024 10:34:51.2246 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gn8a3jSWz5g/IB+VTvT7LRJ1SC1u6M+yLk/YTB0A8dWgZW5jIt3HvAlsiHB9T16Gh6nFZ59Dlfegv5Z+gGcSRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi,=0A= =0A= From: Mahmoud Maatuq =0A= Sent: Tuesday, July 2, 2024 11:14 PM=0A= To: Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; M= atan Azrad; Maayan Kashani=0A= Cc: dev@dpdk.org; Mahmoud Maatuq=0A= Subject: [PATCH v3] net/mlx5: fix matcher object memory leak=0A= =0A= This makes sure that the allocated matcher object is freed=0A= for all branches that return NULL.=0A= =0A= Coverity issue: 426424=0A= Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigure= ")=0A= Cc: mkashani@nvidia.com=0A= =0A= Signed-off-by: Mahmoud Maatuq =0A= =0A= Patch applied to next-net-mlx,=0A= =0A= Kindest regards,=0A= Raslan Darawsheh=0A= =0A=