From: Raslan Darawsheh <rasland@nvidia.com>
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Maayan Kashani <mkashani@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>
Subject: RE: [PATCH v2 2/3] net/mlx5: fix sync meter processing in HWS setup
Date: Tue, 12 Mar 2024 08:03:43 +0000 [thread overview]
Message-ID: <MN0PR12MB6056DAC17C43E4725A33CE54CF2B2@MN0PR12MB6056.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240307101910.1135720-3-getelson@nvidia.com>
Hi,
> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Thursday, March 7, 2024 12:19 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Maayan Kashani
> <mkashani@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org; Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>;
> Suanming Mou <suanmingm@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Alexander Kozyrev <akozyrev@nvidia.com>
> Subject: [PATCH v2 2/3] net/mlx5: fix sync meter processing in HWS setup
>
> Synchronous calls for meter ASO try to pull pending completions from CQ,
> submit WR and return to caller. That avoids delays between WR post and HW
> response.
> If the template API was activated, PMD will use control queue for sync
> operations.
>
> PMD has different formats for the `user_data` context in sync and async meter
> ASO calls.
> PMD port destruction procedure submits async operations to the port control
> queue and polls the queue CQs to clean HW responses.
>
> Port destruction can pull a meter ASO completion from control CQ.
> Such completion has sync format, but was processed by async handler.
>
> The patch implements sync meter ASO interface with async calls in the
> template API environment.
>
> Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action
> with HWS")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
> drivers/net/mlx5/mlx5.h | 35 +++++-
> drivers/net/mlx5/mlx5_flow_aso.c | 178 ++++++++++++++++++-----------
> drivers/net/mlx5/mlx5_flow_hw.c | 99 ++++++++--------
> drivers/net/mlx5/mlx5_flow_meter.c | 27 +++--
> 4 files changed, 216 insertions(+), 123 deletions(-)
Series applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
next prev parent reply other threads:[~2024-03-12 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 10:56 [PATCH] " Gregory Etelson
2024-03-07 10:19 ` [PATCH v2 0/3] " Gregory Etelson
2024-03-07 10:19 ` [PATCH v2 1/3] net/mlx5: fix HWS meter actions availability Gregory Etelson
2024-03-07 10:19 ` [PATCH v2 2/3] net/mlx5: fix sync meter processing in HWS setup Gregory Etelson
2024-03-12 8:03 ` Raslan Darawsheh [this message]
2024-03-07 10:19 ` [PATCH v2 3/3] net/mlx5: fix indirect action async job initialization Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN0PR12MB6056DAC17C43E4725A33CE54CF2B2@MN0PR12MB6056.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).