From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76732A0350; Wed, 1 Jul 2020 19:04:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56CE31D148; Wed, 1 Jul 2020 19:04:12 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9B0D01C1D0 for ; Wed, 1 Jul 2020 19:04:10 +0200 (CEST) IronPort-SDR: Jb70lp+k6maw6jjT3B9jKdvU5xE53EAd0Ok/Cb5fE7ahvq+5VHbJLVCC+3NLCWh7UE4/Q4UQD2 0ZsTofQJYCqA== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="134936011" X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="134936011" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 10:04:09 -0700 IronPort-SDR: 1UlnQMs0IROsRxejPpVll4wrosq7+c6dEiMh0QPURPPkGcKR4EKKICelvoJsgptmX+LVNC1r1Z a+NnI6a+4R0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="481666584" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 01 Jul 2020 10:04:08 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jul 2020 10:04:07 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 1 Jul 2020 10:04:07 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:04:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ibUChW7EUxTLDx2LCcw9jGEFNMfsCX062TZ5Xgiy3ydSrK7ekM+Bh1jx6HpCSgedL7JG8l+RSEj9yLZUYJASXjzrYFEfwScOEFiSYRcWGzQpQaq0HLcL/cT9R8EF2fUcQdZcQbARQZzdh4VKbJSVzHV15u1QBC01pa7PyQ3oloew7qOFIRgXjokeZRAzkwoYJTAyUVOTnleGzs4RjAgLLflpueSXiHwG9oI7nVVrnC7N+iQivPGvMG5JPvqV3pDrTXFU9CtuEEzavbtPz2pSaptmmtjp3ADgq5qKZuxSI7hevvpJjDM+FH5GOHrJ4DUjAV0nh1uaAur5XoKcCtiqIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eRO/OleuiskgYTPNsuLWIBsI6F6S2IMmNSbL4if5wYU=; b=AvVlJ/AYLN3tAYRuCoswLDafKdrLo65B1w2/Fy9ub5r+bKdtXe3LIvSLhWKJc5LL35f4fFouzZZdRfnvIwxGA4KZzu8J/jhd4nLlCZRsGr3hKZAROHs8k0x7stKmiZGAmhJQbdemrFkvopch7bF5gVAQ1Rd25UiiSWgt5ZzksRiGo+vD2+xwRcVPokxKR+IUn64VELhqPNHlApTiKvCNfg2e1trRtj9T4TfyaAkZxFxzSJNaKZ4Bw/KnswDLLXk+kvGP6IDDhJVmAKUiCmTB1Vjhc66rAjzH1qNQkN33tIptkexA4P5d+A0iew8lirZGZw6UBhQAmo00f77Tiq7WlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eRO/OleuiskgYTPNsuLWIBsI6F6S2IMmNSbL4if5wYU=; b=WS7HJ175L250fcg+IppWSrinO7JbCu5W975K2vjEnpzkR4OJKnI0sIx0eCkXdPwHrckXy3r9sM6Gf0AN9Zz2rIC8wHmAPt3Adb+UR2Op2roBPzcvO11wSjzu0GcSs2YiNJ0en36KhecFkV11uAPg5iExu8NdILXlq3dJ/pwOJ8Q= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB4046.namprd11.prod.outlook.com (2603:10b6:208:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Wed, 1 Jul 2020 17:04:03 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8181:d8ec:fef7:532f]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8181:d8ec:fef7:532f%2]) with mapi id 15.20.3153.023; Wed, 1 Jul 2020 17:04:03 +0000 From: "Coyle, David" To: "akhil.goyal@nxp.com" , "Doherty, Declan" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Ryan, Brendan" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "ruifeng.wang@arm.com" , "lironh@marvell.com" , "rnagadheeraj@marvell.com" , "jsrikanth@marvell.com" , "G.Singh@nxp.com" , "jianjay.zhou@huawei.com" , "ravi1.kumar@amd.com" , "Richardson, Bruce" , "olivier.matz@6wind.com" , "honnappa.nagarahalli@arm.com" , "stephen@networkplumber.org" , "alexr@mellanox.com" , "jerinj@marvell.com" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v3 3/8] crypto/aesni_mb: add support for DOCSIS protocol Thread-Index: AQHWTv8BZ/H0ZPCMEU+OOIWGFwwCiKjy5PgA Date: Wed, 1 Jul 2020 17:04:03 +0000 Message-ID: References: <20200623101423.9215-1-david.coyle@intel.com> <20200630163049.61900-1-david.coyle@intel.com> <20200630163049.61900-4-david.coyle@intel.com> In-Reply-To: <20200630163049.61900-4-david.coyle@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c31e8b18-d33b-4c4a-0f8c-08d81de0c1b0 x-ms-traffictypediagnostic: MN2PR11MB4046: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0MnBSmC2MYfdri6A6AvZehUFN9dc36kLOkXPo1LnSgykv0+yZbWCdb6MN55KKeFFKtzVuOhXfY2lirKa5K8gpqsOc8TDTY8Uni6C8ENJLXHOT7Xlyv2RZx9L/8yp/f6wCww2OpBv4MaFhG4iLDa94tWm6jrmVB0zn5NRNNQlQN7mjjJoXW/2dwOqPwhZioAoxw4xmJLKZ3Q1gIeRcX6ZXoHMkTDrTzDGYItx5xJ1WN6xjFE0Hbkkqb8hGxLqPBqqJA14JNzex5Ko4eSw5Qf3fOfCxHxfxCz+/5h1qDM6U2TpPODnkCx7kq3+0L4OrNCN5M5mpBjVrvXYuTNE2WnUpwMSdLjxlephJgFwHt1r5banCp7hLBplgRDpP0TrYHhy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(66946007)(66446008)(71200400001)(55016002)(8676002)(9686003)(76116006)(86362001)(8936002)(316002)(7416002)(4326008)(52536014)(26005)(478600001)(6506007)(7696005)(54906003)(110136005)(6636002)(186003)(107886003)(66556008)(64756008)(66476007)(33656002)(83380400001)(2906002)(5660300002)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Yv0jynKVYnE9adCA0/62NP+KsvLe36O6JuBeb8l2ycvK4QDt4xM48NEWsxl+2y0YzSpOxKboRPqcL53jw4fvSzoBOSI12AzyvP3qZ1gK+cNoBqJPtk+OH9GN/H4+I8Le/RrFOTdMTq/lgqTT4PP4xOhhU+1kJDqFFZi6NSTAloAqnWVO4yYAt7SRzWzbb5bbb4N41iTnhAyr/nftltPGoMggxtpX2+rbKeqo3ORCzDLzjUU+EEqPrT5HpVpk9qcY6sr5KiL7JdZRTycNLuI0bKqUdslsHIvD1eLdqQuTGfvCWcFbmgJ1iYIagavGtFG3FVTXHBvGJdnCdTuATmfdawGWeJhJwKyfQ36/3GdRKOddLAXF3Gdvgnbm/aAIU2h5Jc/KaCVJDTuixYg5bEC1fzRjdgjxSsVC1hN54a/wZ/7W1vkS0CrTcqn5T9e86V3M2cRKvC0VmPz40LQ6GKUmwbyKOhYgIQInB8ygnCFiXM3d9QbitUu5WJtCgCUCTrOs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c31e8b18-d33b-4c4a-0f8c-08d81de0c1b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 17:04:03.0387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 87QzKpxnkmSZ/jIRxdoKeChzvKJN6JiY2ZjnM/hsTKCqw0VtpdjhSVZoDQ7D08eIrnRLnxVWQKsAfi7PUHaPpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 3/8] crypto/aesni_mb: add support for DOCSIS protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > index 2d688f4d3..4b25c5e23 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > @@ -1647,7 +1914,23 @@ cryptodev_aesni_mb_create(const char *name, > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | > RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO | > - RTE_CRYPTODEV_FF_SYM_SESSIONLESS; > + RTE_CRYPTODEV_FF_SYM_SESSIONLESS > +#ifdef AESNI_MB_DOCSIS_SEC_ENABLED > + | RTE_CRYPTODEV_FF_SECURITY > +#endif > + ; > + > +#ifdef AESNI_MB_DOCSIS_SEC_ENABLED > + security_instance =3D rte_malloc("aesni_mb_sec", > + sizeof(struct rte_security_ctx), 0); > + if (security_instance =3D=3D NULL) > + AESNI_MB_LOG(ERR, "rte_security_ctx memory alloc > failed\n"); > + > + security_instance->device =3D (void *)dev; [DC] Possible NULL pointer dereference here... will fix in v4 > + security_instance->ops =3D rte_aesni_mb_pmd_sec_ops; > + security_instance->sess_cnt =3D 0; > + dev->security_ctx =3D security_instance; #endif >=20