From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5580A0350; Wed, 1 Jul 2020 19:03:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D6B01C437; Wed, 1 Jul 2020 19:03:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C7CB11C1D0 for ; Wed, 1 Jul 2020 19:03:34 +0200 (CEST) IronPort-SDR: uYWPlSy6AwHLzRYoZq0IjN9CXQecOQcw7q6k8vKJH5efEGncpPjtkoAuy8oSbp63LmIP6s4T4g yR5i0bi6uXmg== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="126268156" X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="126268156" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 10:03:33 -0700 IronPort-SDR: QiU6dHAzf5TBlu4xdV9DIlQVc00tONqp9+SeO2WNWLTk70PzhUV6HIB6BhzPxVAGf9x0Bt14Fn IEd/DGfOI8BA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="425655165" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 01 Jul 2020 10:03:32 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:03:32 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:03:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:03:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enjCl0bwavApdQBxzzqEZd5nnFE2WhcXBi1WuafhITEi1B6LBqwSAYWvm2yv4i5EbH7xk68e0eJ6f+b2oq2AeXPl9LMzGs/iy0hybW6SrptkA+rIDDNYbRcXmOKqaFWHa3CkgURhiUztINozPszaWJofr8b73YSWoHvppRsTjqWbz5vMloH+0jhjdWDIDUfQn/Vzg9botSRmzBDRAeYss/EkSHnScRZqBfloIyQaz3+2Rk3m4Ei/aaQRiTX8ocbTxQXlJDubQ9sPGcq+reM1VkFB1MFKcTQsTr4BHF5fYdVdnDp91Fjg+8Axe39X6TwzlLol8Z6zeYSdNHnNsW2mZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GJSrNWD+cpSqE4v1nOtxBn2Zpm7e7vFguPs1jcd6HU=; b=KkHfcNNGo5ZsGl0wtsVCTfe59MrVrTP2/JvORnAqn9v0jVVxyVmAGnSqmWuN7kH30qtUuNrCmhR9M/McL+JvCVz/81Uo6qHeK5+R6+9z3xmQCM9kkFeuc1t4Av/58Dku32F0E3Gw6NDPKlf6M71bNyRehT891ioGlVhTE7TLlNzJS0qBK4PsS2fT5kINVd4sGbPliGXN5vW00+QTQFCif2LzFUH7oWOoy0kyvb05WtjjW0pZWk8Fq2Cex/GueQWCkby8EvFBbGKklhGHeRPFSUyycdjih2QdmcC7wc03jqGzE9qEfM3+6FXhLHUBe66z9qnTM8N9066O/Qgj1eEzgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GJSrNWD+cpSqE4v1nOtxBn2Zpm7e7vFguPs1jcd6HU=; b=p0IqVkybjymjLHdK1IXJdixnGLKoyE7peIlBmOrLQKOsXxt4p9kzwYP3ikehTb3Ab+ou9HmozXUYbl1iP1XiOuJl6Yl/EP6ssnmKlHFZ9SwxVheusO0mANLJwjTS0M2gzB9KdaAEbUISM9VGuY9kmVxgQoXz8qf4M0INN1cIw4o= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB4046.namprd11.prod.outlook.com (2603:10b6:208:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Wed, 1 Jul 2020 17:03:26 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8181:d8ec:fef7:532f]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8181:d8ec:fef7:532f%2]) with mapi id 15.20.3153.023; Wed, 1 Jul 2020 17:03:26 +0000 From: "Coyle, David" To: Akhil Goyal , "Doherty, Declan" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Ryan, Brendan" , Hemant Agrawal , "anoobj@marvell.com" , "ruifeng.wang@arm.com" , "lironh@marvell.com" , "rnagadheeraj@marvell.com" , "jsrikanth@marvell.com" , Gagandeep Singh , "jianjay.zhou@huawei.com" , "ravi1.kumar@amd.com" , "Richardson, Bruce" , "olivier.matz@6wind.com" , "honnappa.nagarahalli@arm.com" , "stephen@networkplumber.org" , "alexr@mellanox.com" , "jerinj@marvell.com" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v3 8/8] doc: add doc updates for DOCSIS security protocol Thread-Index: AQHWTv8blpW2pN+9SUCHC5ALodyJjKjxe/aAgAEIbaA= Date: Wed, 1 Jul 2020 17:03:26 +0000 Message-ID: References: <20200623101423.9215-1-david.coyle@intel.com> <20200630163049.61900-1-david.coyle@intel.com> <20200630163049.61900-9-david.coyle@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d0a78f3-c0ee-453f-c1af-08d81de0abed x-ms-traffictypediagnostic: MN2PR11MB4046: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rg04sNsBnBoPsq05xYy+zt1asNMHnGQlhI+JIFpf3k7Y5IW+Kq9yxQIoMNQw5xWaUyMK7LxnFbgrmbvt1tKO2wUMtHBZQDnP/2cdtt4vOiTEFRboMwJYSGtLeJ4JV27yvVYUuMtESL8Yd5OimIqeCzvFBju+ywWrsKAE5c/aO3ev3s0tZwf+LSxlXsGakasL85ApzVf9sw0jz31MrAgblJazd8VlCPMAPfvWelTaRNpaQ02MljxSwG1eMAUxHi10mKjkYyNDxw9bB3G/+c53NONTKV5KRZLTHz3pgxGnsjCdWMmQ9zynup8x90lWG/cPwqvj+xCMI8NFxuvgfB3H/cGQnGLujyQhBZGxmLLZhpo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(66946007)(66446008)(71200400001)(55016002)(8676002)(9686003)(76116006)(86362001)(8936002)(316002)(7416002)(4326008)(52536014)(26005)(478600001)(6506007)(7696005)(54906003)(110136005)(6636002)(186003)(107886003)(66556008)(64756008)(66476007)(33656002)(15650500001)(83380400001)(2906002)(5660300002)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: seT/F4hSMd4B3rXapN52E838LC6kmNjVRNA2/tfIv0K0o/Y7gmu8Tg5Wwixf7ixBY85KNI8UxS17bPQ21hHE80Y6OS8kZW4XTrcAEtJXys8b+4L3fG5aSQNwHlTFsz1171/1rlvdyCJIIoIz3Ru5KeefRyZrpecXUB4vfjvdHri9u4NXxpu1TIzKx07T2qGVwgq/Ks5Cl+USmb8HnV9Jpz7idkAQyhPHY6YB6b6bWLGE1WgK2adkPBNhrAoggwXifioJzdhNIpu/d2+ot7l48cZwnO4M4Etfnw9xVG7kX4DDD8+kKN/600bvl4ur9HxB8+7LnnvTJnEMuixlHm3vQKQ+FhjAfnVZe2kJE1EDP4ONUyu11syJRq3jRGgpMwLOOwI5CbJ3eslFzvMifkm/MiV++YqwtWvYqrVdU5MUemT/qMNbAC4GwmMjjgWyp2f67mIu18lSbFuPdo1WqQNand/8esvsfbtP3wVgspzAqISqcDiYRNjKAw9lkUVgKVk3 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d0a78f3-c0ee-453f-c1af-08d81de0abed X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 17:03:26.5211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c4ViDsQrHyExdxHyrBJOWulAVsBwnnDucZRPHzxnWXO1l2u9hfI8vJ7to28hyDE6ZkoeHfUWIO2Vj507E13Q8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 8/8] doc: add doc updates for DOCSIS security protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, thank you for these comments >=20 > This patch should be split and merged to relevant other patches in the se= ries. > rte_security related in 1/8 > Like aesni-mb related changes should go in 3/8 qat related should be part= of > 4/8 crypto-perf should be part of 7/8 And release notes should also be sp= lit > into 3 different entries and squashed into Rte_security, qat and aesni-mb > patches. [DC] I will make this change in v4. I will wait until there are more comments before submitting v4. > > + > > +The CRC is Ethernet CRC-32 as specified in Ethernet/[ISO/IEC 8802-3]. > > + > > +.. note:: > > + > > + * The CRC offset and length are specified via the auth offset and > > + length fields of the rte_crypto_sym_op. >=20 > The above note is not correct. It should be > * The offset and length of data for which CRC need to be computed are > specified > via the auth offset and length fields of the rte_crypto_sym_op. [DC] Yes, that is a good clarification - I will make that update > > > > +* **Added support for DOCSIS protocol to rte_security.** > > + > > + Added support for combined crypto and CRC operations for the DOCSIS > > protocol > > + to ``rte_security``. Test and test-crypto-perf applications have > > + been updated for unit testing. >=20 > Split this release note entry into two, 1 for 1/8 and one for 7/8 [DC] I will make this change