Re: [dpdk-dev] [PATCH v3 4/8] crypto/qat: add support for DOCSIS protocol

["Coyle, David" <david.coyle@intel.com>]

> diff --git a/drivers/crypto/qat/qat_sym_pmd.c
> b/drivers/crypto/qat/qat_sym_pmd.c
> index e887c880f..711d1585f 100644
> --- a/drivers/crypto/qat/qat_sym_pmd.c
> +++ b/drivers/crypto/qat/qat_sym_pmd.c

<snip>

> @@ -308,7 +346,20 @@ qat_sym_dev_create(struct qat_pci_device
> *qat_pci_dev,
>  			RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
>  			RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |
>  			RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
> -			RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED;
> +			RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED |
> +			RTE_CRYPTODEV_FF_SECURITY;
> +
> +#ifdef RTE_LIBRTE_SECURITY
> +	security_instance = rte_malloc("qat_sec",
> +				sizeof(struct rte_security_ctx), 0);
> +	if (security_instance == NULL)
> +		QAT_LOG(ERR, "rte_security_ctx memory alloc failed\n");
> +
> +	security_instance->device = (void *)cryptodev;

[DC] Possible NULL pointer dereference here... will fix in v4

> +	security_instance->ops = &security_qat_ops;
> +	security_instance->sess_cnt = 0;
> +	cryptodev->security_ctx = security_instance; #endif
> 
>  	internals = cryptodev->data->dev_private;
>  	internals->qat_dev = qat_pci_dev;