From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF944A0350; Wed, 1 Jul 2020 19:05:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CD2B1C437; Wed, 1 Jul 2020 19:05:03 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E7E021C1D0 for ; Wed, 1 Jul 2020 19:05:01 +0200 (CEST) IronPort-SDR: KhPj/fTC7NoEBVBgjIVKh+CwkW/ZGhfDVmnJLvIoWJYCsA+hbpU1oaoT6bKhnA6Wi6iX4LUt7W yPxgLWKjnThA== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="144162830" X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="144162830" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 10:05:00 -0700 IronPort-SDR: ZtTYVhlYFctP5AgmjTqrQNX9gwcLOenjtjcx+1AyioTQq4T6L58Irikj27awn/0pW/jC0M6tO2 mQyiDueKQy3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,301,1589266800"; d="scan'208";a="321814089" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 01 Jul 2020 10:04:59 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:04:59 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jul 2020 10:04:35 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 1 Jul 2020 10:04:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 10:04:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VHqFKBTrNyI04OgNGuGBy+JK5vRX0grdxjZ6XUzcfNUm1sBSixcXnpHKMgq1JYAl46UbaO0nVzu8GEuzB1vGqef2JaCtqzaP4k/FyzKHYrJC+eIdbL00mFZVaEs0MpN61ljmC2hCThqJo1L5ffIN0yRlUoILgwp4htLMCggSAQjznfi/VPKpWuD7gitsjq+HJtpmNyRNJ89IsqQIueunqfenoP6L8iawizMUwYbKLXTxSqjr+bkjHqg3lNqNJwIMGf26BygoOvqYva86AieNLLawok7fht/u0FTIoyFKMP6+83gPYaTxyTpKEvo86uisCXBW1B+EaN/6q6vjkc+CSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=du2lH3uh3CF40aJLOkvXAzWcK4XUdPuN3YajQGpCSIo=; b=OBsqkc1juoqQqK8oplieHGnP+htz9TgcR9oAtnZx6i83M3IzLrOXNC+x47I79OG443ZgAO8klj4DSSL/NLDPIopXMUKyd+moGusJvfWopNgA1MGXEckmtrr5pM3N3Rxfca2ZOj+mfwHLO+2c2nGuhbmwVhJ2wJ+iFMPKeVzYNSW1ipvT857L2IGAnZDklDzuQgm2s6F0RJ+t8UUzSdLuoRnJ9k9ziuSQ/kQn0kjeh8u4smgRmAepbv6tgKt/Jq8DD3WtT/B9MahHHwAVAPKlyF2joNhxwmZv+J71RzW5N03yHyMFXckHJs3GWsHq6sa6DHjBiZ7P/5YUsZTTm5vTQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=du2lH3uh3CF40aJLOkvXAzWcK4XUdPuN3YajQGpCSIo=; b=smhURHipAIVNvmDz6DGQNd6uri04FATmsWYGbPdPuW/MSXEqD0ibLDZMlrCX0x1jy083nzXNluUEQO7mOZqElyf5RE5/zxsi8+SKG+dLSYdIfQ4JbVqi0c5JvJO12T+4DHGjKw0GO1ifFCfo6KHWk5dp4SsSq+dMp89m6di7Law= Received: from MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) by MN2PR11MB4046.namprd11.prod.outlook.com (2603:10b6:208:13b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Wed, 1 Jul 2020 17:04:25 +0000 Received: from MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8181:d8ec:fef7:532f]) by MN2PR11MB3550.namprd11.prod.outlook.com ([fe80::8181:d8ec:fef7:532f%2]) with mapi id 15.20.3153.023; Wed, 1 Jul 2020 17:04:25 +0000 From: "Coyle, David" To: "akhil.goyal@nxp.com" , "Doherty, Declan" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Ryan, Brendan" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "ruifeng.wang@arm.com" , "lironh@marvell.com" , "rnagadheeraj@marvell.com" , "jsrikanth@marvell.com" , "G.Singh@nxp.com" , "jianjay.zhou@huawei.com" , "ravi1.kumar@amd.com" , "Richardson, Bruce" , "olivier.matz@6wind.com" , "honnappa.nagarahalli@arm.com" , "stephen@networkplumber.org" , "alexr@mellanox.com" , "jerinj@marvell.com" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v3 4/8] crypto/qat: add support for DOCSIS protocol Thread-Index: AQHWTv8DHy7kwmf6Q0G9mLpLqYr+IKjy5pwg Date: Wed, 1 Jul 2020 17:04:25 +0000 Message-ID: References: <20200623101423.9215-1-david.coyle@intel.com> <20200630163049.61900-1-david.coyle@intel.com> <20200630163049.61900-5-david.coyle@intel.com> In-Reply-To: <20200630163049.61900-5-david.coyle@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bffb1334-8f5c-4f10-8714-08d81de0ceea x-ms-traffictypediagnostic: MN2PR11MB4046: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kOXBSeZRdyUUTMmMzBjWlhvmXRWUZpDMxmtIc5Xkm7Hk2oMX4DpAY9UJIXSbGPr3MenU0W09t49q12zF5Us28f4P2Sb/AuR9TvL+1mrddWfqq1jmVgYDuQwpycvGURloI3DkC0lyMn75GUez/oMc13MV0VFbkK/AqFHOddVIuBm8X70Oh9PXvRPcNUa0+NZuNkTqP6SebgGyfHWn2RDqqDt+WsGR8VudRKj5W1ywFJLWiGvC7SbJde0isiFac//8PW7G4OWulxcM4WE0QPtcFeIk/q+ROeEf97rrwFn/RbWgu8swLeISkfg9arPc0IARXdkrgOTvzuZed0Tpm+76NBiLnwOJtB2/zP7/RiaQfJQ+5Mx09bnao/7jDkoof+oq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3550.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(66946007)(66446008)(71200400001)(55016002)(8676002)(9686003)(76116006)(86362001)(8936002)(316002)(7416002)(4326008)(52536014)(26005)(478600001)(6506007)(7696005)(54906003)(110136005)(6636002)(186003)(107886003)(66556008)(64756008)(66476007)(33656002)(83380400001)(2906002)(5660300002)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: DFWOEXrCTo0vsnNENttWrIFYjAxh8viJgVMkR8ndZ3ZdtfnAJypaKaZokvwEcN8IxnBVyryz8FSsGKw1PAJZoqLf2bsr2t+ePPgBLdVkugNzEwJtwOzQ0Mxeay+rhnW9ZEGi5QZRdzeQ6KBzpostsodPNWjBzJhX40h4wOflPI+O0vWeKlsIX32OlZZQmVfIlYj2xOYMYvaUgsV6iXufPjKQ8MrxCOQDG2/R5M1B7rBK2uMBMQaKNG0jPf3KKXuBrOT7Lq7YbymiQn6YwxLNafCcBn/KtJoPySTRjsQ6wmQX+kYJovRDvXsHbSh/HQQ2FrrWjhubUxJvSXGhyp0aM8NoYRwDZCajDT0UWRZFckOKFv8HC+elttYVnlfFV3xXDNTvlv197Uiiv54NQgp4T76SbfK5OE8HeeNcnO7STkOGPG4lcg1yYxat042zmNfHSZZGo5JOnF10MnnRraYZ8TMq7yuxeqPJgy00hv/gAobsWRCz5UkO5UeiSJQF7pAW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3550.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bffb1334-8f5c-4f10-8714-08d81de0ceea X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 17:04:25.2012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: evgeVB+KFR8FVx43RuTDEU6zVla/32icm2xRisJHMuCeaI12oUqgIw39dE7S4uSci8W8WNBrqVC2QLtgrcuAoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4046 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 4/8] crypto/qat: add support for DOCSIS protocol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > diff --git a/drivers/crypto/qat/qat_sym_pmd.c > b/drivers/crypto/qat/qat_sym_pmd.c > index e887c880f..711d1585f 100644 > --- a/drivers/crypto/qat/qat_sym_pmd.c > +++ b/drivers/crypto/qat/qat_sym_pmd.c > @@ -308,7 +346,20 @@ qat_sym_dev_create(struct qat_pci_device > *qat_pci_dev, > RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | > RTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT | > RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | > - RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED; > + RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED | > + RTE_CRYPTODEV_FF_SECURITY; > + > +#ifdef RTE_LIBRTE_SECURITY > + security_instance =3D rte_malloc("qat_sec", > + sizeof(struct rte_security_ctx), 0); > + if (security_instance =3D=3D NULL) > + QAT_LOG(ERR, "rte_security_ctx memory alloc failed\n"); > + > + security_instance->device =3D (void *)cryptodev; [DC] Possible NULL pointer dereference here... will fix in v4 > + security_instance->ops =3D &security_qat_ops; > + security_instance->sess_cnt =3D 0; > + cryptodev->security_ctx =3D security_instance; #endif >=20 > internals =3D cryptodev->data->dev_private; > internals->qat_dev =3D qat_pci_dev;