From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 448F9A00BE; Wed, 6 May 2020 08:30:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A58AD1D6EE; Wed, 6 May 2020 08:30:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5BEF11D6E9; Wed, 6 May 2020 08:30:10 +0200 (CEST) IronPort-SDR: eknvvqaVHGD0KJxTyoA+04iU74UVG2kC0w+8KC+3kfxH/F0YoMBemJa4FXRKCSjJUd06ftUeaw omLd2w+b8o5Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 23:30:08 -0700 IronPort-SDR: pT6R2c9ljnA8/s7zFBo4rHpGRLs/q6tLiIC/w9XxZ/YDDH0ZvsvCXAtEhwv30u2HAEyc0EpL6A DHc8iKGWmW3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,358,1583222400"; d="scan'208";a="296081855" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga008.jf.intel.com with ESMTP; 05 May 2020 23:30:08 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 23:30:08 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 5 May 2020 23:30:07 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 5 May 2020 23:30:07 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 23:30:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atHAOumiBuj7pbxvhwCheaIP+A4tEoJZCe2DbqruVORGCOHWvg5wh+/zfSRO1rhxJKkrO5gBxDT6RmYnpDRa+Y/S5jmqo1sh7tfg1YgnhbqrffcXJ7RpBZXIVsG3PVtOGX42vE3KJpTyaH6LlGtvZUfCuG2LUi15hIKwCcvMl71waA1qBg+tLWvO2wMUYE+cQ8ssDqv2VoqEeRhdQaPMVdhnzKKOD4VA1Owbr/FUbpw4LSeevZCOyxN5tcH2yrNFGTiQgPCABVXclR2ZWDxQTJO3aVxL+PQ5qJr2ZTP8f3lt9njDkGdCz9eiTbwINDoA8ZBfVI4n1q7VwZcIyyVzYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjWOS6CJU9xXC6prJd5C9qotxa/TD9oHfbOPuJ2n01Y=; b=dskDgdpKhBx+VLskoylSt6N1aGJYmqVxFAQyZwjFXFTixPsgqf6QpmHl4yGBwyfoFJAB+kukTkkNaqCVxni4z8ULG+Z23IzOMeOlfRJjQG5DDtstIt9+2fff2msOsJmA97vDxJn6gnrZx9GkGpcpG58DOSM9wXcyzNkOfup6tMq0Cms/C16gQyTkv3LrpWhT4IpPf2Cdp3kqP7sdzIf11LT/G0kE5RGNIB+ApzRUVKPhURqpHc3E3wBqop2QND7SHXApCjoIXd+xBjAQM3GWKK39xReNHjxSboLjsXaU88cHjapKtLcpl65NioihyJwc7xBnojMNik0pxOQxE1fRAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjWOS6CJU9xXC6prJd5C9qotxa/TD9oHfbOPuJ2n01Y=; b=lUkZHJzHI3PMHrQKcH2dDBBncVuXgRwXV+c7oX+zw12aGk7aZtpY7MYylWcy5n0nVSRV1IqsfOjz1aUOJkvypMM8ZRigvebSKrlKL96g7q2Ut8m87Go0BA40S4p86mWFfes8wd8iv3Hw5zNeGjVB4Q0BH/Wp67fNhr9rAUU3U4o= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB4061.namprd11.prod.outlook.com (2603:10b6:208:136::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Wed, 6 May 2020 06:30:04 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::e1c5:b5cf:5a94:379f]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::e1c5:b5cf:5a94:379f%3]) with mapi id 15.20.2958.030; Wed, 6 May 2020 06:30:04 +0000 From: "Yang, Qiming" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ice: fix core dumped issue in switch filter Thread-Index: AQHWI1P4WYYTisW/CUmDmUAMXTidRKiamMDw Date: Wed, 6 May 2020 06:30:03 +0000 Message-ID: References: <20200429072516.65403-1-junyux.jiang@intel.com> <20200506030525.3907-1-junyux.jiang@intel.com> In-Reply-To: <20200506030525.3907-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 744c6373-58c9-4e44-62b5-08d7f186e97d x-ms-traffictypediagnostic: MN2PR11MB4061: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 03950F25EC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HmUqeUOFihXa9OmFdALhARY0eQE5V2y+FmJl888FOA5syPKRTdayuGgchRFJqJY9MAnOGg3nIRXDbCyAP+OxdtBfm6s0HGU7xGq3Z0+Jjm6nF5mDE9l+KaAiSVm1tJAO1tok94qneKKON/hWN5hulQlTESUpyvn5F91axTjG4GppUiwmuuOfFqGjKWZ2MO7z+UjnUtbbZ9lna/hIF+XIuA+/VEx/LTiByoW84P6hK1qPd8yGYN+vYXMwLWbNzGK2KIkRHWksH1GMdVzHyPypzvIF4S2BNMsDFTCybzzDlaK43Rrwc+kMNmIbORxbAB/xUHrKHSBtkq9lj1oIluLtWnAQ0Tbb6uZrgAD3MmdS8hlfnuilsIpRizCG9g8AVEd6xf3MwpABOTKbwOFhBBgCORE1kkKoOlAsr27FUoXQSGpm33VA61olE5jUIXbliiEjRZKZ7qgIJlpDl3Pw3AEmylAugc2qsobGRlmFNZ0QD5t/SycP4OKbvc9aaCC50tcHJuIr4reYt/TQBQaNOkQqBA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(39860400002)(136003)(396003)(346002)(33430700001)(66946007)(26005)(2906002)(86362001)(110136005)(316002)(9686003)(478600001)(186003)(8936002)(55016002)(33656002)(8676002)(5660300002)(450100002)(4326008)(53546011)(52536014)(7696005)(66476007)(6506007)(66446008)(66556008)(33440700001)(64756008)(71200400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: FHOX3X7psubTGEpxKEKnjwbk00yORlRIIX82HyVji68GgoxhjxRCMIpCCVP3Q/h6JgrSvv8/kiypxUDebYPBL8cm9Rn+apdzCChPAqlwikPwnLAOvY2Lku9oYVbYkhC+FU2WO30kboBjmuCsp9W6aRniwrwNiiTKUQtHl84iQB7jcCCIk2djMt2OnoZhskDnCiExewYcAvvVyI46/s98prZrL3Sj9+JAgiagZuHxgGON6r82nTE8DT5c9o9vFQxdl2FjlmuFroxyBI2Uz2fKq4WuyXwUI5VJOzswupK7tYF5y1p8Uwtai8h8PbSi8evZoCsO+BomhHPHPtZXIsULWxJe9Cw4A7pYwo7jFsZBC9tdaBHnZSPRWm5y9Gk1sgBDWZSc4PBwoQBe8NZ04tntZmSkX3/MeSL+afaWb1KTb+uY8W20zrBUo7tTnp3sgEai0uSIbLUSeP8TGX8tDdq0pQJMgnFfWNWKdAKBnFFJc2h3yrkVY0Ujd3k+S4GZgRO7MLKKbEJYQDC0TWM+Dl1ESfjBnDEGoly/mGU5driMOPs/rMMAMITu5y4MRg6zp1lltkcHQMpAWlZ6F+Y21tr9OS5jdaaxGVvDm5KoNhvETF937stVrwQjQbF/82mCZ9TF3NNAgHzXvabT5cxTdOO2jhdzb3mNS8dO3gnP8QghfLFqTXBM5JOkM/h15czNiUU9sRu6vSX82yEoTmkF00KFxkxWazZqN+mwHBd+00x1MPftxOa39eN8pOnY8TQeL46VAWM/3zI3PooO9/A5MkOmOTz1uYy8erSqK+ZBwnzyd18= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 744c6373-58c9-4e44-62b5-08d7f186e97d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2020 06:30:03.9286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lzub4tSBz8Nz/Po1EusUk4Mgzk+m4xA6yh952+6NPcD7N6tNQhrteZuN+8F8EgvoPFi8UTVz4oxJm6OK/tn3vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4061 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Qiming Yang > -----Original Message----- > From: Jiang, JunyuX > Sent: Wednesday, May 6, 2020 11:05 > To: dev@dpdk.org > Cc: Yang, Qiming ; Jiang, JunyuX > ; stable@dpdk.org > Subject: [PATCH v2] net/ice: fix core dumped issue in switch filter >=20 > The number of queues in queue group should be checked before using it. > This patch fixed the issue. >=20 > Fixes: 47d460d63233 ("net/ice: rework switch filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > Tested-by: Qimai Xiao > --- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 179430136..c2762e331 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > switch (action_type) { > case RTE_FLOW_ACTION_TYPE_RSS: > act_qgrop =3D action->conf; > + if (act_qgrop->queue_num <=3D 1) > + goto error; > rule_info->sw_act.fltr_act =3D > ICE_FWD_TO_QGRP; > rule_info->sw_act.fwd_id.q_id =3D > -- > 2.17.1