From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A9B8A00C5; Thu, 30 Apr 2020 08:52:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93C761D904; Thu, 30 Apr 2020 08:52:44 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 884A31D8FF; Thu, 30 Apr 2020 08:52:41 +0200 (CEST) IronPort-SDR: j7O8Lfysqg93zb3/q9KGIUayR2LgTKkK5LxgYBF08Fmee9yQQQRN5FHOBixm5zKH4xHi5d/g+D KdmidajNRtYg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 23:52:40 -0700 IronPort-SDR: LYv6Jrtoy6Ubk22peysSbgEDHG5SctEfmiZObpZ3ZD6wbz941s4NolE12FJf0Ij5jNgD84AJRd QB0x2rgGM1Qg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="459833067" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga006.fm.intel.com with ESMTP; 29 Apr 2020 23:52:40 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 23:52:39 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 23:52:39 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 23:52:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNkCf4T86RCxX16lmaGlS54A045kCGN9lUejKIp/C86acedVJLJXgA8q2HmWRRq9OCR9evFnVvBDdpH6W3OeibBoRWyq6iuMRdboGpJ84eMWFHXF7AxNXfpFR07FDfhXx6TQT5pXvC4ZR1NGZAUF/pTk3T6yI1eVE6gs4Lj65PsrUw5S9MBqs1zXPxiEYKiOnHmqpOpRN/rmSgBbHFcpbQ1MXAGOEnXGTGawc7tm79mXreO/OUzBg4oK6WfGRcR5dOnnHFpHdP0DFaFRuCKzzcB8stoFRdZYzBDwLdqPHF2yUamzndYcrHyS9ev0mrgziBhIvZ/XRYXduEEk/1dHAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UIOOpDwouqSTn/vdWyF5C45yDzYBw6VfljrlLu++9nk=; b=GqdIlJB6PFzmteRsNNg3LQzw53Y59DFpktw72y8TjxNarvHxXXHw5Fo2bUBuA7svcmXDVZMGgzMOkA7emUZXvby9vVEPV7kZrlMcU9f2UP3I7TirI6bu4g4KWeO8WDfpQ7NGpRhSMpKHw9Z5XSsHSUcHp3p9I1L4xzRdLEVTs8JvERiDXM1HTj7RegaQhImBe3r3ttoL2nEMGaj1zK+8qfr06NNRuBPpOU+EvZgtehPYJSipIuEGyK6sENTCq35DzcQz51pfVKMChvfEso6F4YyKZ7FIhQNhvc41SLWXIXqKGHbaHzuFY/C2rCFz9voj7LxxReRasAybxX4v4VxirQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UIOOpDwouqSTn/vdWyF5C45yDzYBw6VfljrlLu++9nk=; b=WFHgAs7qOyPuTk3DJrGN019BmVZ1phWc02P20MlsGuJtzKXCySi5ACmDyLNkWouGj/7wSiZath1m8WB+nz11FFswctTBHcHk5oHrPzXsAGNMZDh0hqEapRagCob4E1PLRHQE/lvaqe9zIv91exqFNmFBeXcRnCfumlFV7cF3To0= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB3663.namprd11.prod.outlook.com (2603:10b6:208:f5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 06:52:38 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::e1c5:b5cf:5a94:379f]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::e1c5:b5cf:5a94:379f%3]) with mapi id 15.20.2958.020; Thu, 30 Apr 2020 06:52:38 +0000 From: "Yang, Qiming" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix core dumped issue in switch filter Thread-Index: AQHWHfpEK4wbTdrw3E+vW59ts4jxu6iROrSw Date: Thu, 30 Apr 2020 06:52:37 +0000 Message-ID: References: <20200429072516.65403-1-junyux.jiang@intel.com> In-Reply-To: <20200429072516.65403-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 15f144e3-3fc8-4303-3ff9-08d7ecd31207 x-ms-traffictypediagnostic: MN2PR11MB3663: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(376002)(396003)(39860400002)(366004)(346002)(316002)(450100002)(8936002)(4326008)(71200400001)(478600001)(8676002)(2906002)(5660300002)(9686003)(110136005)(7696005)(52536014)(86362001)(55016002)(6506007)(53546011)(66946007)(26005)(66556008)(66446008)(64756008)(66476007)(33656002)(76116006)(186003); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tYPVyxLID29mwT6IgNxW/cQKYcKLzNHr3e+RpmYv3MoYvEy+V5gVttO/6cogk06hrN9unz+GgsbAHAwHhHxG1raEZZCcz4FgTezj0ziKEgqA4flqjbXV3f4Dvc1AvwSG6idZT73C4v/CfFS7tP3Dd6bEKATjT3oT6A3TFW9umrZq70Y89xx+NEfX2d/vj6iZguzlz4TJ7rQfmROsSC2tOCaRMSQ4ZsFtdj0m8ySFuN27zN0/o60V/tmR/1P5gymYUSQQ+/cuSb2luO7dZ1GNYMwk33ALXBE9wltT+UG1Joo0qY3mu/occfIo4nVuAZWZRjds316M/7j8oR46FIC5tj+/pMG51yQmhkBiIhzjcaAMJ7uUDni2s7iAUXNj5TAZbyUndVwM0NGEH+T70Wt/1LUrz25vEzUZfzc0azW80hU5/SPvt770oB7p0e85He9h x-ms-exchange-antispam-messagedata: b+kwQStNspbNXSKshVHbzYByTIo+ga0jCGEtBNvKK3eRp9cMGVYnslckeBOsV0+/tle9LgfjYJB7+0TteYiqU8+w4ItROjeZc1O6wznMTZ1h5LhSskqgd6HgRAwmMmz5EekLgnc/xCO06I1TCtqsKxj/aT9IsY2aD/lgenzxWgaNtr8WoJYtvsf1vE77fBW3yvHO/uha2wMJD3WLX9Hwe6yDKb+2WyC+5pnxJpnHAdQTdjGmc30sGM/VDK0TyXPs+yKlEZYSLBx/B8Am/gxNfnwoEoZ3lZBxqf7ezqf6N7PsHKAIeHVgZ49aQ7XCYIlc4YW7CFdXjoTN8gu9OzViWZ9LbItcy4ShhwduJXsPWPb2rHprQMz0oIuJbmzqM/JWlRHjfa0ShK1Oz4x30sACnTt4ZHl7HevDcbSsg5Jc04tQ/OKEUjZl2ado/W1IRHYDHP5KrdcW27mNVpafBBs+XKqhZmk/+UNyqxWa87HiJoX5AoPZMMmFy3OBGxeHlTJf3b2HziovHAsF3+U/Dk5qcsskulcyNH4ZdaKnyShv0joV9yW5HJF0NF29AYvdl0ZBAX9puMgKBWClD9Pqp/Q7HeW8kqvXM/a1TUOhVPPvlM9WOANbzJvh710QO2Qi9ikBFSJlO5U5lOkH5vpFX993SfLcHwSLkRkdu+cnq3LwM/80x1+XB6kY3PR6RLli6MCjh8w7+/ZKpE0GzCDF0NDTupFSkYBwmPTXvcOSsx1zgRYbccx89eB+8mioFQdGmHRmv9In5MHHFPVrcZtDTHBboQ0Cf06YulHBUw2jOJlilK4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 15f144e3-3fc8-4303-3ff9-08d7ecd31207 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 06:52:37.8955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5jJWAMRQPMTYJunq1qH89+SV25yNCd7KnMDZekqhdvfG83AdsE2uimYfl0dUQ3u7L7XJoFD4vqa2/xiFBPBLHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3663 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: fix core dumped issue in switch filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,=20 I don't understand your fix log, which pointer is NULL? Qiming > -----Original Message----- > From: Jiang, JunyuX > Sent: Wednesday, April 29, 2020 15:25 > To: dev@dpdk.org > Cc: Yang, Qiming ; Jiang, JunyuX > ; stable@dpdk.org > Subject: [PATCH] net/ice: fix core dumped issue in switch filter >=20 > The number of queues in queue group should be checked before using it to > avoid NULL pointer. This patch fixed the issue. >=20 > Fixes: 47d460d63233 ("net/ice: rework switch filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > --- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 179430136..c2762e331 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > switch (action_type) { > case RTE_FLOW_ACTION_TYPE_RSS: > act_qgrop =3D action->conf; > + if (act_qgrop->queue_num <=3D 1) > + goto error; > rule_info->sw_act.fltr_act =3D > ICE_FWD_TO_QGRP; > rule_info->sw_act.fwd_id.q_id =3D > -- > 2.17.1