From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AB57A0093; Fri, 22 May 2020 09:46:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17F351D91E; Fri, 22 May 2020 09:46:49 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id C16631D91C; Fri, 22 May 2020 09:46:46 +0200 (CEST) IronPort-SDR: 9So89CHJIkrK2HHETbV9vsxrSc0usL3QWlthmBH8GQpbfswBtPhj6Vu+0v3UaNKmD3wGnd8UD/ /7oQkONi6bCw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 00:46:45 -0700 IronPort-SDR: JUg4o1lAeBUDe4wvet+eUXuWg6tN077g9/TRIEekMppGdGiGBTHUfORQ4GLSGSg4JfCimC01Ui cxNm8mc2Ed3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,420,1583222400"; d="scan'208";a="344102302" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 22 May 2020 00:46:44 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 00:46:44 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 22 May 2020 00:46:43 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 22 May 2020 00:46:43 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 22 May 2020 00:46:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFOGyZc9KmydJgufsRXySr4gAx3IXOrY7o716w5OFGnGZ6SHwWfQPnMewmpSa1J7vDELt5zaH1BQifXzGZCEDRrAF8BJ75NbySPhnAldYEU6jRade9fqKSCtgDC0TvnLJOj2V6KBEO+o8mbHwjc6TJ6Cpl9YIeS3yPQhrzmCO7Z9uahnwxpmVhxjLVE6w8ZXivuxUBGJkUu3cwXi0nWrXsJnasEC1bRlGnI2eSn1bBYARmKOgVtAIQjh6vPsnud6COymtSuDDw0WOS0FypLfi2TTS2l+PJlh4HKc0Rrk4ShsSv4XSVtiTzEYGIKTxUGz2OaLcjAN3Lb8qdhQii278w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmlMlrWfrp8UwZ5gtF+F5M3s7AxO0SvFJn86eMkSA10=; b=CIQ2mP/tDGtYe5M0c5kcJHJ81EOrFhk2PDZLWjklPvRujhVdUD7hNpH1HBcrKuuaAH8GclPfe3D/9e1tz21XKUhcdBTq6epo1QWpuKiVi1vhOUs6qFynIHH2sGrm4MLX2u9J+LuZ0nG3k0P2gkSBp+MkLF+hFXSoQVZwAX8olLCZh6dkYEsLfxJWxs41syxEmTO/5AS8CbYURumJPniuqlxagpGIMatyXdRJUg4P1pB1Qrm04SSw/e3AnLL+X2wTpptaOu2sG+xzoZFnKFn6mYUvJ8XeMXm31R/I803+GRHlAegn5qOXzjKCR6g8K3hXI+PjaUd+kazMtprpPC4TyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wmlMlrWfrp8UwZ5gtF+F5M3s7AxO0SvFJn86eMkSA10=; b=G/C1c9gR3tA4WqnT+aoIZV7LQlDPX20WL/gFnNkHopxpkF5xn7gj34r4zNJgGaTCxu0HPP7L7pxgUXKk5y6YL3ght4jO+fZdRJLOFp09YoksvdLi2Pzl+rv7K2Yl92wFcOi2/wfCF/blvKJgN+HklKmK7iMiF/GoIyYpQ2/CMw8= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB4285.namprd11.prod.outlook.com (2603:10b6:208:191::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Fri, 22 May 2020 07:46:41 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::a2:7e68:d1fe:77e8]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::a2:7e68:d1fe:77e8%5]) with mapi id 15.20.3021.024; Fri, 22 May 2020 07:46:41 +0000 From: "Yang, Qiming" To: "Sun, GuinanX" , "dev@dpdk.org" CC: "Zhao1, Wei" , "Sun, GuinanX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter Thread-Index: AQHWMAKawMEEFm9SgUW21zDCVLVQBqizuZFQ Date: Fri, 22 May 2020 07:46:40 +0000 Message-ID: References: <20200522061208.31694-1-guinanx.sun@intel.com> In-Reply-To: <20200522061208.31694-1-guinanx.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4da88709-7a9d-4a3b-8c12-08d7fe244416 x-ms-traffictypediagnostic: MN2PR11MB4285: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-forefront-prvs: 04111BAC64 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZEPHPLR0qoH8xKOHarJBuOf0P1pWKzHET5RwCBA+uiH/umIa3zvoYL4umvKAuitFCPfJr1re6upZKsJGhlSy6bNSH6dybOyMxjb+S48IEARjbu7G8idZeWm78r/MOzW1+0MtRS+6iWnXqtSg2TT5PFHAm5WVDkafHEji3gseAElyyyWzKjoHJbqmzjEj1gZ5U9At+mrSvSPgaZB+uEj70MVtpn8fTqrAaAo3Lfyd1xCUgEMMGD/ezdVC9VVSVUXP2HkVlI5nhm1E8qYi6z9upiwpPqRS5Gu3kbEamtPzeGAzpm2gRfuwrQEkNqhQ7D4iGaolinuI/7HeGDdZObCfFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(136003)(346002)(376002)(396003)(366004)(7696005)(86362001)(55016002)(64756008)(54906003)(6506007)(110136005)(8936002)(66446008)(33656002)(186003)(316002)(66556008)(71200400001)(66476007)(4326008)(2906002)(66946007)(9686003)(478600001)(450100002)(53546011)(76116006)(52536014)(26005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3rxLuxkr11nww/Cl0xCVa1CXFLZvWUM04Igen8uvLyoU/qejCfiJEW6cuJhbd1oPCSLw210glXUp613mJOWggBN78ghnaUFCUHoXkU3g4saA1Yf/7AuTtJrSOOf+bToNQdu+hLGGAWMF6WSZS+Uv5Ujj6I9g8a1IpYPoRClkDZjul9vyxrkG3XXdq4fzbnX/QGNlgWWgeXNb+kYIUJpfYycyKlR/zjAS8aeUWgr2wyKIuQPnBdo5VGV+MCyMrm3YQeUbDiDPLHx+HBg4/KtH2xSyxIEQhJVmiKTpNWNoS1YRmk6YJruge2B4qaImfBg6sf1V0mEvX6QYe+r20e2I7pSxWmt6fu88of2dRapmhacMPq8yA4+kyV7dk9kGZRmek04LisF9wSr/Q86TlTI81sbm1RgvMF0m1umN8nwDeNxr9QvV01FJkb1RzJt1C6grlPrJZxySE698jayCgtlzFIYOazzz97vsmhCIp90WEp3AC4dBO8RLyyYAf36ib8HL Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4da88709-7a9d-4a3b-8c12-08d7fe244416 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2020 07:46:40.7252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MsPDsDrbEA5A8PHvjXMEx5reD86apH9cXmSrZDv1vMqdEVE8rlpL0HtpEUsi/aKaX1L/dytmpnQif4CDoGoSWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4285 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Guinan I don't make sense for this commit log. Don't write like a test case. Pleas= e use technical expression. Qiming > -----Original Message----- > From: dev On Behalf Of Guinan Sun > Sent: Friday, May 22, 2020 14:12 > To: dev@dpdk.org > Cc: Zhao1, Wei ; Sun, GuinanX > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in > struct adapter >=20 > If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port > reset process of >=20 > testpmd> start > testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port > testpmd> start 0 start >=20 > Then after this process, the mac_ctrl_frame_fwd has been change to "off", > so we should delete "adapter->mac_ctrl_frame_fwd =3D 0;" from dev-stop. >=20 > In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get= () > function. >=20 > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: stable@dpdk.org >=20 > Signed-off-by: SunGuinan > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index f8a84c565..dd4023f01 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) >=20 > adapter->rss_reta_updated =3D 0; >=20 > - adapter->mac_ctrl_frame_fwd =3D 0; > - > hw->adapter_stopped =3D true; > } >=20 > @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, > struct rte_eth_fc_conf *fc_conf) > * MFLCN register. > */ > mflcn_reg =3D IXGBE_READ_REG(hw, IXGBE_MFLCN); > + fc_conf->mac_ctrl_frame_fwd =3D mflcn_reg; > + > if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE)) > rx_pause =3D 1; > else > -- > 2.17.1