From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9FA8A057B; Wed, 1 Apr 2020 11:03:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 310341BE0C; Wed, 1 Apr 2020 11:03:18 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5F39B1BDAC; Wed, 1 Apr 2020 11:03:16 +0200 (CEST) IronPort-SDR: WrKbPCkyL8EberAv2qBcTrjPNoAnsKKF8RPi1KDWVf//2kXJNePJ3RtB1OE872KuHlRFRaHz18 oQlgWCyVGIag== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2020 02:03:15 -0700 IronPort-SDR: BVFAbaC2QyPzhrrtrAcjfArgiiVv7JnhqXbe7WAGecyfoS26QEdcbxUakoVgGP1FMGyLx5LJvY dksuxfdVbolw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,331,1580803200"; d="scan'208";a="273086398" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 01 Apr 2020 02:03:14 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Apr 2020 02:03:14 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Apr 2020 02:03:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bi/UenLwpQ/ti2J23PJv9zdnqiDHGkAl51rcJwpEMj/tTPwoZAtJgduVQYorgdg4cxAmI38CsKbgyFrh7u7JWg+wyCldAtSu3Wf87N6lhS1lOtAOuF8VegbPEIs/XcrHR48ffSE6EjvvfuO6a48DstYcDNpNl8DrtQ8AzRGHevvH3IzTs+vC8y5fDpzWu7bo99/y1b66OHQ6YGPvrVo9Rk2RRjpdTk9t/sNvxgW3S6ZJMOyTGRwb85NAtuqDtio7j2eDV+l+3Jmp6iVYnJUf5q1oFpx4gmQdGfPvnV67BesnuP1Eq638rfsMxTE9AtnJJSXd4WCxoFftPMOSEiyjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFo6B4gC+O+0pjNw6k4X8JmrSGgKAGWJWyLpAm3fiu4=; b=WkoChrDHh7TGQ1DdDD3W33k4m3ikoKQmVs5IYQdplLSNnE2jzUK2Lk+l8gMCIRV3/hiEij/qAy9r4r4Yp2FzWjkOIKoz7mgW+Z3BiLpvgI16h4Jk08JQA/gZw/22z5Suyh0AH5yBN6ANFBs7WKIsu/jnxnc4abvTKdN5/k6dSBjOKUv3HMA+lNYI2YYxJS+iMMEdzjE8heRM+09Ryrb66XjwW3SND3J/AeDdP5N2EZnuREfSS4Z+lpY5nH3mjXJi7f2qG3ZD1HOJ4eEbTUzkdXbyjiUQlWMlqVlw0gjdVEkpF5NMxoyhyTiFjGgpstfSetXnJzF8ZcN4iHcv2uJWWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFo6B4gC+O+0pjNw6k4X8JmrSGgKAGWJWyLpAm3fiu4=; b=pzg4hUWvq+C87KuD5ofuMN6kH79C3ittKZFfxGhANftBckZHDofvmIdZ2k+XBwQnMnOknJQTKhbrrqE9w20mEOZLXP1tx/15jaa9JjudBpowFfpR0lQjK+/PErnh1H0NZjOt+lQri2hMbcHGaqWVVDlEw6rWxgpL/YcUlVSTeQY= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB3968.namprd11.prod.outlook.com (2603:10b6:208:151::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Wed, 1 Apr 2020 09:03:12 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26%6]) with mapi id 15.20.2856.019; Wed, 1 Apr 2020 09:03:12 +0000 From: "Yang, Qiming" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [PATCH v4] net/ice: fix RSS advanced rule invalid issue Thread-Index: AQHWCAK2tucK6q4ddUevQYuob8iCyKhj+IWg Date: Wed, 1 Apr 2020 09:03:12 +0000 Message-ID: References: <20200319074825.16035-1-junyux.jiang@intel.com> <20200401082635.9982-1-junyux.jiang@intel.com> In-Reply-To: <20200401082635.9982-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiming.yang@intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ff08a2ea-f647-4723-aad0-08d7d61b81aa x-ms-traffictypediagnostic: MN2PR11MB3968: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 03607C04F0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(136003)(39860400002)(366004)(346002)(376002)(396003)(26005)(316002)(2906002)(54906003)(110136005)(55016002)(71200400001)(81156014)(8936002)(478600001)(9686003)(81166006)(5660300002)(450100002)(4326008)(86362001)(66556008)(7696005)(66446008)(6506007)(52536014)(66476007)(64756008)(186003)(66946007)(33656002)(8676002)(53546011)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ik6tbjK/c2kbmIX3J0FXiBqHsgS5juyvDqu6G6i2rwADyv1vcqELz9eTGulY0c0t3cHSTXyxg8SS4yuumSprZoJbSpcok0Od+z+qmlgq9yidaV91QhRSk3Z4NTb4M6DzBQQADhwUyLLeso5/MH68ok0MEp3oAi5ezrZ+cPqnv28FDgEG5iIYWRSegr2FoCcbcBChXytT/QVhFKbYRiOIgLDbB1+CQaU8DLbPthZO9nKejLW4aIf4XxlmtK5hENZh+fixtL667PtP1gI0miWA0NmXs/n1HpXSnLYTL2NIAuXgu6oz0/uTRfjpuEdTQpjfjn86BKwaXhG+FzO9GbXhyn6b9/9P/GZrIZs7Mq2WmQBOG9fP4jeUeK2igHQBH9OFl4mhupjlTby52JyIsWVh3HNzCNw1xeH4oDEJF9GK0z9XUc66IUIHYmpMNOrQbI5a x-ms-exchange-antispam-messagedata: gVuaBPHdBfSB3zpQW2eXLgi3Uw311BWtXFxanq4E2K0wbtsYZdbl7m0bJ/PYfN85q7Vg9cgqTvteCp6HtXKhMsVeblVSCrdkF7lXXIErpcPkYWljSFVKAT3o5mbfta9M0wOMnFZQWWSn/cxyVLjA3Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ff08a2ea-f647-4723-aad0-08d7d61b81aa X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2020 09:03:12.2612 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WHx2vHBeoM2QYGnZKgDB/5+1ei3noOR8yO6MvUkKrnyzm+ztsQ0Z/xzD2ho3ZPse0FhsM5W368gOyM51ODM94w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3968 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/ice: fix RSS advanced rule invalid issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Nacked > -----Original Message----- > From: Jiang, JunyuX > Sent: Wednesday, April 1, 2020 16:27 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Jiang, JunyuX ; > stable@dpdk.org > Subject: [PATCH v4] net/ice: fix RSS advanced rule invalid issue >=20 > This patch moved the RSS initialization from dev start to dev configure t= o fix > RSS advanced rule invalid after running port stop and port start. >=20 > Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > --- > drivers/net/ice/ice_ethdev.c | 48 ++++++++++++++++++------------------ > 1 file changed, 24 insertions(+), 24 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 85ef83e92..4cfdbd838 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -2446,24 +2446,6 @@ ice_dev_uninit(struct rte_eth_dev *dev) > return 0; > } >=20 > -static int > -ice_dev_configure(struct rte_eth_dev *dev) -{ > - struct ice_adapter *ad =3D > - ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > - > - /* Initialize to TRUE. If any of Rx queues doesn't meet the > - * bulk allocation or vector Rx preconditions we will reset it. > - */ > - ad->rx_bulk_alloc_allowed =3D true; > - ad->tx_simple_allowed =3D true; > - > - if (dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_RSS_FLAG) > - dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_RSS_HASH; > - > - return 0; Why you delete the original logical?! > -} > - > static int ice_init_rss(struct ice_pf *pf) { > struct ice_hw *hw =3D ICE_PF_TO_HW(pf); > @@ -2594,6 +2576,30 @@ static int ice_init_rss(struct ice_pf *pf) > return 0; > } >=20 > +static int > +ice_dev_configure(struct rte_eth_dev *dev) { > + struct ice_adapter *ad =3D > + ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > + struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > + int ret; > + > + /* Initialize to TRUE. If any of Rx queues doesn't meet the > + * bulk allocation or vector Rx preconditions we will reset it. > + */ > + ad->rx_bulk_alloc_allowed =3D true; > + ad->tx_simple_allowed =3D true; > + > + if (dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_RSS_FLAG) > + dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_RSS_HASH; > + > + ret =3D ice_init_rss(pf); > + if (ret) > + PMD_DRV_LOG(ERR, "Failed to enable rss for PF"); > + > + return ret; > +} > + > static void > __vsi_queues_bind_intr(struct ice_vsi *vsi, uint16_t msix_vect, > int base_queue, int nb_queue) > @@ -2797,12 +2803,6 @@ ice_dev_start(struct rte_eth_dev *dev) > } > } >=20 > - ret =3D ice_init_rss(pf); > - if (ret) { > - PMD_DRV_LOG(ERR, "Failed to enable rss for PF"); > - goto rx_err; > - } > - > ice_set_rx_function(dev); > ice_set_tx_function(dev); >=20 > -- > 2.17.1