From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51C7FA0577; Mon, 13 Apr 2020 04:18:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18A581B53; Mon, 13 Apr 2020 04:18:26 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 22AF3F12; Mon, 13 Apr 2020 04:18:23 +0200 (CEST) IronPort-SDR: vetm/GLgNgh4ui9oe+abIHEjObZSudFkeaQXpmsD3FyQ5NCPU3SrvgJO9ecTryEqBphfVCyT4n I9TBehpurvVg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2020 19:18:23 -0700 IronPort-SDR: siWPfsQpD313uQlCFfJXVxw/qDPga8/mz8HuqjPCE/8GAkF1PffUIZlMTZMnVE68IrnG8OZ8Mo CQ/twHRDV1zQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,377,1580803200"; d="scan'208";a="426542827" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga005.jf.intel.com with ESMTP; 12 Apr 2020 19:18:22 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Apr 2020 19:18:22 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Apr 2020 19:18:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KiSGW8Tvli+WvxE3y0f1KY/Eow6kE/Nk43+ZvjYdnPwYStNmrxDmnR4kxJUwqoJKFXUUi4mgjCE9FUnVrHCipLu3txzQJg8LqxKM+kDjowKeb9p3o3ykG+feaYlf3SbJexs1PRUenBZrnr1DuwqmT6cPKyNUjDtgaR6HlXwAIfMacS8p720sXL4rSjhs+XuDkVgIuaLVXzpz5+or+V08clZe7zBw7MCTlUNOnJ5NAa4ddCUbGtDdR7hi4Pvu+UOA3sygHh9aQ0jz3EWFlA51OhGpvYQ2CVx//WyDpmVFMBlhQZls9rBYZUHJkUvcgp4O44YGa0ofeO93t6URG0jnqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RB2D7efycVI9wQin3BXix9IdQsPQxwQygUBK4drUfrA=; b=QHgo3YmDujq1jQXvADw7ISYFRVyHDZnd25f9mzIr/ocsufoj2Ouf+2sjERcwr7dO1vIL91PRkEIErxt+lcNY3DN/ul1D8fwScI9sWA9eG3ve3UM/aqBqvbeS5D6nQ1Yd8u1Fv0PfWT6te/gTcBLjTdcwaSS23b+70B6vvHjZ/H7u9UkuoP3e3+YUScGr85zkhGAQ4hpXLlLcgrpZhh+QVJD4ufKHs4SzMoe4J9oH+iOW73xdIh9lU72ptMYmDMaFgNeegc0pqzFSC+dnDS95t3xQ/+XKu7vusDGzKRA8NSPpIDs6P4vJZdtEY/8Abn0FRH+i+aEcWYZY+9/JKkJ2iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RB2D7efycVI9wQin3BXix9IdQsPQxwQygUBK4drUfrA=; b=L9MdzsKubKBG8NsjG61lNm7N4A5DPBJlPXuDyUyiW2AklhXzrQvjyRGFC9ezLE/tK7BEkeRAq5/t+flB0Ao9Oct83JKj20ROHDoNXFAw6wlpj66I8hbbAWsm65G2aGdnfalMigNmzmpa9thcS43n3Yket34KEStVLBelviOkkfY= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB4382.namprd11.prod.outlook.com (2603:10b6:208:18c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.26; Mon, 13 Apr 2020 02:18:20 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26%6]) with mapi id 15.20.2900.028; Mon, 13 Apr 2020 02:18:20 +0000 From: "Yang, Qiming" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: fix link status after port reset Thread-Index: AQHWETW9EOQVquM+UUOW5aZVVS43jKh2UPvw Date: Mon, 13 Apr 2020 02:18:20 +0000 Message-ID: References: <20200413013839.71374-1-shougangx.wang@intel.com> In-Reply-To: <20200413013839.71374-1-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiming.yang@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47e649ff-4fdc-4078-4812-08d7df50efbf x-ms-traffictypediagnostic: MN2PR11MB4382: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-forefront-prvs: 037291602B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(39860400002)(136003)(396003)(366004)(346002)(376002)(71200400001)(66476007)(66446008)(33656002)(2906002)(186003)(52536014)(5660300002)(55016002)(9686003)(66556008)(450100002)(66946007)(64756008)(316002)(86362001)(7696005)(4326008)(53546011)(26005)(76116006)(478600001)(8936002)(8676002)(110136005)(54906003)(6506007)(81156014); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nlOlZerjIlLW+Qg5MIjehFk51fHDh+dA5JSBwjME2CT3XKQuougfoDXGlOh+XhmXp+L86/iKr9IFMGysoGD7Fucva19YeHLSVs0AD8st5Fr3OSai6VBo6MZ4Yl3VaE9BBWRzDCRFIXP8SiCGlz0HwoLfqLth2FMRnR1a18ozlWLkXyY8XgbSdsWmQUAK06LCYqf6VfpUzZb+VfPjleyvHj/uQbbspXyEaClhC2SdhHyLLQT4up0CZc8DGtgkcBlDI8RZk0Bauvof4+IUhg/aa5vsq+bC5l4eopbxgN4wm4zAQ9GOZOPOgSEGTZn1F28u2EtSFZQQHAEqPZD0manqU45ubTFOtzkbCcMEtEoty0vavhOLQwoBe/nG40yRSNvt4LxlcX99ToJY5Xcwi73dOCIGnB75VhMe6MfcNGO1k1ea8BOZrEM71CzCshuth2Xl x-ms-exchange-antispam-messagedata: ChpN4uwJr17TOeO0tqntAM8bDlFHhhN3nF/GEf8N1A5MdZaZwLeO89M9wFQfbQB7gbu677fuU78bpQwd/b2959tZxJLhhTYP9OHLQlZGYvBcu1czPoZsijDr5Q4ioxy3I/CnL0Jhwy2VZWSSjHZ07A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 47e649ff-4fdc-4078-4812-08d7df50efbf X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2020 02:18:20.7493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nLLiEULZ5sBJ9tUpuFeQMtp5cnu2f3P0zzl2uutjvgRT+tbb49Im4hf3yn3QdzvDeZ45/owvzVgIyWXFXcQaog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4382 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, ShougangX > Sent: Monday, April 13, 2020 09:39 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Wang, ShougangX ; > stable@dpdk.org > Subject: [PATCH] net/ixgbe: fix link status after port reset >=20 > It's a normal behavior to change the link status to up after resetting th= e port. > So it is unnecessary to set link down before starting port, and changing = the > link state(link up/down) frequently will cause link speed unstable. >=20 > Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shougang Wang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 23b3f5b0c..206358b85 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -1196,7 +1196,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, > void *init_params __rte_unused) > diag =3D ixgbe_bypass_init_hw(hw); > #else > diag =3D ixgbe_init_hw(hw); > - hw->mac.autotry_restart =3D false; > #endif /* RTE_LIBRTE_IXGBE_BYPASS */ >=20 > /* > @@ -1307,8 +1306,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, > void *init_params __rte_unused) > /* enable support intr */ > ixgbe_enable_intr(eth_dev); >=20 > - ixgbe_dev_set_link_down(eth_dev); > - > /* initialize filter info */ > memset(filter_info, 0, > sizeof(struct ixgbe_filter_info)); > -- > 2.17.1 Acked-by: Qiming Yang