From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B9A9A00C5; Fri, 8 May 2020 04:54:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2DE11DBE7; Fri, 8 May 2020 04:54:37 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 431C71DBE6 for ; Fri, 8 May 2020 04:54:35 +0200 (CEST) IronPort-SDR: gmh6/fAtqu2dq3G/pKR5eJAsaxd6Y1wnvx0q731I7eEjIHqwpbPdB84ik+VBjEjfd/sYXhj7HL klwc2eBpsZxA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 19:54:34 -0700 IronPort-SDR: gjLhgB97tHMqMtahTGF7ZS4CQOpBPsX2V4KXyFraNzvMkj0kYktPCd5rC53bRxYAiyzWLhVrtZ dDikUFB3FUDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="278809706" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga002.jf.intel.com with ESMTP; 07 May 2020 19:54:34 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 19:54:33 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 May 2020 19:54:33 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 7 May 2020 19:54:33 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 19:54:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6hR0qBKO+IR30Pm2nwvzpF+s7wRyf69crp0gtyaUf9G3bpg0oXs96Hryx4tzL6VfCopO5EG/Lf9Xdv5+aErNq0OZmOv+oYcUikW9DHA7IYdfxMsevbz0YChK7oSJ4PF94iJgdNUA5pT6JaaLExGpJMYhUdhPoc8ZzjhEkqzSPofeBetprhavlLBDjQnhOQBAISyW9TpuEkFijqSH71gYcPiOH4aXQq6D/kUfCv7wz7hMJBFZs3oelBRpwyU6OqaByCiujAhLaqJp0jn72o8tVO0uf6l333L/zi7s57rzPrRZRlocxJEU8OL2nvkjR5DRbXvA32kNLsxj0129VJHgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8TAuipyRKaMWh6FaJ2sYs7lxjhQUN4Qt05z+qtvBBBQ=; b=RRXQTpLG6/WAfeb7iz9A4DLQv07S9nUUrHLlp5fG8Gtcz0E2B07nDvN887Sbuk5EMmgD80O+Buc8yKjuq6sRaZjaS36Wo8yK6vhPZK6ApZLkdzleO+JPNP+leK7Hk+CrnR8w/kwBB3Eo0+KbnWxHeCrxdfj66IyZQvQxfC3CjJdCnPiibqrwvVJgwud3RvOCz7JptFBrl8zFAJHvgO0qdeTw1CwgnJpfyyeBm3k7TSqIW5oOHv+qAwyDTeU5P3rojjRhtm2eBOb1GYoVT4M9msh2f1F4GHqy35KJCn6Xw3Dgda1od5MgDdMdUA3Ca0krXOVf9Gxwn7gV4MOR3NYQmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8TAuipyRKaMWh6FaJ2sYs7lxjhQUN4Qt05z+qtvBBBQ=; b=vVORBmpmmK9Y+H2UWoQVfK+JIU6HVpY5XscEKcgQHORgZicmpGeRQCvmBelk/HYF0HPwLsygc5RTzJOeBzKgv6B/oSmNIbyyDGEq2/vo9jic1+wz/CbfDfHJwBQU+NnhymGmmCteN02sQa9ARFs2lWDB+Vu19GG7Fzkv0sCXI20= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB3919.namprd11.prod.outlook.com (2603:10b6:208:13b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Fri, 8 May 2020 02:54:29 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::e1c5:b5cf:5a94:379f]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::e1c5:b5cf:5a94:379f%3]) with mapi id 15.20.2958.030; Fri, 8 May 2020 02:54:29 +0000 From: "Yang, Qiming" To: "Ye, Xiaolong" CC: "Di, ChenxuX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue Thread-Index: AQHWJFX2HOgQEseH90GUboSjLs4aaKiddfMwgAAER4CAAARmQA== Date: Fri, 8 May 2020 02:54:28 +0000 Message-ID: References: <20200507030928.42082-1-chenxux.di@intel.com> <20200507094941.87470-1-chenxux.di@intel.com> <20200508023617.GC75514@intel.com> In-Reply-To: <20200508023617.GC75514@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e5c0f47-a75d-471a-4644-08d7f2fb2069 x-ms-traffictypediagnostic: MN2PR11MB3919: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uz03bGGmg+LnAF4a3mNrs+Nlf7LKXSMjrojqpTWdxboRH0cDLWJdkqQ2uXmevUrLKwcMGqX+Fo+eDWs3F0WjNKZK05pSNRgHn3lFxjEiHW7V2KKu32tqKusgjNgI8FkbGnxj0+x2mGqoRpsfMRiTecTNMpKIhArAG7I2w2d09VgDsFpkfqa/NYXobzHPJyQ7X8oEHyirOj8cA8+JbJc2iMRNiZ+0oZ4UeReaFQfNidyzjzo8JAsYcaUlTWxSlOY+UbVxR5yqM4aTyXO35pi/r2z/h4DRExMHd/K6W/UkivvGCoZfBzGVwYqgre3/cjm3cCbsE44Jh/hAWmABh/Vge8GWuFLb5IVUNZTp84lGwAIv/C18IfY5+2y8EFbgu2KIbOP43RG3SHr3VQGUWzlDVSPqmBZlWbE2swkNqd+yUSSy9gjHCVZK3mCzpLThj8SjiuMCJPB+7Ip7verwFbhDEJXLKlcBEz3yiHvZ6ISSPzksIqKRIy0fwfyDWwCcSRbOC9tjLb0fvHkpSxENtlC8Tg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3582.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(396003)(376002)(346002)(366004)(136003)(33430700001)(55016002)(6506007)(64756008)(9686003)(66446008)(66556008)(66476007)(33440700001)(33656002)(66946007)(4326008)(52536014)(5660300002)(76116006)(6636002)(8676002)(478600001)(86362001)(6862004)(7696005)(26005)(186003)(316002)(83280400001)(83320400001)(83290400001)(83310400001)(83300400001)(2906002)(54906003)(53546011)(71200400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: zN7gMSgDs6VBPnxG9LuhhDiEJgbLrEtFgYZS84LGQtVkZHQwmYHx+t5MvsrIf1Z6EJYoaoPMSg88/QZuI/YeULIg0gnpODcXzXJBpCjST3HnbWCWlcP6IqHi3gQs+PoSxC9g67Tk24YaIAIZAaHqpz/Ll+MsJxsNoMLG9JNrWxqYSY7beKTqad5o/M6p4K9uBVF2M22a6NP1i05f0CNy/QQYtP432Qjl07YYcRL2jz2PcGDkwqCVtq4BcRM5riQnn0qMaeOQKEXuVnmGjKXjXjdUrt8yjrp/43i8ncAZYRtvYuBqNCkYflNR+V3wLon7X6n+Xe/Ab1WIfBO/76PgLwk0AKZeIc+hontvKGxzLnjL8tveX+UgLDpbvrly7vxUznxhFvU915PyhAbLlikkMK1IwR2oikXdCFLDDCbpXN1wtKSNSaaoELgyRgIm1oT+Zjgy7uCSBdcPQX9jbic8Ga7DSsN1tT7HSTua07Csqsk7VNzMsH+RuOaM7el3xFt6 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1e5c0f47-a75d-471a-4644-08d7f2fb2069 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 02:54:28.8958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dROlG3rIa465LKX/MC0Gd9bUVvMaAm4BfCTevVXKAooFZqSvEESXHYx/cxwReJqgk2Th7yXBkwTo3SOG4/anbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3919 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Xiaolong I reviewed that function, it need rework, not only this coverity issue, the= logical was wrong. Qiming > -----Original Message----- > From: Ye, Xiaolong > Sent: Friday, May 8, 2020 10:36 > To: Yang, Qiming > Cc: Di, ChenxuX ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue >=20 > Hi, Qiming >=20 > On 05/08, Yang, Qiming wrote: > >Nacked by: Qiming Yang >=20 > Could you post the reason why you nack this patch? >=20 > Thanks, > Xiaolong >=20 > > > >> -----Original Message----- > >> From: dev On Behalf Of Chenxu Di > >> Sent: Thursday, May 7, 2020 17:50 > >> To: dev@dpdk.org > >> Cc: Di, ChenxuX > >> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue > >> > >> This patch fixes (out-of-bounds read) coverity issue. > >> > >> Coverity issue: 357699 > >> Coverity issue: 357694 > >> Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS > >> flow") > >> > >> Signed-off-by: Chenxu Di > >> --- > >> drivers/net/i40e/i40e_ethdev.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/drivers/net/i40e/i40e_ethdev.c > >> b/drivers/net/i40e/i40e_ethdev.c index 749d85f54..c2d5c6835 100644 > >> --- a/drivers/net/i40e/i40e_ethdev.c > >> +++ b/drivers/net/i40e/i40e_ethdev.c > >> @@ -13179,6 +13179,9 @@ i40e_rss_config_hash_function(struct i40e_pf > >> *pf, > >> break; > >> } > >> > >> + if (i =3D=3D UINT64_BIT) > >> + return 0; > >> + > > > > > > > >> for (j =3D I40E_FILTER_PCTYPE_INVALID + 1; > >> j < I40E_FILTER_PCTYPE_MAX; j++) { > >> if (pf->adapter->pctypes_tbl[i] & (1ULL << j)) @@ - > >> 13311,6 +13314,9 @@ i40e_rss_clear_hash_function(struct i40e_pf *pf, > >> break; > >> } > >> > >> + if (i =3D=3D UINT64_BIT) > >> + return 0; > >> + > >> for (j =3D I40E_FILTER_PCTYPE_INVALID + 1; > >> j < I40E_FILTER_PCTYPE_MAX; j++) { > >> if (pf->adapter->pctypes_tbl[i] & (1ULL << j)) > >> -- > >> 2.17.1 > >