From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7652DA0583; Fri, 20 Mar 2020 02:20:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B28BD1C07E; Fri, 20 Mar 2020 02:20:31 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 81F0D1C02D for ; Fri, 20 Mar 2020 02:20:29 +0100 (CET) IronPort-SDR: qLavvri2K1MFfuxIF5m1ePUQqaUlla7RDetV97NPv1zi4AdcITWsHKJv4Lu835ec7z9xWGVG8b Ek1qslcLq3LQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 18:20:21 -0700 IronPort-SDR: j1frAxCGxdwtPyQfa9p71ndpBmWgfIogl8i3Jq9rEnxFD0xBFbnDgPX551S27lkEM5azWfS74W rnEiNNzIra0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,282,1580803200"; d="scan'208";a="280271060" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga002.fm.intel.com with ESMTP; 19 Mar 2020 18:20:20 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Mar 2020 18:20:19 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.59) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Mar 2020 18:20:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JwvPoRIlBBAEQ1MvrlAYbs6RuUKVGwj/PHVZ7gduM/nVubARXlsCZhj1AIaJMSPzzoN9VT0P8F1qzrnBboZKDTrUp5P1qBNe+3qmv9s8zVaGbgUzThuQZSJmQHAGMe9FF4wA2I8VYXLQJK54mm8VqqGzMwRczEEAIWAnUz2ANLZKfl1HoWYq3TpRBBOy/TI4TKNS6wf3XajNJZEowXzlnAVy5QeJdtz5FYI0UVyoTBatt6qFZu2WU3+xFZ26a17P4BnPnTwIjqoP9rlJ326Ad/Monh7YI9jATkp/GB4guM+MEoMOs2frZ6TOyJ1SqCdrBQvuJEWw166LsbHEZMfoiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1S5QSRUcZloWRLX2KZyqPwGZ5HLrKhUsfIOVe4Pd3d8=; b=XDCJCWiFltmonlwIPix8BAlxY9EQ/32DgZtZ4ef9xy6ZrIYMATR+uKt2snnL6RS6k3n1Ujb+gmML/+SSV5kXSmS70I4UReTpBwv3jLnJDfmVuMa0W1ctObpgZcZWJ9vF8eYFpqtSOYDPtt0R671iz+1kDGLPzIbv6SPalPWux1Ovdt4GAej01hkoT6gL0g733S0pUpdGdI2+bWh1pxS/mmACD5NCd7XFMcUUjFIBMocEI5knwPQO0QAfsJV5CeWRBrb5tSGCo8hjDo3+Xzp29B17uzxye9WPl+PWwo8p6IiCCgykLj+MZXwGtNYBHMPF8307vWlAuHCUGiz+B76QOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1S5QSRUcZloWRLX2KZyqPwGZ5HLrKhUsfIOVe4Pd3d8=; b=kO+MJaNpyzW/vv+JrJNX/h//1wURivu0FHS430+kClkNKSZ1Pdvs1HTNvryd05K3O7sUVVTCxyLD+5xQpZy9ffPBqAJudArqih9R1qTSGbeegBx8VnA5m2/HP1qPALU9l5t7lkWELs2jPOpG95mEZr4ds/PskYq4jAtWjko8Z+c= Received: from MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) by MN2PR11MB4446.namprd11.prod.outlook.com (2603:10b6:208:17a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18; Fri, 20 Mar 2020 01:20:12 +0000 Received: from MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26]) by MN2PR11MB3582.namprd11.prod.outlook.com ([fe80::f091:55f5:2e58:8b26%6]) with mapi id 15.20.2793.029; Fri, 20 Mar 2020 01:20:11 +0000 From: "Yang, Qiming" To: "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow Thread-Index: AQHV/DcEVwBModoKek+92kFJ2nFy1qhPLCAAgAGGvPA= Date: Fri, 20 Mar 2020 01:20:11 +0000 Message-ID: References: <20200317081745.29450-1-qiming.yang@intel.com> <20200317081745.29450-2-qiming.yang@intel.com> <039ED4275CED7440929022BC67E70611547E3A07@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611547E3A07@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzk4ZmEyODItZjkwMi00MDcyLTg4NzYtOTVjZDJkYzIxNGYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibzYrOGIrTXFGM0kzcTBhU3lRU2I2V1dsMDhwWDVQNVoyODdxaWdlMnZrUk1DSG5WS21NRUFmTWRlYjJhY2NRTSJ9 dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=qiming.yang@intel.com; x-originating-ip: [192.55.52.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b494ea8f-1442-4676-9a52-08d7cc6cd636 x-ms-traffictypediagnostic: MN2PR11MB4446: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 03484C0ABF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(199004)(7696005)(64756008)(66476007)(66446008)(498600001)(5660300002)(53546011)(52536014)(6506007)(110136005)(26005)(8936002)(9686003)(186003)(71200400001)(66556008)(966005)(66946007)(8676002)(81166006)(86362001)(81156014)(33656002)(2906002)(55016002)(76116006)(41533002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB4446; H:MN2PR11MB3582.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gO+y/EzbWEx9rINj18Y+pE12rzhjDgQabREB0bGgUKAUMFeZVb00Dg0LlFSOGNR6coBVWW55VUQ2H5ZTn9cxTirDyHP/zkRHvpjLQSwT6p2hWmb3uYd38yMbJDHivI/7kYW6ET2s2xzebiIEW8GCf5izArObSovwQRuZWJrP9X9v/zHu3WykArGnXlEfVHmvZyEuUFYEIdQG1bQno9UqUF0a32cdHGiK3dFrzNBPJv3125almhB+RULhwptcMSHtgva/XuWuk/bvTDCSY/PAWWgXod3GKX4HB/a4IEwrBaaRu1MhJHKiu5LAmPL1pY1Av8OS3E8rC5zFzc5DNEjjgkM3e1hURkt3IR4fPS9kAheGO4BX43GtZt01DG7vCNPRPgFaCYKxTqlROwfRofcL2Fqg6FagecTyQZ+DvseSnPa03YqrNqUd4MZZVV2MJe/5w1uTn4tdbmoxRIjWd/KCznDLW4JvLDtjcsQGJ4v+K5VgNO3W/aqYSYgC5cM11q+kbrncxBoN9fSA4K5DTNYG/P4Nh8f/jbzTjkR/ScxEGDy3BGuaC33EKem7gVfhFYW4 x-ms-exchange-antispam-messagedata: l+Sv1nYN/afni5GIix6b1xyQIh6NVihwjyCeYdO4J6+0Y0X35j9rRnLMGYEPvCj9psa1Cg7GtJrhXVabTwupHrU9VzZYMDMEQz6fm9p70Xqk4xAbEWSYLe0kWdICAt3yvqMa/om7Af4jf6xvH+xaUA== Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b494ea8f-1442-4676-9a52-08d7cc6cd636 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2020 01:20:11.7102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qS1u2x66b+UQKkN5LQJMExnsLRM7BjEjt1oMnGTUXEC6aLAldGmPDMGtb/giPLztz4qdyJn5x24mGa0jPfdisw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4446 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, I'll fix them in v2 > -----Original Message----- > From: Zhang, Qi Z > Sent: 2020=1B$BG/=1B(B3=1B$B7n=1B(B19=1B$BF|=1B(B 10:01 > To: Yang, Qiming ; dev@dpdk.org > Cc: Yang, Qiming > Subject: RE: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Qiming Yang > > Sent: Tuesday, March 17, 2020 4:18 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming > > Subject: [dpdk-dev] [PATCH 1/2] net/iavf: support generic flow > > > > This patch added iavf_flow_create, iavf_flow_destroy, iavf_flow_flush > > and iavf_flow_validate support, these are used to handle all the generi= c > filters. > > > > This patch supported basic L2, L3, L4 and GTPU patterns. > > > > Signed-off-by: Qiming Yang > > --- > > doc/guides/rel_notes/release_20_05.rst | 5 + > > drivers/net/iavf/Makefile | 1 + > > drivers/net/iavf/iavf.h | 9 + > > drivers/net/iavf/iavf_ethdev.c | 46 ++ > > drivers/net/iavf/iavf_generic_flow.c | 928 > > +++++++++++++++++++++++++++++++++ > > drivers/net/iavf/iavf_generic_flow.h | 279 ++++++++++ > > drivers/net/iavf/meson.build | 1 + > > 7 files changed, 1269 insertions(+) > > create mode 100644 drivers/net/iavf/iavf_generic_flow.c > > create mode 100644 drivers/net/iavf/iavf_generic_flow.h > > > > diff --git a/doc/guides/rel_notes/release_20_05.rst > > b/doc/guides/rel_notes/release_20_05.rst > > index 2190eaf..44d375a 100644 > > --- a/doc/guides/rel_notes/release_20_05.rst > > +++ b/doc/guides/rel_notes/release_20_05.rst > > @@ -56,6 +56,11 @@ New Features > > Also, make sure to start the actual text at the margin. > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > +* **Updated the Intel ice driver.** > > + > > + Updated the Intel ice driver with new features and improvements, > > including: > > + > > + * Added support for DCF (Device Config Function) feature. >=20 > Above comment is not related with this patch, right? >=20 > > > > Removed Items > > ------------- > .... >=20 >=20 > > + > > +static struct iavf_flow_engine * > > +iavf_parse_engine_create(struct iavf_adapter *ad, > > + struct rte_flow *flow, > > + struct iavf_parser_list *parser_list, > > + const struct rte_flow_item pattern[], > > + const struct rte_flow_action actions[], > > + struct rte_flow_error *error) > > +{ > > + struct iavf_flow_engine *engine =3D NULL; > > + struct iavf_flow_parser_node *parser_node; > > + void *temp; > > + void *meta =3D NULL; > > + > > + TAILQ_FOREACH_SAFE(parser_node, parser_list, node, temp) { > > + if (parser_node->parser->parse_pattern_action(ad, > > + parser_node->parser->array, > > + parser_node->parser->array_len, > > + pattern, actions, &meta, error) < 0) > > + continue; > > + > > + engine =3D parser_node->parser->engine; > > + if (engine->create =3D=3D NULL) { > > + rte_flow_error_set(error, EINVAL, > > + RTE_FLOW_ERROR_TYPE_HANDLE, > > + NULL, "Invalid engine"); > > + continue; > > + } >=20 > Please sync with below fix for ice > https://patchwork.dpdk.org/patch/66232/ >=20 > > + > > + if (!(engine->create(ad, flow, meta, error))) > > + return engine; > > + } > > + return NULL; > > +} > > + > > +static struct iavf_flow_engine * > > +iavf_parse_engine_validate(struct iavf_adapter *ad, > > + struct rte_flow *flow, > > + struct iavf_parser_list *parser_list, > > + const struct rte_flow_item pattern[], > > + const struct rte_flow_action actions[], > > + struct rte_flow_error *error) > > +{ > > + struct iavf_flow_engine *engine =3D NULL; > > + struct iavf_flow_parser_node *parser_node; > > + void *temp; > > + void *meta =3D NULL; > > + > > + TAILQ_FOREACH_SAFE(parser_node, parser_list, node, temp) { > > + if (parser_node->parser->parse_pattern_action(ad, > > + parser_node->parser->array, > > + parser_node->parser->array_len, > > + pattern, actions, &meta, error) < 0) > > + continue; > > + > Please sync with below fix for ice > https://patchwork.dpdk.org/patch/66232/ >=20 >=20 > > + engine =3D parser_node->parser->engine; > > + if (engine->validation =3D=3D NULL) { > > + rte_flow_error_set(error, EINVAL, > > + RTE_FLOW_ERROR_TYPE_HANDLE, > > + NULL, "Validation not support"); > > + continue; > > + }