From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 585F6A04F1; Fri, 13 Dec 2019 12:17:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66CC12BD3; Fri, 13 Dec 2019 12:17:52 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C88571F5 for ; Fri, 13 Dec 2019 12:17:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 03:17:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="211356254" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 13 Dec 2019 03:17:49 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 03:17:49 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 03:17:49 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 03:17:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BSnmfv+PPriNwDqouHDVatlWn+N9SI7kLJD77pZogvRH7jN21pvWh6IF68bQTcWdloZzFSFZ6VVmgARCIaqsugkw4zzkvUm5MInLbbUAIWidVXK2itxn/+8OAxVn1ptrdzaToBeCFNAGdehdQ8kzhvSAZpotQWv/vp3/2QTPO+GGKfUzpZmosZk7w8Ita3klWvvWAk0XlCt2l+65ez4e3wxb0DgCCoTfIQEcLEMkpqprGD8sWQcCsjIErXZHhjKZAJoz5dRcVIFzncDaeS+cxYzFUKwkL1I9k2jhI0jEZno4J27HerxeOTgE0TQSmeqdMbbQ1e+/BLhmoG8Yfo6ypw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u2s0fzMusd04IyGqXkH/BSNQTAZcYtgNfTWW0/Os2EI=; b=Hg7Y8mE8mfDjtrtUYfmcbAUI9K6qZ8DempR2LML2O7OY8+I5G7Lf228VhnuHZvu3Py4cS2JGvKurHIBVOfzVRQAnvwsZg50WiDVB3UUG1w5Ae11vEM5SPYvJaIq1LqtmLo0iffMWOxTjKTpRSqDypiOrki6fPs3hLAV0X8DCjy9jZ/EALWH71mnwmJSbITBNAiIZMKJjlsILsIWzH8VCVNw4j+AW8Wc4Vi1laVXGNgkgeB1+WN+avknZNJNHT1sNpGJaQ2SOT2QiEem54VPvVXS1bYFjjnZQz3Hdjo6yIoAFXRmx8lia1IJV6YKIqayjAvq0SEq6aOyGkqSWKbf6cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u2s0fzMusd04IyGqXkH/BSNQTAZcYtgNfTWW0/Os2EI=; b=jPg7N0oALQmg1K6X3VdxT2o8BOVnEAvCBrKpuOj0NTgr1FfzBYSb4R3RlXWnXAfEcQ67lqNH4BJjHY42pv8swb2O5zsfV8fLPoyBlYgM+ycPWcsiCR4AnnHzbD9l372suqTngf0EVvLxVKRcXdNB+EdIt4KamzuV8hnn5uh0gJo= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB4335.namprd11.prod.outlook.com (52.135.38.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Fri, 13 Dec 2019 11:17:33 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c%3]) with mapi id 15.20.2538.016; Fri, 13 Dec 2019 11:17:33 +0000 From: "Sexton, Rory" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "adrien.mazarguil@6wind.com" , "Jagus, DariuszX" Thread-Topic: [PATCH] net/i40e: Add new customized pctype for l2tpv3 Thread-Index: AQHVqq1kBqDCO/GhNEupehiV8y5kVqe1laiAgAJVbdA= Date: Fri, 13 Dec 2019 11:17:33 +0000 Message-ID: References: <20191204141055.3647-1-rory.sexton@intel.com> <20191204141055.3647-2-rory.sexton@intel.com> <94479800C636CB44BD422CB454846E013CEA4464@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CEA4464@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJiYmI3MzktYTA1NC00MTQ3LWIxYjYtMjk1NzkyZmExMzJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieVdBN2hVOFwveExYQm1aaVhGK050bjhrcHE5cjlEMDVZd0pRbzBMbDFJRW5jNFFFT2NGa3BJbVdwcVhIZ2ZkTDUifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.177] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a777a612-fca9-4df6-3b94-08d77fbe0d2d x-ms-traffictypediagnostic: MN2PR11MB4335: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(136003)(39860400002)(346002)(396003)(199004)(189003)(54906003)(110136005)(316002)(2906002)(86362001)(107886003)(33656002)(4326008)(52536014)(64756008)(66476007)(66946007)(66556008)(55016002)(66446008)(9686003)(6506007)(186003)(5660300002)(7696005)(71200400001)(478600001)(76116006)(81156014)(8676002)(81166006)(8936002)(26005)(138113003); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB4335; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rcNYUfhn12S2R2hftQg8fhktXlrbEdjjN9aGKKkBbtKiuJR99NVB7kEka4M6+4n9PSJNU5cwtgZMPhGMsvqd1FDCnV2Dn43oZui+ZhsBBeBzEPBjSLkcy1Vn4TfCkDeMkfKfUQzcQPpkaCtRslSafEkSUmCUtb6SVKgCRqmOLMuQXTEDuFgc9gObhMqorcvVk1Y/Q0OFLA2QzfxPTELDUzRiUy30obfRr3g0kPHcR6Fx/ZcFlWp0y0C8UUZrZAvFhZVF9PWKK+gtqsdTLdjBNstFqR/IrdryPbs9JqMNmKnRdxSe49BlCoI2UdHCPoUpnw05Mn71paGMpJmIsVsoui4TNNQlJUkDrRb8T4cqEqg68L+lO2KR3seLkYZjLYU0opumKmzSTnn9barycEDzGXB8zrhoVWsP9r4ppF+P2q56GI0z66UN/YWI9GbSFLR8nUpvaYPtroGDypAdsaK7ALI9U7sGnpQnXypJ18lVODZlxv8Fjgb+7D/l26AJYLB7 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a777a612-fca9-4df6-3b94-08d77fbe0d2d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 11:17:33.5907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VOj/cP+gWlrk2c/ZJwuI+SkJHwUmh+f7RjdivvDwTsDpjVncl3BU4ooiPuLw3M7RFduJit0lDA5srbZVU0XSRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4335 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei, See comments below. Regards, Rory > > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3 > It's not only add new customized pctype, but mainly enable FDIR for l2ipv= 3, so how about " net/i40e: support FDIR for L2TPv3"? > > Detailed commit log is also needed. Of course can update this in v2. > > +/* A structure used to define the input for L2TPv3 flow */ struct=20 > > +i40e_l2tpv3_flow { > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here? >=20 I'm not convinced we need struct rte_eth_ipv4_flow or struct rte_eth_ipv6_f= low to be part of the struct i40e_l2tpv3_flow. The rte_eth_ipv4/6_flow struct will be included in the flow director patter= n from the following additions. Please advice so I can update in a v2 of the patch if required. +static enum rte_flow_item_type pattern_fdir_ipv4_l2tpv3[] =3D { + RTE_FLOW_ITEM_TYPE_ETH, + RTE_FLOW_ITEM_TYPE_IPV4, + RTE_FLOW_ITEM_TYPE_L2TPV3, + RTE_FLOW_ITEM_TYPE_END, +}; + +static enum rte_flow_item_type pattern_fdir_ipv6_l2tpv3[] =3D { + RTE_FLOW_ITEM_TYPE_ETH, + RTE_FLOW_ITEM_TYPE_IPV6, + RTE_FLOW_ITEM_TYPE_L2TPV3, + RTE_FLOW_ITEM_TYPE_END, +};