From: "Sexton, Rory" <rory.sexton@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"orika@mellanox.com" <orika@mellanox.com>
Cc: "Jagus, DariuszX" <dariuszx.jagus@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP
Date: Mon, 13 Jan 2020 10:42:16 +0000 [thread overview]
Message-ID: <MN2PR11MB367831CFAC17DEA93F2216DEEC350@MN2PR11MB3678.namprd11.prod.outlook.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013CEC972D@SHSMSX101.ccr.corp.intel.com>
Hi Beilei,
PSB
Regards,
Rory
>
> Sorry, NACK the patch since there's compilation issue with clang and coding style issue.
> Please check http://mails.dpdk.org/archives/test-report/2020-January/112422.html and http://mails.dpdk.org/archives/test-report/2020-January/112412.html
> BTW, Doc update is needed in release notes, please also describe what's the supported input set for the new PCTYPE.
>
> Beilei
>
The compilation issue is because for some reason patch 1/2 of this patch-set which affects rte_flow api was not applied before compiling this patch with DPDK test framework.
http://mails.dpdk.org/archives/test-report/2020-January/112422.html
The errors in above would have been avoided if the first patch of this patch-set had been applied before this 2/2 patch. Not sure why this happened.
I've confirmed manually that there are no issues with clang compilation when first patch of set is applied correctly.
As regards coding style issue (http://mails.dpdk.org/archives/test-report/2020-January/112412.html).
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#343: FILE: drivers/net/i40e/i40e_flow.c:3059:
+ filter->input.flow.ip4_l2tpv3oip_flow.session_id
+ = l2tpv3oip_spec->session_id;
If the '=' operator is moved to previous line then the line will exceed 80 characters. There are similar cases earlier in this same file which I followed to keep code consistent throughout.
Please advise which style you prefer to be used, line exceeding 80 chars or '=' operator on 2nd line.
See an earlier example for this case in same file, drivers/net/i40e/i40e_flow.c:2900, which I used as example for how to base coding style for such case:
filter->input.flow.sctp4_flow.verify_tag
= sctp_spec->hdr.tag;
I will do DOC update for release notes separately and describe the supported input set for new PCTYPE there.
next prev parent reply other threads:[~2020-01-13 10:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 15:39 [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API Rory Sexton
2020-01-07 15:39 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP Rory Sexton
2020-01-10 18:27 ` Ferruh Yigit
2020-01-13 3:22 ` Xing, Beilei
2020-01-13 8:07 ` Xing, Beilei
2020-01-13 10:42 ` Sexton, Rory [this message]
2020-01-10 18:26 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API Ferruh Yigit
2020-01-12 10:57 ` Ori Kam
2020-01-12 10:56 ` Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB367831CFAC17DEA93F2216DEEC350@MN2PR11MB3678.namprd11.prod.outlook.com \
--to=rory.sexton@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dariuszx.jagus@intel.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).