From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E202DA04F0; Mon, 13 Jan 2020 11:42:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E8B51D5C7; Mon, 13 Jan 2020 11:42:22 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9E7631D5C5 for ; Mon, 13 Jan 2020 11:42:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 02:42:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="304809690" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga001.jf.intel.com with ESMTP; 13 Jan 2020 02:42:19 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 02:42:19 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 13 Jan 2020 02:42:18 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 13 Jan 2020 02:42:18 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 02:42:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EUuLwnc7BRhGi9+VO8mMl69uTsB8+haVa+YQPT/7vBDz8EHY2m92Y8dbuFtMWNc/qDOvi0v/0yfPCLRrvWqO0Ju8CFfKcMTkDa3m0pXCikV6xd4nWw9VYLPVqas5Z10pGjV3/ZZWvAe2KUWFBAfZ+80IHr2Xij0WTL36wAydEKvq5PXWEHoEhru5084y1FCICFgIGckjBJHidyAznwJV//7dRPCWLzgH6SguYs/1Wtxbrkp+50yPOnK7UfBm/5A/VadPGT4kXU6KrwYLxVx6C9r+ppb9Uh6UUWcLrTyIa+4X4fUL/Yoqwr40cDu+moCRib9hbNrzU8riXONOfx5RJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqClVGE2sNvxiiwmaXIyCzj11rOBqMJIaUF3c19GwFc=; b=Z3VzmRZgBILDclYOBCtOOIXp5meCEAhwbyFvwLLPSIBXAoUv8+NcNd158f8RTGEXg2//zjJFFT689/DhN6X4tHH1sxTeDflKfy2VjkyTPnl89y8cquT0g/HMMxig3fOWPsCosoI25EkOJlPWtjMuZ9m7007BSOMDHviOJ5ZapZYwj42q2Y6TZc3XqVSIAY8eK3+H1bSA1WlF7J6jOR7M7h05tvAkNiq5l9NDA6q2KBGesTGBWwmknqPA8Cl2Dbv5PG2Ngd/nGnQDFLYCn3p4GbtPAFjnaNoesJ9dangB54Qus/p5kjTU/OSJvd6yMd6W2sFRupJyzy/7pkbzE+ubdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqClVGE2sNvxiiwmaXIyCzj11rOBqMJIaUF3c19GwFc=; b=wRYugLYPHyOTBFaC8vdb9AvkGtadiMYjjPaRYOFHdD5tnxSP+Adr4LR43hQdtFXKAQgeX61Lj5dkBQQtW1Z0E2EYph85z/3mf2dTYdRyGD5rqQ8KpWij4Uuy1gT346VfTc8XByx7kVu9ZVJcOlD4clKXquz3HK6iYeet50VeWEo= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB4141.namprd11.prod.outlook.com (20.179.151.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.13; Mon, 13 Jan 2020 10:42:16 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c%3]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 10:42:16 +0000 From: "Sexton, Rory" To: "Xing, Beilei" , "dev@dpdk.org" , "Zhang, Qi Z" , "adrien.mazarguil@6wind.com" , "orika@mellanox.com" CC: "Jagus, DariuszX" Thread-Topic: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP Thread-Index: AQHVyeh+cypIFnq2OEyHmVt1O4vK+qfoYrVQ Date: Mon, 13 Jan 2020 10:42:16 +0000 Message-ID: References: <20200107153946.6876-1-rory.sexton@intel.com> <20200107153946.6876-2-rory.sexton@intel.com> <94479800C636CB44BD422CB454846E013CEC8C94@SHSMSX101.ccr.corp.intel.com> <94479800C636CB44BD422CB454846E013CEC972D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CEC972D@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjRjNzAwYjgtZTY1Ny00N2JjLWJlNTgtZDdmNjIwZmNlNDczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYW1XXC9GUUt3RjA3ZFVvNUVBOW5nVmlWSWNRTWV6QTRlOWxnUlwvdmJsM1wvaXI5anBnYTRUXC93YVY5RzdOZ0VwZlUifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc2fa88f-7fea-4657-c23b-08d798154239 x-ms-traffictypediagnostic: MN2PR11MB4141: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(346002)(376002)(136003)(39860400002)(189003)(199004)(64756008)(8936002)(66446008)(52536014)(55016002)(316002)(66476007)(66946007)(2906002)(76116006)(186003)(26005)(9686003)(7696005)(110136005)(66556008)(6506007)(5660300002)(81166006)(81156014)(107886003)(86362001)(33656002)(478600001)(4326008)(966005)(71200400001); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB4141; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PiEO09T+WevfzJ1Ui6uCDMG2YXeHx9TP9TqezqJh02RFKt704vMthgtBrop67E23PZ1yrwgyQhlvfiwcsGOPIiysM0jNt/IGbe53vSl6aIZwXHzIF9o2wAfRwGt1XrREbJ+eS7yxIQqyqKwFwBdoyXHJN2eQnNDLgwJUHwp3k+XdVQRK4KMpDBbRO602J5FCBfcFuspC2LFPLNSylbxXQWuMtCZjKSKepIfkKIoPFhV/bbAYbbngR2GhQRF4YxhhOZjf/t4BlGC+e5a6HHpaRCYUF3nS55pJ1OH20yHm6yvMU+UTDSWb8M/Lbb7L8OVGxq+PjnHVXmsa68FZrjKPyjZcO3rMu45uwXf6wqXS9+nL2laF26ZyzQ16oJ3Xct1MPNYvS/jeM5m4zegWQiieoSpNZp64meGKyM/SoiujwCOJiG+6HyCvmNsxnxJegUw/7YUYwQSunKsKLgHZHpUr3gf4hY2JqaSmJB2hsntmSTQ8qWrWea0skx2YBapgLCqCih+nM7XUe5mM8n6gR+vQhQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fc2fa88f-7fea-4657-c23b-08d798154239 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 10:42:16.7212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QYU1ezbuQrtBgPIuhY/Y+lTZtCHewC5IB5/7Q1GPQy7KoybhIYwTx61xy+8jzX8Z+tySWY6bcWo3feYqlmuDgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4141 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei, PSB Regards, Rory >=20 > Sorry, NACK the patch since there's compilation issue with clang and codi= ng style issue. > Please check http://mails.dpdk.org/archives/test-report/2020-January/1124= 22.html and http://mails.dpdk.org/archives/test-report/2020-January/112412.= html > BTW, Doc update is needed in release notes, please also describe what's t= he supported input set for the new PCTYPE. >=20 > Beilei >=20 The compilation issue is because for some reason patch 1/2 of this patch-se= t which affects rte_flow api was not applied before compiling this patch wi= th DPDK test framework. http://mails.dpdk.org/archives/test-report/2020-January/112422.html The errors in above would have been avoided if the first patch of this patc= h-set had been applied before this 2/2 patch. Not sure why this happened. I've confirmed manually that there are no issues with clang compilation whe= n first patch of set is applied correctly. As regards coding style issue (http://mails.dpdk.org/archives/test-report/2= 020-January/112412.html). CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the = previous line #343: FILE: drivers/net/i40e/i40e_flow.c:3059: + filter->input.flow.ip4_l2tpv3oip_flow.session_id + =3D l2tpv3oip_spec->session_id; If the '=3D' operator is moved to previous line then the line will exceed 8= 0 characters. There are similar cases earlier in this same file which I fol= lowed to keep code consistent throughout. Please advise which style you prefer to be used, line exceeding 80 chars or= '=3D' operator on 2nd line. See an earlier example for this case in same file, drivers/net/i40e/i40e_fl= ow.c:2900, which I used as example for how to base coding style for such ca= se: filter->input.flo= w.sctp4_flow.verify_tag =3D = sctp_spec->hdr.tag; I will do DOC update for release notes separately and describe the supporte= d input set for new PCTYPE there.