From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0C3FA04F5; Thu, 12 Dec 2019 14:42:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BC11374C; Thu, 12 Dec 2019 14:42:23 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8C39E2BD3 for ; Thu, 12 Dec 2019 14:42:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 05:42:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,306,1571727600"; d="scan'208";a="245726166" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 12 Dec 2019 05:42:20 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 05:42:19 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 05:38:44 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 05:38:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZHmLKar/Sf15tZAD0JDUrqqyU5wM1AHNWU4LZsedUkCI99co7IjgKSLV09a9ooqjxsJEZQR4u3lv5ulWxGQt2TdVvRXPOjlUvbCEfTKM5J0Jt/+efqdsPJcXop9hr9Jlaz7wypawTQQPY4/o+PDzYG9lkvMatC4eryZl47jGYTWXYZc9m9/BxTL0Pb8nIHqDLfS79hNTjonUKjgUa0DX+jDkDF3a+WFDX1BcjtD93LZW2RF6/nntxHav1KLSbseE6u6qHOfI5Yuszg/F2FOo/I2NIXIovjTBbbk5ac+joJKomnE9/yula8gBUmhIRmXlq+fA84LY4YsbUF5Lf1nA4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pJCahKg+ybFRSdifFD5Q+jboQgoo6EHetaEksVXMUng=; b=lG+XQwefORw69z2cWP03+v213J5dLo0SWgtHT6neY/ujJQy3UD5ZY4rS8Pw99TbYjW1Ro3zeIWYV/DN3Zc6DNjnxLHCBknQCOdsb3p/xl4T4fhuAHrght6PKpO2pxK7lGajBgWfPvfLQ7VojdGjdnLyZP6ISEsRh5gpMibfJBoodMetek84u3/7El8Cc+qAdIpLRvVdZwUf6diAmYIHwAzqeIZxqC4nNrlbJ+eDamaIJUqrY6ViCXXGru1HtGUOIpCc0W06y95vwTc5CmGmTuSXY7mEaW9o5p8fU1bkmvvcaLx0f7EWxT4Kyc+CKFzvMTsVGw6xSv6AhTmnJQJg8fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pJCahKg+ybFRSdifFD5Q+jboQgoo6EHetaEksVXMUng=; b=Sk+rTRe/ncofY5hWYG0DcRfpIVJ1kCDzCk97JVWQf0IOCXorC5/DHaAbOUuNJF4DdCFuIVo1adO95UZnRJw6HUcRJKo/aSGqKyYiur630CWXCuxO+HBYC3a8xsWZSJTvSgqsXsOadJDgxL1wJpFFtntqfxSHyJArzCXt2uWkABQ= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB3901.namprd11.prod.outlook.com (20.179.150.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Thu, 12 Dec 2019 13:38:09 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c%3]) with mapi id 15.20.2538.016; Thu, 12 Dec 2019 13:38:09 +0000 From: "Sexton, Rory" To: "Sexton, Rory" , Ori Kam , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Xing, Beilei" , Adrien Mazarguil , "Jagus, DariuszX" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Thread-Index: AQHVqq1WuGnZL6ab8EC6Oc0BGrrb+aezMF2AgABIiPCAAGOWgIAA9PeQgAAncYCAAC6LUIABZPyw Date: Thu, 12 Dec 2019 13:38:09 +0000 Message-ID: References: <20191204141055.3647-1-rory.sexton@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDUyNjk2YTctOTgwMS00NmU4LWE2YmUtY2VkMjRjNzRiYjIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialoxRytMSlpoV3JWdHR0YkhRMXROR0pcL3dnTm9DMVA1ZDF3OEZtc2J5bEtZNlZ4UlBjb0g1Vk16WHJRSFFuUjkifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.177] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62a5e99f-7f8b-401a-f895-08d77f0886da x-ms-traffictypediagnostic: MN2PR11MB3901: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0249EFCB0B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39860400002)(376002)(396003)(136003)(366004)(13464003)(189003)(199004)(51444003)(71200400001)(8936002)(81156014)(8676002)(81166006)(76116006)(5660300002)(26005)(7696005)(478600001)(53546011)(6506007)(186003)(110136005)(54906003)(4326008)(2906002)(86362001)(33656002)(107886003)(316002)(66446008)(64756008)(66476007)(66556008)(66946007)(55016002)(52536014)(9686003); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB3901; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qvz7uf/ZLVMDsvikNRe8HMpbJ4wmgBjp4PYFTQr7aSxKP6JCeEjVh8oN6fUuJjVx++x5xv6gvZbToDbwm4jyCKFypRcc6Q4RXLxgEFqOC5qAVWqPeVJ9PHF6n74GEFPWhprjRtDSB24PGFNf50C1cZqnJ5AtBHonkkHM5R++fwF3h8qBoFuyxvY/BkEH3qoa3FJi8yVPgKnJQEHDK1NPmgBUpB9/GwvGQh0J7q2A7h4dqeOhTKm+uwoeNcQrCRNSG4DL4yC78ORPNgo38I7db17A2j6GTcPE4k3bJecg2p8dgsC59X5WLuyPVpwITtG+kC4oOQjKnIEvEdb/ynTawe53NECYH3cn1V/kRKs+LEaL+Qpp5YH98UHM15lNgygP1yaoLcRs8mhle3wMjTyhwgwOrrvK3p7SN2nzMp8ZjrrZy2QxoXVzPGKdDfcgDeDzk5GIo+Z8R6C9+30TmUgGQzISodjYalNe856CBjuwHWv48qzrbwcLn/Gg2t9T4Ecpj0TKHcqd/rlIautsNycFTA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 62a5e99f-7f8b-401a-f895-08d77f0886da X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 13:38:09.2719 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jgpoXFF2gs9WRg0mPY101QXnf252CcexfCYluElbRJz4+XaVM+Mtj9w+oBhIzp2sOMLU0vGwHSC7JPIt86O1Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3901 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, Let me rework the patch to make it clearer that this is supporting new flow= type for l2tpv3 over IP, rather than l2tpv2/v3 over UDP which is how you i= nterpreted it. Will take into account all your feedback. Please review v2 once I submit. Regards, Rory -----Original Message----- From: dev On Behalf Of Sexton, Rory Sent: Wednesday, December 11, 2019 4:31 PM To: Ori Kam ; dev@dpdk.org Cc: Zhang, Qi Z ; Xing, Beilei ; Adrien Mazarguil ; Jagus, DariuszX Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Hi Ori, See comments below. Regards, Rory > > > > > > +/** > > > > > > + * RTE_FLOW_ITEM_TYPE_L2TPV3. > > > > > > + * > > > > > > + * Matches a L2TPv3 header. > > > > > > + */ > > > > > > +struct rte_flow_item_l2tpv3 { > > > > > > + rte_be32_t session_id; /**< Session ID. */ }; > > > > > > > > > >Does it make sense that in future we will want to match on the=20 > > > > >T / L / ver / > > > > Ns / Nr? > > > > > > > > > >Please also consider that any change will be ABI / API=20 > > > > >breakage, which will be allowed only next year. > > > > > > > > > > > > > I don't foresee us wanting to match on any of the other fields,=20 > > > > T / L / ver / Ns/ Nr. > > > > The session id would typically be the only field of interest in=20 > > > > the > > > > l2tpv3 header. > > > > > > I think that adding all fields to the structure will solve the=20 > > > possible issue > > with adding matching later. > > > Also and even more important you will be able to use it for=20 > > > creating the > > raw_encap / raw_decap buffers. > > > > > >What do you think? > >=20 > > Based on the differences between v2 and v3 the only field of=20 > > interest in > > l2tpv3 over IP is the Session ID. > > I agree it would make sense to add all fields if we were=20 > > implementing > > l2tpv2 however v2 would require a different implementation to v3 due=20 > > to the differences between both Protocols. > > Even if we just support v3, I think that it is a good idea to add all fie= lds of v3.=20 > This will allow the use of the raw_encap / raw_decap actions. > Please also note that you didn't add the new item to cmd_set_raw_parsed = function. > this function is used in order to create raw_encap/ raw_decap encapsulati= ons. I think the confusion here is based on the fact that there are 2 separate t= ypes of l2tpv3. - l2tpv3 over UDP, which is very similar to l2tpv2 with only change being 1= 6 bit Tunnel ID and 16 bit Session ID changing to 32 bit Session ID. All other fields rem= ain (T/L/Ver/Ns/Nr). - l2tpv3 over IP is another type of l2tpv3 that is carried over IP rather t= han UDP and as such the message format is entirely different and consists of just a 32 bit Se= ssion ID. The other fields mentioned above do not exist at all in this l2tpv3 header. This patch was targeted at creating a flow to handle l2tpv3 over IP exclusi= vely. This is why the Session ID is the only field in the flow item. I can add the item to cmd_set_raw_parsed function.