Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: support FDIR for L2TPv3 over IP

["Sexton, Rory" <rory.sexton@intel.com>]

Hi Beilei,

I have resolved all comments below in v3 of patch.

Rory
 
> > Adding FDIR support for L2TPv3 over IP header matching and adding a 
> > new customized pctype for l2tpv3 over IP.
> > 
> > Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> > Signed-off-by: Dariusz Jagus <dariuszx.jagus@intel.com>
> > ---
>
> Version change is needed here.
>

Thanks for noting, will fix this. Just getting familiar with the mailing list process.

> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > index 73ef0b41d..5e6935829 100644
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > @@ -3954,6 +3954,10 @@ This section lists supported pattern items and 
> > their attributes, if any.
> > 
> >    - ``proto_id {unsigned}``: PPP protocol identifier.
> > 
> > +- ``l2tpv3oip``: match L2TPv3 over IP header.
> > +
> > +  - ``session_id {unsigned}``: L2TPv3 over IP session identifier.
> > +
>
> It should not be a part of this patch, which is focus on i40e PMD.
>

Good point.
Moving this change to separate patch where testpmd changes are applied.

> > diff --git a/drivers/net/i40e/i40e_ethdev.h 
> > b/drivers/net/i40e/i40e_ethdev.h index 295ad593b..5b6d43556 100644
> > --- a/drivers/net/i40e/i40e_ethdev.h
> > +++ b/drivers/net/i40e/i40e_ethdev.h
> > @@ -508,24 +508,43 @@ struct i40e_raw_flow {
> >  	uint32_t length;
> >  };
> > 
> > +/* A structure used to define the input for L2TPv3 over IP flow */ 
> > +struct i40e_l2tpv3oip_flow {
> > +	uint32_t session_id; /* Session ID in big endian. */ };
>
> Is this structure needed?
>

This is unused so will remove it.