From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77635A04DD; Tue, 21 Jan 2020 17:43:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C13991B203; Tue, 21 Jan 2020 17:42:59 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1A27314583 for ; Tue, 21 Jan 2020 17:42:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 08:42:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,346,1574150400"; d="scan'208";a="275348066" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jan 2020 08:42:56 -0800 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 08:42:55 -0800 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX115.amr.corp.intel.com (10.22.240.11) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 08:42:55 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 08:42:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q3w+oi8455iKcMep8LrnVRCVh961DIEgdPG8ssw6eqMdmFoQExni7fdMOPElUE0brpj4XJ0i/dAqoltkUjNTzWDp+pwk/6ZdB6wnAf+BPW+IxXckh2QDO2+aTo4k+Hq9yU1TEmNNJ523O+kekkJfa64qo1i1iWkKJodSOU5dy9s77wymKR4keYoOUXrC0jNltn34Jys7ariYTS8WYRxExTdPb2kXxcShiBtZXcVfBvwNVV0Wf3eRAeBJozHO8Mj9AZ2oue/Fs/v9g0gyqPkRWmmDDsy1zslLnH1VSGVI58OBMn4Jypkmc7502r2jJBgdLxen/S4alXRgjN3xJpr4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnYvSK5mF9JKkVjrCwgWLhJPtHDp44/BEcp4NFnTq30=; b=aQPJ5QrzSVLFqacgEL1r+opR9ZAKoUEZrfzy2F/QUAlFzV6TKSe77xCc4T5ebRoECCewFMkDO+BnT5u/jsK4f5+1avst3a7E0a+eEh+zDJoijE9zO5g2GuGxjEsW8t3qPpyzmu4CpSPb9DULy4jT2CPNXBGbdf6XdvWOanlnaESc9+4kfvmlrvyCb0qbYC2mmkjFjb+vOHm4T0AmoM6nBqWGgNPQ3em1/Gz5DSmC44itTslzzikL78gSuU4kiaFFTfYNJKCbi5QOqaWYToykuqu7FznS+6yrde3/Ybad2mhRKqStvskIUvoN9S5vM9kMs5R/CI4eUzgiy+ZCn40eYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnYvSK5mF9JKkVjrCwgWLhJPtHDp44/BEcp4NFnTq30=; b=CUr360omaCcztpT/eSW8F+G7nck4u4317q+Llc2UAjLa6ELnhWCLzK1rtYu88DyVKaALRdn01FzDUOJGOOD53TDMTaqlQ6PItMkPdzsYEGhy07PfJb+31NBw52b0Kbk89Wp/QHuBL7p6cQ4rdfwYvLA+cfR36PWLVBi1krDI/O8= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB3550.namprd11.prod.outlook.com (20.178.251.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20; Tue, 21 Jan 2020 16:42:54 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c%3]) with mapi id 15.20.2644.027; Tue, 21 Jan 2020 16:42:54 +0000 From: "Sexton, Rory" To: "Iremonger, Bernard" , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "Yigit, Ferruh" Thread-Topic: [PATCH] net/i40e: fix i40e flow director merge Thread-Index: AQHV0HRDfJkRQ0DhFU2uiHfwWdcTu6f1TsaAgAADt1A= Date: Tue, 21 Jan 2020 16:42:54 +0000 Message-ID: References: <1579622533-15909-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTEyOWQ4NDYtMjUxNi00YmM1LTg3YmYtYTBjZTdkYjBjOWVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUZ5SG1vbDdnb1FhR3hPMUtHUXJpTEtLTE9RT2Y0b2ZhaXJIOXgxR21BUzErTXdleU9QeXFSQXg5MTQ0WEJTYiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b2621cd-19b6-4b7e-7d5e-08d79e90f669 x-ms-traffictypediagnostic: MN2PR11MB3550: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 0289B6431E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(366004)(376002)(346002)(396003)(39860400002)(199004)(189003)(6636002)(66946007)(76116006)(5660300002)(110136005)(2906002)(52536014)(316002)(81156014)(8676002)(7696005)(6506007)(53546011)(81166006)(478600001)(71200400001)(33656002)(66446008)(66556008)(66476007)(86362001)(9686003)(55016002)(64756008)(26005)(186003)(8936002); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB3550; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 26mIqgIZ6Vpm3fLsnH+G04u0WOp6Et7pGVu2480mzKRxvN9LGtRnsLMEAhrCN4qDQZ+9P82ahdF6GAmy75fEqXg9xDGcy2QW8ge/QJHxZTDFqi5XN6GLqORluUs4/qeTucIf87XOmkbR9Ot0sEhbA0kqld+vfhfp5mc10+vB4gGWfd/PQY5GPg0GGzCc2on2mVfWzJ2RVNVZjj8Phxk5OGseWhxZFpntVg0M/HAfWR30CMe+OY1C2+rGsrbQUYcLWso75c94YZHlTD2KJa2ayocXiFHnVvFZ+KDljZMP/9AzxuQuA+E4OvrVM615yhhbK4ctTvDcYhLyfht+tfr9rbrlvZcAOZ1r7m8SRstS0ZOLj5VT6j96cLqUyn+cxnrT7lUmpZTpGdGRfraziKRU58CULduOBvY8omkZjk10NWRVb39+fOyJPjvF8FqAVzHd Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0b2621cd-19b6-4b7e-7d5e-08d79e90f669 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2020 16:42:54.1093 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yh+AAEIyQZtDtQ/7HrK1VDQQN1lB4HZWjmdS1PHu9yrUKI8MR48Cg1MkDCT6JIWnmW0o3KEBYttdaHoS6R80cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3550 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix i40e flow director merge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Nack - if statement should look like this: else if (pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_TCP || pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP || pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_SCTP || pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_OTHER || pctype =3D=3D I40E_FILTER_PCTYPE_FRAG_IPV4 || ((is_customized_pctype) && ((cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPC) || (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV4) || (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV6) || (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU) || (cus_pctype->index =3D=3D I40E_CUSTOMIZED_ESP_IPV4) || (cus_pctype->index =3D=3D I40E_CUSTOMIZED_ESP_IPV4_UDP) || (cus_pctype->index =3D=3D I40E_CUSTOMIZED_IPV4_L2TPV3)))) { -----Original Message----- From: Iremonger, Bernard =20 Sent: Tuesday, January 21, 2020 4:29 PM To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z ; Yigit, Ferruh ; Sexton, Rory Subject: RE: [PATCH] net/i40e: fix i40e flow director merge > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, January 21, 2020 4:02 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z=20 > ; Yigit, Ferruh ;=20 > Sexton, Rory > Cc: Iremonger, Bernard > Subject: [PATCH] net/i40e: fix i40e flow director merge >=20 > Merge of i40e_fdir.c added checks on cus_pctype->index which are not=20 > necessary and caused flow creation for ESP to fail. > Removed the added lines to fix the issue. >=20 > Fixes: c5f8365bc85d ("net/i40e: support flow director for L2TPv3 over=20 > IP") >=20 > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_fdir.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c=20 > b/drivers/net/i40e/i40e_fdir.c index > c346073..1d7c392 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1063,12 +1063,7 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf=20 > *pf, > pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_SCTP || > pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV4_OTHER || > pctype =3D=3D I40E_FILTER_PCTYPE_FRAG_IPV4 || > - ((is_customized_pctype) && > - ((cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPC) || > - (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV4) || > - (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU_IPV6) || > - (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU) || > - (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_IPV4_L2TPV3)))) { > + is_customized_pctype) { > ip =3D (struct rte_ipv4_hdr *)raw_pkt; >=20 > *ether_type =3D rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4); > -- > 2.7.4 NAK, causes problems for L2TPV3