From: "Sexton, Rory" <rory.sexton@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"Jagus, DariuszX" <dariuszx.jagus@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3
Date: Mon, 16 Dec 2019 10:13:55 +0000 [thread overview]
Message-ID: <MN2PR11MB3678E519575C176D907C3B03EC510@MN2PR11MB3678.namprd11.prod.outlook.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013CEA6079@SHSMSX101.ccr.corp.intel.com>
Hi Beilei,
See below,
Rory
> > > > +/* A structure used to define the input for L2TPv3 flow */ struct
> > > > +i40e_l2tpv3_flow {
> > >
> > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here?
> > >
> >
> > I'm not convinced we need struct rte_eth_ipv4_flow or struct
> > rte_eth_ipv6_flow to be part of the struct i40e_l2tpv3_flow.
> > The rte_eth_ipv4/6_flow struct will be included in the flow director
> > pattern from the following additions.
> > Please advice so I can update in a v2 of the patch if required.
>
> Please refer to union i40e_fdir_flow: A union contains the inputs for all types of flow items in flows need to be in big endian.
> Pattern is part of rte flow, but not the packet sent to HW to create/destroy a FDIR rule.
>
> Beilei
Ok, I follow you now. Thanks for clarification.
Please see updates in v2.
next prev parent reply other threads:[~2019-12-16 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 14:10 [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Rory Sexton
2019-12-04 14:10 ` [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3 Rory Sexton
2019-12-11 22:51 ` Xing, Beilei
2019-12-13 11:17 ` Sexton, Rory
2019-12-13 17:33 ` Xing, Beilei
2019-12-16 10:13 ` Sexton, Rory [this message]
2019-12-10 10:16 ` [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Ori Kam
2019-12-10 14:52 ` Sexton, Rory
2019-12-10 20:32 ` Ori Kam
2019-12-11 11:36 ` Sexton, Rory
2019-12-11 13:30 ` Ori Kam
2019-12-11 16:31 ` Sexton, Rory
2019-12-12 13:38 ` Sexton, Rory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB3678E519575C176D907C3B03EC510@MN2PR11MB3678.namprd11.prod.outlook.com \
--to=rory.sexton@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dariuszx.jagus@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).