From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9C0EA04B3; Mon, 16 Dec 2019 11:14:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51EE61BFB4; Mon, 16 Dec 2019 11:14:01 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5150C1BFAB for ; Mon, 16 Dec 2019 11:13:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 02:13:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,321,1571727600"; d="scan'208";a="209255531" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 16 Dec 2019 02:13:58 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 02:13:57 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 02:13:57 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 02:13:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9+MRRCv/5bwfRBJz6MRMcPdM9gSb2j+/6Fru0EUYCZFKWtEl1YPliQa3ZRlAUHczoYFIaEs6HGn1bglukKA3sFh+dtgqbjHLnav+3DI3HRXvIaUDS9l1aGubOHFthsw2ARZ6LmxAye9SAfhz803aBG8rswZT7Ppu0iTi8ESWKXyiBd+0YDyeNfyzVWz2JHw2VLojM5VuZDa6D2HoyfdffVkyZ535ZqgAdpV9LYO7iL57XiIB80u1A7cZ+bVS2h3CY4z36LTZhlnzH02vRF6EdIz1pqX4ogaxGek8o0HD+yEh4mLh+aH7P13c3CGCbOSSvE8SwIqv6/4KhiSRljKuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZU7eRAEIiMMaBstU68pJDvIAm2rZ2DalGXc3uxz8Okk=; b=dZtwCqhFiDC4k4gLm1+IDBxJm5c38vz+3H9lnkk3mK/8HFVCUfZ74Bxh6Y6txKZbPSo8L6K4Ga7cyedsWaXMAHjpouukCHBJrtjrckevEgD9ILVAGYeo+iU72FkqfHqJke3HKPFzZDcBHo+9kL7w1NqmyxV6DGR3zYR/p8CVQkHw+aFSx0iFTKOgk0VcdVFL2iYig/ZVhKqdpIV9jnmhSGu3YoSCBH2i8DovhMFDHMuriqXRL4Px9gZRDWaPXe0DMOZP3bza6+y8RzzJJVX8fy94vWzmU0JhSkNDHVnwqF0YNMrX8c2EyPT9KEvuZ78F9BXxKUExiulzPnD8OLKNWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZU7eRAEIiMMaBstU68pJDvIAm2rZ2DalGXc3uxz8Okk=; b=Kd6kuARNO5M7ccZOy7uJ0r2p2wien7vscbCGDg0N/CVBoHb7P+nNuXxdNWqrCYDcoFPoVaJ8q+K25LRsZaxe1bdFp8Ey5XnFibDkp1HLBZH2IT02Io3GY27sARowOvkCkOHdTlImlVCiGrb7sQGN7sBO/CYvcHm7GTYh4kX+BZ4= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB3645.namprd11.prod.outlook.com (20.178.254.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.15; Mon, 16 Dec 2019 10:13:55 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::5cee:eb7e:b053:7d5c%3]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 10:13:55 +0000 From: "Sexton, Rory" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "adrien.mazarguil@6wind.com" , "Jagus, DariuszX" Thread-Topic: [PATCH] net/i40e: Add new customized pctype for l2tpv3 Thread-Index: AQHVqq1kBqDCO/GhNEupehiV8y5kVqe1laiAgAJVbdCAAHZYgIAEO8mA Date: Mon, 16 Dec 2019 10:13:55 +0000 Message-ID: References: <20191204141055.3647-1-rory.sexton@intel.com> <20191204141055.3647-2-rory.sexton@intel.com> <94479800C636CB44BD422CB454846E013CEA4464@SHSMSX101.ccr.corp.intel.com> <94479800C636CB44BD422CB454846E013CEA6079@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CEA6079@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJiYmI3MzktYTA1NC00MTQ3LWIxYjYtMjk1NzkyZmExMzJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieVdBN2hVOFwveExYQm1aaVhGK050bjhrcHE5cjlEMDVZd0pRbzBMbDFJRW5jNFFFT2NGa3BJbVdwcVhIZ2ZkTDUifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.177] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0016c39f-5a62-4f8a-c51a-08d78210a86f x-ms-traffictypediagnostic: MN2PR11MB3645: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(346002)(39860400002)(136003)(376002)(199004)(189003)(9686003)(71200400001)(8676002)(52536014)(81166006)(81156014)(7696005)(186003)(76116006)(478600001)(8936002)(4744005)(33656002)(66556008)(66476007)(66446008)(64756008)(316002)(4326008)(6506007)(26005)(66946007)(110136005)(5660300002)(107886003)(86362001)(55016002)(54906003)(2906002)(138113003); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB3645; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0FdPCM7ZgsOlbE2suyquJFU4Xc/wvhtRezDgW+JZFQI2Aed8pFHW2qCRgb+6HzccnF1VDQjpsDyqeA1f9tkf50BnLNl5/l8mX+p7kOj3bLK8j5aWpEMLPEieFYE6SkHiTZdvvrEj3B69CtTT/IvQoq/v3pS8POjrYwbE76mVdMMUvtsDggF8c6hSrtf/K0J1KAYY474G8vPcfilsYZdxbEMtIYbCk18j8n14AumrkjjAEG8GtZd+NULTLmkapu8ayz2OFjdPgbqflBCWavO2Rabt42jICbtS9XttbffH2DiJlurvHWhJoBRgsMaOXITt++k5ltuvTQ0Y701SAFdQUotrlBn0XmKiDKEOQyKpRP+g57Cw2w0VD4qdTUN9ZiXhyaav7LcM5u9jshgKyaQ4LY//ZvT5nskiYRTWFIAdUqF9JcSFl+Z5XTcM3j2jD6qNgbepKdcOp1IHUB0Pi4jccQKUOUhpU/pclrLCbn50/87b1R/ZWn7l4zATYI8bKtgA Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0016c39f-5a62-4f8a-c51a-08d78210a86f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 10:13:55.1660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sv9xdYdNbiqdSJ3eHAHI4s4mQRPcoM37tLjCKXAnH52b8GxeAcdjNJVm17RR6GTG8BjtAVc+AXfy1589bQOmXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3645 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei, See below, Rory > > > > +/* A structure used to define the input for L2TPv3 flow */ struct= =20 > > > > +i40e_l2tpv3_flow { > > > > > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow her= e? > > > > >=20 > > I'm not convinced we need struct rte_eth_ipv4_flow or struct=20 > > rte_eth_ipv6_flow to be part of the struct i40e_l2tpv3_flow. > > The rte_eth_ipv4/6_flow struct will be included in the flow director=20 > > pattern from the following additions. > > Please advice so I can update in a v2 of the patch if required. > > Please refer to union i40e_fdir_flow: A union contains the inputs for all= types of flow items in flows need to be in big endian. > Pattern is part of rte flow, but not the packet sent to HW to create/dest= roy a FDIR rule. > > Beilei Ok, I follow you now. Thanks for clarification. Please see updates in v2.