From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B9A0A04F0; Tue, 10 Dec 2019 15:52:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87E421BC25; Tue, 10 Dec 2019 15:52:34 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 196D31B9B7 for ; Tue, 10 Dec 2019 15:52:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2019 06:52:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,300,1571727600"; d="scan'208";a="215462477" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 10 Dec 2019 06:52:30 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 06:52:30 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 06:52:30 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 06:52:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cX3wzEx64Utr+Q/e0FzwvM8bm2p89vfVDE22zB4zSaHcLH+oWl9XiD9lv3l10iZAb/5M2k670tWF44iE7YRg1BmwUxDrCMnWn676PipSKHN0VBTuRsz8pRELgumzzQ6qBoJfBhKf/UZ9pHBtUi/DgR7iyyh1YORhSRCCY+iStfFKFIM2G05oELQ550WvtMeKNvy+7wZxRfIX1fRzjvLw2800cMIAKbp7kIjAVA3B9w5uNbq3sXdjVgfffhk1PeUTICMNyL8TkCuosp7qDnwTmo6wskSUyCOxuqArrh22KaKgCqn2v2QVQkUf5CcR/sFKp9GOi+O+yNTV5uWN8ZDPOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LhjbmjM+mVpDssOON2ySwBNFwjpaKbRMbFfQs/seNd4=; b=S4xdHZhM5bz/z1G/WhEWid6GjE2vO8bnU6HrTNHERIIKeHQPnyz7qmwBmHD3/eaK+YRQfpAsL+rxIXveR6Vm+qJj6uh9JP48lfI0I4WS6WuvJNyj7DCwrLkqZIMEnV/mDKKlA+AZIj8p3oV/Wm/81c5F72UpF/xo2Vsal4B1XXXuzS1HouhQLVvXhREf502NfuyM83Q6opfaPCzKTrqw+TqC+MiNT0saXb0zE98PTGg6spaM9gl3RRtKQMkURmlob0WIIzsOYBfQnHv6YRbTFO/NbFHuEQW8kkIhVCMZ8539cYm5WF3jcvSyi95Bd+YSQOP3DqK/P9lNsELNNwcp4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LhjbmjM+mVpDssOON2ySwBNFwjpaKbRMbFfQs/seNd4=; b=m9Pi/VZjvewNHRYssirFmpukjdK320p9P59BgxSVwqlo+HO/0exQxl5wYSrm/K+8W9E7aRvFYTF9qQT2d9CjlkVz0X6cIeiEQrWN3zlzdgGoblrT7hJj59wIJ9yd8UTyLSzyrzlTSA6c3tTOcKGSXC5SiQf39S9cXkRhkm4VMxs= Received: from MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) by MN2PR11MB3709.namprd11.prod.outlook.com (20.178.252.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.15; Tue, 10 Dec 2019 14:52:28 +0000 Received: from MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::659f:b4e7:452b:eacc]) by MN2PR11MB3678.namprd11.prod.outlook.com ([fe80::659f:b4e7:452b:eacc%7]) with mapi id 15.20.2516.018; Tue, 10 Dec 2019 14:52:28 +0000 From: "Sexton, Rory" To: Ori Kam , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Xing, Beilei" , Adrien Mazarguil , "Jagus, DariuszX" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API Thread-Index: AQHVqq1WuGnZL6ab8EC6Oc0BGrrb+aezMF2AgABIiPA= Date: Tue, 10 Dec 2019 14:52:28 +0000 Message-ID: References: <20191204141055.3647-1-rory.sexton@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmUzNDNmMzQtZWJlNS00NzI3LWFkNWQtZTJlZTBmMWRmYTliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicVE1OXBkOUtBSVJXRWtCTDZmaXg2c20zbFwvSXNYTVpjdDRPZUE1citJQTNvQ2hTM2x2U2pLTDJyYUU3MmdlUWcifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rory.sexton@intel.com; x-originating-ip: [192.198.151.177] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0c4133c-12c3-420b-77a2-08d77d8093e7 x-ms-traffictypediagnostic: MN2PR11MB3709: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02475B2A01 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(346002)(376002)(366004)(136003)(189003)(199004)(9686003)(81166006)(7696005)(81156014)(26005)(8936002)(5660300002)(478600001)(55016002)(186003)(52536014)(66946007)(4326008)(66476007)(66556008)(110136005)(33656002)(54906003)(316002)(64756008)(66446008)(76116006)(2906002)(71200400001)(8676002)(107886003)(6506007)(86362001); DIR:OUT; SFP:1102; SCL:1; SRVR:MN2PR11MB3709; H:MN2PR11MB3678.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mhpJODCnOaHhTIBwOxgWra4kIrOL2i5TUtDtZnHYfE+ofETq53U1Nl20pP3XJJs9S4iZ856VMe5MoP3a5VI2sdd86kYklZeX+RN9+FkUGil5AiSApxr3w0+5xIK0k1KiiUG7YD6nadgdoLMW2UnXN0BxxLvzhipbKCO3bdg2x2o2k5w9kUnJztMBEsPedbTxVQGg6kUWP7zU3xy9SCC9QvkZMx22Rtyw+/23GDO0SDlKp/hBxrmOVmwaz+YfzrDhniOoKxRXsL5OMxZDDirTqPkQqKbbwxo+d5rhbyVHfwwlfR/W/KwiCFOtj85KM4g6Iy3x67htEaXFHkXG9xUgCRpz4uJSsLLBy1KlE4WQ0JgtXOfhvFsW6G70dxADdxGrp0mYNNbY0w2lSvD/18Vta8z0EnqpVffo+8owrSsgy9ZN5LdjeLyvDdMZetutJNj2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a0c4133c-12c3-420b-77a2-08d77d8093e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2019 14:52:28.2283 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j5JLURNz5zHb0OqYSiTEMp4FU0nq5LKN6Ai0yo6L/LO9QpJSyfj6aNARY5LP9gLyorNtbLhnnneaIaPEVwbTlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3709 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, > One general question why do we want to support only v3 and not also v2? l2tpv3 is more widely used as a tunneling protocol hence it's inclusion. A specific example is the cable industry where DOCSIS cable traffic is enca= psulated using depi and uepi protocols which both make use of l2tpv3 sessio= n ids. Directing flows based on l2tpv3 can be very useful in these cases. Some more comments inline below. Rory >> diff --git a/lib/librte_ethdev/rte_flow.h=20 >> b/lib/librte_ethdev/rte_flow.h index 452d359a1..5ee055c28 100644 >> --- a/lib/librte_ethdev/rte_flow.h >> +++ b/lib/librte_ethdev/rte_flow.h >> @@ -510,6 +510,16 @@ enum rte_flow_item_type { >> * See struct rte_flow_item_tag. >> */ >> RTE_FLOW_ITEM_TYPE_TAG, >> + >> + /* > >Missing *. It should be /** > Will correct this in another version of this patch. >> +/** >> + * RTE_FLOW_ITEM_TYPE_L2TPV3. >> + * >> + * Matches a L2TPv3 header. >> + */ >> +struct rte_flow_item_l2tpv3 { >> + rte_be32_t session_id; /**< Session ID. */ }; > >Does it make sense that in future we will want to match on the T / L / ver= / Ns / Nr? > >Please also consider that any change will be ABI / API breakage, which wil= l be allowed only next year.=20 > I don't foresee us wanting to match on any of the other fields, T / L / ver= / Ns/ Nr. The session id would typically be the only field of interest in the l2tpv3 = header.