From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2DAFA04B1; Thu, 27 Aug 2020 08:46:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CFEE1BEC5; Thu, 27 Aug 2020 08:46:48 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2BCD01BC24 for ; Thu, 27 Aug 2020 08:46:45 +0200 (CEST) IronPort-SDR: Kp4For7AT+atzAZWe344s4obG8lGBQ29ggykoVlL6XIR0epZUEwYTsAUqbvKEa3lzpOE9ZYdqE nIZ+nKtYlvCA== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="153852476" X-IronPort-AV: E=Sophos;i="5.76,358,1592895600"; d="scan'208";a="153852476" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 23:46:11 -0700 IronPort-SDR: b11n4xXk+Wn2uHzm/V8Db1nAfp74UMW77FjieDVoCT8AalDBi9xDPtWAS8r4JFWcgrO+ZALUPr aYKNwaF/bRTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,358,1592895600"; d="scan'208";a="295623480" Received: from fmsmsx606-2.cps.intel.com (HELO fmsmsx606.amr.corp.intel.com) ([10.18.84.216]) by orsmga003.jf.intel.com with ESMTP; 26 Aug 2020 23:46:10 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 26 Aug 2020 23:46:07 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 26 Aug 2020 23:46:07 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Aug 2020 23:46:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjBnYqkVN6uYAbHFQGjNYk5e3Jk2/VU0O+UdYbNY7I7bcdkb13nCyPJFfXa+VD4ot02CQO6vrEHMmze8c9sMQAEMjrYu+/XD4zPNDu4rNLKFph/2sbz6ejpJNM8ZL0Nu1j2EKmraDzydIu/Qw80RCjq7OLPQ/d9O4YRyNRGCMvS7U+8WksXaQOeYCcJ+s4Fh0bfPSx/A8I6heci2/LbOULTsCoks6vE6tB14rLoqRKkGfzHZflv7auPseycoBa1RS0u+oBSAOifPitxswlkhkZNpyIEfSJlKDV07kMAS5LeZ3RQRvSw04Msp6JSbF3hrrWMXeTvP5C7N1mPUXt5jAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RefymVPysyKk2B8PdahKyaM1FWC6XPYBhpQAUl8s7KU=; b=iVgV4s1psFc3cZ7L/zF4TkmA5I2xZ5ERGuMiKAB/RRPbBKDvXV7VZhZLAbQQ/v6MZ9VJ4r56CUNM0LqrpfJ6ny6iy2a1l1hACLzoHoGovsA3GqE4OoDQOm5cAtuheLRbzqCtZ7flKpuvoz7LcPS4Y1sI18+e5G3CO/Gzdw8wC1NSaEkvzopH3KYFrKs+yM5d3l8erymqXgy7G5hYPcz2EYFuuVX9mNaZc+chVP5h1wZfViZsJYSgAcB6amDDB8UPzNYgtDnG1qbS0X1SJQiPz/Z1+2sGDQVIys4WbdoBPjUkuNRV33FQoSytkf2hZq3edPcBWgQA9iu4WtqmSaGP4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RefymVPysyKk2B8PdahKyaM1FWC6XPYBhpQAUl8s7KU=; b=dQM4FYpJll7C5wLP+bRMJzjDYoc+EZLV9Oc4J6QDdNhY4UXaPnw2SLkFc02H/3fNbnFM2gF4lX+hqAAgLtmuRSKqjR9eR3O2wCKIVoArzMPakbCwwnWUm3j30U5ewpvgbKvpzZxNA+z4DGy6TbJDDoegRh6vbVyVtqoqPdpuwIQ= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4728.namprd11.prod.outlook.com (2603:10b6:208:261::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Thu, 27 Aug 2020 06:46:03 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::a874:71a6:50d9:b411%3]) with mapi id 15.20.3326.019; Thu, 27 Aug 2020 06:46:03 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Wu, Jingjing" Thread-Topic: [PATCH v2 2/6] net/iavf: set speed to undefined for default case Thread-Index: AQHWfA98/IIL3Q6eKU2/Okm8pi6YuqlLgXjg Date: Thu, 27 Aug 2020 06:46:03 +0000 Message-ID: References: <20200811075910.20954-1-stevex.yang@intel.com> <20200827011410.18401-1-stevex.yang@intel.com> <20200827011410.18401-3-stevex.yang@intel.com> In-Reply-To: <20200827011410.18401-3-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b44e928f-c05d-44db-f896-08d84a54dde3 x-ms-traffictypediagnostic: MN2PR11MB4728: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qrlWGKdJtHhPld6YJNiCOFJXXt6ZxkW3XfWO92Ln1Ux/TNb/wjCYfszN5gLU66jnvxZjRgkCjGq2t6Lxr+nrQfa9miUQfaDiM242eHDzF5CZstbJhbbAKI/+xhAti/7RaKPYpWtyQmNsm1JKDrvtOE0AqlbuHMPVB+c6BFg8dMYg3P+oj8Z9bCZgkvxkIfuRCP47QiCJ/hyIXI6RbANQt/W32ZnkfXJjQoPRHWIhrotFEK3mW3eTkpVs8dn2cdcjpAZt/H1qsjiryJao1u70ziYFYeSsT9FvVzkmtuQ/Gsf8e/C5USyewzXwav6Mu8zy/Odo6CzJmYhT0DQdfIKwbg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(83380400001)(33656002)(71200400001)(26005)(53546011)(6506007)(478600001)(8676002)(7696005)(66476007)(186003)(76116006)(66946007)(66556008)(64756008)(66446008)(9686003)(2906002)(4326008)(5660300002)(55016002)(107886003)(8936002)(86362001)(316002)(110136005)(52536014)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: rBkAlS2snzlex1VUCxLkj8kwR8Fz9xEP+pNiUMO3fLdqH8VChfUMYZObipjovgY6WAfTbr4zoRxwgnvSXDd9f6lb0LoAuUT3zpRiCzE+8fR/rKjd6zJQSFLAijau/fYbqUlfpPQHvBm9WVciFBVWbjwlIVz0CzHUWRXGOTLBLSXf0z2NvPRqVXUbhdJYMpTkvRrNZCi6eEk5Hk/Mpy7a0e/PpiA3kaakqP5PM+ECMVQnxXHmfnIUNfBserhareVbeAyefN+92h6J/LGZ7/Fbmf7mAIimZQeENIzD+Q9SxkRpfYiu88yU0CU9ybyWu4CEIgCDMUu4jFngJccgNhM0TYDND7cwHoiGMu9ofQd5XY9nTeIgbDIQYSLFs+Q36d7iPYIf7be9QINYhZ6Sh0jaBocR4g2prWn/LcUMnmvRH2hnL4LA83IZK0YSFKj+EWgJkDBQ3xJ+cF9AIs6lR/098+ZjnEJJaSoMwGJGAIw3dO/nGoglK2K4WAB93uM3IEP8HvRmvF0JnWK0WN3WJBMj7O6tR6RYv3aRadVSGIzIsypDMXB/OQ8lr9yUyUBvJQZyxPvnhiQ1dlbvV9b2xF4VK5XaxtVX2IETHGIklScoRzpqDTOwvh+N7EVue9jydG5rvVr8pt32T4FYhS0VsuRw/Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b44e928f-c05d-44db-f896-08d84a54dde3 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2020 06:46:03.2339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: up8vB78Ijk+WeMj7yVFiMcMZQI+NksUWpuOR8YbaGO4wcqjkYqShnZUXG7/RHSRpHaPd2A+/pM+IwComuW4P5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4728 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/6] net/iavf: set speed to undefined for default case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, SteveX > Sent: Thursday, August 27, 2020 9:14 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Jingjing > ; Xing, Beilei ; Yang, Stev= eX > > Subject: [PATCH v2 2/6] net/iavf: set speed to undefined for default case >=20 > During PF/VF link update, a default speed value of 100M will be set if > get_link_info has failed or speed is unknown. >=20 > Consequently if PF is put in no-carrier state, VFs will switch to "in car= rier" state > due to a link up + a link speed set to 100M (default value if no speed de= tected). >=20 > To be consistent with linux drivers on which PF and VFs are in same carri= er > state, sets default speed to undefined (instead of 100M) and updates a li= nk > status of VF only if link is up and speed is different from undefined. The original fix is focus on i40e, the fix includes changes for both PF and= VF. But this patch is only for iavf, so please pay attention: 1. rework the commit log, since the PF changes has been applied. 2. double check if the issue exists on ice. Thanks, Beilei >=20 > Fixes: 48de41ca11f0 ("net/avf: enable link status update") >=20 > Signed-off-by: SteveX Yang > --- > drivers/net/iavf/iavf_ethdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index f9dd5710c..ae508f2f0 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -620,8 +620,9 @@ iavf_dev_link_update(struct rte_eth_dev *dev, > } >=20 > new_link.link_duplex =3D ETH_LINK_FULL_DUPLEX; > - new_link.link_status =3D vf->link_up ? ETH_LINK_UP : > - ETH_LINK_DOWN; > + new_link.link_status =3D (vf->link_up && > + new_link.link_speed !=3D > ETH_SPEED_NUM_NONE) > + ? ETH_LINK_UP : ETH_LINK_DOWN; > new_link.link_autoneg =3D !(dev->data->dev_conf.link_speeds & > ETH_LINK_SPEED_FIXED); >=20 > -- > 2.17.1