From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7D15A0C46; Fri, 23 Jul 2021 04:43:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69BAB40040; Fri, 23 Jul 2021 04:43:11 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 7E63F4003C; Fri, 23 Jul 2021 04:43:09 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10053"; a="233622445" X-IronPort-AV: E=Sophos;i="5.84,262,1620716400"; d="scan'208";a="233622445" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 19:43:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,262,1620716400"; d="scan'208";a="433379473" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 22 Jul 2021 19:43:06 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 22 Jul 2021 19:43:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 22 Jul 2021 19:43:06 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 22 Jul 2021 19:43:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JD6sOldUgDtcVnB9Wz1yY6qNctXK7C7jcZcJN6XW0tiQsK5XhMKRKYzp3HX095G1frKyb5zukIiEArcJ/VRhyMANEjJk1ePx42LmKvG8XFxHgCYl4Zw27+jEjSlDZGGzFj4dgceUIyjCRRdun4TDPOytRJ1PNL9vb+fxwTS3OeOz0jzN67TDcb77Jbr9XFiOF+61RMQU/7h7TOdcMdDNrlUPZa2PhF8IlCBQVUYlnQXKQK6cHbMsa2L0mlwWcerbqVsBwjFnATiy9suviprnrnzspOET2mBUhEeKWY5/av5oeP9EOPLKVeJPhgAf2JH5r/dfzJiBygfSV0v8UPHGgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=erbzAt7+MO7JqXpCfwEJaHYEsN4opODpM44ztLBTX58=; b=hunBBK3JmWwB/F+WDliAkQlH4vvd0AIcSi5yO+sLxzhCVmtyWyNDOeaUITWYsdDKcr4moMIJVh4ZKdYc3bYIPgFgx3lBIPe4y06PMR590N5GXf+A790oIFaEIad0HZ486jul8onUIc3470Na3wqZQWZs7BDwpepAso8Ai5ef9ma6OJlfEJoZsTk00IIz51nZMY+n3pod7U5O/yNXY+WaL27Yz/n8YsIq4lF/Cd4+fmAa1yWED5B7ZuATJRlCulNaOHm9Nn9nnf868SRNsmIFLP+w9p7oMFms9itNP88w9OsgRRIwsm7vCq3HnYH6ISOAmt+zrg987rCXLP6/plvndA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=erbzAt7+MO7JqXpCfwEJaHYEsN4opODpM44ztLBTX58=; b=jj8QhsqZDmcnpr49Um2T8wpdzVxtFckxz6qXWEDm4SiCr0+A4p4wbS1ptLLPlTuI2AIJsBf3NFw6W98eJB8dmIHHHlsdKsUYlPI3AFNdWn86Ti/Bz1j0LfZEoT0D5Bz7sZaT0bq7sZ+V1ORcfwl9DhTsXcjFfN+UWIpOxCrr1pA= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3902.namprd11.prod.outlook.com (2603:10b6:208:150::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25; Fri, 23 Jul 2021 02:43:03 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::197b:884c:3d10:ee6a]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::197b:884c:3d10:ee6a%5]) with mapi id 15.20.4331.035; Fri, 23 Jul 2021 02:43:03 +0000 From: "Xing, Beilei" To: "Li, Xiaoyun" , "dev@dpdk.org" , "Wu, Jingjing" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix tx thresh check issue Thread-Index: AQHXftCSZRU3PYg0MU6IAam1b52tTKtP2wHQ Date: Fri, 23 Jul 2021 02:43:02 +0000 Message-ID: References: <20210722075620.472438-1-xiaoyun.li@intel.com> In-Reply-To: <20210722075620.472438-1-xiaoyun.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7280e98-6292-480c-c5bf-08d94d8397ad x-ms-traffictypediagnostic: MN2PR11MB3902: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MfAkhkWKdbUoKWohBuQefvva+XdVaUmW4XF7zm8ZsWOVQHe4Czq9GyqSRdWgNfBqKbBgul2RXo7wsDfKE9wLX2Nrim/bHfKNqfeEjSQj3FcfCfbEBOKXUOnR7Kj1GnKsqg8nuSX3zYEwFZFZLeaIu3bO8D543im/a5uNwu0Ht9X8qQ51EbMTZvJynhgiZGia3O1Eo/+/732lP/KC7hN51U1N3ImAkw9zdE5hyLCLd1wVBTo3yW9YCkfYmpCvTEJGMLmOvUQqckm7E+lFdkLJG/xcG4ZsMeDQKvIWpRKqrX5WnuKqwGJCp+cxzOlhmTfdDfQs0T7WkP+cpSrXLlyFYngktJqPPZa0apU3AqHsVvska53AnEALZ1sBm2FRKfmXxew79XzRAgSOz3hpE8qnocZSYxcmwLOS1sHxoR1dN5zTJNTuqNDOi5mOEREaVL1BLiRsn8eefbWn4h8WjnteIofMfL0ER5MSZkZ1SKGpV9la9jngVzxcyWjsdw7F56utfRMn66+qd9dDseOD54lLM+JKh+/R/o7LaEAyo+HE20heOmX5ZOWvf4Y56hWk5ApHDQs6iY/0VrfQ5LwaBxfaSIebKQU4uCFMEX2H+NTFCc0Eie5aWuRBBfPismFff7DbM26ZbIq0GXiFciTn+ifhDDzgIA/AqLsmkAifyVwkMXVQiXLGC/nWF2RfdzG+VPyqIn8HO5cCeMwINIGGMDN1hQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(366004)(64756008)(66556008)(33656002)(53546011)(6506007)(4326008)(71200400001)(316002)(8936002)(186003)(450100002)(478600001)(9686003)(6636002)(66446008)(66476007)(66946007)(86362001)(7696005)(38100700002)(76116006)(5660300002)(52536014)(122000001)(83380400001)(110136005)(55016002)(8676002)(26005)(2906002)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AZNUFfsT+w2j6Yc2mSRCKgJ0ta+1XmC2aG3fyCspH+/EzPfNDDRwQ8qjlyUb?= =?us-ascii?Q?rZGONJoM1xU6Oz/6fESdrQhUc7snd6cRvq2ewTuT3NqZ9T7dbto9baf7Kj5a?= =?us-ascii?Q?Gg/r1qD3n5I7n97h6vfRzwhLUmOfMoQdDKKr8fw4I5TqgBrpkdvnykNivV+9?= =?us-ascii?Q?lW+kNqLoEuEjjKX/ta6qYiAMHP7Tmq4ynf95EYjg81+qUZhWGDG7RWCXCijU?= =?us-ascii?Q?dy2441itCz+Y8vx5rqByQ0X/kbesKPOJNxCh/fb8ycCSh6W9KNCiQNmiNzO2?= =?us-ascii?Q?B/wZsiUvVzXqPvzbVTAEcFg8eoMbjrf42ANe6ITSQK9sdq0pJQ2bzTJp7G2w?= =?us-ascii?Q?110I+bpz1+UnzUJYAEwhsBwAtKQqZ/j+XaleF61I/SczozZsGK50gvMoKvMX?= =?us-ascii?Q?dyJxzEahgESdg49ldJLCmI1zUp5YN0zG52eyHT7aehKxgdH4qoqYv7U7JAld?= =?us-ascii?Q?NLH5lJlZNYravaTZI/MM2e91jugcSTUuulAH4RaG931vrFcIsiPLn1UzIVFz?= =?us-ascii?Q?KakdhrLNqeofhxdFsJ/fMx+omc6uJ2j8AuZEW596o+9QGfZcnuM8BBm7LSII?= =?us-ascii?Q?b8sPZdAp+d/FZ1qNbU9V1G4HI1kkvgHb/WUGF2/Uh5nW3JwEo0H1S1HjvwU7?= =?us-ascii?Q?4/t3hxFmD005lcGpuVs2EMpUZIhkCIjwloSvep2QGHDnQQW0QhO9tJ/vuV/E?= =?us-ascii?Q?ISy+vfWFF9rfRUoBCuKR1HpLdiqMRmnX/lr9KG6fe1mArUHzU+rwGqVPwAd7?= =?us-ascii?Q?atwnXgWqK5opItAEx/ai/SJ63wII3xcfOfPVTAOI7gV4W3d0Dg4tPHzYJ6kO?= =?us-ascii?Q?CbQ8NgwV+BazKmSex6yYynF8gL/StwV2W18DtDMAKqoXombDz7pszxAChYa0?= =?us-ascii?Q?x4CUTECSOWq8K7jaSe3ugZ+cSDQTVK1rBjynBLuuCTjC7hHycmorCswNLIfa?= =?us-ascii?Q?OgLIn7L83kob8wDA8AoKF1LCEFotEBymqT0pY/wmb33aZL7JqcGdHBtpwG2E?= =?us-ascii?Q?AC/1AUDv6m99SuFSadBCbJ75nx/usVEr8O//FoLZ76hivTlcFtghrE5GauKg?= =?us-ascii?Q?2QHxxvDzH/tD279Jo2DbsTiHKZT2ltihOBU7Um9VGU17rl7ynxqkmphC4EdN?= =?us-ascii?Q?wOgndeqs9AItvKpsYcBtLZkFjxIpYJYy3HuI1lNuopKoNSmORWYdNaJSgT5r?= =?us-ascii?Q?Pcc8UfSQTiBco5OB8nP5Z4/Yo4gINQssJT8yOjrMHzfTMO99QZFpI4mCz45J?= =?us-ascii?Q?vAx6/IrDoJ3OfBNSLCOHRo3tLqnWeInzSg7EEEzJEItuHoVvF9l5nPkdlDL9?= =?us-ascii?Q?OIE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7280e98-6292-480c-c5bf-08d94d8397ad X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 02:43:02.9448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LwvSqnzffRSPAA3xzUt5Q1LFlXc2AKOF2zT+M7JBvFh/JaQYgAulg+1gKkKr/rvg3vuEYyISXr6NLtWwjT5O1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3902 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix tx thresh check issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Li, Xiaoyun > Sent: Thursday, July 22, 2021 3:56 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Li, Xiaoyun ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix tx thresh check issue >=20 > Function check_tx_thresh is called with wrong parameter. If the check fai= ls, > tx_queue_setup should return error not keep going. > iThis patch fixes above issues. Typo: This Except that, Acked-by: Beilei Xing >=20 > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyun Li > --- > drivers/net/iavf/iavf_rxtx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c = index > d61b32fcee..e33fe4576b 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -708,7 +708,8 @@ iavf_dev_tx_queue_setup(struct rte_eth_dev *dev, > tx_conf->tx_rs_thresh : DEFAULT_TX_RS_THRESH); > tx_free_thresh =3D (uint16_t)((tx_conf->tx_free_thresh) ? > tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH); > - check_tx_thresh(nb_desc, tx_rs_thresh, tx_rs_thresh); > + if (check_tx_thresh(nb_desc, tx_rs_thresh, tx_free_thresh) !=3D 0) > + return -EINVAL; >=20 > /* Free memory if needed. */ > if (dev->data->tx_queues[queue_idx]) { > -- > 2.25.1