From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30AE7A052B; Fri, 31 Jul 2020 05:50:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE4B01BFFD; Fri, 31 Jul 2020 05:50:13 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E25E2276C; Fri, 31 Jul 2020 05:50:10 +0200 (CEST) IronPort-SDR: 0/H1+RkoxbQwP7emZQfxNleF5MxtZZLwsxK6HPLn4JF1lhpdfgOJAJ0H6SEoJEIqLALsgOhcDB LaFBSNBZqmuA== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="139711678" X-IronPort-AV: E=Sophos;i="5.75,416,1589266800"; d="scan'208";a="139711678" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 20:50:09 -0700 IronPort-SDR: JmcxGLLwjDV9fVuNRg66F/cVzsf/eUEeEUSvYKbUBjzYrAqNqKIjup94uW9Tq2YZQIFxSErVlq 4Q5QTElnZE+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,416,1589266800"; d="scan'208";a="365391394" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 30 Jul 2020 20:50:08 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 20:50:08 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 30 Jul 2020 20:50:08 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 30 Jul 2020 20:50:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 20:50:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQ06GzB5kjJhkjUyCiYPbMW6YEh9DHaIfPecjjXYWIKcyVUcrnEhEkovaOtojtz6sMv9yeXi999prnu2kcl48psGhB+CK5bDaRxo1Ttj7CgNQ4wJZa2eccKqwCOWKB4oLIHLOVFyRNmgQ+Zli1dtrIPSHX0CrCBMdpbl9+j9c/dDXbtLt+wtGwXlomTAjrrQs+Hgiuq0QVFZtjiZ1oB+Y4pJqGMVbDqmwwONrOF20j8+MLeJLPu/+hxlSY2TOWKY+2gvFp/8KU5HIjxh1Mry3ZfIDH+rbXN7Awe4wCtJSRmpQXHENysC6ou1GQNs7GveurUd3jbdj2G5tbcA1RU7Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43waByzL6ACg7HnOG9T54OXz7XFsqEIYTy8D73BG1/E=; b=GMcnysp85x3AAU4XyU2jd5pGSUO+dlOWceKXrIMwthpBGcLXFTGDwWZTUuJxCTn6G01x3csqbsaw3E7SS+vVP6geCAxS3zK4eS536ymfJkvKkr+f9gefhedu0QOTYUCuzuaZGPt1VK+MQfnDb4TFbkk3IRB5R7KZgc3lH++h42S+vH/U5phwIqdLkrsqszz/nwqijueH4XHBIlk2wKAZY0kaD9Um/70j2hBeie4Hc392cCV4gzsVSC+jbdA6oBoaQdQV6m+G5YjD3zxUBtaztbvPOxqNjail8pZYPkgrcdHgTbXvJC9uhhSS87FIudb+JfNDhA1tjBqKnqd8HtHHQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43waByzL6ACg7HnOG9T54OXz7XFsqEIYTy8D73BG1/E=; b=cIGIMLt0QnWfu3lCjk0qTsirHjzKdXjQDbHMkf4zdbNon/MW51s/KIrwAMD01oiZmByOyu7wHoGLPLqDtV6KzBEAahc+eD051TTieXQMQuUItE6wpHU25quqZri7CYY2lxQC/css9re8xZCNdI+1GGsl8P2TUv/Djrd7Tqs2Vfg= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4014.namprd11.prod.outlook.com (2603:10b6:208:137::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17; Fri, 31 Jul 2020 03:50:04 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::401c:b4b:31c4:98b8]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::401c:b4b:31c4:98b8%3]) with mapi id 15.20.3239.020; Fri, 31 Jul 2020 03:50:03 +0000 From: "Xing, Beilei" To: "Wang, ShougangX" , "Sun, GuinanX" , "Guo, Jia" , "dev@dpdk.org" CC: "Sun, GuinanX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix link status Thread-Index: AQHWZl0jSSwyLyvP7UOn9YwAfe5U5qkg9unggAADggCAABL+8A== Date: Fri, 31 Jul 2020 03:50:03 +0000 Message-ID: References: <20200730082539.24104-1-guinanx.sun@intel.com> <20200730102527.49884-1-guinanx.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc26a13c-0bf3-48ec-8ce5-08d83504cedb x-ms-traffictypediagnostic: MN2PR11MB4014: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uTtUrZClu2yXgi/7jisO2LOEOyNv9XOXSoVFGvxQsX1n3fzV1+HUwCIwz9+4fmHZucYPU0XFNOBT09QQNwO6MKjyPjg0IOki9yhVlBPfxuwwMH9aS9JRK9ZICeC6pM/U2ZQ9tICPwQAnBB0ZO3YwQNcLDTSdXdyaNdEKIZHQCUTTxFzBX9YOHlL0BnlJ8W7XMb1NonZmxCOCkrnmf97vcJQzP+AhqwaxWmYUmaSivwfFFVfuzbq0ucaxi6fl/PIolj5JLIvBAHXeZ9HBnQi7t3wFRfia8N5C9mK5dyPy3rcLsoUdz5Xy2trC4pUETPpR5o3sNIhwJSGlWu/f9PphBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(110136005)(83380400001)(7696005)(316002)(86362001)(186003)(2906002)(26005)(54906003)(9686003)(55016002)(53546011)(478600001)(76116006)(52536014)(8936002)(4326008)(5660300002)(6506007)(71200400001)(33656002)(450100002)(66946007)(64756008)(66556008)(66476007)(8676002)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: xeElKxHxEIlv+sXDcLASPv7X/qo0EBmcUn4DnWsPzLXI/z+e0sc0wJ4cEnWY9WXM/qexujjPehM9IK0sU/DclwxV3Ga3QGl81w+E67czhCQNTRNMMRNFGa8X9cqaMSAOhZEV5/v7Vva5lKWTzvKOHR/aRHH3pFr+XGOm1FyuvcDIl4kB0OHJxhvqpbYENj3ssnpFb69/qYgvZOKHvK/YeKq8acPgxy4ihThUp7bC1zyNQUjARUOf1K3rTe/qdFVLpqe8yNk3XfbUFyu9ApTNe1ySlGckWBaoeidShEcjgJM6xDyKtuHt4519kfIiRlFmRCjuuYoN4X3Q6QP001GRl5y7kko8L6o8uZf2qIy5tz6Mdzq08ZAzfaGsbO8SJ0XVEhJ4O2uXjbd3AlcwWR1ohdxUjmA7Apf5Qj52N5VNTURNsg8SPj4S/Hgh+H3HXLh5n8nrGaDTY2SZN3p/PzQsCi8VZw9uXTF4zPbzqfSlXeCl+i9ITy+O8veEnEtiwadjZzvJUINdvEn6y1ZsHenwfKoefEa1FnaMK+QJfPSl71swYIP9R64ZyrA/JpFGJgVO4W30jxUon+AueVtXSySp/UfdxPYi6Iloh+GI5Sc/VcL7/Z1yatJwCaJ0/mVueUwo0jMOTkS3zcHb9TsnCmEFvw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc26a13c-0bf3-48ec-8ce5-08d83504cedb X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2020 03:50:03.8721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1G/lW43vRXha0El+1i7HqNQZ+1+zirdL+dJaNh07C9mqYMIaNab61SN/HTYEZ+n+YZWaQjohHufn3N8+Ae3Jtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4014 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, ShougangX > Sent: Friday, July 31, 2020 10:38 AM > To: Xing, Beilei ; Sun, GuinanX > ; Guo, Jia ; dev@dpdk.org > Cc: Sun, GuinanX ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix link status >=20 > Hi Beilei >=20 > > -----Original Message----- > > From: dev On Behalf Of Xing, Beilei > > Sent: Friday, July 31, 2020 10:30 AM > > To: Sun, GuinanX ; Guo, Jia > > ; dev@dpdk.org > > Cc: Sun, GuinanX ; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > > > > > -----Original Message----- > > > From: dev On Behalf Of Guinan Sun > > > Sent: Thursday, July 30, 2020 6:25 PM > > > To: Xing, Beilei ; Guo, Jia > > > ; dev@dpdk.org > > > Cc: Sun, GuinanX ; stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > > If the PF driver supports the new speed reporting capabilities then > > > use link_event_adv instead of link_event to get the speed. > > > > > > Fixes: 2a73125b7041 ("i40evf: fix link info update") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Guinan Sun > > > --- > > > v2: > > > * Modify commit log. > > > * Add code comments. > > > * Delete useless codes. > > > --- > > > drivers/net/i40e/base/virtchnl.h | 16 +++++++++++- > > > drivers/net/i40e/i40e_ethdev_vf.c | 42 > > +++++++++++++++++++++++++++++-- > > > 2 files changed, 55 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/i40e/base/virtchnl.h > > > b/drivers/net/i40e/base/virtchnl.h > > > index 4f498ca45..9c64fd469 100644 > > > --- a/drivers/net/i40e/base/virtchnl.h > > > +++ b/drivers/net/i40e/base/virtchnl.h > > > @@ -240,7 +240,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, > > > virtchnl_vsi_resource); > > > #define VIRTCHNL_VF_OFFLOAD_ENCAP 0X00100000 > > > #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM 0X00200000 > > > #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000 > > > - > > > +/* Define below the capability flags that are not offloads */ > > > +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED 0x00000080 > > > > You defined the new capability VIRTCHNL_VF_CAP_ADV_LINK_SPEED in the > > patch, but didn't request the capability for i40evf? >=20 > This capability is given by i40e kernel pf if > VIRTCHNL_VF_CAP_ADV_LINK_SPEED is defined. So vf doesn't need to request > it. All the capabilities for VF is required by VF, please check i40evf_get_vf_r= esource. >=20 > Thanks. > Shougang