Re: [dpdk-dev] [PATCH v7 1/6] net/iavf: handle virtchnl event message without interrupt

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Sunday, October 18, 2020 6:34 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Wu, Jingjing <jingjing.wu@intel.com>; Xu, Ting <ting.xu@intel.com>
> Subject: [PATCH v7 1/6] net/iavf: handle virtchnl event message without
> interrupt
> 
The patch looks fine to me except the some typo in commit log:
> Currently, VF only handle virtchnl event message when interrupt is called. In
> some cases, event message is supposed to be handled with interrupt disabled,
> for example request queues. To solve this issue, virtchnl event message
> handling are added in reading message from PF in this patch.

It's better to explain why we need the asynchronous way, but not use the example of request queues

> 
> Signed-off-by: Ting Xu <ting.xu@intel.com>
> ---
>  drivers/net/iavf/iavf.h       |   8 ++
>  drivers/net/iavf/iavf_vchnl.c | 138 ++++++++++++++++++++++------------
>  2 files changed, 97 insertions(+), 49 deletions(-)
>