From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96FF0A0547; Mon, 24 May 2021 05:32:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A19B4003E; Mon, 24 May 2021 05:32:45 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 45D1D4003C for ; Mon, 24 May 2021 05:32:43 +0200 (CEST) IronPort-SDR: B9s9N++orRZ7QOKe4KxnXCgO03lO9kbQcsOpukmQzpwcm+QolB3LuZ7ZHanMroHGoBbNMayRN4 q1EpwaF4jFUA== X-IronPort-AV: E=McAfee;i="6200,9189,9993"; a="198787073" X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="198787073" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2021 20:32:42 -0700 IronPort-SDR: P1eoo2YPUsizEaPCdSIWINkqsBs/inRx7TilLECLywICuaume5Kk9A3Mh6CLqpBTvGlJf1pLoH qSQi/lxHpL/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,319,1613462400"; d="scan'208";a="470361818" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by FMSMGA003.fm.intel.com with ESMTP; 23 May 2021 20:32:42 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 23 May 2021 20:32:41 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 23 May 2021 20:32:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 23 May 2021 20:32:41 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Sun, 23 May 2021 20:32:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZqVAQqptvn9HjjogxPOpry5q36/wnA72liXTld4dt+LH0tZniF02VkZfu1dmL9IGB4zcDTA4Mph+AXE2xEwPgM+GnazNhocO2cXJAPT8X3ThxVigmiSCDa9UTISc+eSAI3dz6W47BBe43K13mp7Yq9+bJHufSb0qus9rkEde8gDNKBcY736WWOGViVzp3E2urxyxxErVDyaVoNNGeKnxqWgaDAf1RhXQsqiWvf6HgMTl69v+EKhJGpthbOSGKHAZDfoUpfr9JNNrH4gxZm9k7wON3QdlGmjrXHW+BwZ6IDLH2ZflqeEbe1vwV6u1CfAaWv+ecwquxf2yzct/lg05cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tMl07ZXECLs36dHqE/Q2A81djZODyiFCkmuRfZ+/ZhE=; b=OHirwzNhTefQfhYHYtcUJfucMuBFP1q0ssZa/k5Hiuk3WHBF5qeyaTWJOdUzhfOXQ/7qGLDGzlMl9HzqCQlUe7V4umAndZv0BVzGk0EuNSYFZ6pfEhVFb1m5cUdVkBJclQbwluEvnU3XkAdkP4HaF9z7g1rdT5Ntfqwi9H8rM9XGuRC2g+H8D36/Wjy66UzK3SjP1WjKiqipmZdYgAhxsoL5fJDw7o70F/G81aXXi3D6D67fv5Qa3cTgST/E49oFdnu4tvUEF+NJ2KG5XUYo4qy0Drk88ZO8+w0RiXjGnDSx9/HRQvfRNS+4l/HLNXMhzZI2EGhBdLwnnVkWuKJJGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tMl07ZXECLs36dHqE/Q2A81djZODyiFCkmuRfZ+/ZhE=; b=l7TP41e/ZF0/8rWx+ZIzWdnlQ/tcRT2/QHb+sz3w4FiT1IYLjjvzK6CeIzA3Wr2Tu+VOjwC89wFwy8gpSkYs/dz3YZkPZ5nVbtUR5VItHi/w+nE7KSrcknlujfBcT9rs+fTn5t8LiVEYN/DQBKta9CI0ZCfq9picR0ICl6gfPcg= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4095.namprd11.prod.outlook.com (2603:10b6:208:150::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Mon, 24 May 2021 03:32:39 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4150.027; Mon, 24 May 2021 03:32:39 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" Thread-Topic: [PATCH v1] net/i40e: fix flow director does not work Thread-Index: AQHXTF8dJSo2kdI5+EiMXhVGREwWparyAhxQ Date: Mon, 24 May 2021 03:32:39 +0000 Message-ID: References: <20210519032745.707639-1-stevex.yang@intel.com> In-Reply-To: <20210519032745.707639-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ed47c71-3921-482a-532b-08d91e6494df x-ms-traffictypediagnostic: MN2PR11MB4095: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FVkdHeTagsLgdYVvCnn6B1KIv/45jTbUYgR7zHKrUGorv/nW1l1FNNLHuqUWkusGctSWexTalKlCbwmq/mOLG14xu8JCg45c0QiMnHdjLh5T2o4WI6QK8GgKQZ26i+k69HuW2ecSwIrhA+dBONF25iv3/YD4rg4ehioRM53G0OqGx4BIsrP7js4tRvfWBHl408YtfVgUfRvp/tLsqQafcODzJapkBGgvUW1w+0oSF7xcBs0WuDc+cgHZGAMxl47zMFUZTuhx5QlcS0B4uCgJblLLcaFWgYGhameRpbiXFc/6BLLZMWPhyGPEiKvtYkzDRE1gs4+kX0DHwsqxyo8ggEmCM3nebb4J9wwTtnWIw4R3hS3HYlQNa1phqzHBf84Fwx2d3hmG38i7WYKzrdibOVa1i5JzrRcrlUpZWiXb9S7XGC7JV0C4KSfZuKYRLCvdGFr3LKDFGq8C2V1+3hWW3ff6Tixde7QQzAsCMITDxkk79I0aCBjXL+sGLjYrSeEMqoePs0GG/OXTlRB82Wa0LTPbUdfrvowz15uyw269tKXIUHk1xx39jG6GLjmF51ca51BF2NAiUZOgVHIPKvDJG9cgl+FbWWAxbdjfy5wKLT0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(39860400002)(376002)(136003)(366004)(346002)(83380400001)(8676002)(7696005)(316002)(71200400001)(86362001)(66946007)(33656002)(122000001)(478600001)(38100700002)(66476007)(76116006)(26005)(8936002)(186003)(9686003)(66446008)(2906002)(52536014)(64756008)(66556008)(55016002)(5660300002)(53546011)(6506007)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wK7vszOacgMpMjgF98XIV66bPJ4SpMKd7VULGnH5FucZ5RAzdTzMaKzMNz8n?= =?us-ascii?Q?K+lxGsbc6LUKGTkiktAF7VBHBhth1FlNY4voNiHt479++FD9iJHtpygGH7Ai?= =?us-ascii?Q?O6PE8WICna8uk/hguAcao087+ICENsYUyMqhqFxk7eF4AlK9p4FsVEX1+vy9?= =?us-ascii?Q?aZmXxFCxepeJ31ZOlhVYIiU4wMlewd8WBLTI5ONTic983Z8kIxkyO0kAvIQb?= =?us-ascii?Q?7rF8SX92A8Me4EncBsojeiNdURtqLKRy0X052KpH1dew+rpBUUJONk1SpB0C?= =?us-ascii?Q?ctiTchwPH1zaKYcV6J/UF/UdMUQzSmh1ZygDa17ZYNmxtfqAje9c93uiWmU/?= =?us-ascii?Q?3oN59ZA2X5JuD0lklXTzInKqT4knY9vj4pFr4s+285DypVMdVD0lvJlMuAeO?= =?us-ascii?Q?Zg8rvZRW2KsMm3peKpGlTIzmT0d06BFu+1hD6zF+uhQqRVK+TyNIh7tJ8I25?= =?us-ascii?Q?i+3RHQtHJABHrSG9q3b2Dwl8ll8q2W8akpS/OUXvnb2O1XixmgBHR4aanbR1?= =?us-ascii?Q?8WiYMjSsVBytjYKC2AiU9aUIxwrGf+bvGxa2TxxqP8kxvP78kncgAq7/PNQw?= =?us-ascii?Q?qBPsvJyhj2swAm54UlmavzpCw5e3xSLDc5su9qpBzXIml5dGgcNNeJEleDc0?= =?us-ascii?Q?jE/JGawqAY5h6dZCQ6euurXf71QPvalL5A0DXQvxS39O9NDDrAVInTLPNYl2?= =?us-ascii?Q?e39ARAK+r5jcY0SA4opPrPXvu0a6q2uiUxXWaqpJccQL+HC6i9X/1q0MnfHC?= =?us-ascii?Q?HO0QUlxIo8ZCF7ONVEikWq5KSRDCmGE5drcqv5p/bhsdeFxgFdbgZzcrjvYQ?= =?us-ascii?Q?V0WslWFNfUESVtLZStOWCYB29uXqMBM7Pd9NfsrynStjqTA/Pcn9I8NFPff7?= =?us-ascii?Q?vRp45IHlYbhiuV2kGInc6+JTRuXDXtuC/5dptEdCH+U9p3jLVfI3byPTtqAh?= =?us-ascii?Q?dVDShVqs6CMB9rCQG5lh7yMol7ck0YOM6RAkCWv7LNTGyUhM/imoeiEZcWtz?= =?us-ascii?Q?6iRP/ZJuYOYU6uI2WEXoT4HALLI5T6VFkZhf27GBevpwrrs0yvmvrj6c5xFS?= =?us-ascii?Q?wj/w8J5kGiHxyDEK57prrrgVEFwzhR/hvxX48ToMFu2cBewgBDV3hKP4LX51?= =?us-ascii?Q?IfLq8SK70cSJruJ4ZYl5Xfz5g7tRpJXoN2dG0CTBRPBz6fgUbQx1pqBSAne+?= =?us-ascii?Q?CtzpbyFxtwyAT8cjxfYu0WVND/BYvsAfO7C2XvSIA0WRaEzg6JdHQplV8bVg?= =?us-ascii?Q?JV2KK/2iNNWxDmVTa5HdYDn+V7k/QSiGrWIfAoB+fm52ipU7ouvBVedt+myW?= =?us-ascii?Q?eSB7NKjD5E63oR0FVFJt6lYm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ed47c71-3921-482a-532b-08d91e6494df X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2021 03:32:39.1893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +DRFgiP2uvkAfJ4JkRrgFxvZ2eWMnVFynrp4rclkmkgevxb2ICbN+iIWXWGJzPVB6okggFylZSREeSNOXzwZAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4095 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, SteveX > Sent: Wednesday, May 19, 2021 11:28 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, SteveX > Subject: [PATCH v1] net/i40e: fix flow director does not work >=20 > When user configured the flow rule with raw packet via command > "flow_director_filter", it would reset all previous fdir input set flags = with > "i40e_flow_set_fdir_inset()". >=20 > Ignore to configure the flow input set with raw packet rule used. >=20 > Fixes: ff04964ea6d5 ("net/i40e: fix flow director for common pctypes") >=20 > Signed-off-by: Steve Yang > --- > drivers/net/i40e/i40e_fdir.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > ac0e09bfdd..3c7cf1ba90 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1768,7 +1768,8 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > *dev, >=20 > if (add) { > /* configure the input set for common PCTYPEs*/ > - if (!filter->input.flow_ext.customized_pctype) { > + if (!filter->input.flow_ext.customized_pctype && > + !filter->input.flow_ext.pkt_template) { > ret =3D i40e_flow_set_fdir_inset(pf, pctype, > filter->input.flow_ext.input_set); > if (ret < 0) > -- > 2.27.0 Acked-by: Beilei Xing