From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A460A0C53; Wed, 25 Aug 2021 09:13:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2260440140; Wed, 25 Aug 2021 09:13:44 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4077640041 for ; Wed, 25 Aug 2021 09:13:43 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="281183182" X-IronPort-AV: E=Sophos;i="5.84,349,1620716400"; d="scan'208";a="281183182" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2021 00:13:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,349,1620716400"; d="scan'208";a="494118673" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 25 Aug 2021 00:13:42 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 25 Aug 2021 00:13:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 25 Aug 2021 00:13:41 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 25 Aug 2021 00:13:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VxcdTrKweHZTh85R2BS4/sStLMDrqh36qUYv695JYn9cS0p2mcoEDc3mhfyYc3rWSNG3xp0JWqlIzyOnYCBfWTVe9jAYB/dLeoaF56CR56gXQ8/R26xkmfgJrj2XeWxqiH9em381pjLuQ6n1XtyErg4FvMb25OSJkmAKx/1NK+xQbzZL1KYejQKoLnlQYn1h4QexmmqqAwKNqQcDD2urCV9PB1dPONinpxmmVsxsoyJIwVqT4984dLkXB3JuMgFLDnIxnpQao2f1thIOFnCp2TIdosfBFRmTkNt6yA+6webnIEm6i/Tp+Ga4sx1sQyc8diI2upS1nVUkZ5LBZHfxIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bvtxWWauQAJmlmiibIj1I1MDvf9PV7LLiRO1HwxlOHM=; b=heqBVJaVD7gyyZ+JSON95vVeiLqJBpotUiIMq1nUO9mtU/KccTAjTurA+8r5DFgTqULA1P642+DQ0bYOOcDm17Dsm7d086uTmah0qx2C8qj8yjLfOkSjvBo2dJZAOSx6dRDZxTbtP+9cciKg5aIhSmnKz+vwnkc6+7dUkZnv/9pi/rx85azFXHJyX0xTNej6uVFQnvrbZBBglSKY4TJh8PN38VRpYEta/bWtmaU96HC44IQi2vacyPb8uJidAuIyn9VYgawCFhWtsWX88ku+5RZ5saA2KNwKzad6OkviQH8TVNolXOpiuYF1AtD7WofSbQ/Sl9fY77V2LakoHn9+eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bvtxWWauQAJmlmiibIj1I1MDvf9PV7LLiRO1HwxlOHM=; b=T5c4T5WhjaPmdRVoMz1paQvWnMO7Mi5+4SVPgZz3pel1WMlNuJ7CrTcHE3QRZOFptR1mHU5Dod+z1WmRquBNUgCrxZJjNqd3+9bS/w2opN8vGbKHEjVFtpWCGf8JU3BaoujA3NPxXv3jGxQ93P+b3gAeApLq3GLJnlMjmpWEWgo= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4142.namprd11.prod.outlook.com (2603:10b6:208:135::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Wed, 25 Aug 2021 07:13:36 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::197b:884c:3d10:ee6a]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::197b:884c:3d10:ee6a%5]) with mapi id 15.20.4436.024; Wed, 25 Aug 2021 07:13:36 +0000 From: "Xing, Beilei" To: Qiming Chen , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: solve the failure of vf vlan filtering Thread-Index: AQHXmMrFlhJZ81yf4ES/Zjv/q3LBWKuDq+dw Date: Wed, 25 Aug 2021 07:13:36 +0000 Message-ID: References: <20210824085101.9142-1-chenqiming_huawei@163.com> <20210824092951.9701-1-chenqiming_huawei@163.com> In-Reply-To: <20210824092951.9701-1-chenqiming_huawei@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0981b460-463d-4c8e-2404-08d96797db61 x-ms-traffictypediagnostic: MN2PR11MB4142: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HxtP3hAozLfY5Q2jbH+nMGoAR6urhO+86nBtrqsl8f66Xf+YAVAvq6035G0PYLHvr4qeGlp5sdnsabaCm2yVQ/M/rv/8HWP2hwEwwdHK+yBpZvw2UeOyEOrwO5mSX+ffE3vG82pcB55VrECzjz48VGimU1tkA+vq29d0H6jWTPljZeUEl/m78r5s0CcHqM2POKtkAYN3zUa2Klqd34CFeZSTnhdL+B0w517XIBZz4B+gIg2RtMZ0cTC1Fq6LxU/wMzzgyuTZcsvBxvDOWey6Y+GDORX5mApCgOUwwLGRd93WsBsbxovtN7E9pJnT/DxwAz5WMI3K381tX1ektNu2wg0vzeMgL7yyQTqFWB1s8EJFSHrviUvLY1c5Yvsbu4a4mndlleK2EAJtR556HQj7Q8dj63zI8vije1rx+u535sMPLhxtAlH9t0eDlGSpSSNG6HhrEs+GX20abmg3VagkLI7FMoL/TNNld43tck6T6QcxyHuVChmwS+GpXwMze5qDJiqaKgAO3Pr1SPWQZTbgXFD3WNLV8bwa0kusiTnRYJynV0p86hMyLjcEp6QZx+N19zQI7FVxQLxUXKRxGau5ISfSRWNagorVB/JcELgbAaiDIgljIBK9w6xvDHgqsFEg24/EFQV5T4By4mUrrx0ZvlGz8rLrmu+n4UbklS8Wyw5lqC8KyIwKvYdTMukg+sCjpqkcCr/3gsta4dfqQyft/tQMo06MglMOdPBZhQHEYzZp47H6/dBASfySNuhfyB1/0GYQlLmzZtpm+daIjIGaRtzyt7rZf5RLGSU4oZ9MRVI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(366004)(136003)(376002)(83380400001)(52536014)(122000001)(186003)(9686003)(2906002)(38070700005)(26005)(53546011)(478600001)(6506007)(66476007)(64756008)(38100700002)(66556008)(66446008)(110136005)(966005)(33656002)(71200400001)(7696005)(66946007)(86362001)(76116006)(8676002)(8936002)(5660300002)(316002)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2RRO+SEUAi8fxBlq4BcOdsq8qylPdEkBFWgg3g5F/nUh7Vj2xIZlvbRPfiOL?= =?us-ascii?Q?PBVMueTX7xa+mnd3+DcxeDKk0+Y5AayyHuHWg5THh9I5o/gzsQJupVxbGstE?= =?us-ascii?Q?rFoapfyUpvz+Dyl0OzxUkR7KHcOEmDerFQCOQtWvGu8FORJK2Lni1JftohSY?= =?us-ascii?Q?YDOXwJzWTR0ybzoNdgOWCRgsiAMWOpJOssV3B+Eb2ka1zrF83lXQjoBEWL6H?= =?us-ascii?Q?tXZX4jtGNozVra8BcyAiTsjIznP9y1ZWKbRt0KHDfq0RExXjxfKGLXWzrkex?= =?us-ascii?Q?+XC9c4euiHHvGrY1oaz81e3px1vSAbBD9DUKXHMosS8WsELL/9DaK3FVq214?= =?us-ascii?Q?G7nhywOyM00lroZghbckUaDZ39n28FYm7mFxMhtrIbRJTjUwUbUxSXfSGhNo?= =?us-ascii?Q?aLT18KdIPIHE/1/mC9UwOpkSQnW94AizelDris17bwtk+gyTr+VATpZSla62?= =?us-ascii?Q?lbedtT29RrJ0a9RGEloMvpFqtw0gXS78oVisK1aJ0U7ZUhyNiwYbx4pLFSCf?= =?us-ascii?Q?lM4NARg0HXlg/CxjYQ3sJhpwIYkIDqH/MBxo0yRY2brmnceZ2G6uuw0MDcoQ?= =?us-ascii?Q?aNQLaH6Ln0YaxTTOa9Tm94Z8SqfyUiIaQo6F4BVAX4F27GSbGzioMzavqQH3?= =?us-ascii?Q?Jli5iY1/SKgTOJOj0eEBoAfBkliTGRkz7G8zVxocF2QVqYXukS3o+ZG5Yd/9?= =?us-ascii?Q?Z2rlIRBaZUtG78b7Frkef49buB4JvW6jQLP/vhmjXwE8BVQU2uZOK7SlGsgc?= =?us-ascii?Q?gK/vKNk3+TnvWj414GcSHViwz0unGuzaAjxAyOuNmt+qIqFWwJCgVOkV+epG?= =?us-ascii?Q?9vjxW0e5Tx8gYr0L15alVlI3g5w36l3eBElflaO0RRM/EFs/2d7JmIeiDe/0?= =?us-ascii?Q?BkT6YCETs/EMY0AV0yQeI2xWu8bDXsB7X4zCEtuoDlRycHZ5Hyw2clty6Vwh?= =?us-ascii?Q?1ibf/LecLiqpZ92E2gIlyof7hZ/pofgQJUsGKKXsD86MFwA9UDG8A5ogBwmr?= =?us-ascii?Q?Fl4NiaznlqmcdoA7TSCMq8Vf1KCNDm0GIlIhjl677BKcKSS9aNutWwjUPqKs?= =?us-ascii?Q?o0Ha8Gp9dvypL/ijJuE3ANLyqpda9NktsJ5eatgVvIB/+3b1WdsOPGXS2wiF?= =?us-ascii?Q?rJ6TGaj3sJyjY+rqUlLVSS4dYvPCBwCFIYJWmmMUCoDQ1qDsnwJAui4Kgxa0?= =?us-ascii?Q?T7+uFsKfPLMSYr7p8XU5JUU4n8sZitPd6Ao8Bt3XZtJvtuf+fMB4rG9GGhjB?= =?us-ascii?Q?32dKCmNwqc3NUmjttcmyNJIFLCyJfJieJKbO4hrCn9408Ou7x+doJj0bd9LM?= =?us-ascii?Q?iZw=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0981b460-463d-4c8e-2404-08d96797db61 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Aug 2021 07:13:36.6645 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lSxgC6FsLE7hwudF7Hpo6nxGcMsWljIJtqLs17/nCHHM3gRVA+wkpIdJqQW7g2h12mI8CPU9GGG5e7fG/7p4Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4142 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: solve the failure of vf vlan filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Qiming Chen > Sent: Tuesday, August 24, 2021 5:30 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > > Subject: [dpdk-dev] [PATCH v2] net/i40e: solve the failure of vf vlan fil= tering >=20 > When vf driver port promiscuous is turned on, the vlan filtering function= is > invalid. > Through communication with PAE expert, this is a limitation of the i40e c= hip. > Before adding or removing VLANs, you must first disable unicast > promiscuous or multicast promiscuous, then operate the vlan, and finally > restore unicast promiscuous or multicast promiscuous state. Thanks for the patch. But I heard from DPDK validation team that there's no vf vlan filter issue = with i40evf driver. Please refer to the test plan https://doc.dpdk.org/dts/test_plans/kernelpf_iavf_test_plan.html. So could you please detail the issue? E.g. do you use kernel PF + DPDK VF or DPDK PF + DPDK VF?=20 What's the driver version? And what's the step to reproduce with testpmd? BTW, for the commit log, needn't to describe the details you communicated with PAE, just describe what's the issue, the root cause, and how to fix it= . Besides, fix patch needs fix line. Please refer to other fix patches. Beilei >=20 > Signed-off-by: Qiming Chen > --- > drivers/net/i40e/i40e_ethdev_vf.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 12e69a3233..a099daae6b 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1900,11 +1900,30 @@ static int > i40evf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on= ) { > int ret; > + struct rte_eth_conf *dev_conf =3D &dev->data->dev_conf; > + struct i40e_vf *vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data- > >dev_private); > + bool promisc_unicast_enabled =3D vf->promisc_unicast_enabled; > + bool promisc_multicast_enabled =3D vf->promisc_multicast_enabled; >=20 > - if (on) > + if (promisc_unicast_enabled) > + i40evf_dev_promiscuous_disable(dev); > + > + if (promisc_multicast_enabled) > + i40evf_dev_allmulticast_disable(dev); > + > + if (on) { > ret =3D i40evf_add_vlan(dev, vlan_id); > - else > + if ((dev_conf->rxmode.offloads & > DEV_RX_OFFLOAD_VLAN_STRIP) =3D=3D 0) > + i40evf_disable_vlan_strip(dev); > + } else { > ret =3D i40evf_del_vlan(dev,vlan_id); > + } > + > + if (promisc_unicast_enabled) > + i40evf_dev_promiscuous_enable(dev); > + > + if (promisc_multicast_enabled) > + i40evf_dev_allmulticast_enable(dev); >=20 > return ret; > } > -- > 2.30.1.windows.1