From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix error handle for unsupported promisc configure
Date: Thu, 27 May 2021 01:54:29 +0000 [thread overview]
Message-ID: <MN2PR11MB3807A37878B3435896B86A05F7239@MN2PR11MB3807.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210526095305.1060069-1-qi.z.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Wednesday, May 26, 2021 5:53 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix error handle for unsupported promisc configure
>
> iavf_execute_vf_cmd returns standard error code but not IAVF_xxx, The patch
> fix the wrong error handling in iavf_config_promisc.
>
> Fixes: 1e4d55a7fe71 ("net/iavf: optimize promiscuous device operations")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/iavf/iavf_vchnl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 5d57e8b541..02e828f9b7 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -1257,8 +1257,8 @@ iavf_config_promisc(struct iavf_adapter *adapter,
> PMD_DRV_LOG(ERR,
> "fail to execute command
> CONFIG_PROMISCUOUS_MODE");
>
> - if (err == IAVF_NOT_SUPPORTED)
> - return -ENOTSUP;
> + if (err == -ENOTSUP)
> + return err;
>
> return -EAGAIN;
> }
> --
> 2.26.2
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2021-05-27 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 9:53 Qi Zhang
2021-05-27 1:54 ` Xing, Beilei [this message]
2021-06-01 11:07 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB3807A37878B3435896B86A05F7239@MN2PR11MB3807.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).