From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE3A7A0546; Thu, 27 May 2021 03:54:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FD2E40150; Thu, 27 May 2021 03:54:43 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id DA45040143; Thu, 27 May 2021 03:54:40 +0200 (CEST) IronPort-SDR: BRkYXcYFdrq0QIHWZ6Pnr8cVCt5Tl8RN5K6tiewWGz60F0nwpiijVoBOZEwCBQXrpjwOeHwhXq nozWeUbaM4aw== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="182961578" X-IronPort-AV: E=Sophos;i="5.82,333,1613462400"; d="scan'208";a="182961578" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2021 18:54:33 -0700 IronPort-SDR: yJ6l21xVoQTU2lZqBagsHq6xwQtoL13EiFV4HqIWt5HHeu2soN8yHLE1MPLMFoE1m1ihuewxtU wPkNXwYBbaMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,333,1613462400"; d="scan'208";a="414699992" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 26 May 2021 18:54:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 26 May 2021 18:54:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Wed, 26 May 2021 18:54:32 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Wed, 26 May 2021 18:54:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0cjnY01nLXWXUAeocgXlnJ9nIrEpmJhHNHcbvSq5mxdmHHOJqcjpCRtTcXfsaoixC7ivnXS1PyYy9h/dM3KLucKI8lb8RVWX0bSVghvj9llAyWOooAcXPpSlfvx37PraLc8rvBwxLGHvgCmhee1JKC81QH/IGtnD84kxRkSVk5sk+V73FB+ZgHZJUJQ+Tzhflnth72u3yB0+vhs+eTafy52SAsCrqGagO+f2kU/xxFaJe1zZHEOPpF+GdTRml0fEKZrBcBZfsMEivPnCrdPCAs4wKG43oH0R7jm/nIhYZEVaIpNGLKvYFL3UAejLWdVtPnBLX7oYPlqxMiOGK4riA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uldlqQsAeBUuoXiqHP+0mSe2fnFz/vttLlMroPPDCs8=; b=P5zrfelaIdzQCVbxjmPoT6kbVPd5Jsm8TSuE8dKqTBGSOsUDipq8pYGYSeGriSCEvQslQb0qfJYzj9o18hB4kUlmR7wL889NfhZswC8eplRGfuvKjYuxDW9uFPVHafMuTGpPo4KpnhPh5xTyDTf2cS8yBqMaZ+OSdZPm47yn8CUoqZILitsPiMzCdQTFJebbhJrs4sh/fiGQYFTrb/3+SmdwsJLq7zpzad0k5maSV86/QbIajfGt0DWnjQXtPwGDACKs4KIt4AkMNW25RaAo5tGhH6VPyk8GpjPucTK7ZMaIBWPUECBlVpeRvw5vZo6a+g16gYmbhFgbxNlcRSVh7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uldlqQsAeBUuoXiqHP+0mSe2fnFz/vttLlMroPPDCs8=; b=pJD4UlrkOraXxYZTnevD3+pJL6Gk8Rc4XyIdZUXxyOC4A7PHtITFDDDq0XgWX+W82eclBZfZgmn80SNLwBHv8IK60vk/96v4wGdGOuQZYU/nsA8NvE4ohMOkAus+g1rDM/ExA++YG1k3RZveNCWxf/oQ2jpDSEH+o/eJndEqdp8= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3838.namprd11.prod.outlook.com (2603:10b6:208:f3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.22; Thu, 27 May 2021 01:54:29 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4150.027; Thu, 27 May 2021 01:54:29 +0000 From: "Xing, Beilei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/iavf: fix error handle for unsupported promisc configure Thread-Index: AQHXUhSAGu1GcQZtzkejD8l5c6IRaKr2kj0g Date: Thu, 27 May 2021 01:54:29 +0000 Message-ID: References: <20210526095305.1060069-1-qi.z.zhang@intel.com> In-Reply-To: <20210526095305.1060069-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cbfe672-55f9-40d7-e930-08d920b25d94 x-ms-traffictypediagnostic: MN2PR11MB3838: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IYa8D0rA3yc48avOMIf04QBTgZD0K+JRFfIxPTcBVm2j8D48WCF1kPDX0ocmA2wMlvuf9hOFnpP7dR9jiZR40dN1WPuAj4tXuWXBu5eoCn9iH9dsrZgo6tEPjQ6aIJKmj53Pqw1RC7sXmndYemDVO/rFjLwB5ZxlHrL6eg5GV5anrlT5hwL6ojDgtUAxBs0cBBQScn3EH5i1ycqszxLI4SQTl/y/l0LH5GFQNcKjUhsOritUcfjTKsLMG5jrcJYIWZbgPpf/fOl4IQs57Lzt0l/wBOWGwsAnTOBp/2yDAL5j0CaGVfqcEr+JIW4NtZ8dpg504dcqYe5WAelimgKdyRrs9sc/i3OfJ1g59ZT3f2cAQ00rAkGE0UgZfcfawnUSvRg1WqUa0owpQSYnGZwKYHV6I9qudW937CGemE33E/vRviSbT1VF5vy4+emNvy9XBHMLnc1OxFJ5Z2j4FBt75KTTkTe4oNYAO93EyIppUvu4jUekekzXRTMBFcMlyGCqpZJt1tPpl1Ie2Of6tB+DsJmUFNGVFOAXg2w+sbknBRQOKKUYoB91+/l4NT0sXh40xZz1YGhLmOswTbV9A8gASTcon2c7zZKUqXrIqZbWBHpXK6pa4bytmFPRVn88GuvH5TOlMRzMPu1cFIVzly55Pw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(39860400002)(376002)(366004)(346002)(54906003)(86362001)(316002)(186003)(38100700002)(8676002)(64756008)(122000001)(55016002)(26005)(6506007)(478600001)(66556008)(66476007)(7696005)(6636002)(53546011)(66946007)(71200400001)(66446008)(76116006)(9686003)(4326008)(450100002)(6862004)(83380400001)(5660300002)(8936002)(33656002)(2906002)(52536014)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?RgXWixVLOBue0rufUhLAbXZoVdErN/oOnD3e2o/bqyqyN+XVw+Ypss1WIVQS?= =?us-ascii?Q?Cq/1BdFS07cOeSkEOZLqZj8C7bXGqz2wbp9l1Dwi3woTYmkBDCqlxFTVyAN9?= =?us-ascii?Q?js24MALaPONHoAMPGKaxFky703q9Fb4dOL8dmoBmQ4E7HSaJxY8tQ3twhqST?= =?us-ascii?Q?j5Eo6FOOkTEIjECv6KhqjHsRBE+10X3E6CZdMv6XEhE1UOxcEqZvxsknynn5?= =?us-ascii?Q?l6DSfSAaJCW5IB/2gh6mM+iekCzrgn6+jeKQmV5tLSB+0fk9QvYVW+mEAEaz?= =?us-ascii?Q?X3yaIr3tk585gaPqYZjlwXH5b0k9YgQ2247jCiHeIMYtI9MMFk9XbzAMAXOv?= =?us-ascii?Q?r0NZqI+0Nsx1IL1b4Uwpp0QfhEhA+hJmnqxkjLOejTCm/8wWMqcIU75rz43P?= =?us-ascii?Q?U4c4Rd2KtNtkSY5WdX3pvx7nyHvNbEXG1m8zUR462ugbhEifO1oqCw3tmy6f?= =?us-ascii?Q?54p6qzjCm50XQoAypCEdn/ONrdRszHjJvHzoQoBHyEpBsXEz35mSvENO5LIt?= =?us-ascii?Q?S3ssDBnHXkQibkuDf6xTbXWUgHR4xxWMYYkTaoMFw4b7iw5G2mNQ2N4b9ODl?= =?us-ascii?Q?Q/Mm1IQcP2/3/+7BR65tpVXZL+z/0p1ElUagNHWMZeCwnzBU25t3xGtU1jTl?= =?us-ascii?Q?s7Cyw2uQybwwYUuGFA9VaZ+387eBpKmKmzMLH7//TmlvL8ECySpQIjm7o4rs?= =?us-ascii?Q?gKJKMAy/vsMYtCTtp9b3riKpWEv0x29sbmn0msl9H9Td4PTixjjmhO/5P4g7?= =?us-ascii?Q?eCMb3LxRD4AXJwgGhG59trUb7XMI/mf8OLsGLE85fCsxQwDSToahHF11BGYN?= =?us-ascii?Q?OOAWJRr4/j81h+RrijKKOZOscIyA32LD0SzaUZLdK+y1wU+w1pZkmvDGsnfV?= =?us-ascii?Q?Jxqk/ZyeBvCBuxlz4NV3i63OA/oMG2rZEZjhynsxAbgsMoY8SocdrL76KJiI?= =?us-ascii?Q?4IyQDeeM2YEG5oLDSB2c5axcbQR9uP5iCC0orr6mIhVp0jM0/LLdqTYQTG/Y?= =?us-ascii?Q?FWe5vabyT6QloOk+Hw9D8Lnhhs4XZGk4dDTBqE4VXD6KgkqdDWawlLslupJu?= =?us-ascii?Q?2anrUoL2UNWn/FuHbeGxKVqOKrh+bGB/gIb3oZelLMTcoMPt9OKCaSyK6B/6?= =?us-ascii?Q?sBCDNdiqvinpPV7Fu872Bj4p0uKK4m6+9pggv2nypqOgOyS6wjZEjZMj+V55?= =?us-ascii?Q?ZGZ3jizKVr/ldRRIIPa/ZNXAsmJS8CZ8OmV+QpjU4NWS7OF58VolkhZk8vcP?= =?us-ascii?Q?WW1Oxg69Yzu9vSBchyXKz7185CDkNgIswDuVUtNs8qjutNzXJ3qOmdgyAMtn?= =?us-ascii?Q?Sna+M+bJavrhip77rJnuI9hO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cbfe672-55f9-40d7-e930-08d920b25d94 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2021 01:54:29.4404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5w546WW/wDTUC8nXPRndWSgoBL/w1NWPOmygz+wSkvQ3ueqTFxedKXJfhk11HQ3/wQ2Ypi0FQgBHWDJmu/rqeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3838 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix error handle for unsupported promisc configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, May 26, 2021 5:53 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH] net/iavf: fix error handle for unsupported promisc confi= gure >=20 > iavf_execute_vf_cmd returns standard error code but not IAVF_xxx, The pat= ch > fix the wrong error handling in iavf_config_promisc. >=20 > Fixes: 1e4d55a7fe71 ("net/iavf: optimize promiscuous device operations") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/iavf/iavf_vchnl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.= c index > 5d57e8b541..02e828f9b7 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -1257,8 +1257,8 @@ iavf_config_promisc(struct iavf_adapter *adapter, > PMD_DRV_LOG(ERR, > "fail to execute command > CONFIG_PROMISCUOUS_MODE"); >=20 > - if (err =3D=3D IAVF_NOT_SUPPORTED) > - return -ENOTSUP; > + if (err =3D=3D -ENOTSUP) > + return err; >=20 > return -EAGAIN; > } > -- > 2.26.2 Acked-by: Beilei Xing