Re: [dpdk-dev] [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules

Re: [dpdk-dev] [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules

[Xing, Beilei]

> -----Original Message-----
> From: Liu, Lingyu <lingyu.liu@intel.com>
> Sent: Tuesday, June 15, 2021 10:53 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: Liu, Lingyu <lingyu.liu@intel.com>
> Subject: [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules
> 
> When a FDIR rule is destroyed, the corresponding input set needs to be
> cleared.
> 
The fix should be if deleting all the rules of some PCTYPE, then the input set need to reset.

Missed fix line.

> Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
> ---
>  drivers/net/i40e/i40e_fdir.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index
> ac0e09bfdd..e679324c20 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -1845,6 +1845,10 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev
> *dev,
>  			return -EINVAL;
>  		}
> 
> +		/* clear input_set flag */
> +		pf->fdir.input_set[pctype] = 0;
> +		pf->fdir.inset_flag[pctype] = 0;
> +

So should check if it's the last rule of the pctype.

>  		pf->fdir.flex_mask_flag[pctype] = 0;
> 
>  		if (fdir_info->fdir_invalprio == 1)
> --
> 2.25.1

[dpdk-dev] [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules

[Lingyu Liu]

When a FDIR rule is destroyed, the corresponding input set needs
to be cleared.

Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
---
 drivers/net/i40e/i40e_fdir.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index ac0e09bfdd..e679324c20 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -1845,6 +1845,10 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev *dev,
 			return -EINVAL;
 		}
 
+		/* clear input_set flag */
+		pf->fdir.input_set[pctype] = 0;
+		pf->fdir.inset_flag[pctype] = 0;
+
 		pf->fdir.flex_mask_flag[pctype] = 0;
 
 		if (fdir_info->fdir_invalprio == 1)
-- 
2.25.1