From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38843A0C49; Tue, 15 Jun 2021 10:36:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1784D4067E; Tue, 15 Jun 2021 10:36:12 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 98B8C40140 for ; Tue, 15 Jun 2021 10:36:10 +0200 (CEST) IronPort-SDR: 502DaiJdxKVINNMkSjW9Y+ixw/WwMgCRjDG44oIkUfpYNoUl6DIXzuG8JCDmjVuHbQAOrnijrw xZoA8Fzbtx0A== X-IronPort-AV: E=McAfee;i="6200,9189,10015"; a="291580900" X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="291580900" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2021 01:36:09 -0700 IronPort-SDR: uxAs9Br8g08gzDT0HtgC1NFRiH7//CbYZYJ/AVXKgwtNaAxeRQMyKdyDjB/J74clNyXfN2q/qx aL6U3Ke6doHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="403909224" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 15 Jun 2021 01:36:09 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 15 Jun 2021 01:36:09 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 15 Jun 2021 01:36:08 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 15 Jun 2021 01:36:08 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 15 Jun 2021 01:36:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MiMx8nNEPXSWZJGUNIGM0zFqkKxV+BxriSuSDAm2TyFOtrn5mUFkxDPNloh9C3uRIBMB6ghNEoMVSfpoTloxl28bfJ8OyTkX34tuqj2qZCeZbX7k3ITbL/GQ3URrhwQV5JkUjrHuTYMvbf7WVhDz+c5f13qefoBAk2/Kgm5HH6Vn1AR4rCl95USVPPCUA9tKCg1TFmlPYp98pJamVQiB42dxnKp/rNM2aK9NLLtDP2MGhNyaIZHb7RPgX5cVohJPJAzZweuhPhV/B4ZxmX/EI71SAsA0lx8JIBn2/xj5k8xwRPUilrAClEaQbr/45ptB/v/qsWuxZ6abHepQlEuk6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5VtRTdpSE5w1p4grJJSIKdmCJccOB/29zwU8tsXDbBA=; b=UkH7+dPSoNK8YlYEluhm4k5msbJwHGeBC8zD+GhlkBGbVQNhr7F7auerPm8bDhpIdHM1otZ4NcDI7/mQA8XkK6H2GxL7fdcw4BHmkJfcAYu+or3egxVlOxH9wwfDpgjI4tTf6dzEPGPbHmaNki6E8FrPagMmWQqsJ/N0G6nIav91l5L8lUm8DF7iRilCm8RrlQ3E3PnS60fzP3dqHkyaLq/KmOESvmR/afdy2a+DYQg+bA1crRtNzpWHZCJiS4T/TweFIQ+xPxCoMJAY9wn7+N9rA9Gxf6dKFyhhksVQdsPEiRmT9fT49845xh9RrpTg2AAGw0VpMhj0lnp9LAD9Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5VtRTdpSE5w1p4grJJSIKdmCJccOB/29zwU8tsXDbBA=; b=Nk5lmVpQHiPFiL90Dhyrd8Kzqn4PrSLUxfjiUfdKfCpwCLKoK6gqInoe+SRc1PnHduiqe0NWzaZKsdShsTcEHxFENj8cNukWmP+7cVv93+18T/fEpFVxBIHE1i0kIBOkMD/CMDKzMhExNSKFX5WrOzRSAjGW+UEWF7PlB7X2jTo= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3663.namprd11.prod.outlook.com (2603:10b6:208:f5::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Tue, 15 Jun 2021 08:36:05 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4219.025; Tue, 15 Jun 2021 08:36:05 +0000 From: "Xing, Beilei" To: "Liu, Lingyu" , "dev@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules Thread-Index: AQHXYb8r8To/4kQzS0y8teAES/ixJqsUvo0A Date: Tue, 15 Jun 2021 08:36:05 +0000 Message-ID: References: <20210615145259.51859-1-lingyu.liu@intel.com> In-Reply-To: <20210615145259.51859-1-lingyu.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 817dbca8-6198-4ba4-8fbd-08d92fd89dc5 x-ms-traffictypediagnostic: MN2PR11MB3663: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:935; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SilULYrs2g8k8Iiv91bbj2K7JuYv16xhmhZzZQyUl+MXQPa3NYInwc+jpA1Y2we7FT69l5yfCeZ5byQsyybUVSPRrugD6YTYd49bamVy886kTwSY3D9F7rqHvKi3eS3ngSGxvGSrfJxZbZnUx06AQ2lqXIjOlCOzaObEp/Pol3m0xuqidRHoQ1nvW0Cwp+zC29h842Lbz9RWGJg/0QrCNi/QzEMvJIJTCfYi+L5Wp5Ywg3m85K6+uJC7Be0aQzv8ECYEzK49rD4OGSFdiWP/3Dysy1Amj2LCCN2XTSksk4Cgel6IgEA8KyXJBM4L8mEqqvKTwptRWUN6/0GaqaLRpaQDBWZ9k7Ro+QCF5QJLizT7l+rj4GlLdHPKlPGNr9KStK+uVM4ZfmdlZIAX1ntRHdrO5XyOXON0V5pgvJ+9HChQmphEle+dRhC0JtuKTJmsdQXXl+AKhI/lFwQHzqmh3POq4gmua5H7b+Aj8ekyOf9VRTKnUD4pkhf4u/vPzjVmA09FdZ5x/pJtVPjaPeR7aP3ueGaGi/fkLufhI/7PcYtWDyQ/OIccqG3wHlpn+9H1W+1XcO6aBJlbCo8KrZRB4tBXO4d81QJ3i1lRaqcO7Wc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39860400002)(136003)(366004)(376002)(396003)(86362001)(316002)(7696005)(26005)(478600001)(2906002)(6506007)(186003)(8936002)(110136005)(83380400001)(53546011)(9686003)(33656002)(71200400001)(6636002)(66476007)(76116006)(38100700002)(66556008)(5660300002)(55016002)(66946007)(52536014)(66446008)(8676002)(122000001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xGZsdrLle8Cegam9kkbrTugsEAPQ9hSkLsBZ4TpYqmvbY1uztpT1ALGhuuoU?= =?us-ascii?Q?hg29mfLMX9NuY5QcsmgTC7QblPArm7a55lCUDXMAkzZpPqJJ2Me9T4aStKEq?= =?us-ascii?Q?tTbIwdn+9cdhpDP9EeMUeLkEq9E7Qhjo7801b0l3Hp7Z79KWj+pCXml9b1WX?= =?us-ascii?Q?fw6VUUf9gdG7IiE8YF6xz7KdMraCH0x59SI3uYWwNqv6BwT4ApXRCCO+vNKR?= =?us-ascii?Q?wVfRMcknDIzUbMTDRcG2+A4NlNMRbfb5pqYdWwMCNYMw0HFUaZtog2voPG62?= =?us-ascii?Q?TQjclJrSHo7MC+roTVMMuO8DlI9TUK3m5tgU85F8ykkVwU3uxzH3BicPqvOM?= =?us-ascii?Q?k0bl7ZdgIi0C1ZQlHGFZZZJyHxuAh53kr0hKwocoUNs5yuKM/QQDTz0cblFb?= =?us-ascii?Q?8XgyAjHLnFtqgzP8E/u+6Bc2PeoDB0vENdUd7gHXFvvtxyCgOLpVBiqDIL8U?= =?us-ascii?Q?za71pGM4ZIYJFneT1iz2CO0BbKjuXCIWOYQ5HwvMwsiCnciNzauURBvJSvp8?= =?us-ascii?Q?lIbs0TFhTtSNv0vrlhcYnvdQSQA+ZeDD6UXAB5KGWCQ9V6F4wjBDlU5/L8Km?= =?us-ascii?Q?HPlPYEponsU4PPqP7YrEP3tLGpHkGYgjcdqrGGtOELnLvuAFgzLOOOHJT6CY?= =?us-ascii?Q?mIo+dVb64NFD0p4QfHUZ7mVMHUG9aQzVEV5vKASEMObikreFsixWAdfFWA3E?= =?us-ascii?Q?Cj37/LSddd88R+muTlrdGxWVvBAcGEUXpObuE77aGXSif+ifrNuK4lj/EnCq?= =?us-ascii?Q?0zLJtrgJm1hLMjprD1UVS3cxhhjz/8JT5rOIzI2p8/epsxq+3lMKiZvFamc6?= =?us-ascii?Q?0Fte6w7Uh2FPIf2xDm/Fqx58GDbeuRKx7KoQvMAi8Ju6v98DWQLMVcCc93A+?= =?us-ascii?Q?MAmt4VjmvZF4oAiKH8bfNPWX/30Bp6rJLUMlWNDlAOR3Dcw/aQr/ODpIKAqy?= =?us-ascii?Q?9D8LoXsPZpWtN9BS3xOdvaTMOEvgv1lwN4Z9QRL4sp4lTKcsS5H+7Ih293i1?= =?us-ascii?Q?0zQMpr1YFsG3z73OIeTN6L96EHcJnwA+yAHWtjfFlI5jym0RiuJ+9ijWaM7A?= =?us-ascii?Q?+OhuGnmkd5NJ1/3hB/07YLG0psMDmBqMavvYBVyaNcSQpVNiSjfnlezmMJ2O?= =?us-ascii?Q?IbAPbjSSbIQDIfvcEVWY2UQUaNLHGbJDCOQyaKxOC3GMoXyChtYxhghm7OZh?= =?us-ascii?Q?kXuX0P1BD7MI7JDZ+6BAAvPG5Az3a5/D1zkrbKnPWC8alxdEjeO68qhzIhyr?= =?us-ascii?Q?w6TttYqjyQBReKTbXNsv0onTv6CPwlMIovsGY6mS1uGjMt6I5Kq+qX5SWHJN?= =?us-ascii?Q?s80=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 817dbca8-6198-4ba4-8fbd-08d92fd89dc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2021 08:36:05.4638 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7kdJqt+K8x8yLheLqXMjSiolWRdaj2UWEUhzeKZiPHKuFKKoI6O497YWuijrfVqGRWuQBpJijs4y/FD8VzWZAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3663 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Liu, Lingyu > Sent: Tuesday, June 15, 2021 10:53 PM > To: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Cc: Liu, Lingyu > Subject: [PATCH v1] net/i40e: clear FDIR SW input set when destroy rules >=20 > When a FDIR rule is destroyed, the corresponding input set needs to be > cleared. >=20 The fix should be if deleting all the rules of some PCTYPE, then the input = set need to reset. Missed fix line. > Signed-off-by: Lingyu Liu > --- > drivers/net/i40e/i40e_fdir.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > ac0e09bfdd..e679324c20 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1845,6 +1845,10 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > *dev, > return -EINVAL; > } >=20 > + /* clear input_set flag */ > + pf->fdir.input_set[pctype] =3D 0; > + pf->fdir.inset_flag[pctype] =3D 0; > + So should check if it's the last rule of the pctype. > pf->fdir.flex_mask_flag[pctype] =3D 0; >=20 > if (fdir_info->fdir_invalprio =3D=3D 1) > -- > 2.25.1