From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/iavf: fix RSS key access out of index
Date: Thu, 20 May 2021 01:23:50 +0000 [thread overview]
Message-ID: <MN2PR11MB3807C8C3A48DC3ACDF12925DF72A9@MN2PR11MB3807.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210519075933.11807-1-haiyue.wang@intel.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, May 19, 2021 4:00 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; stable@dpdk.org; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH v1] net/iavf: fix RSS key access out of index
>
> The array rss_key has size 'vf->vf_res->rss_key_size', the array index should
> be less than that.
>
> Cc: stable@dpdk.org
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index d688c31cfb..cb38fe81e1 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -366,7 +366,7 @@ iavf_init_rss(struct iavf_adapter *adapter)
> /* configure RSS key */
> if (!rss_conf->rss_key) {
> /* Calculate the default hash key */
> - for (i = 0; i <= vf->vf_res->rss_key_size; i++)
> + for (i = 0; i < vf->vf_res->rss_key_size; i++)
> vf->rss_key[i] = (uint8_t)rte_rand();
> } else
> rte_memcpy(vf->rss_key, rss_conf->rss_key,
> --
> 2.31.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2021-05-20 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 7:59 Haiyue Wang
2021-05-20 1:23 ` Xing, Beilei [this message]
2021-05-27 9:51 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB3807C8C3A48DC3ACDF12925DF72A9@MN2PR11MB3807.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).