From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B54EA0547; Mon, 21 Jun 2021 10:19:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD3D64116E; Mon, 21 Jun 2021 10:19:15 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 133A541158 for ; Mon, 21 Jun 2021 10:19:13 +0200 (CEST) IronPort-SDR: 5Aw/ZFtkjC4DsRcN+dsgMeEJkiSM7GBJV+FiX2L0DEyzMpFXGS+qGYwAKMG/Z/xyR/4uKm67oM sy81zncFYMOA== X-IronPort-AV: E=McAfee;i="6200,9189,10021"; a="267940793" X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="267940793" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 01:19:12 -0700 IronPort-SDR: EbsMoO9k7HF0WDrGv3UPeBOF+ghkKvGQowdio+1NtqzXCdyFFaNbgjuelkrT6fzC/heJi65QRH Q95Zkkx5z3IA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="405549670" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 21 Jun 2021 01:19:12 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 01:19:12 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 01:19:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 21 Jun 2021 01:19:11 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 21 Jun 2021 01:19:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kToWCENWFk8TxTugQNhfkAKq8DIGWl5LdVVUSkxY4Ph9ZRc3UfHXgmzEVuXfTe4Ol8Sk2Z8LrLPSxlXYQB/kXbWOBJ94wgr4xbCIOEUblJjGlcneJ6cGXMULeBIPNYf3tj2gc/WIxAH/a+RRBWVk98/10rTi6rr3QhZKil5kZSinf51NaQlBwc0dx5VMgDsyl3wnljGNHJ/tL+SzoBimy9Nb2Hz/2dYFXD9CuTdJFp/fJik5QrCFLRSlKxT7ZvMt17OumGGXUabQ+YW2debZbN4O1rU97Fsdka/D+Luk6P64PhUb95S45ZgHxZiD2oJAmh/mLNjYzF+Z35E41yWFgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hi1WWgXXzGSavSw+8+PxkiYQPgyj3+CiKVkjjrG6gtQ=; b=aGZOjfHUWcZW9acpAYosDzZUAfma2txYPxlgdIWGIIlFtlS77oEnQAkqI3uzV7t3ys6zTZ0h+FhQdTxWTedEtODi8AFb/zyN0EVOg3suwQ+any5kIQ58j75YKdUepoTqSWRwjzWYxVINJt6eMGGqqh9ewq99L0SW8kpY/KTAwQWcDW/aXe7wQ5b6rdJD9YIX+7ezWw8AmxxDk1D7gqroyxixffvENdSuGc48fuVqUtx8hFHknKBSvEEU2elVRHCGX+aZ1NRkkZPUzolR1fcq6mNVsLfgFPZGWEwMhkDAzHzfmDOHgWxHkx+uRvP7giUCZ/Hm5yPjJbQhKNJChoUAdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hi1WWgXXzGSavSw+8+PxkiYQPgyj3+CiKVkjjrG6gtQ=; b=PX1GZBWPZzCCfpB30rYeTn3o55IY5UjsikwyUA3ebM2Fcf5aDrl+SJF1nRMwEZseiftHq//06qK/lTDxkOQnbEAGaMXw5v/PbkmxW66+wj9P0eJkncWnvZJc2yQV2Th75vlz/2pLWy++wMVnowIya1Cjqav2Go7sT4dQDMU0AB0= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3550.namprd11.prod.outlook.com (2603:10b6:208:ee::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Mon, 21 Jun 2021 08:19:09 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4242.023; Mon, 21 Jun 2021 08:19:09 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Yang, SteveX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid Thread-Index: AQHXZnReyb4VOVA52U+DF/UrvnZ+GqseH0Bg Date: Mon, 21 Jun 2021 08:19:09 +0000 Message-ID: References: <20210611065457.988344-1-stevex.yang@intel.com> <20210621080342.184889-1-stevex.yang@intel.com> In-Reply-To: <20210621080342.184889-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fca62ca5-f355-4573-251d-08d9348d3eac x-ms-traffictypediagnostic: MN2PR11MB3550: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1079; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Mo0HV4nos1ZssRIqzVP3ahZcLHHiSr2u/PIOu9JvtrquXm1WvDMLyP8Z9UPsg4cK/YUk3BazHUB4E9ROBcBtAFUqd9hCvsRJu8Uvt9vSIEXDHkMwGyV1zjr7zi/i0JUU/pBn+3lemQJrSp9Ln17GRkeEnJeEmT+y4+yUQY5yvrGrXwJRMF5J/6eiOUgNdJFaCmEZUONyqdaw7m5F2NUhkfysEIRSQUxDIE/5Cq723wn9egGZ9v3W64pZsBgyHmGgWOnrsuiHIK72nuvx8tmIcRMAhSkgYAevnOKLbcwa3pK4JdqspCJ4qD9etx2L2PFC7pC11aFtf9jzpDdIDefJI5ciDFnlfklS3ZxTUNwr/F5lIqdh2r4EkpRERB+lV0RsdEWQOSe+unTmggjzo9U4isILNcEoz2N2V1xIYQUMN4/eU6wzmFk/enOrQBqD6chzKvdWl8cwT3wgkqtn1rXYSk2OGvz49jsbM4ksW0m5zf3mtTlGfbU/LPtywFNMSah9U5xh6XrrWs4uwJ4A4g4Ptx5JPB15AV1YsYUWlMLuTA3iFEEpRZ9qcetKopg2zwXQIY/KrQs6BFNm8FT+T+2Zo/8WzsdhCbsJTYmL1U8EfH8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(39860400002)(346002)(376002)(366004)(186003)(71200400001)(478600001)(26005)(86362001)(52536014)(122000001)(38100700002)(7696005)(33656002)(8676002)(66946007)(8936002)(5660300002)(6506007)(53546011)(76116006)(64756008)(66556008)(66476007)(55016002)(450100002)(9686003)(66446008)(54906003)(2906002)(4326008)(110136005)(83380400001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q6VNlk7+UvuLP7zat+L0qEsztQwgLE+ely97oBGwBDw8rgMUJkDONEfdHEov?= =?us-ascii?Q?UlBUzWrFpXbb8kNAEbX06O+HORSC+T1/Fc4JJ05i86+TUSb2K+NtfDab2vqd?= =?us-ascii?Q?AxkpmmXYfgzmI5bKfhQx5t0QuE6xG07Q5hXT8Q0LfQgyK3TNQVgwvu+81YBF?= =?us-ascii?Q?vZnv0mtlnS0pQGuMRXgYf2A+nIQqUNRPxNZ6EzNCvAFWiVHzV8Yx+hTpmTb6?= =?us-ascii?Q?4YY4F7o1+npK4BWybAYNRRHVTIsaVCNfxfcB4E8XCEGFn67EPmtHmgBU4e20?= =?us-ascii?Q?l8JpqL1vaMp8pLEA6SNxNf4/BfNx2ZPEB7lgOZagfG/eyfmRVb/kMnsda3X1?= =?us-ascii?Q?Qkr8+W0PusSw9cDfJU7ADZhFnzeA0DjG2AF4kSleVqptcL3eqO5UjiUfJ/u/?= =?us-ascii?Q?laFtkK7WeLXKoz9XOlCQqQat3nnqHm2HjHVKhYXgf9mmwAtHPU9BCSGnHkyz?= =?us-ascii?Q?HSJcwd0WzfvzmT3sIiyYLkAEwSAaHSmqdDhoU9dIS3U/IZj20nFTnTYGYCG+?= =?us-ascii?Q?6RIRWvfST7YrOyT7VzxHwkwqTwlsSeNKOt8YhyIPnEYFTjq51zbJgazg9Hhu?= =?us-ascii?Q?3YIw1QXBTUFkgrn6AO6FloFfb4VWyOwQCdXQMj0h4awSf5NCpdsZZrtqExPH?= =?us-ascii?Q?UdgO6WCy03TtVfFa+tkmqRE2Wrvd6sx36C44CqS2gkZ597SvbTdLwpL8nHMS?= =?us-ascii?Q?S0GJSd7sDQEE49CgBcBqIsxb+TntGNVMs8XUrBARTpjj532Iaa2gZRTm/I7T?= =?us-ascii?Q?Y6eGY8VN+mLC7NaXCSq/Mu1/XVZ3sX0Wtu0xh0pHVLVp64o1dxgPeIbbShVy?= =?us-ascii?Q?3E/bQHTZ6JaoZ5Ris8ouYRqCIQAtqqIxSjb0G6ijPplx7xCcP9O0VJWxZ8ne?= =?us-ascii?Q?5dCfJePhLxvcTsvxLaZfn3ITjE5cBznEyYamkGWnp3wiy5AbS1sWTOzNejwH?= =?us-ascii?Q?lbEA5idiorxBON1WcjlqDDEPITmuplQxmCNOqHxnFvElJihs3lb7MUA9oz7K?= =?us-ascii?Q?7cm1lWEZzOj8bRDh5g9MH+8ZsgcftdOjD1DOtl/qQqz4GqY0DQc/T72voOBv?= =?us-ascii?Q?zPfW/f1KFYoAjo31OB8yCwMGl3y8rtjKpx5bGyZ8uMmezwOWatUzCyisLLlj?= =?us-ascii?Q?tE5SnnN3kw+MYe1e2HnlKU3F0gzyByWKcrAR8QiHBPNXrrptIC8LVOAgOYS+?= =?us-ascii?Q?TIHxwyVkJxUCluUNJ45c6obMHYQBOrwJFOPq1OMMCrbMC4wq+XUOXmgGFJLv?= =?us-ascii?Q?+N0RVG5XvsXUhlJaY8qY2VbuEOgYEnfkYaOTiqSJcvTJA0yR58BzX282HQLg?= =?us-ascii?Q?Ugw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fca62ca5-f355-4573-251d-08d9348d3eac X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2021 08:19:09.4968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Di6croCqv/LDrK1sj1mdSwb7FLtBfrkQgXi6pLOD4ymx+0eHmG42DSC52hV2MlMFS/MjAKk4jn0K6AVCMC3S+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3550 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Steve Yang > Sent: Monday, June 21, 2021 4:04 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, SteveX > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invali= d >=20 > i40e can support following rss hash function types: default/toeplitz, > symmetric toeplitz, and simple_xor. However, when filter engine parses > pattern action, it only supports symmetric toeplitz & default. >=20 > Add simple_xor and toeplitz hash functions support when parsing pattern > action. >=20 > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") > Cc: stable@dpdk.org >=20 > Signed-off-by: Steve Yang > --- > v3: > - add Cc stable line. > v2: > - add the fix line. > - support simple_xor and toeplitz hash functions explicitly. >=20 > drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c > index b1cb24f437..0cef21c88f 100644 > --- a/drivers/net/i40e/i40e_hash.c > +++ b/drivers/net/i40e/i40e_hash.c > @@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct > rte_eth_dev *dev, > NULL, > "RSS Queues not supported when > pattern specified"); >=20 > - if (rss_act->func =3D=3D > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) > + switch (rss_act->func) { > + case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: > rss_conf->symmetric_enable =3D true; > - else if (rss_act->func !=3D RTE_ETH_HASH_FUNCTION_DEFAULT) > - return rte_flow_error_set(error, -EINVAL, > - > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > - NULL, > - "Only symmetric TOEPLITZ > supported when pattern specified"); > + break; > + case RTE_ETH_HASH_FUNCTION_DEFAULT: > + case RTE_ETH_HASH_FUNCTION_TOEPLITZ: > + case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR: > + break; > + default: > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION_CONF, > + NULL, > + "RSS hash function not supported " > + "when pattern specified"); > + } >=20 > if (!i40e_hash_validate_rss_types(rss_act->types)) > return rte_flow_error_set(error, EINVAL, > -- > 2.27.0 Acked-by: Beilei Xing