From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37E2BA0C53; Fri, 3 Sep 2021 11:42:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3A0040DF7; Fri, 3 Sep 2021 11:42:16 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id B118C40DF4 for ; Fri, 3 Sep 2021 11:42:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10095"; a="217520038" X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="217520038" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 02:42:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="543434778" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 03 Sep 2021 02:42:13 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 3 Sep 2021 02:42:12 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 3 Sep 2021 02:42:12 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 3 Sep 2021 02:42:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2cLa+E+YMC1XGxb/VbVL9sXU9g3oxO4bAQFp9iZ/M708fSbDw2KqzRWiwAp8V2qQTjegtjeoGDB14fOzIBYpKtYev7V4NP+fovqxQq7suUP1o7HWGtuLT8OLHEoa4H27sfe3Y7tExK9StQu4cGAqOnZujd8IOkB7n8Lz8srGkAMohFgqynPv31YDakDWgMm33lchZOSbl71z2z6nnlZyxCm/Roi5Nj6+93OVUFS6OLTdPxV8KrLxH4SwufCH2H5Yf8/l0afMUpoVHi5AcMz7DCgA21M9qKZ8ShN/3jTiPtE9f+LTvcb8gCZxhzKtVpftZ3PryLRuWHjg22uWLf5Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4B/5okXBpq+z3GJo/J7tkBwRf1FdyhkxBukzxOcFtE0=; b=cDyxy/FT8neE41voRtw50Ev3e3JPHqnholKaDG1jhiF0OevboZAZCLyGjJAeyWMw6UhXHof7Pz+u+AX4gHzXJD781x9Vsb7IM7IeVis4JIJBRCrqfqV1IqdhPFqaGEOdXijJh334bvzyeJWswOz7miCHr2TViUZsG8qFPav7cXn9GEwx4HuaL1OcPag0kRS69HnPf/tStjY7MZZppQwmmsVIPPV5/fP8I6uWSn2oMaMU75GoNG9Na45aqbaKtmWOENfsQwVxaSYdyBu0s/8agW7o781bga5bW0zItATiBOHpRt8j4si6zF8J+HbzAhZWCZPu17ytMNF88172+Ig1lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4B/5okXBpq+z3GJo/J7tkBwRf1FdyhkxBukzxOcFtE0=; b=W/5X+2oxyu5n9Z4STwrB/baRweNgtxoxtZuyhEEhpKqPE0WnKG8GJNPHeK6+yK8FKSB7aItKUyWnzmzO14wkhAw7LmjPdJyXR9Evu3T/RWsaf4Ayo2+otTl7Zt0bEdoHFtYSWgxxdsrk+AsqRTE/hMSAJMPn1kHqfeg12DNIf9A= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by BL1PR11MB5349.namprd11.prod.outlook.com (2603:10b6:208:308::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Fri, 3 Sep 2021 09:42:11 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::ec2a:14c6:a7de:bcb3%6]) with mapi id 15.20.4478.019; Fri, 3 Sep 2021 09:42:11 +0000 From: "Power, Ciara" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v3 2/5] test/crypto: add combined mode tests Thread-Index: AQHXoH7WDhk0tg6QY0eBWiwtc4kI5quSDgwg Date: Fri, 3 Sep 2021 09:42:11 +0000 Message-ID: References: <1628675138-17300-1-git-send-email-anoobj@marvell.com> <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1630644420-1256-3-git-send-email-anoobj@marvell.com> In-Reply-To: <1630644420-1256-3-git-send-email-anoobj@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73666821-24af-4a26-08ad-08d96ebf1adb x-ms-traffictypediagnostic: BL1PR11MB5349: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rjZXS0gXTJrGEKiihjVI47CDuCtIF9R2H9F+GqVWzPrVVshH/VFk7FiAw6RAHDWDDlKxOQkW93BFeVonIgxvoa3h/kwF4mOINGFfX8xj8rgUFXnajET5+e25ETa6dAKgziOs08VUUj40HVfH3S1X7DEVioB47vCmYgbOiXhISTq0TtEX8noju5inh/63cgs4VAhtuq69oEH2po66vivBieg0CjwVGJ9T+xyHOeUxsKmeXPjjltjttVDujQHV96cRsSIOJJb0cNab1Pxnp+5jLyF6n208Xgbv00XMlw0pkgfMyh4Lw7+H6BUXUsNs9k766MgQwPotNyDgFUy/tFnXfMYCJ6rGS9jB139kV/c+X6qxZ4Qywg5OI/olFP5DWDyQEpim1rc5W3u3BSrgMaPQX/Ox88Ju0BNY7u3tpCnEdFn4ttWM3C2zDsglP+gf2aC6nRNJbnX2sk8Sb1auNI0GxGcJk19pNaZgjbjscx58AtpuuP5nvsZ0hhFKyQD71QRNOt/IvSTTTCKJtOd9viNsQ6KxuyeAiaUZNZAJXA7/SENMOyRbEqHrzSmUYKO2gb7nY+NMmHG5b25kiVexOEx4aQo18gdmnzOOWF+M0PzBZy1YqUM1hxUImcFpZrld/I0gfnZh8mbn0JmNP9rl8OCPJicsTKdoCZZ8K6b2XLFkdtayc6xC6Sr3axLCIV4P1kao5YUga8nC2h92lS2AJtRdAw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(8676002)(7696005)(186003)(9686003)(52536014)(26005)(66556008)(6636002)(76116006)(66476007)(33656002)(6506007)(122000001)(66946007)(2906002)(4326008)(55016002)(38070700005)(66446008)(5660300002)(83380400001)(71200400001)(86362001)(54906003)(8936002)(110136005)(508600001)(38100700002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zs9JzRwDQQsQUGy33Jq4vYY4DYE5I3YLvrEUQfNh7bZkUIc3kq3ZK0s8gbyz?= =?us-ascii?Q?sPUShfcVk74AMWFijhZkwQcNem8M83N8THE0P2ELvLMdZA0Rx5p37wnuQH/I?= =?us-ascii?Q?3bLhIyEaUJ7wEAiYlzONGI4zFwid2kc/F4cHDmA+l1J9HlP02jOMl8xjUET6?= =?us-ascii?Q?upo9CuLEc8sPg7PFwChG71DyDlIboUtzJjFN6B9v6qhpKYpBMR7hjOodufj6?= =?us-ascii?Q?XYdorMDgH9AzC9dHWmZXQYUr7TC65oLmSxSejVdcZ1+gYd+lFMZTpOGmZiew?= =?us-ascii?Q?MuegEf6LzPn830Iu/IJU89KqYX6FACl+hZA/RpCg6HQA0D21tkFRv398mCdF?= =?us-ascii?Q?rhFRsPI4PxQMVGOl4G239hXUcNIfMM85NJW3SOnA9xg47gU22osiBVyK9DZR?= =?us-ascii?Q?qyPSuHEzMNb6JryH2hIfCqvdHb1ejTjVkVIdrYoa3HYqeKyBOgvU2SreWqMl?= =?us-ascii?Q?lK3dpm4/HUmeDvgYJkiiymKE9p3HfWP/7py3zv3DpHZVGAYCflxlyYj+oPDf?= =?us-ascii?Q?BB8EPCw4pBLFVamFkBIjmX0qdfAMeyXWrOMUWU99HyWploy476cAKL1MK+zQ?= =?us-ascii?Q?QlMMdmzokwQZGGqq0Q7u4CR0/wPkxLj4V0FH1zrECU9w+8IJQKxOV6sjK8kc?= =?us-ascii?Q?kf0apEdyJY3IkzeMNkNJlDJObgn+MOx68X89A6Jwut5krnlC6MGvcBPggRbY?= =?us-ascii?Q?RTCv7OSY5FmMCJJX3p9P0zg1f/VagZ/6Fvv/PWbRz6gOtYDDWAH6T5e6HP1n?= =?us-ascii?Q?joOhT1lDpbqfcnazut5do36M9x5c7UDueqcoRf0tY5EU/JUPBnysmvbBfGmn?= =?us-ascii?Q?8P3wxEZV2OxiRA9Ke+Yez27PyvaKmic3GkwyMA/ZMcKzCF9qAKblqXsJrHo/?= =?us-ascii?Q?8tnlaCynsFH5af60x9REe3xi7A7ScC3Z+m9pGyqfJsLfyjiw8cDC32d2VGoo?= =?us-ascii?Q?7Paa42JcN9vgBkY3oxVMplq+7V2j8rai2TpJ3bwCusPfewr8FwgWDIz5NrgV?= =?us-ascii?Q?XWoBNZ1G5DrFgl7+vgXtMC4vdfrf0Jevt69/FbMr24cTn7cZ8nfojv3CVHCL?= =?us-ascii?Q?rFo3Ci8kwKnnrm/+DWSicHGnJ4iBAg8Y+vvFU+WJuIcrSa/8kQxfy94Mrohk?= =?us-ascii?Q?WUHlO1vwl0ul4lQqPIulIhx/pULbvDOPN9EM+up/SkaWQ9KdLx9ovWACKSYp?= =?us-ascii?Q?cEMrAHAc3gvdMoGk13UlCMDo5UqTpzgE5ZxYxyJLSac3mkO5/IcWZk2KASXQ?= =?us-ascii?Q?I/jvTFocN1vv0wETRBF5gg/xNMAwYSabFEWoBt1yOe8Ipj+69qJViBi/+DRs?= =?us-ascii?Q?2Ds=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73666821-24af-4a26-08ad-08d96ebf1adb X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 09:42:11.7487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yvQBcFgQW+pSs8EI/qQRqjMe5LklBOGsgmSb0zK49hAcAF2c+p6q02M8gSpyHYOpKKtQUiYu8CHQ3YwOr/aYrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5349 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob,=20 >-----Original Message----- >From: Anoob Joseph >Sent: Friday 3 September 2021 05:47 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; >Ananyev, Konstantin >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara >; Gagandeep Singh ; dev@dpdk.org >Subject: [PATCH v3 2/5] test/crypto: add combined mode tests > >Add framework to test IPsec features with all supported combinations of ci= phers. > >Signed-off-by: Anoob Joseph >Signed-off-by: Tejasree Kondoj >--- >+static int >+test_ipsec_proto_all(const struct ipsec_test_flags *flags) { >+ struct ipsec_test_data td_outb[IPSEC_TEST_PACKETS_MAX]; >+ struct ipsec_test_data td_inb[IPSEC_TEST_PACKETS_MAX]; >+ unsigned int i, nb_pkts =3D 1, pass_cnt =3D 0; >+ int ret; >+ Is this testcase actually running multiple testcases under the hood? I wonder could it be suited to use a sub-testsuite structure to bring the t= estcase results up to the top level, as done with cryptodev blockcipher tes= ts. Have you considered this approach? Thanks, Ciara >+ for (i =3D 0; i < RTE_DIM(aead_list); i++) { >+ test_ipsec_td_prepare(&aead_list[i], >+ NULL, >+ flags, >+ td_outb, >+ nb_pkts); >+ >+ ret =3D test_ipsec_proto_process(td_outb, td_inb, nb_pkts, true, >+ flags); >+ if (ret =3D=3D TEST_SKIPPED) >+ continue; >+ >+ if (ret =3D=3D TEST_FAILED) >+ return TEST_FAILED; >+ >+ test_ipsec_td_update(td_inb, td_outb, nb_pkts, flags); >+ >+ ret =3D test_ipsec_proto_process(td_inb, NULL, nb_pkts, true, >+ flags); >+ if (ret =3D=3D TEST_SKIPPED) >+ continue; >+ >+ if (ret =3D=3D TEST_FAILED) >+ return TEST_FAILED; >+ >+ if (flags->display_alg) >+ test_ipsec_display_alg(&aead_list[i], NULL); >+ >+ pass_cnt++; >+ } >+ >+ if (pass_cnt > 0) >+ return TEST_SUCCESS; >+ else >+ return TEST_SKIPPED; >+} >+