From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3355FA0C45; Wed, 22 Sep 2021 10:43:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABD0741196; Wed, 22 Sep 2021 10:43:19 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 87A4E4069E; Wed, 22 Sep 2021 10:43:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="223580837" X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="223580837" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 01:43:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="613317126" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2021 01:43:16 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 01:43:15 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 01:43:15 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 01:43:15 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 01:43:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7xGpEbnoW6Bji6YwV+XLUal7NpIDpAPoi11ypcOq9yRlUzI5yrLKbkaFFTY3zLNu2uWy2dB6AZyMfyxYFDgS3BcdF+98AR/3qfbtaNVe17nbBU9Zs7+866TNz/Uht30Rm4xWajuYZPCKxRJvwlFH90Od/KZEJ/g+cXC7CBKB1LQYdNUNoCXuTGJX2XXVlOVs+2gLj/dZxvfz0UfQk5qN2iTJOFGrM11yR5Gi0WNdnnZefANXqVc/Lw98hoq5NkA6+AaNoMNIxxi+vXm6WvWROtMzFXK3vM75/Ep7zmuvI3wF07iqLpn9bk8EB24xBXrmAd/XettTjADNf7i2nhbIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n3I13p+Hr8rGXgbdob9WIBJv3Ok/Zxfk+JQFrFY2NsU=; b=Ox+hrEoEKxFZYsK6EyF79m2yRDKd97mn7VHzbFmmuGpNeEIwoP73WhDq7biY/JTu0Cthg8ltNczCvHJB619jZOyulsGsAd/NLicRiVc/HsC5dsfDdKF1k9dH3PvNI0pEF9i4TWGONeG5/bTpPSEEtiRptWbi0cmpSydFASJYdGJzf4gF0L/Bz8wVG0S6v/SJsvCpiC4zZdUGK0Gppzr/Q0JhzVPjHtiXMBKqWUFOcGcLZLOJ655hN0dY/DRj/kzQyyARg0laC2DR4mLe6aQRVQ9G/l1uaGPNQc5invCv3PmRiEVNS9V5h7y0PqnfOOYv2oxVkhZnwKmprlFyWLbGoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n3I13p+Hr8rGXgbdob9WIBJv3Ok/Zxfk+JQFrFY2NsU=; b=EnN9iXa/skj0Kextg9zk2tgm3uH+x88svmTkjtC7zrmbmFL75SfQub+RpaT+7cKkk69+aN7tvdcnUhJEdHyU6GfHpEF+I2rqaXOaSuLewFfQbcB4DPWPu1UJbC4c0X0zXBsbgTUIOsRoCs+wxQd62wERY+H0fckaORp2zUNWHJY= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB4014.namprd11.prod.outlook.com (2603:10b6:208:137::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 22 Sep 2021 08:43:12 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4544.013; Wed, 22 Sep 2021 08:43:12 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Burakov, Anatoly" , "stable@dpdk.org" , David Marchand Thread-Topic: [PATCH] telemetry: fix "in-memory" process socket conflicts Thread-Index: AQHXqjuB2UKdRiIcqUKh/+K7dYZADKuvxXqw Date: Wed, 22 Sep 2021 08:43:12 +0000 Message-ID: References: <20210915141030.23514-1-bruce.richardson@intel.com> In-Reply-To: <20210915141030.23514-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 31ad801b-9e84-487a-71bc-08d97da50359 x-ms-traffictypediagnostic: MN2PR11MB4014: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E7EYXa0+qYHQ/lvhZkiYMrR5SfIqKBDd4HuDPn+gWry5wlbFNfKx+igifHGtoatsQ4uDXolFtmFTNHttzS0vYUV3SJ2X1vJOH0d/4iayTxbchPz6+CmtaqzwhTKTrtr2K7jl0t9SGU/LhSUxmze+YbI8sgFwR2lShPUfLYFvxiSbydZDVosuH4a+FPvRsFbRiwk5oZcf0t7a3966q6TE1jDtdpe8BPdCAgpkuaybXwQDBmNPLPpszNptZF/P24bxpFQ3wOR3KprIV59bEYdptU8RNI/+YJiz/ZiK0G/8pwdxhC8oUwPCxI2NVslPPY79FbYVQbiGKQFY6q9kTQ8sgifIuUy/069yvcOYj9YvCKEcppID2651fdsVehW94VrehC6EB3762m7A9oBLu0s6WM3iwKT2y5jtb4ApLjq/W2IE/BTDq6Sl4KvZ4Eg7muKef+N7IjDEH9cf8oup+08Zsk1aGeWOGw0fBJJWkJfUE2lNXVOyqDgvCB3pjMg08Do1t8iOIg31faLvDu/FIqWE5/bw0vpDAT2RN5cjDOswwYJdaAaqoQhsyjRvJvI4cZN5Q23w6F0Tpn2bVnv3PGPFLsCGLFKhNYRxE27IWt9yj7cgiSjA+JCABXGEby0JLaVVFO8ZkAwFu+5xuog6jZ2K2dVtEdsmn5TKs3/qNulJiOQqqQQa+Cud3VfQLtdgFK896bdLSiY50ksFFUpd07xtoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(7696005)(186003)(33656002)(38100700002)(38070700005)(71200400001)(52536014)(55016002)(122000001)(8676002)(9686003)(8936002)(110136005)(2906002)(54906003)(66476007)(66556008)(66446008)(66946007)(76116006)(64756008)(316002)(86362001)(83380400001)(5660300002)(6506007)(26005)(4326008)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Aqjp7pTorEMCMWsPcNbDM6lK8SxGBUJImtxM50RVUK7BbMbOHDPNaZQn1oW?= =?us-ascii?Q?F00HtS7OdA2W21rqCQZZUGGfcrZimwrI3xJr6C15b2jiCcekMUavRKsYLmT7?= =?us-ascii?Q?EjieTBrPHjXBZPqNC/BBBuRax+SHT+0vz6CKJn+7DfEvdkjSxY2gRPY81sJI?= =?us-ascii?Q?8Ogar3UG+IvpV6fqTCJ0l/nsixn+Uj6Jg0dLmzgH820pSfdIkd4jKD1D4KMU?= =?us-ascii?Q?KKZdznbg+c+MExCfGJ3pKvWckhW6P2uJvS8RgqzFy+ykZwSgLyltkCatcxPm?= =?us-ascii?Q?9ZVFTdZqVd7bhg6ZGHKr4UX8ujDZ7krrFtSQwz4Z+oOqGrVDiJ4k7FKNuM36?= =?us-ascii?Q?euLWhc43oxQkt6vhbnYhiRyYrA0OOmWmZVqKr1SHWUzJ+aKeF4+lIbKG56tT?= =?us-ascii?Q?oKq3Hvgak75SemB7F54qlX73JuMO76LjP1aeSQJzNmANJobTtve8ZsFx9F5R?= =?us-ascii?Q?gXhwlObkxi+312hxvDsgGZrVesd1HLTzwtCaOuNp/aSNBgHdX9NR4GcbJ1hu?= =?us-ascii?Q?dCHEsmxEfNFgSuPBVa5pwfJ7+XCyGl3mUXa5rU7MmqbsmkjZILzxhgY+bv0A?= =?us-ascii?Q?BNAJlwxojJRViczf2+xQnUKuRj10B2II9+dMtE+Ox7jFotc8HJh7cQI19NUh?= =?us-ascii?Q?BN7QxvBLhHgLKTu80b7oaVBHKtD+8Lg9sXtoeaTvvEeUUEWWD5n7bCowHMpF?= =?us-ascii?Q?PGimh7oPOA232eq1bv0RgLcIxbHzz/gRy+9R7aldCqe6d/ZwjkjVEmdQu5HQ?= =?us-ascii?Q?W7SFdmPeuYEFS/oNmP2DFGuykj6jvvlr5GGTcEAEehUWWKOMaAQSQEOOO5UJ?= =?us-ascii?Q?ATaVBSfYUuA0Mh7hmQwUSO1KUnxzICUUyFTLDjsogKwhEdwxLiMNMKA4MlPT?= =?us-ascii?Q?D1Eb60Y06l3lqoZ5FwVxrzgPHf1waGRJN+J2uyx+QVM9cEiaziJ+TM3UbjmM?= =?us-ascii?Q?ZCUUbSFNiRmJjXM65TEN6o1amyjVQHxg+9OYSBHYz7BFGt3IV1ykO8ignY9K?= =?us-ascii?Q?pD8R9wVSeb+n6aBk1BXCOAgFlaELu/QMqvUejB13bQcw2/iZo54vVkO+GZkJ?= =?us-ascii?Q?3g1dkSZ0kMeVFNFggcHQqRSOp5f/fFZUNEzhZ4+45WK4KTz2npfIh+WfBbBe?= =?us-ascii?Q?dUD+AMoy+0Zew4q+uzVUaySDGiimid0yDQoDxoDFV2DHOwZUFS10tCcxK6bB?= =?us-ascii?Q?RCYio5yeFDHjw/HTIhzzFZZhUIEmUcyBY7VyTsqoSEtfDgeCQh1T3chMJy1g?= =?us-ascii?Q?8K1KZlzQxbUFYNreI8Qn/M8u4CNwx9z8r5DIpKp9AeZS021FX8jbb7VzJH6t?= =?us-ascii?Q?w6/Kjx7+F9fUeVerr+5e9hV5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31ad801b-9e84-487a-71bc-08d97da50359 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 08:43:12.7376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: njTRTxJuhs5TZXKVygrQO+fY2YkAogeTVf2IvCMIKNxwiIiaqwnRZkU+6Z37y1Sdoz6B5+MSri9E6hysGWp3zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4014 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] telemetry: fix "in-memory" process socket conflicts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, >-----Original Message----- >From: Richardson, Bruce >Sent: Wednesday 15 September 2021 15:11 >To: dev@dpdk.org >Cc: Power, Ciara ; Burakov, Anatoly >; Richardson, Bruce >; stable@dpdk.org; David Marchand > >Subject: [PATCH] telemetry: fix "in-memory" process socket conflicts > >When DPDK is run with --in-memory mode, multiple processes can run >simultaneously using the same runtime dir. This leads to each process >removing another process' telemetry socket as it started up, giving >unexpected behaviour. > >This patch changes that behaviour to first check if the existing socket is= active. >If not, it's an old socket to be cleaned up and can be removed. If it is a= ctive, >telemetry initialization fails and an error message is printed out giving >instructions on how to remove the error; either by using file-prefix to ha= ve a >different runtime dir (and therefore socket path) or by disabling telemetr= y if it >not needed. > >Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") >Cc: stable@dpdk.org > >Reported-by: David Marchand >Signed-off-by: Bruce Richardson >--- > lib/telemetry/telemetry.c | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > Patch looks good overall, although I see CI is reporting some problems for = FreeBSD: ../lib/telemetry/telemetry.c:435:21: error: incompatible pointer types pass= ing 'struct sockaddr_un *' to parameter of type 'const struct sockaddr *' [= -Werror,-Wincompatible-pointer-types] if (connect(sock, &sun, sizeof(sun)) =3D=3D 0) { ^~~~ /usr/include/sys/socket.h:662:41: note: passing argument to parameter here int connect(int, const struct sockaddr *, socklen_t); ^ 1 error generated. Thanks, Ciara