From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E488FA0C41; Thu, 30 Sep 2021 10:47:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77331410EA; Thu, 30 Sep 2021 10:47:52 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 648614067E for ; Thu, 30 Sep 2021 10:47:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="212216810" X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="212216810" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 01:47:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="563958734" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 30 Sep 2021 01:47:49 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 01:47:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 01:47:48 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 01:47:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yz9BWeTDeKVgmUT8WJsqFimm7tkWTsdM1/f54QnHWM/QhcLg134ruaz97FVBee2ctn0P6Fcgz4/uOSPcq4INy6oprC70DiVNyf4339TNcAHbybBQ0wR9BFGeFRCsnCLeMY1ldpnMueXT/xI1/qd6f3xdTpWjwrdDMKP/1ifQycHf5h5GmeOtY2p55vjbP0RyMgi93Uil7Zht+yGPPqJdE/GLwaZTwKlClNC1GxV9J+LSmCjXH5qmbjs+F0IANgGMpykbWHuiKwkPp4LQ7eGOFy47m/OyWpsfTkZc8qhWmPq8kGXIROuKshhKD9S7Bdwfx2eFuXxbhc/G4nTl2D5kzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7t/E/y9xBcrZGHzCi6yZQgpqLnZAZa7DHspnwoGgM78=; b=eXSHIXpYU8OaQK/uAYivMlYK0+6lztnY1N2UIat9U1mEewhmYm8PQHY+fKlk/sKLR4trrJN8g8+B1AaWf2tjh5Ahv3qeIBIIdZCijUwXgkPEYQyUG1c/IWcECv/IEyNHCbW+lMQ0Ijqmtx1I+czcPKHKYPlDn6Wa+MWhViK1u50766TkMsSLm+h9miBClrUD5NW/AqNexA6XRy5lk8fTM/GVjtqBZ5Hhk94yE94rTKsV1r39ehGDGL/KYlxuYwuER9xDn44vUYH9WfXjRxZVK+e7nE9Xrx6RCjtf6fISFlZ4HfVkVViGcEwN58MI9j7tFfuIp06KmIrZcRz9IklJMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7t/E/y9xBcrZGHzCi6yZQgpqLnZAZa7DHspnwoGgM78=; b=N/MtAhPsqcCJ3N1jZxGLqdSKhVonjG+UAcIupY84u3+i4DUZRhMnMuNTr2nFVMu15Zx2ovk9uWZkmBnljt/nFS/V7exk+junOX9UqTwLiW4quQd8hXxspmvvXCXNgUgrMgAZBb43zGBYneMF8cfjPU2Yl2Aw8bQ9hZmGZK7p3s8= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3871.namprd11.prod.outlook.com (2603:10b6:208:13c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13; Thu, 30 Sep 2021 08:47:46 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4566.014; Thu, 30 Sep 2021 08:47:46 +0000 From: "Power, Ciara" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [v2] telemetry: fix json output buffer size Thread-Index: AQHXrthAvQTHEc+Z0EiUoJioWg7zR6uvxxUggAFZ2gCACzB9MA== Date: Thu, 30 Sep 2021 08:47:46 +0000 Message-ID: References: <5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com> <20210921110243.1919933-1-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 126bc3fe-6366-450e-38aa-08d983eef9b2 x-ms-traffictypediagnostic: MN2PR11MB3871: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Q6yAXa3YhylqoXd/IZJT2yB1eKtuVkCNjEa0TRivxNjfzsTvcWIBWu7KYCeOx2rU7CdyU5SiZP0CzJQHCgvdWuhGBP+OYWvLZAmn8uwubsF6qWPLK7E44FwS8lvef9V+uRXnyecbuijc++jXgQsBk4ftkHXW0WbprobMLKeO292AtfPUGCC8nhegeMjVBhItL8BLwpZluVt2FC1GpnCem9oVlTwSgqvx1hYJtE5JTQFhJdHSkkM1XD+SiodEuBlGyIH0JmlJR0LvUXkROofu2YSvzk0tZku13TH8acSwcfyqH6Foc9jLcagMRAo5yq59s0+4ZqtleIKHdPQw/WXaqY1PShcJk++3gZIIaL922X/x7KdVTl93qFLv6XQg3XIyywALBc3q+gFk/rU2mjuDP+qAHWqNMbSzeTgFb1X9ZA0jFVW7qFsOHKoNcBt66sA9XQ9n03MuP3yyuU+S1lJhyPbHa6CCqeLMmf7ZvfDtOcnMUjfXvWt9ISAgqbVwNVNe+h1qwsrzYXpuFFRV5m7bCVhpT7vMKZNDBmUnZy+SdknATyvLNGWLYcdn8JxhKjF98yGduTdU+Wg/GI7lXiSnQ25EV2fXrjLQxb9WZWE6NW5t1ve6ic1S+1BxsdD3PCRAVtqlMW4Dph6yvA8/2X2egxBgrwba3lAZjAyQq4+6UF825pPg9zQ3rV6sqsiID1IHYwzZ4w5+QsV0mEFiTrMmA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(2906002)(316002)(8936002)(5660300002)(83380400001)(71200400001)(38100700002)(55016002)(66446008)(76116006)(33656002)(66556008)(66946007)(66476007)(7696005)(64756008)(110136005)(8676002)(52536014)(9686003)(107886003)(186003)(4326008)(6506007)(38070700005)(122000001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?55F/RpMlf4BIC7bO8Ay32SIv8SiuREybny9msPDXtBBhu20kxPo3S6cW0lpf?= =?us-ascii?Q?Y5oO4hIASx+VL3B/1lgcbvmMFjzBlK+39YdJ7kHF5uXj4O/2HwF51wgfaCn/?= =?us-ascii?Q?/oSRefV5Rh7fCYv0idE+SmxA5uCDY1MWylNk4+QUXJDqOLNwpVjlNrgGRxEW?= =?us-ascii?Q?MRtSinP2ntyUeVUwZy7KQX86YF5Ccp1oCCQvi0Teqds8i3uTZBzsFVwRybxG?= =?us-ascii?Q?aW+4BIfdj8Z9sGdPl1etoMrAwPz+wMnx9htRXkTV5IolHhC/xZHcZFp/w8fI?= =?us-ascii?Q?Dshsu7Fv1StD9YgQTAHH1AXf77dThNxcYUkenaXzf1d7CvhucxK25lm3KCXq?= =?us-ascii?Q?8kMRshlvNIE4TUTSHPbtYGDV03aDaBBcYk31fzj3HbocbTI6RzZnXzMXd8Ey?= =?us-ascii?Q?1K+JHWUuzl5SUCPtY82VjyAa2ikcIJ8lKM315vIswj7uYYqy1P/zP0vS1TJg?= =?us-ascii?Q?ACxsqlt/hmU0Z9b9ur9x9TJIoOAosSeiZ7EalBuS9AJrJuXQubdvNUz+GNIU?= =?us-ascii?Q?CDFK60YFdVn+RZEspdiqxr0aEzHK0JqWhXut8uSLeR4L+FAFU41TQatUHbdn?= =?us-ascii?Q?Vl70s+lqPLVwhqNGJF3iU9WwL+tLCdezRHnRn7knfEMcjKRngkeXY7v7wpst?= =?us-ascii?Q?6nK8P1JVjIXA45fXqE0GrjRxu3Rt+NruEGVzM+HUhBnPEfpbCWgubJoacPnr?= =?us-ascii?Q?JW3y+XEe/ou7dDGEjHdYaM8jR+wp2I4xlI73SPRUVD2N+ZVGwUtf9XE0DbHC?= =?us-ascii?Q?eozQnMMWdQTNWC2F4jB83Ww+9v9pft5Sh0sGmdXXt6lfqHw0tb7QiEN9pXow?= =?us-ascii?Q?f+AlMPRhPrFVa+5HIAgYJIkkpbu7jcmYhXTS3Nok8nn1wsEz/iVOPfSzEPug?= =?us-ascii?Q?q7WudhB65OKGZYTaRwSxcAuYl1ttMZy9urcsygoN5v7NVaJEtDcRMVOc7Wsp?= =?us-ascii?Q?TVVwgllGCW6/5MT2RW3i5jveEyweF1IF3UUGGsn84De4QxVRvXGH4u0LJWxS?= =?us-ascii?Q?gEvT4tx7APT7s3g8wfi26DP1RBVxKfy8eQr3mQT0vXjc4dE7jypsCryVc4oM?= =?us-ascii?Q?i6AJ75UPHHZloQrFBRQ2pweKqdTA6UgVO0rXDcSte4kC2bSVTlWLfej1/ImD?= =?us-ascii?Q?RErzv0iZO3ca2hWEIdbWztEUgfphB9PKLF8Qub+WVLHObD30jyKhqCd8wBX0?= =?us-ascii?Q?s/mfAU88T0gF/KoI01MUlnCdnKNPHVAIfk47E/shPq2LUn3SJKVtljC9gb2J?= =?us-ascii?Q?CICOS6fZ4xZl43IZ7QgWXSvz35zZDpkh28i0NNgOai4vhpLHFC511cI0Onxa?= =?us-ascii?Q?AykRuv0dmhdquXfEse09Iq4C+wRcRFgJyfRJR1sIIemBVnc7gY7UqlTxA6Pp?= =?us-ascii?Q?F0uH9gZ2/CpIpERnjgJOA+R8Kifh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 126bc3fe-6366-450e-38aa-08d983eef9b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 08:47:46.2618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8GM1CDa3qUrCmpEEzWkJ5a5VIdc6mDB8Tq05SphwSRc5HFCgUEBIYktOjSs2BrH43BnshebHvNGvTu5+xNwi9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3871 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v2] telemetry: fix json output buffer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gowrishankar, >-----Original Message----- >From: Gowrishankar Muthukrishnan >Sent: Thursday 23 September 2021 06:53 >To: Power, Ciara ; dev@dpdk.org >Cc: Richardson, Bruce >Subject: RE: [v2] telemetry: fix json output buffer size > >Hi Ciara, >> I am not sure about why we would want this to allow for >> "RTE_TEL_MAX_SINGLE_STRING_LEN - 6". >> The RTE_TEL_MAX_SINGLE_STRING_LEN is used to represent the max size >of a >> singular string value e.g. the response to client being {"" : "value >> here up to max size in length>" } >> >> I wonder could we use the "len" parameter in some way here, that would >> be the available space to be filled of the "buf" being passed in, >> allowing the function to copy in the maximum amount to fill the buffer. > >Got it. Yeah, "len" is actual available space. I ll send next version base= d on this. > >Also, I propose if we can have platform defined upper limits (esp >MAX_CMD_LEN, MAX_SINGLE_STRING_LEN etc) so that, we need not revisit >lib/telemetry for platform needs (and I don't think one size fits all plat= form, >may be excess too). >Thoughts ? I am not sure why it is needed to have limits defined per platform - can yo= u explain further about why it is necessary? Thanks, Ciara > >Thanks, >Gowrishankar > >> >> Thanks, >> Ciara