From: "Power, Ciara" <ciara.power@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"aconole@redhat.com" <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc/guides: add details for new test structure
Date: Tue, 3 Aug 2021 12:11:28 +0000 [thread overview]
Message-ID: <MN2PR11MB38213AD2C7607BA1ACFD2C37E6F09@MN2PR11MB3821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2341002.Dq8tm8rJDb@thomas>
>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Saturday 31 July 2021 18:42
>To: Power, Ciara <ciara.power@intel.com>
>Cc: dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty,
>Declan <declan.doherty@intel.com>; aconole@redhat.com
>Subject: Re: [dpdk-dev] [PATCH v2] doc/guides: add details for new test
>structure
>
>16/07/2021 15:40, Ciara Power:
>> The testing guide is now updated to include details about using
>> sub-testsuites. Some example code is given to demonstrate how they can
>> be used.
>
>The trend is to avoid adding code in the doc, but include some existing code
>with literalinclude instead.
>Can it be applied here?
>
Hi Thomas, thanks for the review.
I considered this when creating the patch, but chose to follow the style of the example in Aaron's doc patch for consistency.
To include existing code, it would need to be functions from the cryptodev autotest, but I feel there would be extra code that isn't needed to demonstrate using this framework.
I tried to keep the example as simple and short as possible to help with understanding.
Thanks,
Ciara
next prev parent reply other threads:[~2021-08-03 12:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:55 [dpdk-dev] [PATCH] " Ciara Power
2021-05-17 18:01 ` Aaron Conole
2021-05-18 14:30 ` Power, Ciara
2021-07-16 13:40 ` [dpdk-dev] [PATCH v2] " Ciara Power
2021-07-19 11:06 ` Zhang, Roy Fan
2021-07-31 17:41 ` Thomas Monjalon
2021-08-03 12:11 ` Power, Ciara [this message]
2021-08-06 10:00 ` Mcnamara, John
2021-10-18 14:50 ` [dpdk-dev] [PATCH v3] " Ciara Power
2021-10-18 14:54 ` Power, Ciara
2021-11-26 16:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB38213AD2C7607BA1ACFD2C37E6F09@MN2PR11MB3821.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=aconole@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).