From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F67DA0A02; Thu, 14 Jan 2021 16:06:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82EE3141352; Thu, 14 Jan 2021 16:06:22 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id CDB1314134D; Thu, 14 Jan 2021 16:06:20 +0100 (CET) IronPort-SDR: rGQe6/7eqAMRG4SR06tjUaZ25ALdDEuM1alEGuHmOiSgIx17tB9WpDheKjI+Dc1LvBI6yxqRy9 5l50qECPNplQ== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="178531233" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178531233" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 07:06:17 -0800 IronPort-SDR: Z3j2Fqg7nkIWRklqvKHJ5BgO/kmbNnP9mGv8z19N90PgHlKhfKCMfLEIdq1CmEXoqgd7KiV2dc nAcgYgC9uqVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="465276579" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 14 Jan 2021 07:06:17 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 14 Jan 2021 07:06:16 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 14 Jan 2021 07:06:16 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 14 Jan 2021 07:06:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bj2bVxdedzSW9K7qTbpjazz9Gde9O6uqT6WvqmSusmMJyvDi7yPMAzesiFhF37H5zLXtrBcirWNjn1y7O4wzGJtQsh7euZ8mRbS2g443SABhXktrMqvMLyIo4LZPTcbml11GTnJkPFonD8II6OI8A9XZxg+1UPGCRl0pAHlCXnFSqiqLy5r2LxJ1kVk4ncjyuKcxTtdSodLHKhFFiPWLvEgxxlp2xg8NOeotwS3BfuSpVf4sBWizgzwYCcduIDh6lrgMAWnBWkk1cex38Ijiv4wOL0dZcXtRZ2GS1u+zTlVDsmQncqDh1QQxDvBL+c6cvPPH67ujB8f7L14HPVYlKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76PYvQF6Hng00EheG6bNi5Sh92AoZbP/rAhuoZp6vrE=; b=E0J/DnrTQy5/qd6zPiTS54514p2tTZjIgUNCCgGrGK1QfDlhp5r1BqZXiHXHEe1et/ew781sgPW1R532ArGuOZpWQ68mhkaA7wQIVaIjvc1+rUSYKgKnV+dxQi8Qby/zGVTVlXQFCTeghsZjBA4QrUEMkw0he2TX3MiESkfEeZ0dkZgh76qYMi4dZL8GEvRh+R/TEi2wHN33W5C0mdiVtDJa03GEfIMVrJSArv8K6u8+o8mfYHboRsNfFr7StZNoMg5GZnEkAJEHT7AtTbJwH2QxOYw7n+D/wk3BJ0+vKOZjDYAK6Ot/H3eXfYGipcqDN5NcZ7Ocy40IkSw/7CgPuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76PYvQF6Hng00EheG6bNi5Sh92AoZbP/rAhuoZp6vrE=; b=fMlMNbmIeeY3rZtcBYUDg6N4CaoAA6EYgpXgCLRSxvbThEcSMDJnF7oLork/5e8LThF+4gkqGIwzYZAxJbQlBv12CacFQCwn//pN8YsxLgNYnj8nzgb+ga8VdGECr4ZbsOtBjgVFWjpV+/RXuOz6dVFloCSiesXP+yenc+fN4EI= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3567.namprd11.prod.outlook.com (2603:10b6:208:ed::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.11; Thu, 14 Jan 2021 15:06:13 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::57a:d13a:782:bc31]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::57a:d13a:782:bc31%6]) with mapi id 15.20.3742.012; Thu, 14 Jan 2021 15:06:13 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "stable@dpdk.org" , Thomas Monjalon , "Yigit, Ferruh" , "Andrew Rybchenko" , "Wiles, Keith" Thread-Topic: [PATCH] ethdev: avoid blocking telemetry callback for link status Thread-Index: AQHW6m+tXy34YmGOuEC2pABc3v88GaonOExQ Date: Thu, 14 Jan 2021 15:06:13 +0000 Message-ID: References: <20210114121733.46801-1-bruce.richardson@intel.com> In-Reply-To: <20210114121733.46801-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4486e182-9b8b-47e8-3d00-08d8b89def1e x-ms-traffictypediagnostic: MN2PR11MB3567: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V+LAJnqq58eWK3bq1LQXbQed06ICstCKSkqDI4TcM8AQqlTvEaJe1nB7sW9N/df+NeT+hM3t/AGk/VpITJQxHveW2g162xLJ6FgeA/tvsC7wwsRW4gXnX207tRpy6Skgl9ASn8icAkeyT6mIPNKBXz8uPUQ4r7W3RlXs3IOQeDKqALKuW1J4yNbOiqIIEcaVm6GLyQqwMUzuFF7QFVSoTPYDuAYt2h9aRPtR4CKMqCFLXTZn8OYB4niA5vt/x7wW8t/sPOgyYWL4B2WSNDuhJD8ksZzOcKvS5quFxmYVrgsy4QnTJ8zNGhuhJbO8sJ9exFlks+J0a+Ko/f/SaaEqEUuIjqT1e6jcvpC+aTxUchkhJiUUNkmn06/iLjOa2gLUgy2cw7QY0Ab7kuFBoMUXBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(8676002)(66946007)(76116006)(186003)(8936002)(83380400001)(64756008)(52536014)(26005)(6506007)(66446008)(66476007)(66556008)(5660300002)(2906002)(71200400001)(7696005)(478600001)(54906003)(110136005)(316002)(55016002)(9686003)(33656002)(4326008)(86362001)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Tz0iJCJZWztvuO5dG3cu71Ch11UEWvSOXrlWlg9zNoPIkAbsShMDSav4eNvR?= =?us-ascii?Q?+BVbO/C77v0g1NLHWWwd/pNdeAueRQuCYoSQch2KrDLgJ/5NfBzknQJEmKcA?= =?us-ascii?Q?N9fHuPEOmtFWh2KV2MJP8AdSgl8cnIX32kbvuxojIy37yo1hIG6TuFn6u+58?= =?us-ascii?Q?l7CBO/+Vdf+S58ttdXo1ePu9VPEyJ5ru03q94iGjKeqO5BPHYv0SVm9PLBX0?= =?us-ascii?Q?cmiww9arN1+AZkNW7W1MV4C8wifmK4Rn+RB6Bc+cWmH9wkEMYZK5zlUFHQbL?= =?us-ascii?Q?3Praf70rWRo5Z5/rr5K6KnJ2dif/d5OqHccSgZDVZ7aVr1gNMYnGyXwSakq0?= =?us-ascii?Q?r4Ypc8uPiXUGEuUc/n+uxiwh+YHjAeBfDyYCXn0qDr0KdNrJZqqWikugCJhn?= =?us-ascii?Q?515iY/E7WRACHShrHkoAOi+weAR/JdK0jtGjbREITvIAmwG63G6ZviPpNDWM?= =?us-ascii?Q?sgj+RhememzT3yOncKJYAWOWzVqofd8Jf6eJ3M6I61Fqv0iw9tkdcgQeZVJ8?= =?us-ascii?Q?pIqQejoLT0XNVn1OG9SZGiiKWoadyEZIUHiG9XhVkvLnOAkkIrLGFUtXzpwN?= =?us-ascii?Q?CCNWWiLsg2mA8WsZPDnGH39PEDSVjDr6bHcPoS3L6gvPIw4Vx7mk/fVZVxzj?= =?us-ascii?Q?rzgqxQa0pRKNkLj86DASxwWH1PqaJe566CQKoQT5r47dm9w5fgiqnnxpFiaV?= =?us-ascii?Q?2VFmcvTXILfY/aHVhyRrFz8M8shvJoto7VDMUqyrUMmvWJxpcYwQzYjkxevr?= =?us-ascii?Q?tNdpTnzRhXp5r6Voh1gGn9pgGZUcUTWcq26fyl9U0u4baTu1aDE9L6DOjR+e?= =?us-ascii?Q?lJ916A6LwcOWAnpU3c5LndIrm5noVIYnFiLqukY7jceZy6s0C3M0oqKky+vT?= =?us-ascii?Q?nGB3tWt3byXlk4q4K4/V4PI1KukXEO+httALUy1xCYXyw8yRfpg/tNNXYS6g?= =?us-ascii?Q?8jhbeEYWHLz6clQ90kp9wGYpgTp+vjbM+YyZrVUn3MU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4486e182-9b8b-47e8-3d00-08d8b89def1e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2021 15:06:13.2078 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kDu1rFZYOG0LegjeL/YpKnQOnsrXMKv1eC60lOIVX99p9Jq/1ojgGpIAZYe6TcyYZCw6o+1Kf8oeIdgo3mWLOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3567 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid blocking telemetry callback for link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, >-----Original Message----- >From: Richardson, Bruce >Sent: Thursday 14 January 2021 12:18 >To: dev@dpdk.org >Cc: Richardson, Bruce ; stable@dpdk.org; >Thomas Monjalon ; Yigit, Ferruh >; Andrew Rybchenko >; Power, Ciara ; >Wiles, Keith >Subject: [PATCH] ethdev: avoid blocking telemetry callback for link status > >When querying the link status via telemetry interface, we don't want the >client to have to wait for multiple seconds for a reply. Therefore use >"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the teleme= try >callback. > >Cc: stable@dpdk.org >Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") > >Signed-off-by: Bruce Richardson >--- > lib/librte_ethdev/rte_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev= .c >index 17ddacc78..1f4545fe0 100644 >--- a/lib/librte_ethdev/rte_ethdev.c >+++ b/lib/librte_ethdev/rte_ethdev.c >@@ -5692,7 +5692,7 @@ eth_dev_handle_port_link_status(const char *cmd >__rte_unused, > if (!rte_eth_dev_is_valid_port(port_id)) > return -1; > >- ret =3D rte_eth_link_get(port_id, &link); >+ ret =3D rte_eth_link_get_nowait(port_id, &link); > if (ret < 0) > return -1; > >-- >2.27.0 This change looks good to me. Acked-by: Ciara Power