From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBE4CA0C47; Thu, 7 Oct 2021 17:47:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47596411EC; Thu, 7 Oct 2021 17:47:47 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 66947411E2 for ; Thu, 7 Oct 2021 17:47:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="287169525" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="287169525" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 08:47:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="522642357" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 07 Oct 2021 08:47:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 08:47:23 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 08:47:22 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 7 Oct 2021 08:47:22 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 7 Oct 2021 08:47:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLD7iM6G8En2Kg1XhZt2jByJhXYsKy3NCwrgkvskTIiHMxc0ZfuoTbxvUdIcwK1UzEsg4xYs/TjkEchk3cOIZhxTlNCmgFp/KwnVU0ZfVTHh4zUl4zBX7ydcAknckfcHySmxYhMgqDbeaSC3VbiwpmOkcnGGLM4LqFLbmvEqjt3Juswn+uUUTunpanhN7FuzPgSViS08SOSZXeQcW/R2P7HzNmXNDQnTkUyCBUmXnrx/f5FGIlJB6Qk+oGvkexoJhJ5myh6M/hI2Hqs/SaQh3hMhm+08k1FURPzzc0283YjWyBAHOH0kY3i4/UY/YacwTG0cjoCIgsnE8q3eeJM9HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=apewFl9fRzq7ubTZCPp+nNkIBQhMHnIF9bKNGQs/sWU=; b=ggiCTi/RdMxxInBGzr7696aCArCDwbbBrIFM/Oo1mDSHJFBp9p2BuGX5FuYOeKIvEbAxast1j/IL1lnD0V4vtxSoH0LruAsZxI0a7slutyuTMX0pNfBmXkptsiDeizDBKkFg+J2c5793DBK2Ri89U/2k/c+BpywgLF0/7k7uCJeow4/7kZBC1II+HcEn74bmm2Ak+b3T+y6cnUqcisM3O9xzCAJO0cw3abv4uGWS1EShJGrYkx0dRvZVp3qgLI+Fk7/AZBQpzrS2HXq3txFKx+3DJl0ntzTXJBdnGoH8C0KlqHoBiLyt+oVeI+mm6RnqLsJfST8aiZ7CGC8scid6pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=apewFl9fRzq7ubTZCPp+nNkIBQhMHnIF9bKNGQs/sWU=; b=puWnXI5aEs0Plj1VaqVo2tE6f1ia3V6er4fpGsPgKR5NTvAhwJLe/AuJ6iRZ94RTpNF+ym0SmDhlsXNQwZFS1zJi/rW8zZmRnaDIikjFv3R05dzPa9yHZo/IGBItok5nBHuzJDlDBmaM5lGF7rSS7KBIxNqgQZmjHyAqqAjuhxo= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3984.namprd11.prod.outlook.com (2603:10b6:208:153::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Thu, 7 Oct 2021 15:47:18 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021 15:47:18 +0000 From: "Power, Ciara" To: "Walsh, Conor" , "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [PATCH] usertools/telemetry: add listing of available file prefixes Thread-Index: AQHXufnP8HMelWW0T0uOyMJnqFue6KvHr7CA Date: Thu, 7 Oct 2021 15:47:18 +0000 Message-ID: References: <20211005150017.2779845-1-conor.walsh@intel.com> In-Reply-To: <20211005150017.2779845-1-conor.walsh@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ccb7c633-8bba-4f45-a44b-08d989a9be22 x-ms-traffictypediagnostic: MN2PR11MB3984: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z1yz8rkZjnpVB9ifePVm7X4noooLO0In+w2y+giEftCIANk/fJDFhX+rxOmTml6BYYYL1D95wSrnLQMJ2XhfC4p75Aki5ey3DZK7el8uLSgSm9vEKga1qdc45UJB3VNanwgI9QuoLhbOhLIbnsNRJyvNgRUOgiwTHJ7xqJ68LZCwEyoT/69j5XDb8zPhpTc8pSlt45K8HysKRTdmbDGZERFttkLdIGtiA1Xp6ieNoG9jpAU0MgKRiuI08K5qdEdoVK7TjkcreCmPwcsnDI/xOLcqw1FaAOOIuIlfL/Z7ctCbsOpbFLV7E+GldGHG5JFx13bB5Uv8V5RbeohE3L3tvyrfpVlSJCSEPZQjtGCisSqTVQDfaQ7spDvDyxogc/rvqemjIZCOugXe9087dDhZh3BPgCT2w3zG7hIeVfJbscKW9flUY76F278zDiRlC5DW6UUVM6nTczFwOmmBRQdYKRylk+hgXFIdZlvKfFnjmXR/Y6PFCNVVDGCUEwucp3Hrf5p2vo1xZrQOrWXhBimUQOW69ODa97D6SCvMdQqLkmJ9Md/C0X28oDDC0eDAko8hdUuY2BvJQNcU/vBgCxiatUVXoGJejpVt6psPIvPPQkXtljtjUCEFdZH1JOn4WCBJtHnUALADDm/78uvVj2WIU2vND/9WoRZbUUepyD8IEDahNaKhxgaPPTE1bC7Vs2MSxPwu1QawvEfRd18VMmsM9Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(38070700005)(8936002)(4326008)(33656002)(38100700002)(2906002)(83380400001)(71200400001)(66476007)(66556008)(66446008)(5660300002)(52536014)(55016002)(9686003)(7696005)(66946007)(76116006)(6506007)(64756008)(26005)(316002)(110136005)(86362001)(6636002)(508600001)(122000001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DUuIhRrgu7cDHo1xFX7Vo/LEn0+ZrUrmoVD8stA3nhj82PklwYy/XCFviO2K?= =?us-ascii?Q?bTdXCjvAQmswkSWKzRQfD5QM/G4YN3tD/90S0KneFFcmyinWtnMl6QEx+KC2?= =?us-ascii?Q?BZJxXZh9/FUEhoMjoq3Q2e4S12/p7Bns8766ANqvzIc4SPR3SZEp8ovDEYye?= =?us-ascii?Q?ebUG2cDPJvV0mLfZslQt5qO6FF1w+5RwioB6hdPUH24rxY9b8dvaA95N5mEz?= =?us-ascii?Q?qcgl0nHnh0AS3rQauCjX6ESGPdk1/Oq0G/sS+g7JMtsT1q1CpBwiZj0dbQXl?= =?us-ascii?Q?xS1yA85f/yHEQGut10siyXKV6hbs07UDcNn/Mo+RuHjK++nSOTGPNYrwdPd0?= =?us-ascii?Q?L6IrzKsF061hkQWRD1KkOMGQqZH4dB2lewuOmLu5u1k69BNi59mhAghhQMNp?= =?us-ascii?Q?xIKUP5i3Vnu2PZjzmPT+j3sXJZipz4/8uTQnS1i6MHk2ij9EvvRLCf7HeBaI?= =?us-ascii?Q?+4xkTEaG31h7xGuStrpc2odaKFzsZLTPeOkrWpkIrTJU4RVb4lfTRP2xQZLV?= =?us-ascii?Q?cRVSCwAwSyXi+ro6zMqTod8acXhXlebrceh8vp1jhLqh9Bj3ZUuBDgUoMvMs?= =?us-ascii?Q?CIXu5XIXjAuBONY59D5I/fy0aMLm4UMmOdbf9yXfWRJm9EiH7CRiLjOQt6W9?= =?us-ascii?Q?KuHFv/kbsLOaQuXDLZS0ggFkGpGjd3fIorRvv5NBLPK/ucP541rKb9wF2SAZ?= =?us-ascii?Q?jbshJJqeFFPsIanfQ4bl04ORyzlo7ebdYnYu8E1vUW5BqHqS50mxdmtlmfVj?= =?us-ascii?Q?aVcCy9Z7RXVgdnHLhj1jNiiyPqvCWbAggswsdyMuTHyYq6szXTdsKvh0lgZy?= =?us-ascii?Q?0IpngVC/6oVAVvpvDFW+FUdyxg/NUVQbFWBrrWIfFVHddEJ4cWxGPnTpHgOb?= =?us-ascii?Q?nLGYg/l8Pvzj46qdE7LDXHLm7bulg+vbFH6qiC7wPYIyD1592Rm1bYxngl62?= =?us-ascii?Q?uqnEYT5D0sMdE8qUrPxxHTbrqk7CkSEOVxz/K+hWfRQwL4vptXKEWZqnoxgh?= =?us-ascii?Q?gNXlzU4iTyrbTr4qZ2tYfz1TPJr1OAnYunizeNfWCSf9T4ODbj++M1Coqv8F?= =?us-ascii?Q?M/zwBfGE0W1cjUCUCn1xWLGeiK1anrtVfDww1EdzJ38LB/1KRJPBFAME/qgg?= =?us-ascii?Q?l3Izhy/EMj4v9Nv6QG1ktDaC314Ri8tsscMGGBAcXTCTb/WQgqtp2Zc8tGRJ?= =?us-ascii?Q?33JEaK99Xnpp/MtrTAmcCI0EQQJXXF9sCIJMnUvz59gAX+wFWAV15MxfZtJc?= =?us-ascii?Q?QKoO7wjeisBA3t1aXf+iZ+bb7kIYUSGWGGkTljac7VWAEcfYSxIHsjnpi3nN?= =?us-ascii?Q?xa8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccb7c633-8bba-4f45-a44b-08d989a9be22 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 15:47:18.0216 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AN56ZFF1ThUtng3fEQRma4lTmgMLa9Xm/832CIpqmCe1v5KXEBB2UuUSGTx5erj9cL9SClJCqAA6cyxEH2JbGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Conor, >-----Original Message----- >From: Walsh, Conor >Sent: Tuesday 5 October 2021 16:00 >To: Power, Ciara ; Richardson, Bruce > >Cc: dev@dpdk.org; Walsh, Conor >Subject: [PATCH] usertools/telemetry: add listing of available file prefix= es > >This patch adds the option --list (-l) to dpdk-telemetry.py which will pri= nt all of the >available dpdk file-prefixes that have telemetry enabled. >The prefixes will also be printed if the user passes an incorrect prefix i= n the --file- >prefix (-f) option. > >Depends-on: series-19390 ("improve telemetry support with in-memory mode") > >Signed-off-by: Conor Walsh >+ >+def list_fp(): >+ """ List all available file-prefixes to user """ >+ print("Valid file-prefixes:\n") Nit: I think it might be cleaner to move this down to just before the file = prefixes print out, so it doesn't print out when no apps are available. >+ path =3D get_dpdk_runtime_dir('') >+ >+ sockets =3D glob.glob(os.path.join(path, "*", SOCKET_NAME + "*")) >+ prefixes =3D [] >+ if not sockets: >+ print("\tNo DPDK apps with telemetry enabled available") >+ for s in sockets: >+ prefixes.append(os.path.relpath(os.path.dirname(s), start=3Dpath)= ) >+ for p in sorted(set(prefixes)): >+ print(p) >+ print_socket_options(p, glob.glob(os.path.join(path, p, >+ SOCKET_NAME + >+ "*"))) Asides from that one small comment, Acked-by: Ciara Power Thanks!