From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C0BDA0C43; Wed, 20 Oct 2021 17:56:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BB59411BB; Wed, 20 Oct 2021 17:56:25 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 32EDB41196 for ; Wed, 20 Oct 2021 17:56:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10143"; a="227582576" X-IronPort-AV: E=Sophos;i="5.87,167,1631602800"; d="scan'208";a="227582576" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2021 08:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,167,1631602800"; d="scan'208";a="494679828" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 20 Oct 2021 08:45:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 08:45:58 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 20 Oct 2021 08:45:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 20 Oct 2021 08:45:57 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 20 Oct 2021 08:45:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxNkXbV3gMhM7/N8gKIem7L+jWxX7D/TB83IXI55gIpYwFbuwtYmkVlVgcqAN8Cve+T4pry+p2Aq7H02oba5gESu+vR/Fc7JL46hv9Se6tFELoxUN08oHmxnigOI1TMYbn6/N3Npi6foIVtdpfWIPZp5nV84+Yb+QXmGKKjuqWfQncqNLAdL62yD76X0G7RXnASuADUq59651XtdL4c/WP3cV1hjBWzxDNfOYsMXqQo7gzjDd86T9e5YY/QtS2UIYEOpIYbfHJiD5FB+Id31+Ki9WgnjxWccT4maw3g2Pv5FT1F3w7TKVIm6MPPotstWox9/SkXvlzM4k8Fq+gC/DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t3SjVwNG7laL0Bsbkexpp2iycvc9a5nrVPF9wWmEPK4=; b=nioH7wMGZ5jixobSIXjL+NK/O4eeH5rMz3B/tz9X3hNShK+X3a7AR26mgelaKpOaJFREkWcANBRalu/mJYD9kvv48GTWrMzQbDJQOm3u6goa3IIl3IwNDXGzpIBmrmmfYzuJlML8uheUznaymDBbhxs5ygjKaTzF3uEZO339WIFelsqiAFlmWcG4+NC190VeFXJdkvaj5Euw5Qe7cRZr1jwxu/k2tGFtsckkfaunpmbuMlsOh0P6Yh6wFjmjUThGXh01sjUcCk8WNVY06RKh1sKNMiUM0zo3vhh0//YvzkiSno7Tj0/+8uMWzMCle62ffQjhZAizl4Of64qUFuN7ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t3SjVwNG7laL0Bsbkexpp2iycvc9a5nrVPF9wWmEPK4=; b=gHWodxUkLlvZgdfYr0Nc6GNbTopsH6GfE/GjYHVCYHj0HLi/QZ7Pl5wxw25Cu7phw7B35B3bUWzqFETHbBDOLOPMxaVAvhwB0INJV9dZ+Uor0+kcxZXBMLIP5RcVDTVsqyxpS6tHt+GusvLKV9KpHIVmbx04Yh2XTkRQV9r6pDs= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3871.namprd11.prod.outlook.com (2603:10b6:208:13c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 15:45:56 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 15:45:56 +0000 From: "Power, Ciara" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "Zhang, Roy Fan" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Ananyev, Konstantin" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "Wang, Haiyue" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" Thread-Topic: [PATCH v3 0/8] crypto/security session framework rework Thread-Index: AQHXxGgVvUqlHEE9K0mQeb5L5rKNvqvcCL1g Date: Wed, 20 Oct 2021 15:45:56 +0000 Message-ID: References: <20211013192222.1582631-2-gakhil@marvell.com> <20211018213452.2734720-1-gakhil@marvell.com> In-Reply-To: <20211018213452.2734720-1-gakhil@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30f199b4-9dfd-44ec-e970-08d993e0b4c7 x-ms-traffictypediagnostic: MN2PR11MB3871: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uoYs99A13rftrTQyhF9IUP84F8nto9AZnXu3R+EYidJzBO4e3I8tsW/GeNcAJkyQt63Vgszw8MvfbsMD+iSiRgyxh4vZqChlAfuA+9oPQ0EGPCpMM5ikDI3/xwxgFyzSqLbZwVFVAwuR09RMRFdHCRfS4334brBuo+ryBkYtkni6F0zEl63kZkYBCNKBcNLPO4eSD3EppjmccRP0TQ3/vb+1hyWMgCQMEY+OmRWUngEbjmZBjLf4cKuaRisXZHhZ/lwJvFUVcLimpJo+s8h5Rycmjtui+8jIsvJYbeLlpo6aZiAHu6hdCvBdkfKW0nryS4Uhp1IRAtS+ZCcQqt1p4lz0hSynFt4fMuMvTIt4Chqsx7jA4rdJeqFmJebPFZFBR8L9FljX9C0eVMpobrmedh8w6ek/M8GXjK5CJLdrPCZo1BIgvGk+wQe7pdTIkuDyhdalE5az3i3vCy7JC3tw58M4S95HBCUCvaoxr8z1dvTMxaYfCsdQcJFMQb1RTn9KLSQrLgVRas/84HFG0G2CGT925iWj4uYTdo8A1lUu8C41s2rYtCvUzBOo4MfzykoJnZ/RXxcOjNvM6/OpPSYw2NmAX1Ps0h03IhovHtj0ntv0ziD0ygZjMaDmTtdIp/K/lK9cOzmWu2zD2EFgts6dNO8lB1UC5C1Hl5jVwCMd7XYrJb+nSKfSABbSOMwaZG8WotcpyDoHgf+BRXpaXkvzJw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(55016002)(5660300002)(86362001)(38070700005)(186003)(33656002)(110136005)(15650500001)(26005)(316002)(508600001)(82960400001)(122000001)(54906003)(38100700002)(52536014)(8936002)(6506007)(9686003)(7696005)(83380400001)(7416002)(76116006)(66946007)(66446008)(8676002)(4326008)(66556008)(64756008)(66476007)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1W3yZ4dGm8znI/B+3CkO1BUNA80Df4CYptXfPQBcv8RegvgsMaFz2xaKYNOJ?= =?us-ascii?Q?nRHKjj5ZpzGi+lGAFUHnqi3TnWLb7BNoo6Quoziz7+Ip4FXR8IMORjiaNoz8?= =?us-ascii?Q?w0SViYMOIGQxBCFG+ZO3iUxDYjA6MO8yarvnrV2zhPgec+Etrt+L0wRyv21T?= =?us-ascii?Q?/1WbOBWUA9ifD9Gt2lho7Q/ZPhvrZoumQrBkoFS8xwITiaJYegnCRHxgYycg?= =?us-ascii?Q?EMlMSYiWPANLbZE6C8GRFO+KAd24eYXvdMWpvkcxoQtn14nEzHZx0TFKwNzL?= =?us-ascii?Q?ElimdxCQeglUQO0kscdDBZa2IDdCBZHHWwtTs94UqowHwk9FsyCO291Z9f29?= =?us-ascii?Q?z0Lpu7yQEKjBth7mg2k71rFdO45u73yqBkrEgDiBhVlEN5L6vTtwJWZ1hSBl?= =?us-ascii?Q?4RM9I3NtoZ9gbF/Q9IItvMc8fS8FY9+vxGi8bcHOjYgemwIcyGUrv1BPxkxk?= =?us-ascii?Q?bnWRwNZvHeRh6T2c2eefLMZJZ9h4tGodaku5tiL1jEgohit7NZ3hV9bebsVm?= =?us-ascii?Q?b9hyiA6llGFBRPwhVnTZLU9+ZjbVvn/YUQ7s9ct7la43PuFokP+vqBpEToyS?= =?us-ascii?Q?1z38MDCAl73jP3FtuKzzsEYO0jB1f2gKvQiYsAgVLgLaUSYZ5wxPXL5yBssb?= =?us-ascii?Q?KS/D3hoP5wfk2n3Yuoycp0+C3J8fj6Mhy3XcPsW+4mvjDB8Sadt+RbjHxNRa?= =?us-ascii?Q?8y7YWQS1Gk4QseehvlV33Yd/lgBknoDFCuNy3nYkra29lIiw4+F63zRLNezn?= =?us-ascii?Q?lXj2o6wLvkcctazb98GDEhdQn44Ge8dyzgfKCT8FwjcfTrYWNuLGQpKxVIK4?= =?us-ascii?Q?QMibFQt08ANaajKicAUC2BkB4zhZw2m9gIIjY5W6XtnKgK9CheNOblSrvdRx?= =?us-ascii?Q?VfzxIxlctUagiJGvwrpcBX8Jl5vLFpbTFZtYTU9K0vKT+ShHppI8erBmbiwZ?= =?us-ascii?Q?TwOTLVLMFNUtNrILylyaNTceAl/YPrH32eHcKZyuJ6BOQ5boLG7jcp+l6Awr?= =?us-ascii?Q?+IPSR/PHvKgH/dPph2dUHfIR5fJ3m25ByC/g1UDk2uliqikWd/a2RgVlDa0l?= =?us-ascii?Q?CjRLo3bVonFkaAiZlZStLaceJcZai+RZ1uixP9YBP3KgX3GRltePh8zvTcqK?= =?us-ascii?Q?8LiD6a2mbWjq738hwULwj96qXZ+rd4dMLD3H6Aa8xOlfjw2mkoBCW9pH8IJL?= =?us-ascii?Q?MFsEJba+imVF0G7H3M1BBD6cwLFPmn8bRCEvr5SqsBpS/rUG51skSAguwMhz?= =?us-ascii?Q?lY2EWnoYNtr3nptrL8YXxWLyB+Js4c8h8wiv6AOLAcPjgPxXua5aK9C6BsX+?= =?us-ascii?Q?2ZXgFBQeFI0Z/+U66oIMIAFs?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30f199b4-9dfd-44ec-e970-08d993e0b4c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 15:45:56.2864 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jl6oOsWW1+xF4DLIRznHV4TeXft0WoMmu8DnHsr6NcUmQ63aPd2S6rF0QPWVSK7jFjzz+VWEx/3f4yx5vjeAGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3871 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 0/8] crypto/security session framework rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, >-----Original Message----- >From: Akhil Goyal >Sent: Monday 18 October 2021 22:35 >To: dev@dpdk.org >Cc: thomas@monjalon.net; david.marchand@redhat.com; >hemant.agrawal@nxp.com; anoobj@marvell.com; De Lara Guarch, Pablo >; Trahe, Fiona ; >Doherty, Declan ; matan@nvidia.com; >g.singh@nxp.com; Zhang, Roy Fan ; >jianjay.zhou@huawei.com; asomalap@amd.com; ruifeng.wang@arm.com; >Ananyev, Konstantin ; Nicolau, Radu >; ajit.khaparde@broadcom.com; >rnagadheeraj@marvell.com; adwivedi@marvell.com; Power, Ciara >; Wang, Haiyue ; >jiawenwu@trustnetic.com; jianwang@trustnetic.com; Akhil Goyal > >Subject: [PATCH v3 0/8] crypto/security session framework rework > >As discussed in last release deprecation notice, crypto and security sessi= on >framework are reworked to reduce the need of two mempool objects and >remove the requirement to expose the rte_security_session and >rte_cryptodev_sym_session structures. >Design methodology is explained in the patch description. > >Similar work will need to be done for asymmetric sessions as well. Asymmet= ric >session need another rework and is postponed to next release. Since it is = still >in experimental stage, we can modify the APIs in next release as well. > >The patches are compilable with all affected PMDs and tested with dpdk-tes= t >and test-crypto-perf app on CN9k platform. I am seeing test failures for cryptodev_scheduler_autotest: + Tests Total : 638 + Tests Skipped : 280 + Tests Executed : 638 + Tests Unsupported: 0 + Tests Passed : 18 + Tests Failed : 340 The error showing for each testcase: scheduler_pmd_sym_session_configure() line 487: unable to config sym sessio= n CRYPTODEV: rte_cryptodev_sym_session_init() line 1743: dev_id 2 failed to c= onfigure session details I believe the problem happens in scheduler_pmd_sym_session_configure. The full sess object is no longer accessible in here, but it is required to= be passed to rte_cryptodev_sym_session_init. The init function expects access to sess rather than the private data, and = now fails as a result. static int scheduler_pmd_sym_session_configure(struct rte_cryptodev *dev, struct rte_crypto_sym_xform *xform, void *sess, rte_iova_t sess_iova __rte_unused) { struct scheduler_ctx *sched_ctx =3D dev->data->dev_private; uint32_t i; int ret; for (i =3D 0; i < sched_ctx->nb_workers; i++) { struct scheduler_worker *worker =3D &sched_ctx->workers[i]; ret =3D rte_cryptodev_sym_session_init(worker->dev_id, sess= , xform); if (ret < 0) { CR_SCHED_LOG(ERR, "unable to config sym session"); return ret; } } return 0; } Thanks, Ciara