From: "Power, Ciara" <ciara.power@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: RE: [PATCH v3 0/9] Standardize telemetry int types
Date: Fri, 13 Jan 2023 16:39:58 +0000 [thread overview]
Message-ID: <MN2PR11MB38217C71195DEA74E1BF6D6FE6C29@MN2PR11MB3821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230112174116.2105237-1-bruce.richardson@intel.com>
Hi Bruce,
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Thursday 12 January 2023 17:41
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [PATCH v3 0/9] Standardize telemetry int types
>
> Rather than having 64-bit unsigned types and 32-bit signed types supported
> by the telemetry lib, we should support 64-bit values for both types. On the
> naming side, since both are 64-bit, we should no longer call the unsigned
> value u64 - "uint" is better.
>
> This patchset implements these changes as far as is possible while still
> keeping API and ABI compatibility.
>
> * Internal structures and functions are updated to use 64-bit ints
> * Internal functions are renamed from u64 to uint
> * Public enum values are renamed from u64 to uint, and a macro is
> added to ensure that older code still compiles
> * The public add_*_int functions are changed to take a 64-bit value
> rather than a 32-bit one. Since this would be an ABI break, we
> use function versioning to ensure older code still calls into
> a wrapper function which takes a 32-bit value.
>
> The patchset also contains a couple of other small cleanups to the telemetry
> code that were seen in passing when making these changes - removing RTE_
> prefix on internal enums, and simplifying the init of the the array of data
> types.
>
> NOTE: the renaming of the u64 functions to uint is split across 3 patches in
> this set - patches 4,5 and 6. This is to make it easier to review and to avoid
> warnings about new functions not being marked initially as experimental.
> Some/all of these 3 can be combined on merge if so desired.
>
> V3:
> - fix build issues due to missing a driver code change
> - fix spelling issue flagged by checkpatch
>
> V2:
> - added additional patches to replace the old function calls within DPDK
> code, something missed in RFC version
> - added new patch to make the renamed/new functions immediately public
> allowing us to mark the original named versions as deprecated
> - re-ordered patches within the sit, so the extra cleanup changes come
> first
>
> Bruce Richardson (9):
> telemetry: remove RTE prefix from internal enum values
> telemetry: make array initialization more robust
> telemetry: rename unsigned 64-bit enum value to uint
> telemetry: add uint type as alias for u64
> global: rename telemetry functions to newer versions
> telemetry: mark old names of renamed fns as deprecated
> telemetry: update json functions to use int/uint in names
> telemetry: make internal int representation 64-bits
> telemetry: change public API to use 64-bit signed values
>
> app/test/test_telemetry_data.c | 22 ++---
> app/test/test_telemetry_json.c | 9 +-
> doc/guides/rel_notes/deprecation.rst | 5 ++
> drivers/common/cnxk/roc_platform.h | 4 +-
> drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 24 ++---
> drivers/net/cnxk/cnxk_ethdev_telemetry.c | 6 +-
> examples/ipsec-secgw/ipsec-secgw.c | 72 +++++++--------
> examples/l3fwd-power/main.c | 4 +-
> lib/cryptodev/rte_cryptodev.c | 6 +-
> lib/dmadev/rte_dmadev.c | 2 +-
> lib/eal/common/eal_common_memory.c | 19 ++--
> lib/ethdev/rte_ethdev.c | 12 +--
> lib/ethdev/sff_telemetry.c | 2 +-
> lib/eventdev/rte_event_eth_rx_adapter.c | 22 ++---
> lib/eventdev/rte_event_timer_adapter.c | 38 ++++----
> lib/eventdev/rte_eventdev.c | 5 +-
> lib/ipsec/ipsec_telemetry.c | 33 +++----
> lib/rawdev/rte_rawdev.c | 4 +-
> lib/security/rte_security.c | 8 +-
> lib/telemetry/meson.build | 1 +
> lib/telemetry/rte_telemetry.h | 51 +++++++++--
> lib/telemetry/telemetry.c | 56 ++++++------
> lib/telemetry/telemetry_data.c | 95 ++++++++++++++------
> lib/telemetry/telemetry_data.h | 24 +++--
> lib/telemetry/telemetry_json.h | 16 ++--
> lib/telemetry/version.map | 9 ++
> 26 files changed, 325 insertions(+), 224 deletions(-)
>
> --
> 2.37.2
Series-Acked-by: Ciara Power <ciara.power@intel.com>
next prev parent reply other threads:[~2023-01-13 16:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:27 [RFC PATCH 0/7] " Bruce Richardson
2022-12-13 18:27 ` [RFC PATCH 1/7] telemetry: rename unsigned 64-bit enum value to uint Bruce Richardson
2022-12-14 17:30 ` Tyler Retzlaff
2022-12-15 9:41 ` Bruce Richardson
2022-12-15 17:53 ` Tyler Retzlaff
2022-12-13 18:27 ` [RFC PATCH 2/7] telemetry: add uint type as alias for u64 Bruce Richardson
2022-12-14 17:38 ` Tyler Retzlaff
2022-12-15 9:44 ` Bruce Richardson
2022-12-15 13:36 ` Thomas Monjalon
2022-12-15 13:58 ` Bruce Richardson
2022-12-19 10:37 ` Thomas Monjalon
2022-12-19 13:22 ` Bruce Richardson
2022-12-15 17:58 ` Tyler Retzlaff
2022-12-15 1:49 ` lihuisong (C)
2022-12-15 9:42 ` Bruce Richardson
2022-12-15 18:02 ` Tyler Retzlaff
2022-12-13 18:27 ` [RFC PATCH 3/7] telemetry: remove RTE prefix from internal enum values Bruce Richardson
2022-12-13 18:27 ` [RFC PATCH 4/7] telemetry: make array initialization more robust Bruce Richardson
2022-12-14 17:50 ` Tyler Retzlaff
2023-01-09 12:16 ` Bruce Richardson
2023-01-09 17:49 ` Tyler Retzlaff
2023-01-10 9:11 ` Ferruh Yigit
2022-12-13 18:27 ` [RFC PATCH 5/7] telemetry: update json functions to use int/uint in names Bruce Richardson
2022-12-13 18:27 ` [RFC PATCH 6/7] telemetry: make internal int representation 64-bits Bruce Richardson
2022-12-13 18:27 ` [RFC PATCH 7/7] telemetry: change public API to use 64-bit signed values Bruce Richardson
2022-12-13 20:19 ` Morten Brørup
2022-12-14 17:53 ` Tyler Retzlaff
2022-12-15 2:39 ` lihuisong (C)
2023-01-12 10:58 ` [PATCH v2 0/9] Standardize telemetry int types Bruce Richardson
2023-01-12 10:58 ` [PATCH v2 1/9] telemetry: remove RTE prefix from internal enum values Bruce Richardson
2023-01-12 10:58 ` [PATCH v2 2/9] telemetry: make array initialization more robust Bruce Richardson
2023-01-12 10:58 ` [PATCH v2 3/9] telemetry: rename unsigned 64-bit enum value to uint Bruce Richardson
2023-01-12 10:58 ` [PATCH v2 4/9] telemetry: add uint type as alias for u64 Bruce Richardson
2023-01-12 10:58 ` [PATCH v2 5/9] global: rename telemetry functions to newer versions Bruce Richardson
2023-01-12 10:59 ` [PATCH v2 6/9] telemetry: mark old names of renamed fns as deprecated Bruce Richardson
2023-01-12 10:59 ` [PATCH v2 7/9] telemetry: update json functions to use int/uint in names Bruce Richardson
2023-01-12 10:59 ` [PATCH v2 8/9] telemetry: make internal int representation 64-bits Bruce Richardson
2023-01-12 10:59 ` [PATCH v2 9/9] telemetry: change public API to use 64-bit signed values Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 0/9] Standardize telemetry int types Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 1/9] telemetry: remove RTE prefix from internal enum values Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 2/9] telemetry: make array initialization more robust Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 3/9] telemetry: rename unsigned 64-bit enum value to uint Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 4/9] telemetry: add uint type as alias for u64 Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 5/9] global: rename telemetry functions to newer versions Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 6/9] telemetry: mark old names of renamed fns as deprecated Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 7/9] telemetry: update json functions to use int/uint in names Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 8/9] telemetry: make internal int representation 64-bits Bruce Richardson
2023-01-12 17:41 ` [PATCH v3 9/9] telemetry: change public API to use 64-bit signed values Bruce Richardson
2023-02-05 22:55 ` Thomas Monjalon
2023-01-13 16:39 ` Power, Ciara [this message]
2023-02-05 23:15 ` [PATCH v3 0/9] Standardize telemetry int types Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB38217C71195DEA74E1BF6D6FE6C29@MN2PR11MB3821.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).