From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4B3DA0C47; Tue, 12 Oct 2021 17:47:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45778410EF; Tue, 12 Oct 2021 17:47:40 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 908EF410E4 for ; Tue, 12 Oct 2021 17:47:38 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="214338375" X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="214338375" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 08:47:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="715219820" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 12 Oct 2021 08:47:37 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 08:47:36 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 08:47:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 12 Oct 2021 08:47:36 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 12 Oct 2021 08:47:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3Al2rFuqBbZ+0XbRrsn8WLjAEzfxeV/NR3eO2n3fgYhT3oW/34lHylnwlLT7dxQo8AtpexMD/EDavPXUfZoyaq1tW3cH2Y4irhwXL9yZxWOKRGunSciH383pRR6XTm0+SCEjTG+CEKRJd2TrmdBY4cSVBikHDn97QElX7faiczyulEp4PAIaaR/Zfk6qpa4ICuTzW19gnWjP8O0lAGlYLIIPFcu6oU9WydN1neHCspew3Yjj8nhYB1l5oTWnQkYGMrmiAQrDadfZcH1sOL3LBzbThXdPeIWSP0+dQ4jRzOgQlQ9jnnapSqAirHR/yiesIdwmXCReDMlBD4cTkZjyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fB7evL9t8RmU0nOKZCS6BtbPaS6SY5dvZD2Ose/5Ue0=; b=Kb/Fk/bAd9zpyVGwDBCJ8CAM1WpX+3eNCW7Olud14t5T2FKiABI6lNY6pdmDlJjGoVgUv6DEOELhiqyWipSPCENWwKDW4+34K3ItusH9Byo3o7PuhiHI6dtSRZuzng8xjuPywLx0XLV/H49YmWR9m4v/A/HT7EFvSGZwQvW/z+wW+covWJirrjQDuftl4lYcLex2ubZwaJ0iWXo/GmABPMELn+v/yUuPVNgb1RKJMFLKIRDQ+2pJLXdqi0RpeoVsutDMfXA/ZRQ4wHq9tHkEAL8tFs7K75N1izWSORIbxCiK7LOOvWijVKxDn1LqqguUk22dWzyhB7FcQWwBMS45ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fB7evL9t8RmU0nOKZCS6BtbPaS6SY5dvZD2Ose/5Ue0=; b=p/d+b+kh9vjbnKufg4A1PiNBDXx/Mw8Ucu5POCEwPmdAghuHhLQ+bVwcJmn4Ptp+xKXMIsQapuCur+4b52bYSltDdS82jca7L8sWK6qGDjkqkBd9Z9fTatPNwdGxv/2WuoIpQKi1tM0Ff4e1X4GodX9dB85mYNIB/xPuV2FG/vo= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3999.namprd11.prod.outlook.com (2603:10b6:208:154::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Tue, 12 Oct 2021 15:47:34 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 15:47:34 +0000 From: "Power, Ciara" To: "Richardson, Bruce" CC: "dev@dpdk.org" , David Marchand , "Burakov, Anatoly" , Kevin Traynor Thread-Topic: [PATCH v7 3/5] telemetry: use unique socket paths for in-memory mode Thread-Index: AQHXvGig/gHotkB3q0G6Zl8186J+JqvPhO7QgAABPgCAAAEwIA== Date: Tue, 12 Oct 2021 15:47:33 +0000 Message-ID: References: <20210915141030.23514-1-bruce.richardson@intel.com> <20211008171852.736387-1-bruce.richardson@intel.com> <20211008171852.736387-4-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16b5c1f1-b8f0-4174-f59e-08d98d979b9d x-ms-traffictypediagnostic: MN2PR11MB3999: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mCQXkWqe96QH2K+lUU8Q+8673wKhNyxwFEPOLUZHNYZhBtCtXKzbSsCi6s2gDrdwPXcwQcOHj6NTasgs20jn+mDJ/el2A3xJ37u66WzkeGZvwq/r1elvQ6RN+gJON1sqlTMtwyPXIGs+oe7bM88Sxe97mMz8FAUTHMtZYkYfPXAnwAFEYC1XxSkYyNaZ3kcOgHaRuV9ose3E5i4ayhAawH3yAVuXVH3wh2e/PiNsrffArsljcAhQNSiMniav9cfNZAFlkiyKJBzpkGQ0cGwI5jKfnIZG6h/sqYeCQir3iZnsephnoSlQw/IYlxmfMESzt1yV8G6TJMPKMHsPQoox0eGH3s1zgLltqAOD4JezN6WHqcv7kWk/mdBgmDFNW4yNrgDHx8fLJERXwccPRSpYlaxpiIR5nU5Z6xOpr6lk1uSAHxQEL8YI3QbCccabNxAEpD7Mn3b7Y4ltgApKWK+huEc9AcL36nC9A4DC47JAnYpYqqhXHtyn8Tw56t9fV4tdvTebJ/sN+gMvoHRkxCHEwQ0wrWwHRXTRMjZCdloxEUqXJxrqk52dEl41Dn+xIF2UPDcT0IuPU/XAVwxgTqdN0qohgprS6AhuZOM/bRAKKMSqoxZksXCWx3JQQ2sr9X1NU27fthXHUZSYJUX95iW8e/uq2A4WsXbl92xYMRqzxVMpaWiar/9IabAZJhOGETVBU1UzCGxR2+Y5aokYM4V2tw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(66446008)(71200400001)(5660300002)(7696005)(52536014)(76116006)(66946007)(6506007)(2906002)(66476007)(64756008)(66556008)(8936002)(316002)(186003)(508600001)(9686003)(6862004)(8676002)(33656002)(4326008)(6636002)(55016002)(83380400001)(54906003)(38070700005)(38100700002)(122000001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wpcwQ3H/RdwAWI5N8wtLu0cL9XDTCS8KOvBvxuKhI4F9GY52D4mY/TOBwbR8?= =?us-ascii?Q?MeFsud1Gh3Wfq/D2gRbNZ1rTgXwoccsq/muARQ8Mci5Tr7S/gXQtehFfPJag?= =?us-ascii?Q?vg+jHRmD+uVx8OVDu82I5dmU4X2AQTmykVXOrRp2X3cdN8IVQqFJS/1SLE4E?= =?us-ascii?Q?6cLDqznnYPrSY0p+tfcyOE3SHIBKPFm5pMStjpKCTTgXyS8ucyhxszRccnJm?= =?us-ascii?Q?fiwSg1rzgN2KJkIqHiLUVhxn84Pez9FudJyirdN2kFmR5Cj3v6u/F3y1N4qb?= =?us-ascii?Q?jAjSzFES+v7/hOrVbIavOyXkknhh1vU6HXFH7YnnkMLGj9Kdqp+jtfMYMj79?= =?us-ascii?Q?YJD1HDpQ7LYez4ASL2NZZSDFpLyuLn9ltX3DsnYRVPkOLjiR2qcUGA/1ZtWz?= =?us-ascii?Q?mrENnsYq8lLjXUJdXJPm1I5t8WD+Wn9upgs1otefAFTNTsAD3+Wb6S40NcBB?= =?us-ascii?Q?HBZ/UlAVzV/qHVPEeym912+jvQRcYLJHH1tE9bC7u1xOzr5QnyBPeS5mtFOP?= =?us-ascii?Q?YITVRkW78s8qcVTqhfNgA4gE6SQSyVr6mNA0NS3jWgtpe56jMtGe23hcUvxH?= =?us-ascii?Q?ZAJFSS1ofwvvwFfz8bYB83d2BWh+kBiW61S3w51n0z6euIDJkmreRrrFbGYB?= =?us-ascii?Q?XOJfbYEbs3W6zHLmmf9fUMPrStRNs0OKKPESNV0fvp2HvqJrQOofcUXretPf?= =?us-ascii?Q?em9f8cdDaF7sgQTih3RJcYbiWJlOxKHfAXD1WqaRv8gxzibvi9/U8t697Hkf?= =?us-ascii?Q?Q/fATC4fDJWwk1uvggwdeQrn8C4nWgQbkrMS+KjqxL2SIlI1Na3bJPeAow9Y?= =?us-ascii?Q?v6H1tdOXJjYvBa6Fon+YzHfIQLY0Us6BAaoJvVyJewtreYv/NGy+n6FDIxaF?= =?us-ascii?Q?3bhEEa4xcLCJmVAujgwkmOwCfmWtp250dxhseLZ7tyudoXLsYQyGtAQsXdVu?= =?us-ascii?Q?HbywJQKDqZtSk+uLDwjsszJR8v9FF5K4Iku/ApkQR/oQfnjawLDAvUhdCFol?= =?us-ascii?Q?99vsyMrZHFJKep3f4Zg3sSAjy7btkoLUbja6o48xf/25sGGADau5UmmcnuW1?= =?us-ascii?Q?IR2spdPYZ+b5x9U0/tugmC8kh2FUyJGr8JAbbILWXDJ+lKlSBjw0kPxobdnh?= =?us-ascii?Q?JTxMBCE3ZiLbLLuN0jrNFpdnbGHJQVkP7JgwfKvNeN/B3jvxJRcBztaipxBN?= =?us-ascii?Q?SGUT1uvLlqWyZNzNSwWUdCInoWEEshScsql7ok+AgTGk2V18jQOu+Af3Tcrg?= =?us-ascii?Q?zamAuWqqGaber1/SSodeTLZt0ApbH/3SQnJmBEmigfPQGR6/cJuU5K9QWFiV?= =?us-ascii?Q?Mq0z9wKO2eSVSI1RdmsVSzpr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16b5c1f1-b8f0-4174-f59e-08d98d979b9d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2021 15:47:33.9404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B/dlE6XT6/IJqvaYB4H0dO2wX/KdOe+hZJM7N9EpNf0yf4IliFQgnuO77bWLBVKVtgRr5daCDM+CDHe6xhRoKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3999 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 3/5] telemetry: use unique socket paths for in-memory mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Richardson, Bruce >Sent: Tuesday 12 October 2021 16:41 >To: Power, Ciara >Cc: dev@dpdk.org; David Marchand ; >Burakov, Anatoly ; Kevin Traynor > >Subject: Re: [PATCH v7 3/5] telemetry: use unique socket paths for in- >memory mode > >On Tue, Oct 12, 2021 at 04:37:07PM +0100, Power, Ciara wrote: >> Hi Bruce, >> >> >-----Original Message----- >> >From: Richardson, Bruce >> >Sent: Friday 8 October 2021 18:19 >> >To: dev@dpdk.org >> >Cc: Power, Ciara ; David Marchand >> >; Burakov, Anatoly >> >; Kevin Traynor ; >> >Richardson, Bruce >> >Subject: [PATCH v7 3/5] telemetry: use unique socket paths for >> >in-memory mode >> > >> >When running in in-memory mode, multiple processes can use the same >> >runtime dir, leading to conflicts with the telemetry sockets in that >directory. >> >We can resolve this by appending a suffix to each socket beyond the >> >first, with the suffix being an increasing counter value. >> >Each process uses the first unused socket counter value. >> > >> >Signed-off-by: Bruce Richardson >> >--- >> >> >> Thanks, >> >> Acked-by: Ciara Power > >Thanks. > >I'm actually in two minds as to whether to this patch should be merged wit= h >the previous one. It was already reviewed and acked as a bugfix, but this >patch also affects a lot of the same areas of code. What do you think? > >/Bruce Yes, I was actually wondering about that myself. I think it would make more sense to merge them, rather than adding some cod= e in patch 2 that then gets removed in patch 3. Thanks, Ciara